| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:03b47601-5372-ea1e-ab02-ada0f0dbd251 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B452:2373EB:5B1B126:807B2B0:6A500AA7 |
| html-safe-nonce | d3ed97933d30b30f1ac31f8a11bffaca042b949dbe44f8efcc25cbdfe1f6f3a5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDUyOjIzNzNFQjo1QjFCMTI2OjgwN0IyQjA6NkE1MDBBQTciLCJ2aXNpdG9yX2lkIjoiMjQ3NTAwNjc4NzY0NTg2ODcxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 91cf70173caa6d4386dffd8a683dcf4f1d05b5a565902caa1c36cb188d3325b8 |
| hovercard-subject-tag | pull_request:335934024 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30229/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fe73016009d82d54b4fd9ffd0bcff88db90435086f628caf053a3b698c6b9673/nodejs/node/pull/30229 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fe73016009d82d54b4fd9ffd0bcff88db90435086f628caf053a3b698c6b9673/nodejs/node/pull/30229 |
| og:image:alt | These changes should help make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.
The first commit is #30228. (Marking this as blocked until that l... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93a615b89b7dcbdb6b678f4772931ecc28ada82a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30229#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30229 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30229 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30229 |
| Reload | https://github.com/nodejs/node/pull/30229 |
| Reload | https://github.com/nodejs/node/pull/30229 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:embedding-improvements | https://github.com/addaleax/node/tree/embedding-improvements |
| Conversation | https://github.com/nodejs/node/pull/30229 |
| Commits6 (6) | https://github.com/nodejs/node/pull/30229/commits |
| Checks | https://github.com/nodejs/node/pull/30229/checks |
| Files changed | https://github.com/nodejs/node/pull/30229/files |
| src: various improvements toward a complete embedder API | https://github.com/nodejs/node/pull/30229#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:embedding-improvements | https://github.com/addaleax/node/tree/embedding-improvements |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 2, 2019 | https://github.com/nodejs/node/pull/30229#issue-516710816 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| #30228 | https://github.com/nodejs/node/pull/30228 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| codebytere | https://github.com/codebytere |
| November 2, 2019 20:25 | https://github.com/nodejs/node/pull/30229#event-2765532432 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Nov 2, 2019 | https://github.com/nodejs/node/pull/30229#event-2765532474 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
embedding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding |
| Nov 2, 2019 | https://github.com/nodejs/node/pull/30229#event-2765532579 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| joyeecheung | https://github.com/joyeecheung |
| November 2, 2019 20:26 | https://github.com/nodejs/node/pull/30229#event-2765532622 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 3, 2019 | https://github.com/nodejs/node/pull/30229#event-2765874846 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/30229#pullrequestreview-311840804 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30229/files |
| addaleax | https://github.com/addaleax |
| November 5, 2019 20:56 | https://github.com/nodejs/node/pull/30229#commits-pushed-193d09b |
|
| https://github.com/addaleax |
| src: track no of active JS signal handlers | https://github.com/nodejs/node/pull/30229/commits/193d09b818ff2edf4be788ae3be05b1c6f9068e1 |
| 193d09b | https://github.com/nodejs/node/pull/30229/commits/193d09b818ff2edf4be788ae3be05b1c6f9068e1 |
|
| https://github.com/addaleax |
| src: make EndStartedProfilers an exit hook | https://github.com/nodejs/node/pull/30229/commits/49e17211043a14b08aaf158244a0079a8303332f |
| 49e1721 | https://github.com/nodejs/node/pull/30229/commits/49e17211043a14b08aaf158244a0079a8303332f |
|
| https://github.com/addaleax |
| src: make WaitForInspectorDisconnect an exit hook | https://github.com/nodejs/node/pull/30229/commits/e4e4e76cc7689772d6dc60eb71611adc3af9f3c7 |
| e4e4e76 | https://github.com/nodejs/node/pull/30229/commits/e4e4e76cc7689772d6dc60eb71611adc3af9f3c7 |
|
| https://github.com/addaleax |
| src: use unique_ptr for InitializeInspector() | https://github.com/nodejs/node/pull/30229/commits/ded953f80fcb7dd0308a5e77ceb10413c7464c0e |
| ded953f | https://github.com/nodejs/node/pull/30229/commits/ded953f80fcb7dd0308a5e77ceb10413c7464c0e |
|
| https://github.com/addaleax |
| src: run RunBeforeExitCallbacks as part of EmitBeforeExit | https://github.com/nodejs/node/pull/30229/commits/36787d7b5c28177dd902412a8795ab299fa33312 |
| 36787d7 | https://github.com/nodejs/node/pull/30229/commits/36787d7b5c28177dd902412a8795ab299fa33312 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/7bf8cdf8fa7b67c8d6031e0c5e7cd5c5d4a5588d..36787d7b5c28177dd902412a8795ab299fa33312 |
| 7bf8cdf | https://github.com/nodejs/node/commit/7bf8cdf8fa7b67c8d6031e0c5e7cd5c5d4a5588d |
| 36787d7 | https://github.com/nodejs/node/commit/36787d7b5c28177dd902412a8795ab299fa33312 |
|
Compare
| https://github.com/nodejs/node/compare/7bf8cdf8fa7b67c8d6031e0c5e7cd5c5d4a5588d..36787d7b5c28177dd902412a8795ab299fa33312 |
| November 5, 2019 19:57 | https://github.com/nodejs/node/pull/30229#event-2772760514 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 5, 2019 | https://github.com/nodejs/node/pull/30229#event-2772761399 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 5, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-549993500 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://ci.nodejs.org/job/node-test-pull-request/26359/ | https://ci.nodejs.org/job/node-test-pull-request/26359/ |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| gireeshpunathil | https://github.com/gireeshpunathil |
| November 6, 2019 13:14 | https://github.com/nodejs/node/pull/30229#event-2775259406 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312435676 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30229/files/193d09b818ff2edf4be788ae3be05b1c6f9068e1 |
| src/signal_wrap.cc | https://github.com/nodejs/node/pull/30229/files/193d09b818ff2edf4be788ae3be05b1c6f9068e1#diff-452859f373075e431619a4a72602a804658954c9883d4ee83a29eaaf5abffcb7 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| src/signal_wrap.cc | https://github.com/nodejs/node/pull/30229/files/193d09b818ff2edf4be788ae3be05b1c6f9068e1#diff-452859f373075e431619a4a72602a804658954c9883d4ee83a29eaaf5abffcb7 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| src/node_internals.h | https://github.com/nodejs/node/pull/30229/files/193d09b818ff2edf4be788ae3be05b1c6f9068e1#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
|
| https://github.com/addaleax |
| fixup! src: track no of active JS signal handlers | https://github.com/nodejs/node/pull/30229/commits/e18e4f062c1d722aceb5148719752e3123a6115a |
| e18e4f0 | https://github.com/nodejs/node/pull/30229/commits/e18e4f062c1d722aceb5148719752e3123a6115a |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312490943 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#event-2775638760 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-550347800 |
| https://ci.nodejs.org/job/node-test-pull-request/26407/ | https://ci.nodejs.org/job/node-test-pull-request/26407/ |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312572476 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312572476 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| src/inspector_profiler.cc | https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a#diff-98240c78433cab1bbba602d2dea112d8404b922c41376c024fb809d0bb6d16b3 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#discussion_r343198101 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#discussion_r343221716 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @joyeecheung | https://github.com/joyeecheung |
| @bcoe | https://github.com/bcoe |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| src/inspector_agent.cc | https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a#diff-70a38bba4bd6538b0bdf462db5268047b43a0260fe71c3f469d5ad52cbf8f2dd |
| joyeecheung | https://github.com/joyeecheung |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#discussion_r343200041 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#discussion_r343221800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312582528 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
| codebytere | https://github.com/codebytere |
| https://github.com/nodejs/node/pull/30229#pullrequestreview-312582528 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-550410901 |
| https://ci.nodejs.org/job/node-test-pull-request/26410/ | https://ci.nodejs.org/job/node-test-pull-request/26410/ |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-550440928 |
| https://ci.nodejs.org/job/node-test-pull-request/26411/ | https://ci.nodejs.org/job/node-test-pull-request/26411/ |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-550505811 |
| https://ci.nodejs.org/job/node-test-pull-request/26414/ | https://ci.nodejs.org/job/node-test-pull-request/26414/ |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-55f98df |
|
| https://github.com/addaleax |
| src: track no of active JS signal handlers | https://github.com/nodejs/node/commit/55f98df303939774639bb597c6392c1c85bae6dd |
|
| https://github.com/nodejs/node/commit/55f98df303939774639bb597c6392c1c85bae6dd#comments |
| 55f98df | https://github.com/nodejs/node/commit/55f98df303939774639bb597c6392c1c85bae6dd |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-5bf4372 |
|
| https://github.com/addaleax |
| src: make EndStartedProfilers an exit hook | https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 |
| 5bf4372 | https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-7e2a182 |
|
| https://github.com/addaleax |
| src: make WaitForInspectorDisconnect an exit hook | https://github.com/nodejs/node/commit/7e2a182d03c40faa567daebee5ce064675190bff |
| 7e2a182 | https://github.com/nodejs/node/commit/7e2a182d03c40faa567daebee5ce064675190bff |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-86cdfc6 |
|
| https://github.com/addaleax |
| src: use unique_ptr for InitializeInspector() | https://github.com/nodejs/node/commit/86cdfc60a9ae21f64058e7292db3566d91d09085 |
| 86cdfc6 | https://github.com/nodejs/node/commit/86cdfc60a9ae21f64058e7292db3566d91d09085 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-d4b2cc7 |
|
| https://github.com/addaleax |
| src: run RunBeforeExitCallbacks as part of EmitBeforeExit | https://github.com/nodejs/node/commit/d4b2cc7ead4ffdbe8091c7cb0e6a621be712a79b |
| d4b2cc7 | https://github.com/nodejs/node/commit/d4b2cc7ead4ffdbe8091c7cb0e6a621be712a79b |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#issuecomment-550537545 |
| 4aca277...d4b2cc7 | https://github.com/nodejs/node/compare/4aca277f16b8649b5fc21d41f340fad0a47c2e61...d4b2cc7ead4ffdbe8091c7cb0e6a621be712a79b |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30229#event-2777168786 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| November 6, 2019 22:52 | https://github.com/nodejs/node/pull/30229#event-2777169199 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-8234d04 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: track no of active JS signal handlers | https://github.com/nodejs/node/commit/8234d04b566b9bbc764efb988e9884df9ece0369 |
| 8234d04 | https://github.com/nodejs/node/commit/8234d04b566b9bbc764efb988e9884df9ece0369 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-cd233e3 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: make EndStartedProfilers an exit hook | https://github.com/nodejs/node/commit/cd233e3f1679e78207597557321f4f7088388aa3 |
| cd233e3 | https://github.com/nodejs/node/commit/cd233e3f1679e78207597557321f4f7088388aa3 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-db7deb6 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: make WaitForInspectorDisconnect an exit hook | https://github.com/nodejs/node/commit/db7deb6e7aef4ce8934836f6305f3fb3cdab2b76 |
| db7deb6 | https://github.com/nodejs/node/commit/db7deb6e7aef4ce8934836f6305f3fb3cdab2b76 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-66b3619 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: use unique_ptr for InitializeInspector() | https://github.com/nodejs/node/commit/66b3619b4e50e17095d14fafe88fa7a0bcf69cb2 |
| 66b3619 | https://github.com/nodejs/node/commit/66b3619b4e50e17095d14fafe88fa7a0bcf69cb2 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-906d279 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: run RunBeforeExitCallbacks as part of EmitBeforeExit | https://github.com/nodejs/node/commit/906d279e697af654cb731d3ca9079bb3c52080e7 |
| 906d279 | https://github.com/nodejs/node/commit/906d279e697af654cb731d3ca9079bb3c52080e7 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30229#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-5ec3573 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: track no of active JS signal handlers | https://github.com/nodejs/node/commit/5ec35730bb2dc8b2c1ed0906855a727c442ace38 |
| 5ec3573 | https://github.com/nodejs/node/commit/5ec35730bb2dc8b2c1ed0906855a727c442ace38 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-619b718 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: make EndStartedProfilers an exit hook | https://github.com/nodejs/node/commit/619b718071d8f581da935bd75f83aac7b1742aee |
| 619b718 | https://github.com/nodejs/node/commit/619b718071d8f581da935bd75f83aac7b1742aee |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-79713ed |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: make WaitForInspectorDisconnect an exit hook | https://github.com/nodejs/node/commit/79713ed8e5f36d19b4cda89281f47c7c4b0936b3 |
| 79713ed | https://github.com/nodejs/node/commit/79713ed8e5f36d19b4cda89281f47c7c4b0936b3 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-b40eede |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: use unique_ptr for InitializeInspector() | https://github.com/nodejs/node/commit/b40eedeb61a7c51f3f3acd6fc81c54b25b3df99f |
| b40eede | https://github.com/nodejs/node/commit/b40eedeb61a7c51f3f3acd6fc81c54b25b3df99f |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-f97f1ca |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: run RunBeforeExitCallbacks as part of EmitBeforeExit | https://github.com/nodejs/node/commit/f97f1cadcc11447262f2b9573410909fd577629e |
| f97f1ca | https://github.com/nodejs/node/commit/f97f1cadcc11447262f2b9573410909fd577629e |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30229#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-eb8beb5 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: track no of active JS signal handlers | https://github.com/nodejs/node/commit/eb8beb5f5f9492d18082cb5c34d56b1e40831188 |
| eb8beb5 | https://github.com/nodejs/node/commit/eb8beb5f5f9492d18082cb5c34d56b1e40831188 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-d14d9e8 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: make EndStartedProfilers an exit hook | https://github.com/nodejs/node/commit/d14d9e8b1b8e6d114b89b2eb112c582c968105f8 |
| d14d9e8 | https://github.com/nodejs/node/commit/d14d9e8b1b8e6d114b89b2eb112c582c968105f8 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-fc9e708 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: make WaitForInspectorDisconnect an exit hook | https://github.com/nodejs/node/commit/fc9e7082fda4122b629f056c801dc285a0de6506 |
| fc9e708 | https://github.com/nodejs/node/commit/fc9e7082fda4122b629f056c801dc285a0de6506 |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-da8ceb9 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: use unique_ptr for InitializeInspector() | https://github.com/nodejs/node/commit/da8ceb965d1a9ce7a9f6a77143f3db25f7ec3e9f |
| da8ceb9 | https://github.com/nodejs/node/commit/da8ceb965d1a9ce7a9f6a77143f3db25f7ec3e9f |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30229#ref-commit-e1a1244 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: run RunBeforeExitCallbacks as part of EmitBeforeExit | https://github.com/nodejs/node/commit/e1a12446c52925815cfc07c90ddc96628ea8e59a |
| e1a1244 | https://github.com/nodejs/node/commit/e1a12446c52925815cfc07c90ddc96628ea8e59a |
| #30229 | https://github.com/nodejs/node/pull/30229 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30229#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30229 |
|
| https://github.com/codebytere |
|
codebytere
| https://github.com/codebytere |
|
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30229/files/7bf8cdf8fa7b67c8d6031e0c5e7cd5c5d4a5588d |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30229/files/e18e4f062c1d722aceb5148719752e3123a6115a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
embedding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/30229 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/codebytere |
|
| https://github.com/cjihrig |
|
| https://github.com/joyeecheung |
|
| https://github.com/gireeshpunathil |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |