René's URL Explorer Experiment


Title: process: make source map getter resistant against prototype tampering by addaleax · Pull Request #30228 · nodejs/node · GitHub

Open Graph Title: process: make source map getter resistant against prototype tampering by addaleax · Pull Request #30228 · nodejs/node

X Title: process: make source map getter resistant against prototype tampering by addaleax · Pull Request #30228 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of worker.terminate(). Checklist make -j4 test (UNIX),...

X Description: Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of worker.terminate(). Checklist make -j4 test (UNIX),...

Opengraph URL: https://github.com/nodejs/node/pull/30228

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cc0bfc5a-4528-6e9d-ef44-a3b660061681
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7F4:16195D:5F6A78F:8607741:6A500B15
html-safe-nonce68903455d961d1d494f3e0f11b75505e34d8cf3e9a682a6b59d6359383ab14d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0Y0OjE2MTk1RDo1RjZBNzhGOjg2MDc3NDE6NkE1MDBCMTUiLCJ2aXNpdG9yX2lkIjoiMTY0NzIzNDM4NjMxODMzMDY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbb654db6ad643d1e09d7afe8dcc8bc43472133c0268a75e2e28160aa6dffcd4f
hovercard-subject-tagpull_request:335933311
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30228/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f994e964e6293efd48eed05ee973448e9c3165f7216d44ab4fb8d50b1149c1eb/nodejs/node/pull/30228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f994e964e6293efd48eed05ee973448e9c3165f7216d44ab4fb8d50b1149c1eb/nodejs/node/pull/30228
og:image:altSince this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of worker.terminate(). Checklist make -j4 test (UNIX),...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release93a615b89b7dcbdb6b678f4772931ecc28ada82a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30228#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30228
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30228
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30228
Reloadhttps://github.com/nodejs/node/pull/30228
Reloadhttps://github.com/nodejs/node/pull/30228
Please reload this pagehttps://github.com/nodejs/node/pull/30228
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30228
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:source-map-tamperinghttps://github.com/addaleax/node/tree/source-map-tampering
Conversationhttps://github.com/nodejs/node/pull/30228
Commits3 (3)https://github.com/nodejs/node/pull/30228/commits
Checkshttps://github.com/nodejs/node/pull/30228/checks
Files changedhttps://github.com/nodejs/node/pull/30228/files
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/pull/30228#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:source-map-tamperinghttps://github.com/addaleax/node/tree/source-map-tampering
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2019https://github.com/nodejs/node/pull/30228#issue-516710031
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/pull/30228/commits/ba02c7421d4da7f837d7e23352ece10f99c5557f
ba02c74https://github.com/nodejs/node/pull/30228/commits/ba02c7421d4da7f837d7e23352ece10f99c5557f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
bcoehttps://github.com/bcoe
November 2, 2019 20:23https://github.com/nodejs/node/pull/30228#event-2765530585
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2019 https://github.com/nodejs/node/pull/30228#ref-pullrequest-516710816
src: various improvements toward a complete embedder API #30229 https://github.com/nodejs/node/pull/30229
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
source maps https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22source%20maps%22
Nov 2, 2019https://github.com/nodejs/node/pull/30228#event-2765533657
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-310787376
View reviewed changes https://github.com/nodejs/node/pull/30228/files/ba02c7421d4da7f837d7e23352ece10f99c5557f
lib/internal/source_map/source_map_cache.jshttps://github.com/nodejs/node/pull/30228/files/ba02c7421d4da7f837d7e23352ece10f99c5557f#diff-3aae89de0ff7c36d1eec9aeb9d52e785b5863604dd2fdfb0649647694a5e769a
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/targos
targoshttps://github.com/targos
Nov 2, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-310788943
View reviewed changes https://github.com/nodejs/node/pull/30228/files/ba02c7421d4da7f837d7e23352ece10f99c5557f
lib/internal/source_map/source_map_cache.jshttps://github.com/nodejs/node/pull/30228/files/ba02c7421d4da7f837d7e23352ece10f99c5557f#diff-3aae89de0ff7c36d1eec9aeb9d52e785b5863604dd2fdfb0649647694a5e769a
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
fixup! process: make source map getter resistant against prototype ta…https://github.com/nodejs/node/pull/30228/commits/2a121a0d512914c1a86bb0c301341f2153c59618
2a121a0https://github.com/nodejs/node/pull/30228/commits/2a121a0d512914c1a86bb0c301341f2153c59618
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 3, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-310831337
View reviewed changes https://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/30228#pullrequestreview-310831337
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30228
lib/internal/source_map/source_map_cache.jshttps://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618#diff-3aae89de0ff7c36d1eec9aeb9d52e785b5863604dd2fdfb0649647694a5e769a
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/bcoe
bcoehttps://github.com/bcoe
Nov 4, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-310883762
View reviewed changes https://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618
bcoehttps://github.com/bcoe
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/nodejs/node/pull/30228#pullrequestreview-310883762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30228
lib/internal/source_map/source_map_cache.jshttps://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618#diff-3aae89de0ff7c36d1eec9aeb9d52e785b5863604dd2fdfb0649647694a5e769a
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
fixup! process: make source map getter resistant against prototype ta…https://github.com/nodejs/node/pull/30228/commits/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
24905dbhttps://github.com/nodejs/node/pull/30228/commits/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2019https://github.com/nodejs/node/pull/30228#issuecomment-549249261
https://ci.nodejs.org/job/node-test-pull-request/26312/https://ci.nodejs.org/job/node-test-pull-request/26312/
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/targos
targoshttps://github.com/targos
Nov 4, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-310911725
View reviewed changes https://github.com/nodejs/node/pull/30228/files/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2019https://github.com/nodejs/node/pull/30228#issuecomment-549339547
https://ci.nodejs.org/job/node-test-pull-request/26327/https://ci.nodejs.org/job/node-test-pull-request/26327/
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 5, 2019https://github.com/nodejs/node/pull/30228#event-2772511175
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30228#issuecomment-549960436
https://ci.nodejs.org/job/node-test-pull-request/26351/https://ci.nodejs.org/job/node-test-pull-request/26351/
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 5, 2019 https://github.com/nodejs/node/pull/30228#pullrequestreview-311976520
View reviewed changes https://github.com/nodejs/node/pull/30228/files/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30228#issuecomment-549984425
https://ci.nodejs.org/job/node-test-pull-request/26356/https://ci.nodejs.org/job/node-test-pull-request/26356/
Please reload this pagehttps://github.com/nodejs/node/pull/30228
addaleaxhttps://github.com/addaleax
Nov 5, 2019 https://github.com/nodejs/node/pull/30228#ref-commit-f17e414
https://github.com/addaleax
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/commit/f17e414dc4b5d80dd5b5c7ee7107659ec5ebeb1a
f17e414https://github.com/nodejs/node/commit/f17e414dc4b5d80dd5b5c7ee7107659ec5ebeb1a
#30228https://github.com/nodejs/node/pull/30228
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30228#issuecomment-549992704
f17e414https://github.com/nodejs/node/commit/f17e414dc4b5d80dd5b5c7ee7107659ec5ebeb1a
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30228#event-2772758205
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 5, 2019 19:56https://github.com/nodejs/node/pull/30228#event-2772758507
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30228#ref-commit-7b41874
https://github.com/addaleax
https://github.com/MylesBorins
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/commit/7b4187413ec44599b93384b1df46ca511f0044ca
7b41874https://github.com/nodejs/node/commit/7b4187413ec44599b93384b1df46ca511f0044ca
#30228https://github.com/nodejs/node/pull/30228
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30228#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30228#ref-commit-5cbe7c2
https://github.com/addaleax
https://github.com/targos
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/commit/5cbe7c2c8ca8108dcae5fcd75142f6ad26f014c9
5cbe7c2https://github.com/nodejs/node/commit/5cbe7c2c8ca8108dcae5fcd75142f6ad26f014c9
#30228https://github.com/nodejs/node/pull/30228
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30228#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30228#ref-commit-56b3edc
https://github.com/addaleax
https://github.com/MylesBorins
process: make source map getter resistant against prototype tamperinghttps://github.com/nodejs/node/commit/56b3edcce814cda5cab92800262b7d66ab9d60f2
56b3edchttps://github.com/nodejs/node/commit/56b3edcce814cda5cab92800262b7d66ab9d60f2
#30228https://github.com/nodejs/node/pull/30228
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30228#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30228
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30228/files/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/30228/files/24905db9b71cdbd643829e226cd4f2b69f6fa3b7
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618
https://github.com/bcoe
bcoe https://github.com/bcoe
https://github.com/nodejs/node/pull/30228/files/2a121a0d512914c1a86bb0c301341f2153c59618
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
source maps https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22source%20maps%22
Please reload this pagehttps://github.com/nodejs/node/pull/30228
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/bcoe
https://github.com/jasnell
https://github.com/targos
https://github.com/joyeecheung
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.