René's URL Explorer Experiment


Title: dgram: remove listeners on bind error by addaleax · Pull Request #30210 · nodejs/node · GitHub

Open Graph Title: dgram: remove listeners on bind error by addaleax · Pull Request #30210 · nodejs/node

X Title: dgram: remove listeners on bind error by addaleax · Pull Request #30210 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: dgram: reset bind state before emitting error This was previously done inconsistently, sometimes before, sometimes after emitting the event. dgram: remove listeners on bind error This avoids piling...

X Description: dgram: reset bind state before emitting error This was previously done inconsistently, sometimes before, sometimes after emitting the event. dgram: remove listeners on bind error This avoids piling...

Opengraph URL: https://github.com/nodejs/node/pull/30210

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60112f25-2936-6b46-de78-b2c7d3891404
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDC6:383777:46D4F29:6341C0C:6A4F7363
html-safe-nonce4144f83f84472cdc9fbc04486be59de6e3e3b48d0776d2b1102628fbae027b6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREM2OjM4Mzc3Nzo0NkQ0RjI5OjYzNDFDMEM6NkE0RjczNjMiLCJ2aXNpdG9yX2lkIjoiMzExMzQzNDg4MTQxOTM0MjY5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc062b6e1a074c9876b82ed5171fe1c2fb77f4aba980dd6fa80d7566464fcd9de
hovercard-subject-tagpull_request:335568063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30210/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e79b14d583e996d388892692adb24600920cdc2468e450e50e70acd75edbc8fe/nodejs/node/pull/30210
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e79b14d583e996d388892692adb24600920cdc2468e450e50e70acd75edbc8fe/nodejs/node/pull/30210
og:image:altdgram: reset bind state before emitting error This was previously done inconsistently, sometimes before, sometimes after emitting the event. dgram: remove listeners on bind error This avoids piling...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30210#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30210
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30210
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30210
Reloadhttps://github.com/nodejs/node/pull/30210
Reloadhttps://github.com/nodejs/node/pull/30210
Please reload this pagehttps://github.com/nodejs/node/pull/30210
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30210
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dgram-bind-errorhttps://github.com/addaleax/node/tree/dgram-bind-error
Conversationhttps://github.com/nodejs/node/pull/30210
Commits3 (3)https://github.com/nodejs/node/pull/30210/commits
Checkshttps://github.com/nodejs/node/pull/30210/checks
Files changedhttps://github.com/nodejs/node/pull/30210/files
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/pull/30210#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dgram-bind-errorhttps://github.com/addaleax/node/tree/dgram-bind-error
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 1, 2019https://github.com/nodejs/node/pull/30210#issue-516290312
#30209https://github.com/nodejs/node/issues/30209
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30210
addaleaxhttps://github.com/addaleax
November 1, 2019 19:50https://github.com/nodejs/node/pull/30210#commits-pushed-e17fcc8
https://github.com/addaleax
dgram: reset bind state before emitting errorhttps://github.com/nodejs/node/pull/30210/commits/e17fcc85410a5aa54fb3b227096b4999feaf28fe
e17fcc8https://github.com/nodejs/node/pull/30210/commits/e17fcc85410a5aa54fb3b227096b4999feaf28fe
https://github.com/addaleax
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/pull/30210/commits/2d8aa6407fa8f098bb57f91dff4803031a426e43
2d8aa64https://github.com/nodejs/node/pull/30210/commits/2d8aa6407fa8f098bb57f91dff4803031a426e43
nodejs#30209https://github.com/nodejs/node/issues/30209
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dgram https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram
Nov 1, 2019https://github.com/nodejs/node/pull/30210#event-2764168204
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Nov 1, 2019https://github.com/nodejs/node/pull/30210#event-2764169148
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2019https://github.com/nodejs/node/pull/30210#issuecomment-548910181
https://ci.nodejs.org/job/node-test-pull-request/26285/https://ci.nodejs.org/job/node-test-pull-request/26285/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 2, 2019 https://github.com/nodejs/node/pull/30210#pullrequestreview-310789083
View reviewed changes https://github.com/nodejs/node/pull/30210/files/2d8aa6407fa8f098bb57f91dff4803031a426e43
test/parallel/test-dgram-bind-error-repeat.jshttps://github.com/nodejs/node/pull/30210/files/2d8aa6407fa8f098bb57f91dff4803031a426e43#diff-8324d45748c6941ad2077c5bb058e805bb853be001ab1cdd37095c0205a0326c
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/addaleax
fixup! dgram: remove listeners on bind errorhttps://github.com/nodejs/node/pull/30210/commits/f603ff405d7253580436b64b4c0ad2bb2a787e12
f603ff4https://github.com/nodejs/node/pull/30210/commits/f603ff405d7253580436b64b4c0ad2bb2a787e12
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 3, 2019 https://github.com/nodejs/node/pull/30210#pullrequestreview-310818481
View reviewed changes https://github.com/nodejs/node/pull/30210/files/f603ff405d7253580436b64b4c0ad2bb2a787e12
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 5, 2019https://github.com/nodejs/node/pull/30210#event-2772521511
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30210#issuecomment-549961779
https://ci.nodejs.org/job/node-test-pull-request/26353/https://ci.nodejs.org/job/node-test-pull-request/26353/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30210#issuecomment-549994716
https://ci.nodejs.org/job/node-test-pull-request/26360/https://ci.nodejs.org/job/node-test-pull-request/26360/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30210#issuecomment-550044141
https://ci.nodejs.org/job/node-test-pull-request/26373/https://ci.nodejs.org/job/node-test-pull-request/26373/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 6, 2019 https://github.com/nodejs/node/pull/30210#pullrequestreview-312132733
View reviewed changes https://github.com/nodejs/node/pull/30210/files/f603ff405d7253580436b64b4c0ad2bb2a787e12
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30210#issuecomment-550298845
https://ci.nodejs.org/job/node-test-pull-request/26404/https://ci.nodejs.org/job/node-test-pull-request/26404/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30210#issuecomment-550505961
https://ci.nodejs.org/job/node-test-pull-request/26415/https://ci.nodejs.org/job/node-test-pull-request/26415/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30210#issuecomment-550528813
https://ci.nodejs.org/job/node-test-pull-request/26421/https://ci.nodejs.org/job/node-test-pull-request/26421/
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 6, 2019https://github.com/nodejs/node/pull/30210#issuecomment-550555276
99e874ehttps://github.com/nodejs/node/commit/99e874e545b7c69bbd22c93b7546037290a727d3
115792dhttps://github.com/nodejs/node/commit/115792dfde436354c82f38361cbff75ad226b8d0
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 6, 2019https://github.com/nodejs/node/pull/30210#event-2777298430
addaleaxhttps://github.com/addaleax
Nov 6, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-99e874e
https://github.com/addaleax
dgram: reset bind state before emitting errorhttps://github.com/nodejs/node/commit/99e874e545b7c69bbd22c93b7546037290a727d3
99e874ehttps://github.com/nodejs/node/commit/99e874e545b7c69bbd22c93b7546037290a727d3
#30210https://github.com/nodejs/node/pull/30210
#30209https://github.com/nodejs/node/issues/30209
addaleaxhttps://github.com/addaleax
Nov 6, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-115792d
https://github.com/addaleax
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/commit/115792dfde436354c82f38361cbff75ad226b8d0
115792dhttps://github.com/nodejs/node/commit/115792dfde436354c82f38361cbff75ad226b8d0
#30209https://github.com/nodejs/node/issues/30209
#30210https://github.com/nodejs/node/pull/30210
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 6, 2019 23:55https://github.com/nodejs/node/pull/30210#event-2777298627
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 7, 2019 https://github.com/nodejs/node/pull/30210#ref-pullrequest-507020038
module: Conditional exports #29978 https://github.com/nodejs/node/pull/29978
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-0433d79
https://github.com/addaleax
https://github.com/MylesBorins
dgram: reset bind state before emitting errorhttps://github.com/nodejs/node/commit/0433d7995a16ceeadd99e703adc538ef1286042e
0433d79https://github.com/nodejs/node/commit/0433d7995a16ceeadd99e703adc538ef1286042e
#30210https://github.com/nodejs/node/pull/30210
#30209https://github.com/nodejs/node/issues/30209
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-f8ee70c
https://github.com/addaleax
https://github.com/MylesBorins
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/commit/f8ee70c94dc9fbb001b89e9ee86f0d0cb70acbbe
f8ee70chttps://github.com/nodejs/node/commit/f8ee70c94dc9fbb001b89e9ee86f0d0cb70acbbe
#30209https://github.com/nodejs/node/issues/30209
#30210https://github.com/nodejs/node/pull/30210
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30210#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-aa30eb5
https://github.com/addaleax
https://github.com/targos
dgram: reset bind state before emitting errorhttps://github.com/nodejs/node/commit/aa30eb518289028b57126e878379a5685ef0007c
aa30eb5https://github.com/nodejs/node/commit/aa30eb518289028b57126e878379a5685ef0007c
#30210https://github.com/nodejs/node/pull/30210
#30209https://github.com/nodejs/node/issues/30209
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-29c8199
https://github.com/addaleax
https://github.com/targos
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/commit/29c819979b2d937f7abff0706dc536f60625997a
29c8199https://github.com/nodejs/node/commit/29c819979b2d937f7abff0706dc536f60625997a
#30209https://github.com/nodejs/node/issues/30209
#30210https://github.com/nodejs/node/pull/30210
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30210#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-fd5fed1
https://github.com/addaleax
https://github.com/MylesBorins
dgram: reset bind state before emitting errorhttps://github.com/nodejs/node/commit/fd5fed1c898906668fdd8b36a785dc1365d854e7
fd5fed1https://github.com/nodejs/node/commit/fd5fed1c898906668fdd8b36a785dc1365d854e7
#30210https://github.com/nodejs/node/pull/30210
#30209https://github.com/nodejs/node/issues/30209
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30210#ref-commit-3d39be7
https://github.com/addaleax
https://github.com/MylesBorins
dgram: remove listeners on bind errorhttps://github.com/nodejs/node/commit/3d39be73d470ca57094ca8c98be5e2ee7126ab66
3d39be7https://github.com/nodejs/node/commit/3d39be73d470ca57094ca8c98be5e2ee7126ab66
#30209https://github.com/nodejs/node/issues/30209
#30210https://github.com/nodejs/node/pull/30210
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30210#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Feb 27, 2020https://github.com/nodejs/node/pull/30210#event-3077975175
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Nov 16, 2020https://github.com/nodejs/node/pull/30210#event-4000006380
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30210
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30210/files/f603ff405d7253580436b64b4c0ad2bb2a787e12
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30210/files/2d8aa6407fa8f098bb57f91dff4803031a426e43
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30210/files/f603ff405d7253580436b64b4c0ad2bb2a787e12
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
dgram https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram
EventEmitter memory leak with socket bind https://github.com/nodejs/node/issues/30209
Please reload this pagehttps://github.com/nodejs/node/pull/30210
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.