| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9c1e4afb-9a5f-02bd-4c9b-820420c1a776 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9690:35D054:78309A:9C4E42:6AED32BF |
| html-safe-nonce | eb00549827f70e767fe7700d53c8f131fc946a979a1b7b3cd53c987132f49bb2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjkwOjM1RDA1NDo3ODMwOUE6OUM0RTQyOjZBRUQzMkJGIiwidmlzaXRvcl9pZCI6IjYwNjAxODU4NDI2OTkwMjMwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 30b92de5dbd779b88e4ca5324d708400addfa36f01b0c24494348ecf6c1be568 |
| hovercard-subject-tag | pull_request:332842535 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30143/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a04ad759367d1c0e0d14154c3e46d0ae58adc736c0cbee710f26bf1d5f905f74/nodejs/node/pull/30143 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a04ad759367d1c0e0d14154c3e46d0ae58adc736c0cbee710f26bf1d5f905f74/nodejs/node/pull/30143 |
| og:image:alt | As discussed in #30129 (comment), when we vendor in code, we own the Syntax Errors in that code. This PR adds a Travis CI test run that looks for syntax errors and undefined names in the Python co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/30143#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30143 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30143 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30143 |
| Reload | https://github.com/nodejs/node/pull/30143 |
| Reload | https://github.com/nodejs/node/pull/30143 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests665 (665) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| cclauss | https://github.com/cclauss |
| master | https://github.com/nodejs/node/tree/master |
| flake8-the-entire-repo | https://github.com/nodejs/node/tree/flake8-the-entire-repo |
| Conversation | https://github.com/nodejs/node/pull/30143 |
| Commits2 (2) | https://github.com/nodejs/node/pull/30143/commits |
| Checks | https://github.com/nodejs/node/pull/30143/checks |
| Files changed | https://github.com/nodejs/node/pull/30143/files |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/pull/30143#top |
| cclauss | https://github.com/cclauss |
| master | https://github.com/nodejs/node/tree/master |
| flake8-the-entire-repo | https://github.com/nodejs/node/tree/flake8-the-entire-repo |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Oct 27, 2019 | https://github.com/nodejs/node/pull/30143#issue-512947248 |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Oct 27, 2019 | https://github.com/nodejs/node/pull/30143#event-2746559949 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Oct 27, 2019
| https://github.com/nodejs/node/pull/30143#ref-pullrequest-512968142 |
|
tools: fix Python 3 syntax error in mac_tool.py
#30146
| https://github.com/nodejs/node/pull/30146 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Oct 27, 2019 | https://github.com/nodejs/node/pull/30143#event-2746655784 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Trott | https://github.com/Trott |
| richardlau | https://github.com/richardlau |
| sam-github | https://github.com/sam-github |
| targos | https://github.com/targos |
| October 27, 2019 13:58 | https://github.com/nodejs/node/pull/30143#event-2746662097 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Oct 27, 2019
| https://github.com/nodejs/node/pull/30143#ref-issue-512785992 |
|
./configure fails after Python version default changed
#30129
| https://github.com/nodejs/node/issues/30129 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 27, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-307575543 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files |
|
tools: use print() function in buildbot_run.py
#30148
| https://github.com/nodejs/node/pull/30148 |
|
tools: git rm -r tools/v8_gypfiles/broken
#30149
| https://github.com/nodejs/node/pull/30149 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 27, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-307583602 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 28, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-307760690 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 28, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-307763290 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 28, 2019 | https://github.com/nodejs/node/pull/30143#issuecomment-546924300 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4016/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4016/ |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 28, 2019 | https://github.com/nodejs/node/pull/30143#event-2748311083 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Oct 29, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-308241913 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files |
| cclauss | https://github.com/cclauss |
| October 31, 2019 17:31 | https://github.com/nodejs/node/pull/30143#commits-pushed-8444de8 |
|
| https://github.com/cclauss |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/pull/30143/commits/8444de800deebf2199f51f93237acdf087e35454 |
| 8444de8 | https://github.com/nodejs/node/pull/30143/commits/8444de800deebf2199f51f93237acdf087e35454 |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
|
| https://github.com/cclauss |
| fixup: allow_failures until dependencies pass | https://github.com/nodejs/node/pull/30143/commits/c69a472219e6ce04141be76c73461eb1b455ad30 |
| c69a472 | https://github.com/nodejs/node/pull/30143/commits/c69a472219e6ce04141be76c73461eb1b455ad30 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/238e6e22a16144aead5fe1e6063482832d9ce0f8..c69a472219e6ce04141be76c73461eb1b455ad30 |
| 238e6e2 | https://github.com/nodejs/node/commit/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
| c69a472 | https://github.com/nodejs/node/commit/c69a472219e6ce04141be76c73461eb1b455ad30 |
|
Compare
| https://github.com/nodejs/node/compare/238e6e22a16144aead5fe1e6063482832d9ce0f8..c69a472219e6ce04141be76c73461eb1b455ad30 |
| October 31, 2019 16:32 | https://github.com/nodejs/node/pull/30143#event-2760543665 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 31, 2019 | https://github.com/nodejs/node/pull/30143#issuecomment-548480731 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4024/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4024/ |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 31, 2019
| https://github.com/nodejs/node/pull/30143#pullrequestreview-310167863 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30143/files/c69a472219e6ce04141be76c73461eb1b455ad30 |
| cclauss | https://github.com/cclauss |
|
Oct 31, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-b23b8dc |
|
| https://github.com/cclauss |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/b23b8dc0fab6153ce73019247aa8d0c306ad1fb0 |
| b23b8dc | https://github.com/nodejs/node/commit/b23b8dc0fab6153ce73019247aa8d0c306ad1fb0 |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Oct 31, 2019 | https://github.com/nodejs/node/pull/30143#issuecomment-548565021 |
| b23b8dc | https://github.com/nodejs/node/commit/b23b8dc0fab6153ce73019247aa8d0c306ad1fb0 |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Oct 31, 2019 | https://github.com/nodejs/node/pull/30143#event-2761393813 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| October 31, 2019 20:56 | https://github.com/nodejs/node/pull/30143#event-2761394004 |
| targos | https://github.com/targos |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-5469811 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/54698113c02f8ab319744fe3588d6cf28a166b0e |
| 5469811 | https://github.com/nodejs/node/commit/54698113c02f8ab319744fe3588d6cf28a166b0e |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/30143#ref-pullrequest-517668487 |
|
v13.1.0 release proposal
#30262
| https://github.com/nodejs/node/pull/30262 |
| targos | https://github.com/targos |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-3de6522 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/3de6522e4774ed08d339e21b06f30288e6bee4d2 |
| 3de6522 | https://github.com/nodejs/node/commit/3de6522e4774ed08d339e21b06f30288e6bee4d2 |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-59bf124 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/59bf12469b39e700346f05e3e216f5d3538aadf3 |
| 59bf124 | https://github.com/nodejs/node/commit/59bf12469b39e700346f05e3e216f5d3538aadf3 |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-cd1cbce |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/cd1cbce3918ab19aa6022d42223c01228d1ec48b |
| cd1cbce | https://github.com/nodejs/node/commit/cd1cbce3918ab19aa6022d42223c01228d1ec48b |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30143#ref-pullrequest-520604598 |
|
v12.13.1 release proposal
#30352
| https://github.com/nodejs/node/pull/30352 |
| targos | https://github.com/targos |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30143#ref-commit-c5d312f |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: find Python syntax errors in dependencies | https://github.com/nodejs/node/commit/c5d312f821d58cc9b9df64c0f6537faa3154456c |
| c5d312f | https://github.com/nodejs/node/commit/c5d312f821d58cc9b9df64c0f6537faa3154456c |
| #30129 (comment) | https://github.com/nodejs/node/issues/30129#issuecomment-546662351 |
| #30143 | https://github.com/nodejs/node/pull/30143 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30143 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/30143/files/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30143/files/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30143/files/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/30143/files/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/30143/files/c69a472219e6ce04141be76c73461eb1b455ad30 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/30143/files/238e6e22a16144aead5fe1e6063482832d9ce0f8 |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Please reload this page | https://github.com/nodejs/node/pull/30143 |
|
| https://github.com/cclauss |
|
| https://github.com/Trott |
|
| https://github.com/sam-github |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/gengjiawen |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |