René's URL Explorer Experiment


Title: src: do not use `std::function` for `OnScopeLeave` by addaleax · Pull Request #30134 · nodejs/node · GitHub

Open Graph Title: src: do not use `std::function` for `OnScopeLeave` by addaleax · Pull Request #30134 · nodejs/node

X Title: src: do not use `std::function` for `OnScopeLeave` by addaleax · Pull Request #30134 · nodejs/node

Description: Using std::function adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. Checklist make -j4 test (UNIX), or vcbuild test (Windows...

Open Graph Description: Using std::function adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. Checklist make -j4 test (UNIX), or vcbuild test (Windows...

X Description: Using std::function adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. Checklist make -j4 test (UNIX), or vcbuild test (Windows...

Opengraph URL: https://github.com/nodejs/node/pull/30134

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9db71718-1df3-42e4-6264-7cadf13b39db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8058:2BFBB8:E206AA:137F3BB:696A9250
html-safe-noncebc90bc4b3e36770a3193ee628671bbbae27c30a2fb372834e10a284b450ae17e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDU4OjJCRkJCODpFMjA2QUE6MTM3RjNCQjo2OTZBOTI1MCIsInZpc2l0b3JfaWQiOiI2NzczMTc4NjQ4OTI0Njg4OTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacade3c2955eeff56926453ebd159f5b2c2d47919e93f22f16451b9f3087656e4f
hovercard-subject-tagpull_request:332782294
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d91e2179132b7ce2f7d5fbaca7128651cf7891bf47a9f2e9ea14347d1af469c/nodejs/node/pull/30134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d91e2179132b7ce2f7d5fbaca7128651cf7891bf47a9f2e9ea14347d1af469c/nodejs/node/pull/30134
og:image:altUsing std::function adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. Checklist make -j4 test (UNIX), or vcbuild test (Windows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30134#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30134
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30134
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30134
Reloadhttps://github.com/nodejs/node/pull/30134
Reloadhttps://github.com/nodejs/node/pull/30134
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30134
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30134
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30134#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:onscopeleave-nostdfunhttps://github.com/addaleax/node/tree/onscopeleave-nostdfun
src: do not use std::function for OnScopeLeave https://github.com/nodejs/node/pull/30134#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:onscopeleave-nostdfunhttps://github.com/addaleax/node/tree/onscopeleave-nostdfun
Conversation 21 https://github.com/nodejs/node/pull/30134
Commits 3 https://github.com/nodejs/node/pull/30134/commits
Checks 0 https://github.com/nodejs/node/pull/30134/checks
Files changed https://github.com/nodejs/node/pull/30134/files
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2019https://github.com/nodejs/node/pull/30134#issue-512857851
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 26, 2019https://github.com/nodejs/node/pull/30134#event-2746171607
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 26, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-307534155
View reviewed changes https://github.com/nodejs/node/pull/30134/files
src/util.hhttps://github.com/nodejs/node/pull/30134/files#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070f
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 26, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-307534368
View reviewed changes https://github.com/nodejs/node/pull/30134/files
src/util.hhttps://github.com/nodejs/node/pull/30134/files#diff-40ab92941994ec9418dbb76ae46d5aef0e4cb8b034f2be2b31562bb9aca8070f
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 26, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-307534782
View reviewed changes https://github.com/nodejs/node/pull/30134/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2019https://github.com/nodejs/node/pull/30134#issuecomment-546621587
https://ci.nodejs.org/job/node-test-pull-request/26211/https://ci.nodejs.org/job/node-test-pull-request/26211/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Oct 26, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-307539204
View reviewed changes https://github.com/nodejs/node/pull/30134/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 26, 2019https://github.com/nodejs/node/pull/30134#event-2746235558
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2019https://github.com/nodejs/node/pull/30134#issuecomment-546630919
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2019https://github.com/nodejs/node/pull/30134#issuecomment-546630977
https://ci.nodejs.org/job/node-test-pull-request/26214/https://ci.nodejs.org/job/node-test-pull-request/26214/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 26, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-307546757
View reviewed changes https://github.com/nodejs/node/pull/30134/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 1, 2019https://github.com/nodejs/node/pull/30134#event-2762980835
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2019https://github.com/nodejs/node/pull/30134#issuecomment-548763755
https://ci.nodejs.org/job/node-test-pull-request/26278/https://ci.nodejs.org/job/node-test-pull-request/26278/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2019https://github.com/nodejs/node/pull/30134#issuecomment-548917816
https://ci.nodejs.org/job/node-test-pull-request/26287/https://ci.nodejs.org/job/node-test-pull-request/26287/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2019https://github.com/nodejs/node/pull/30134#issuecomment-549251166
https://ci.nodejs.org/job/node-test-pull-request/26316/https://ci.nodejs.org/job/node-test-pull-request/26316/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2019https://github.com/nodejs/node/pull/30134#issuecomment-549339152
https://ci.nodejs.org/job/node-test-pull-request/26323/https://ci.nodejs.org/job/node-test-pull-request/26323/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30134#issuecomment-549964315
https://ci.nodejs.org/job/node-test-pull-request/26355/https://ci.nodejs.org/job/node-test-pull-request/26355/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 5, 2019 https://github.com/nodejs/node/pull/30134#pullrequestreview-311973575
View reviewed changes https://github.com/nodejs/node/pull/30134/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550023463
https://ci.nodejs.org/job/node-test-pull-request/26368/https://ci.nodejs.org/job/node-test-pull-request/26368/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550070521
https://ci.nodejs.org/job/node-test-pull-request/26381/https://ci.nodejs.org/job/node-test-pull-request/26381/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550299190
https://ci.nodejs.org/job/node-test-pull-request/26405/https://ci.nodejs.org/job/node-test-pull-request/26405/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
addaleaxhttps://github.com/addaleax
November 6, 2019 22:21https://github.com/nodejs/node/pull/30134#commits-pushed-206f134
https://github.com/addaleax
src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/pull/30134/commits/206f1348a27cc1e1c6c11ea171c3d5993d294337
206f134https://github.com/nodejs/node/pull/30134/commits/206f1348a27cc1e1c6c11ea171c3d5993d294337
https://github.com/addaleax
fixup! src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/pull/30134/commits/776285fdc5bb6bec869931d9b98b7dbad900f958
776285fhttps://github.com/nodejs/node/pull/30134/commits/776285fdc5bb6bec869931d9b98b7dbad900f958
https://github.com/addaleax
fixup! src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/pull/30134/commits/e3aa3b6ad958ff5f77904f17b935e159dc8e05d6
e3aa3b6https://github.com/nodejs/node/pull/30134/commits/e3aa3b6ad958ff5f77904f17b935e159dc8e05d6
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/552b639ed82f03c20549fe83b9dfc871b4fe32f6..e3aa3b6ad958ff5f77904f17b935e159dc8e05d6
552b639https://github.com/nodejs/node/commit/552b639ed82f03c20549fe83b9dfc871b4fe32f6
e3aa3b6https://github.com/nodejs/node/commit/e3aa3b6ad958ff5f77904f17b935e159dc8e05d6
Compare https://github.com/nodejs/node/compare/552b639ed82f03c20549fe83b9dfc871b4fe32f6..e3aa3b6ad958ff5f77904f17b935e159dc8e05d6
November 6, 2019 21:28https://github.com/nodejs/node/pull/30134#event-2776945897
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550508316
https://ci.nodejs.org/job/node-test-pull-request/26417/https://ci.nodejs.org/job/node-test-pull-request/26417/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550509276
https://ci.nodejs.org/job/node-test-pull-request/26418/https://ci.nodejs.org/job/node-test-pull-request/26418/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550528857
https://ci.nodejs.org/job/node-test-pull-request/26422/https://ci.nodejs.org/job/node-test-pull-request/26422/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 7, 2019https://github.com/nodejs/node/pull/30134#issuecomment-550558824
https://ci.nodejs.org/job/node-test-pull-request/26426/https://ci.nodejs.org/job/node-test-pull-request/26426/
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2019https://github.com/nodejs/node/pull/30134#issuecomment-551003365
6072e01https://github.com/nodejs/node/commit/6072e01c938e22498cd46c3d8a2c21a16a632456
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2019https://github.com/nodejs/node/pull/30134#event-2778665492
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 7, 2019 09:45https://github.com/nodejs/node/pull/30134#event-2778666244
addaleaxhttps://github.com/addaleax
Nov 7, 2019 https://github.com/nodejs/node/pull/30134#ref-commit-6072e01
https://github.com/addaleax
src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/commit/6072e01c938e22498cd46c3d8a2c21a16a632456
6072e01https://github.com/nodejs/node/commit/6072e01c938e22498cd46c3d8a2c21a16a632456
#30134https://github.com/nodejs/node/pull/30134
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30134#ref-commit-058a8d5
https://github.com/addaleax
https://github.com/MylesBorins
src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/commit/058a8d53631df7aba5fbbff8859ebc8e88fade49
058a8d5https://github.com/nodejs/node/commit/058a8d53631df7aba5fbbff8859ebc8e88fade49
#30134https://github.com/nodejs/node/pull/30134
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30134#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
https://github.com/targos
targoshttps://github.com/targos
Dec 1, 2019https://github.com/nodejs/node/pull/30134#issuecomment-560084381
#29874https://github.com/nodejs/node/pull/29874
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Dec 1, 2019https://github.com/nodejs/node/pull/30134#event-2843309040
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2020 https://github.com/nodejs/node/pull/30134#ref-commit-69dac4b
https://github.com/addaleax
https://github.com/MylesBorins
src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/commit/69dac4b9b91b6541e3cfbb296f02450d6a928bef
69dac4bhttps://github.com/nodejs/node/commit/69dac4b9b91b6541e3cfbb296f02450d6a928bef
#30134https://github.com/nodejs/node/pull/30134
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30134#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30134#ref-commit-a5d2b66
https://github.com/addaleax
https://github.com/BethGriggs
src: do not use std::function for OnScopeLeavehttps://github.com/nodejs/node/commit/a5d2b66bdc6e164247d331ea406ca619a7d2fd01
a5d2b66https://github.com/nodejs/node/commit/a5d2b66bdc6e164247d331ea406ca619a7d2fd01
#30134https://github.com/nodejs/node/pull/30134
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30134#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30134
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/30134/files/552b639ed82f03c20549fe83b9dfc871b4fe32f6
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30134/files/552b639ed82f03c20549fe83b9dfc871b4fe32f6
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30134/files/3fd0dc28328a1a1630c9a5c6e1ec488bcc4157a8
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30134/files/772b8cb3ff9fccefff9b9c2d3250aad44c8b548c
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/30134/files/3fd0dc28328a1a1630c9a5c6e1ec488bcc4157a8
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/30134
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/fhinkel
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.