René's URL Explorer Experiment


Title: encoding: make TextDecoder handle BOM correctly by addaleax · Pull Request #30132 · nodejs/node · GitHub

Open Graph Title: encoding: make TextDecoder handle BOM correctly by addaleax · Pull Request #30132 · nodejs/node

X Title: encoding: make TextDecoder handle BOM correctly by addaleax · Pull Request #30132 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not accept the BOM if it comes from a different encoding, and only discard the BOM after it has actually been read (including when it is spread over multiple chunks in streaming mode). Fixes: #2...

X Description: Do not accept the BOM if it comes from a different encoding, and only discard the BOM after it has actually been read (including when it is spread over multiple chunks in streaming mode). Fixes: #2...

Opengraph URL: https://github.com/nodejs/node/pull/30132

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3f584568-5ce6-1745-af4f-511aad35b770
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA650:1E92:16646AA:1FEA4EC:6A4F5D4B
html-safe-nonce4e970754735ebdceca2937282d7f16b6a38a270ede28d8896af8ab58c44dc799
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjUwOjFFOTI6MTY2NDZBQToxRkVBNEVDOjZBNEY1RDRCIiwidmlzaXRvcl9pZCI6IjQzNTA0MjQ5NTA1OTY2NTY0NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9bd8845658964b79b2b5e76301d3c39bd46bca2b3754c2354752ae9e47962176
hovercard-subject-tagpull_request:332774569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30132/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c9daa8ba8bf9c9e0d4732074d6d57ffc46c6bb0efa8aeea5fe67d383b4fd8068/nodejs/node/pull/30132
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c9daa8ba8bf9c9e0d4732074d6d57ffc46c6bb0efa8aeea5fe67d383b4fd8068/nodejs/node/pull/30132
og:image:altDo not accept the BOM if it comes from a different encoding, and only discard the BOM after it has actually been read (including when it is spread over multiple chunks in streaming mode). Fixes: #2...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30132#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30132
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30132
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30132
Reloadhttps://github.com/nodejs/node/pull/30132
Reloadhttps://github.com/nodejs/node/pull/30132
Please reload this pagehttps://github.com/nodejs/node/pull/30132
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30132
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:textdecoder-bomhttps://github.com/addaleax/node/tree/textdecoder-bom
Conversationhttps://github.com/nodejs/node/pull/30132
Commits1 (1)https://github.com/nodejs/node/pull/30132/commits
Checkshttps://github.com/nodejs/node/pull/30132/checks
Files changedhttps://github.com/nodejs/node/pull/30132/files
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/pull/30132#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:textdecoder-bomhttps://github.com/addaleax/node/tree/textdecoder-bom
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2019https://github.com/nodejs/node/pull/30132#issue-512847181
#25315https://github.com/nodejs/node/issues/25315
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 26, 2019https://github.com/nodejs/node/pull/30132#event-2746125646
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2019https://github.com/nodejs/node/pull/30132#issuecomment-546611663
https://ci.nodejs.org/job/node-test-pull-request/26209/https://ci.nodejs.org/job/node-test-pull-request/26209/
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
encoding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 1, 2019https://github.com/nodejs/node/pull/30132#event-2763036846
https://github.com/addaleax
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/pull/30132/commits/a30272b33395317fe79d39c42dd2d1e313561080
a30272bhttps://github.com/nodejs/node/pull/30132/commits/a30272b33395317fe79d39c42dd2d1e313561080
nodejs#25315https://github.com/nodejs/node/issues/25315
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/b6414f51f2ba39ec5869a3cde48cda1814cf3903..a30272b33395317fe79d39c42dd2d1e313561080
b6414f5https://github.com/nodejs/node/commit/b6414f51f2ba39ec5869a3cde48cda1814cf3903
a30272bhttps://github.com/nodejs/node/commit/a30272b33395317fe79d39c42dd2d1e313561080
Compare https://github.com/nodejs/node/compare/b6414f51f2ba39ec5869a3cde48cda1814cf3903..a30272b33395317fe79d39c42dd2d1e313561080
November 1, 2019 12:45https://github.com/nodejs/node/pull/30132#event-2763079153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2019https://github.com/nodejs/node/pull/30132#issuecomment-548775151
https://ci.nodejs.org/job/node-test-pull-request/26282/https://ci.nodejs.org/job/node-test-pull-request/26282/
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2019https://github.com/nodejs/node/pull/30132#issuecomment-549251348
https://ci.nodejs.org/job/node-test-pull-request/26317/https://ci.nodejs.org/job/node-test-pull-request/26317/
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 4, 2019 https://github.com/nodejs/node/pull/30132#pullrequestreview-310918917
View reviewed changes https://github.com/nodejs/node/pull/30132/files/a30272b33395317fe79d39c42dd2d1e313561080
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Nov 4, 2019https://github.com/nodejs/node/pull/30132#event-2767555561
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30132#issuecomment-549982050
237be2ehttps://github.com/nodejs/node/commit/237be2ed9e25e4d56deaf3935be0c217913e5a75
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30132#event-2772675021
addaleaxhttps://github.com/addaleax
Nov 5, 2019 https://github.com/nodejs/node/pull/30132#ref-commit-237be2e
https://github.com/addaleax
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/commit/237be2ed9e25e4d56deaf3935be0c217913e5a75
237be2ehttps://github.com/nodejs/node/commit/237be2ed9e25e4d56deaf3935be0c217913e5a75
#25315https://github.com/nodejs/node/issues/25315
#30132https://github.com/nodejs/node/pull/30132
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 5, 2019 19:30https://github.com/nodejs/node/pull/30132#event-2772675628
https://github.com/srl295
srl295https://github.com/srl295
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30132#event-2772688256
https://github.com/srl295
srl295https://github.com/srl295
Nov 5, 2019 https://github.com/nodejs/node/pull/30132#pullrequestreview-311991503
View reviewed changes https://github.com/nodejs/node/pull/30132/files/a30272b33395317fe79d39c42dd2d1e313561080
srl295https://github.com/srl295
https://github.com/nodejs/node/pull/30132#pullrequestreview-311991503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30132#issuecomment-549988385
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/srl295
srl295https://github.com/srl295
Nov 5, 2019https://github.com/nodejs/node/pull/30132#issuecomment-550004887
https://unicode-org.atlassian.nethttps://unicode-org.atlassian.net
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2019https://github.com/nodejs/node/pull/30132#issuecomment-550009882
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/srl295
srl295https://github.com/srl295
Nov 5, 2019https://github.com/nodejs/node/pull/30132#issuecomment-550017539
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/30132
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30132#ref-commit-c2c74fc
https://github.com/addaleax
https://github.com/MylesBorins
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/commit/c2c74fc93e9cc80e38f3e1aaab921680ce1e93f4
c2c74fchttps://github.com/nodejs/node/commit/c2c74fc93e9cc80e38f3e1aaab921680ce1e93f4
#25315https://github.com/nodejs/node/issues/25315
#30132https://github.com/nodejs/node/pull/30132
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30132#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30132#ref-commit-3be9b22
https://github.com/addaleax
https://github.com/targos
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/commit/3be9b223482de057032510ddc57ddcf5c4e01332
3be9b22https://github.com/nodejs/node/commit/3be9b223482de057032510ddc57ddcf5c4e01332
#25315https://github.com/nodejs/node/issues/25315
#30132https://github.com/nodejs/node/pull/30132
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30132#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30132#ref-commit-c80a4d8
https://github.com/addaleax
https://github.com/MylesBorins
encoding: make TextDecoder handle BOM correctlyhttps://github.com/nodejs/node/commit/c80a4d851d2aae06871ae499ecc4dece202c4794
c80a4d8https://github.com/nodejs/node/commit/c80a4d851d2aae06871ae499ecc4dece202c4794
#25315https://github.com/nodejs/node/issues/25315
#30132https://github.com/nodejs/node/pull/30132
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30132#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.com/phated
phatedhttps://github.com/phated
Apr 18, 2022 https://github.com/nodejs/node/pull/30132#ref-pullrequest-1207468227
lib: ensure TextDecoder only removes utf8 BOM on utf8 encoding #42779 https://github.com/nodejs/node/pull/42779
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30132
https://github.com/srl295
srl295 https://github.com/srl295
https://github.com/nodejs/node/pull/30132/files/a30272b33395317fe79d39c42dd2d1e313561080
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/30132/files/a30272b33395317fe79d39c42dd2d1e313561080
https://github.com/addaleax
addaleax https://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
encoding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding
TextDecoder should not output BOM https://github.com/nodejs/node/issues/25315
Please reload this pagehttps://github.com/nodejs/node/pull/30132
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/srl295
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.