René's URL Explorer Experiment


Title: build: fix detection of Visual Studio 2017 by richardlau · Pull Request #30119 · nodejs/node · GitHub

Open Graph Title: build: fix detection of Visual Studio 2017 by richardlau · Pull Request #30119 · nodejs/node

X Title: build: fix detection of Visual Studio 2017 by richardlau · Pull Request #30119 · nodejs/node

Description: When run in a Visual Studio 2017 command prompt the VCINSTALLDIR environment variable will be already set and is not cleared by the tools/msvs/vswhere_usability_wrapper.cmd utility when it fails to...

Open Graph Description: When run in a Visual Studio 2017 command prompt the VCINSTALLDIR environment variable will be already set and is not cleared by the tools/msvs/vswhere_usability_wrapper.cmd utility when it fails to...

X Description: When run in a Visual Studio 2017 command prompt the VCINSTALLDIR environment variable will be already set and is not cleared by the tools/msvs/vswhere_usability_wrapper.cmd utility when it fails to...

Opengraph URL: https://github.com/nodejs/node/pull/30119

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57b8460d-b56d-f70e-9256-69a312122d3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2FC:1E4FEF:BE4FAF:F52D3D:696AFE3E
html-safe-nonced29c6e6bd23160642b29a4da7f78064477ee4c8b8feb5ef47ffd17201cdaa85d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZDOjFFNEZFRjpCRTRGQUY6RjUyRDNEOjY5NkFGRTNFIiwidmlzaXRvcl9pZCI6IjgwMTE0MzQ5NjAzNjAyNDI3NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7fe798553cdf57df8b30c67d57030f9b252044405fd9e77da697f8de91081a32
hovercard-subject-tagpull_request:332584544
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30119/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b81a54757bdadefd5c0abd301f182120588e4a767e9104b1a3d69f4f2a7d7d4/nodejs/node/pull/30119
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b81a54757bdadefd5c0abd301f182120588e4a767e9104b1a3d69f4f2a7d7d4/nodejs/node/pull/30119
og:image:altWhen run in a Visual Studio 2017 command prompt the VCINSTALLDIR environment variable will be already set and is not cleared by the tools/msvs/vswhere_usability_wrapper.cmd utility when it fails to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30119#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30119
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30119
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30119
Reloadhttps://github.com/nodejs/node/pull/30119
Reloadhttps://github.com/nodejs/node/pull/30119
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30119
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30119
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30119#issue-comment-box
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:vs2017https://github.com/richardlau/node-1/tree/vs2017
build: fix detection of Visual Studio 2017 https://github.com/nodejs/node/pull/30119#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:vs2017https://github.com/richardlau/node-1/tree/vs2017
Conversation 20 https://github.com/nodejs/node/pull/30119
Commits 1 https://github.com/nodejs/node/pull/30119/commits
Checks 0 https://github.com/nodejs/node/pull/30119/checks
Files changed https://github.com/nodejs/node/pull/30119/files
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issue-512603440
Please reload this pagehttps://github.com/nodejs/node/pull/30119
#30118https://github.com/nodejs/node/issues/30118
#30022https://github.com/nodejs/node/pull/30022
@targoshttps://github.com/targos
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Oct 25, 2019https://github.com/nodejs/node/pull/30119#event-2744750936
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019 https://github.com/nodejs/node/pull/30119#ref-issue-512599155
vcbuild.bat fails with Visual Studio 2017 #30118 https://github.com/nodejs/node/issues/30118
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#event-2744802729
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/906cb2e0bdb503364fc9cda62df41b5bb432989a..89d2593fae8d6e92cc2cf58760a123a632f6364f
906cb2ehttps://github.com/nodejs/node/commit/906cb2e0bdb503364fc9cda62df41b5bb432989a
89d2593https://github.com/nodejs/node/commit/89d2593fae8d6e92cc2cf58760a123a632f6364f
Compare https://github.com/nodejs/node/compare/906cb2e0bdb503364fc9cda62df41b5bb432989a..89d2593fae8d6e92cc2cf58760a123a632f6364f
October 25, 2019 16:39https://github.com/nodejs/node/pull/30119#event-2744807748
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#event-2744807762
https://github.com/targos
targoshttps://github.com/targos
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546455802
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/targos
targoshttps://github.com/targos
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546456240
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546456852
#30118 (comment)https://github.com/nodejs/node/issues/30118#issuecomment-546415509
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546461538
Please reload this pagehttps://github.com/nodejs/node/pull/30119
node/vcbuild.bathttps://github.com/nodejs/node/blob/11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93/vcbuild.bat#L239-L272
11275dchttps://github.com/nodejs/node/commit/11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546467287
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546470304
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 25, 2019https://github.com/nodejs/node/pull/30119#event-2745149747
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/89d2593fae8d6e92cc2cf58760a123a632f6364f..f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6
89d2593https://github.com/nodejs/node/commit/89d2593fae8d6e92cc2cf58760a123a632f6364f
f129125https://github.com/nodejs/node/commit/f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6
Compare https://github.com/nodejs/node/compare/89d2593fae8d6e92cc2cf58760a123a632f6364f..f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6
October 25, 2019 19:36https://github.com/nodejs/node/pull/30119#event-2745261325
https://github.com/richardlau
richardlauhttps://github.com/richardlau
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 25, 2019https://github.com/nodejs/node/pull/30119#event-2745261903
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 25, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546485896
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6..15e8421005090f511e8969bff5cf97482953091c
f129125https://github.com/nodejs/node/commit/f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6
15e8421https://github.com/nodejs/node/commit/15e8421005090f511e8969bff5cf97482953091c
Compare https://github.com/nodejs/node/compare/f1291253baf00a9ceea0b384ad61ccb3cfd1f2a6..15e8421005090f511e8969bff5cf97482953091c
October 25, 2019 19:39https://github.com/nodejs/node/pull/30119#event-2745269162
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546565055
https://ci.nodejs.org/job/node-test-pull-request/26202/https://ci.nodejs.org/job/node-test-pull-request/26202/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2019 https://github.com/nodejs/node/pull/30119#pullrequestreview-307526966
View reviewed changes https://github.com/nodejs/node/pull/30119/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 26, 2019https://github.com/nodejs/node/pull/30119#event-2746084661
https://github.com/targos
targoshttps://github.com/targos
Oct 27, 2019 https://github.com/nodejs/node/pull/30119#pullrequestreview-307557188
View reviewed changes https://github.com/nodejs/node/pull/30119/files
https://github.com/targos
targoshttps://github.com/targos
Oct 27, 2019https://github.com/nodejs/node/pull/30119#issuecomment-546677158
@joaocgreishttps://github.com/joaocgreis
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Oct 29, 2019 https://github.com/nodejs/node/pull/30119#pullrequestreview-308217191
View reviewed changes https://github.com/nodejs/node/pull/30119/files
joaocgreishttps://github.com/joaocgreis
https://github.com/nodejs/node/pull/30119#pullrequestreview-308217191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/30119
vcbuild.bathttps://github.com/nodejs/node/pull/30119/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
joaocgreishttps://github.com/joaocgreis
Oct 29, 2019https://github.com/nodejs/node/pull/30119#discussion_r339847277
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30119
joaocgreishttps://github.com/joaocgreis
Oct 29, 2019https://github.com/nodejs/node/pull/30119#discussion_r339847542
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30119
richardlauhttps://github.com/richardlau
Oct 31, 2019https://github.com/nodejs/node/pull/30119#discussion_r340967437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/dcdd3286ce69ef7caf55247fe17e8aabdd87e868..07c4965dc1cc440aaa3214d35bfa7017f8c55f9d
dcdd328https://github.com/nodejs/node/commit/dcdd3286ce69ef7caf55247fe17e8aabdd87e868
07c4965https://github.com/nodejs/node/commit/07c4965dc1cc440aaa3214d35bfa7017f8c55f9d
Compare https://github.com/nodejs/node/compare/dcdd3286ce69ef7caf55247fe17e8aabdd87e868..07c4965dc1cc440aaa3214d35bfa7017f8c55f9d
October 31, 2019 05:39https://github.com/nodejs/node/pull/30119#event-2758516692
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 31, 2019https://github.com/nodejs/node/pull/30119#issuecomment-548231685
https://ci.nodejs.org/job/node-test-pull-request/26253/https://ci.nodejs.org/job/node-test-pull-request/26253/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 31, 2019https://github.com/nodejs/node/pull/30119#issuecomment-548242802
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://ci.nodejs.org/job/node-test-pull-request/26254/https://ci.nodejs.org/job/node-test-pull-request/26254/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 5, 2019 https://github.com/nodejs/node/pull/30119#pullrequestreview-311469232
View reviewed changes https://github.com/nodejs/node/pull/30119/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30119#issuecomment-549633184
https://ci.nodejs.org/job/node-test-pull-request/26337/https://ci.nodejs.org/job/node-test-pull-request/26337/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30119#issuecomment-549642957
https://ci.nodejs.org/job/node-test-pull-request/26338/https://ci.nodejs.org/job/node-test-pull-request/26338/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 5, 2019https://github.com/nodejs/node/pull/30119#issuecomment-549644800
https://ci.nodejs.org/job/node-test-pull-request/26339/https://ci.nodejs.org/job/node-test-pull-request/26339/
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
build: fix detection of Visual Studio 2017https://github.com/nodejs/node/pull/30119/commits/1f2fdc9538f2ee9d9fad68137798c49113e96274
1f2fdc9https://github.com/nodejs/node/pull/30119/commits/1f2fdc9538f2ee9d9fad68137798c49113e96274
nodejs#30119https://github.com/nodejs/node/pull/30119
nodejs#30118https://github.com/nodejs/node/issues/30118
nodejs#30022https://github.com/nodejs/node/pull/30022
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/07c4965dc1cc440aaa3214d35bfa7017f8c55f9d..1f2fdc9538f2ee9d9fad68137798c49113e96274
07c4965https://github.com/nodejs/node/commit/07c4965dc1cc440aaa3214d35bfa7017f8c55f9d
1f2fdc9https://github.com/nodejs/node/commit/1f2fdc9538f2ee9d9fad68137798c49113e96274
Compare https://github.com/nodejs/node/compare/07c4965dc1cc440aaa3214d35bfa7017f8c55f9d..1f2fdc9538f2ee9d9fad68137798c49113e96274
November 5, 2019 03:43https://github.com/nodejs/node/pull/30119#event-2769991836
https://github.com/richardlau
richardlauhttps://github.com/richardlau
1f2fdc9https://github.com/nodejs/node/commit/1f2fdc9538f2ee9d9fad68137798c49113e96274
Nov 5, 2019https://github.com/nodejs/node/pull/30119#event-2770009753
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 5, 2019https://github.com/nodejs/node/pull/30119#issuecomment-549653124
1f2fdc9https://github.com/nodejs/node/commit/1f2fdc9538f2ee9d9fad68137798c49113e96274
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
richardlauhttps://github.com/richardlau
November 5, 2019 04:03https://github.com/nodejs/node/pull/30119#event-2770015927
targoshttps://github.com/targos
Nov 5, 2019 https://github.com/nodejs/node/pull/30119#ref-commit-1bded98
https://github.com/richardlau
https://github.com/targos
build: fix detection of Visual Studio 2017https://github.com/nodejs/node/commit/1bded9841c24bf2f119ad61c88b7ad3703ec0d0c
1bded98https://github.com/nodejs/node/commit/1bded9841c24bf2f119ad61c88b7ad3703ec0d0c
#30119https://github.com/nodejs/node/pull/30119
#30118https://github.com/nodejs/node/issues/30118
#30022https://github.com/nodejs/node/pull/30022
https://github.com/targos
targoshttps://github.com/targos
Nov 5, 2019 https://github.com/nodejs/node/pull/30119#ref-pullrequest-517668487
v13.1.0 release proposal #30262 https://github.com/nodejs/node/pull/30262
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
Nov 8, 2019https://github.com/nodejs/node/pull/30119#event-2782877839
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 17, 2020 https://github.com/nodejs/node/pull/30119#ref-issue-531600514
VS 2019 libuv/libuv#2560 https://github.com/libuv/libuv/issues/2560
https://github.com/bingenito
bingenitohttps://github.com/bingenito
Oct 28, 2020 https://github.com/nodejs/node/pull/30119#ref-issue-731629081
vcbuild.bat fails for Visual Studio 2019 if VCINSTALLDIR intentionally pre-defined #35856 https://github.com/nodejs/node/issues/35856
https://github.com/bingenito
bingenitohttps://github.com/bingenito
Nov 13, 2020 https://github.com/nodejs/node/pull/30119#ref-pullrequest-738050844
build: conditionally clear vcinstalldir #36009 https://github.com/nodejs/node/pull/36009
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30119
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30119/files/15e8421005090f511e8969bff5cf97482953091c
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/30119/files/15e8421005090f511e8969bff5cf97482953091c
https://github.com/joaocgreis
joaocgreis https://github.com/joaocgreis
https://github.com/nodejs/node/pull/30119/files/07c4965dc1cc440aaa3214d35bfa7017f8c55f9d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
vcbuild.bat fails with Visual Studio 2017 https://github.com/nodejs/node/issues/30118
Please reload this pagehttps://github.com/nodejs/node/pull/30119
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/joaocgreis
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.