| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0df4fed4-2884-e338-4b82-585a8989a49e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCB6:CD446:2992A0D:3943FCC:6A4F02B6 |
| html-safe-nonce | 6a7762f8c04b68a4c2d2ce874eaad69b72330335e4a669edf68d69238ef9bcbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0I2OkNENDQ2OjI5OTJBMEQ6Mzk0M0ZDQzo2QTRGMDJCNiIsInZpc2l0b3JfaWQiOiIzOTE4MjQzMDgwNDU3NjE4MTAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 28ffff2c941148a5caf75b12e2bdf453adcdf3d8b86555a3eee5e6535b40e8cf |
| hovercard-subject-tag | pull_request:331227089 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30070/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a2428370e434537e3c7f8daa619c3502356fe30f72951185b0b2c6da3149f37e/nodejs/node/pull/30070 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a2428370e434537e3c7f8daa619c3502356fe30f72951185b0b2c6da3149f37e/nodejs/node/pull/30070 |
| og:image:alt | Since worker threads are complete Node.js environments, including the
ability to load native addons, and since those native addons can
allocate resources to be freed when objects go out of scope, a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30070#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30070 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30070 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30070 |
| Reload | https://github.com/nodejs/node/pull/30070 |
| Reload | https://github.com/nodejs/node/pull/30070 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| gabrielschulhof:backport-28428-to-v12.x | https://github.com/gabrielschulhof/node/tree/backport-28428-to-v12.x |
| Conversation | https://github.com/nodejs/node/pull/30070 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30070/commits |
| Checks | https://github.com/nodejs/node/pull/30070/checks |
| Files changed | https://github.com/nodejs/node/pull/30070/files |
| [v12.x] src: render N-API weak callbacks as cleanup hooks | https://github.com/nodejs/node/pull/30070#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| gabrielschulhof:backport-28428-to-v12.x | https://github.com/gabrielschulhof/node/tree/backport-28428-to-v12.x |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#issue-510938668 |
| tc39/proposal-weakrefs#125 (comment) | https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130 |
| #28428 | https://github.com/nodejs/node/pull/28428 |
| @addaleax | https://github.com/addaleax |
| @mhdawson | https://github.com/mhdawson |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#event-2734934675 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#event-2734935150 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#event-2734935556 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| addaleax | https://github.com/addaleax |
| cjihrig | https://github.com/cjihrig |
| mhdawson | https://github.com/mhdawson |
| October 22, 2019 21:46 | https://github.com/nodejs/node/pull/30070#event-2734935753 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/30070#pullrequestreview-305529120 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30070/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/30070#pullrequestreview-305529120 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-545170897 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/30070#ref-pullrequest-510969260 |
|
[v12.x] build: build benchmark addons like test addons
#30072
| https://github.com/nodejs/node/pull/30072 |
| src: render N-API weak callbacks as cleanup hooks | https://github.com/nodejs/node/pull/30070/commits/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| 063c2ff | https://github.com/nodejs/node/pull/30070/commits/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| tc39/proposal-weakrefs#125 (comment) | https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130 |
| nodejs#28428 | https://github.com/nodejs/node/pull/28428 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/7c9b66f04cb5d6d54d1e82dcc6ab2fc8fbf6ab15..063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| 7c9b66f | https://github.com/nodejs/node/commit/7c9b66f04cb5d6d54d1e82dcc6ab2fc8fbf6ab15 |
| 063c2ff | https://github.com/nodejs/node/commit/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
|
Compare
| https://github.com/nodejs/node/compare/7c9b66f04cb5d6d54d1e82dcc6ab2fc8fbf6ab15..063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| October 22, 2019 22:45 | https://github.com/nodejs/node/pull/30070#event-2735070680 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-545188125 |
| #29995 | https://github.com/nodejs/node/pull/29995 |
| #30072 | https://github.com/nodejs/node/pull/30072 |
| #30072 | https://github.com/nodejs/node/pull/30072 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30070#pullrequestreview-305584514 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30070/files/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30070#ref-issue-507864682 |
|
Context-aware add-ons?
nodejs/node-addon-api#567
| https://github.com/nodejs/node-addon-api/issues/567 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 23, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-545358681 |
| #30072 | https://github.com/nodejs/node/pull/30072 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Oct 23, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-545676745 |
| @targos | https://github.com/targos |
| nodejs/node-addon-api#567 (comment) | https://github.com/nodejs/node-addon-api/issues/567#issuecomment-544835511 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 24, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-546129999 |
| @gabrielf | https://github.com/gabrielf |
| @targos | https://github.com/targos |
| https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Oct 26, 2019
| https://github.com/nodejs/node/pull/30070#pullrequestreview-307547589 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30070/files/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 8, 2019 | https://github.com/nodejs/node/pull/30070#issuecomment-551797432 |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 8, 2019 | https://github.com/nodejs/node/pull/30070#event-2782921568 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| March 13, 2020 06:47 | https://github.com/nodejs/node/pull/30070#event-3125582961 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30070 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/30070/files/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30070/files/7c9b66f04cb5d6d54d1e82dcc6ab2fc8fbf6ab15 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30070/files/063c2ff7a7ae380c98ac3d9b275947af091539c8 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/30070 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/targos |
|
| https://github.com/mhdawson |
|
| https://github.com/fhinkel |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |