| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:09eafe37-d036-c627-5350-aa5b830f9444 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 865C:13D32C:17573EE:1FCEBE9:6A52323B |
| html-safe-nonce | 90a15511f0ad6467bea7f22817c23c3d9cc5063fa9b043ceaeba793213b99949 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjVDOjEzRDMyQzoxNzU3M0VFOjFGQ0VCRTk6NkE1MjMyM0IiLCJ2aXNpdG9yX2lkIjoiOTE0NDg0NTc0MjgxNjUwNjQyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1d15618958edc85ee7be21d72ec205ba66a0aba91b763f1086fdc04f006436f9 |
| hovercard-subject-tag | pull_request:45688047 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3007/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc67bd1290d1a45e90019f246e45cc2da502884c13d9edb627910d7a859b0fd1/nodejs/node/pull/3007 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc67bd1290d1a45e90019f246e45cc2da502884c13d9edb627910d7a859b0fd1/nodejs/node/pull/3007 |
| og:image:alt | Went ahead and changed the failing test to use String.prototype.normalize so path strings are compared form-independently.
@srl295 The test will still fail on debug builds that don't include IC... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | silverwind |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/3007#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3007 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3007 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/3007 |
| Reload | https://github.com/nodejs/node/pull/3007 |
| Reload | https://github.com/nodejs/node/pull/3007 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
983
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| silverwind | https://github.com/silverwind |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| silverwind:normalize-fix | https://github.com/silverwind/node/tree/normalize-fix |
| Conversation | https://github.com/nodejs/node/pull/3007 |
| Commits0 (0) | https://github.com/nodejs/node/pull/3007/commits |
| Checks | https://github.com/nodejs/node/pull/3007/checks |
| Files changed | https://github.com/nodejs/node/pull/3007/files |
| test: use normalize() for unicode paths | https://github.com/nodejs/node/pull/3007#top |
| silverwind | https://github.com/silverwind |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| silverwind:normalize-fix | https://github.com/silverwind/node/tree/normalize-fix |
|
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#issue-107754860 |
| String.prototype.normalize | https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize |
| @srl295 | https://github.com/srl295 |
| #2165 | https://github.com/nodejs/node/issues/2165 |
| nodejs/docs#42 | https://github.com/nodejs/docs/issues/42 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#event-416074482 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-142346395 |
| https://ci.nodejs.org/job/node-test-pull-request/362/ | https://ci.nodejs.org/job/node-test-pull-request/362/ |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Sep 22, 2015
| https://github.com/nodejs/node/pull/3007#ref-issue-94518046 |
|
OS X 10.11: system calls return non-normalized unicode strings
#2165
| https://github.com/nodejs/node/issues/2165 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-142392903 |
| @silverwind | https://github.com/silverwind |
| https://github.com/nodejs/node/blob/master/test/parallel/test-intl.js#L13 | https://github.com/nodejs/node/blob/master/test/parallel/test-intl.js#L13 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-142393993 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 22, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-142401325 |
| https://ci.nodejs.org/job/node-test-pull-request/365/ | https://ci.nodejs.org/job/node-test-pull-request/365/ |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Sep 25, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-143374629 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
|
process.versions.icu
#3089
| https://github.com/nodejs/node/issues/3089 |
|
Test "test-process-chdir" fails on El Capitan
#3108
| https://github.com/nodejs/node/issues/3108 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 29, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-143948814 |
| #3089 | https://github.com/nodejs/node/issues/3089 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-144539517 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-144541564 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 3, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145209839 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 3, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145210496 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Oct 3, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145213084 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 3, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145216068 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 5, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145641972 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 5, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145664580 |
| https://ci.nodejs.org/job/node-test-pull-request/418/ | https://ci.nodejs.org/job/node-test-pull-request/418/ |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145793233 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| silverwind | https://github.com/silverwind |
|
Oct 6, 2015
| https://github.com/nodejs/node/pull/3007#ref-commit-81e98e9 |
|
| https://github.com/silverwind |
| test: use normalize() for unicode paths | https://github.com/nodejs/node/commit/81e98e9363c918899f964a6e054a41a82c04dc1b |
| 81e98e9 | https://github.com/nodejs/node/commit/81e98e9363c918899f964a6e054a41a82c04dc1b |
| #2165 | https://github.com/nodejs/node/issues/2165 |
| #3007 | https://github.com/nodejs/node/pull/3007 |
| #2165 | https://github.com/nodejs/node/issues/2165 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#event-428151630 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| force-pushed | https://github.com/nodejs/node/compare/dfd7a132d1ad6b94ec4e66efec6bdb5d4993cca4..81e98e9363c918899f964a6e054a41a82c04dc1b |
| dfd7a13 | https://github.com/nodejs/node/commit/dfd7a132d1ad6b94ec4e66efec6bdb5d4993cca4 |
| 81e98e9 | https://github.com/nodejs/node/commit/81e98e9363c918899f964a6e054a41a82c04dc1b |
|
Compare
| https://github.com/nodejs/node/compare/dfd7a132d1ad6b94ec4e66efec6bdb5d4993cca4..81e98e9363c918899f964a6e054a41a82c04dc1b |
| October 6, 2015 16:14 | https://github.com/nodejs/node/pull/3007#event-428151631 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| October 6, 2015 16:14 | https://github.com/nodejs/node/pull/3007#event-428152156 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145916361 |
| 81e98e9 | https://github.com/nodejs/node/commit/81e98e9363c918899f964a6e054a41a82c04dc1b |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145921134 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145921664 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 6, 2015 | https://github.com/nodejs/node/pull/3007#issuecomment-145922079 |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 8, 2015
| https://github.com/nodejs/node/pull/3007#ref-issue-110350972 |
|
Preparing v4.x for LTS
#3252
| https://github.com/nodejs/node/issues/3252 |
| silverwind | https://github.com/silverwind |
|
Oct 8, 2015
| https://github.com/nodejs/node/pull/3007#ref-commit-ddf2583 |
|
| https://github.com/silverwind |
|
| https://github.com/jasnell |
| test: use normalize() for unicode paths | https://github.com/nodejs/node/commit/ddf258376dd35d5813255b921701a75b28611979 |
| ddf2583 | https://github.com/nodejs/node/commit/ddf258376dd35d5813255b921701a75b28611979 |
| #2165 | https://github.com/nodejs/node/issues/2165 |
| #3007 | https://github.com/nodejs/node/pull/3007 |
| #2165 | https://github.com/nodejs/node/issues/2165 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-landed-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x |
| Oct 8, 2015 | https://github.com/nodejs/node/pull/3007#event-429878341 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 8, 2015
| https://github.com/nodejs/node/pull/3007#ref-pullrequest-110375513 |
|
Release proposal: v4.2.0 'Argon' (LTS)
#3258
| https://github.com/nodejs/node/pull/3258 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3007 |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/3007 |
|
| https://github.com/silverwind |
|
| https://github.com/srl295 |
|
| https://github.com/jbergstroem |
|
| https://github.com/rvagg |
|
| https://github.com/Fishrock123 |
|
| https://github.com/thefourtheye |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |