René's URL Explorer Experiment


Title: process: set process.env prototype to null by watson · Pull Request #30063 · nodejs/node · GitHub

Open Graph Title: process: set process.env prototype to null by watson · Pull Request #30063 · nodejs/node

X Title: process: set process.env prototype to null by watson · Pull Request #30063 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This removes all Object.prototype inherited features from process.env which make this a breaking change (e.g. hasOwnProperty(), toString() etc). Due to this, it might not be feasible to land this ...

X Description: This removes all Object.prototype inherited features from process.env which make this a breaking change (e.g. hasOwnProperty(), toString() etc). Due to this, it might not be feasible to land this ...

Opengraph URL: https://github.com/nodejs/node/pull/30063

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b0834293-b76f-6b36-0ea3-eaeadc9a5611
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD450:132037:842312:BC214D:6A51062D
html-safe-nonce7fbe9e6b4b8db257dc4bea2b1c6c66f6294122c928eb4c0b37e150ec25371348
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDUwOjEzMjAzNzo4NDIzMTI6QkMyMTREOjZBNTEwNjJEIiwidmlzaXRvcl9pZCI6IjkxODk5MDc1MDAzMDM5NzU5ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4143292d683e0f63335fdfc4c561660c6fd46ff30ffc4b4310007f711b0de6f9
hovercard-subject-tagpull_request:331004762
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30063/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2c7053311f6e6b15ed54fca2120bc35594f4f2e39ee5ce16d5ddfcb79c32f007/nodejs/node/pull/30063
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c7053311f6e6b15ed54fca2120bc35594f4f2e39ee5ce16d5ddfcb79c32f007/nodejs/node/pull/30063
og:image:altThis removes all Object.prototype inherited features from process.env which make this a breaking change (e.g. hasOwnProperty(), toString() etc). Due to this, it might not be feasible to land this ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatson
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30063#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30063
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30063
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30063
Reloadhttps://github.com/nodejs/node/pull/30063
Reloadhttps://github.com/nodejs/node/pull/30063
Please reload this pagehttps://github.com/nodejs/node/pull/30063
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30063
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
watsonhttps://github.com/watson
nodejs:masterhttps://github.com/nodejs/node/tree/master
watson:harden-process-envhttps://github.com/watson/node/tree/harden-process-env
Conversationhttps://github.com/nodejs/node/pull/30063
Commits3 (3)https://github.com/nodejs/node/pull/30063/commits
Checkshttps://github.com/nodejs/node/pull/30063/checks
Files changedhttps://github.com/nodejs/node/pull/30063/files
process: set process.env prototype to nullhttps://github.com/nodejs/node/pull/30063#top
watsonhttps://github.com/watson
nodejs:masterhttps://github.com/nodejs/node/tree/master
watson:harden-process-envhttps://github.com/watson/node/tree/harden-process-env
https://github.com/watson
watsonhttps://github.com/watson
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issue-510671149
prototype pollutionhttps://www.youtube.com/watch?v=LUsiFV3dsK8
#30008https://github.com/nodejs/node/pull/30008
#30008https://github.com/nodejs/node/pull/30008
@joyeecheunghttps://github.com/joyeecheung
test/parallel/test-process-env.jshttps://github.com/nodejs/node/blob/master/test/parallel/test-process-env.js
node/test/parallel/test-process-env.jshttps://github.com/nodejs/node/blob/31217a8e88d7414579284267f8715112bf8a0fc6/test/parallel/test-process-env.js#L41-L42
31217a8https://github.com/nodejs/node/commit/31217a8e88d7414579284267f8715112bf8a0fc6
fee02dbhttps://github.com/nodejs/node/commit/fee02db705152a42c8db442d3ab76b2296e59bbd
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
process: set process.env prototype to nullhttps://github.com/nodejs/node/pull/30063/commits/7d7285bf908f2c00336ac2b80e43c9a4442b5b19
7d7285bhttps://github.com/nodejs/node/pull/30063/commits/7d7285bf908f2c00336ac2b80e43c9a4442b5b19
https://github.com/watson
watsonhttps://github.com/watson
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
discuss https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adiscuss
Oct 22, 2019https://github.com/nodejs/node/pull/30063#event-2733381406
https://github.com/watson
watsonhttps://github.com/watson
Oct 22, 2019https://github.com/nodejs/node/pull/30063#event-2733381463
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 22, 2019https://github.com/nodejs/node/pull/30063#event-2733381664
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 22, 2019 https://github.com/nodejs/node/pull/30063#pullrequestreview-305234309
View reviewed changes https://github.com/nodejs/node/pull/30063/files/7d7285bf908f2c00336ac2b80e43c9a4442b5b19
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/30063#pullrequestreview-305234309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30063
src/node_env_var.cchttps://github.com/nodejs/node/pull/30063/files/7d7285bf908f2c00336ac2b80e43c9a4442b5b19#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issuecomment-545009627
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
Improve C++ codeehttps://github.com/nodejs/node/pull/30063/commits/a5bb9f5ecd5dd555d1b6ead90ed83c621c7ae966
a5bb9f5https://github.com/nodejs/node/pull/30063/commits/a5bb9f5ecd5dd555d1b6ead90ed83c621c7ae966
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 22, 2019 https://github.com/nodejs/node/pull/30063#pullrequestreview-305458133
View reviewed changes https://github.com/nodejs/node/pull/30063/files/a5bb9f5ecd5dd555d1b6ead90ed83c621c7ae966
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/30063#pullrequestreview-305458133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30063
src/node_env_var.cchttps://github.com/nodejs/node/pull/30063/files/a5bb9f5ecd5dd555d1b6ead90ed83c621c7ae966#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
watsonhttps://github.com/watson
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issuecomment-545121259
@devsnekhttps://github.com/devsnek
#30008https://github.com/nodejs/node/pull/30008
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
Final C++ fixeshttps://github.com/nodejs/node/pull/30063/commits/589d287e47b1f99ce3c81d0eaa7e41fbf7d27d81
589d287https://github.com/nodejs/node/pull/30063/commits/589d287e47b1f99ce3c81d0eaa7e41fbf7d27d81
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issuecomment-545124925
@watsonhttps://github.com/watson
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
watsonhttps://github.com/watson
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issuecomment-545127289
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
watsonhttps://github.com/watson
Oct 22, 2019https://github.com/nodejs/node/pull/30063#issuecomment-545127901
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2019 https://github.com/nodejs/node/pull/30063#pullrequestreview-307528665
View reviewed changes https://github.com/nodejs/node/pull/30063/files/589d287e47b1f99ce3c81d0eaa7e41fbf7d27d81
https://github.com/watson
watsonhttps://github.com/watson
Oct 29, 2019 https://github.com/nodejs/node/pull/30063#ref-issue-513836004
Ensure spawning of child processes are not susceptible to prototype pollution elastic/kibana#49605 https://github.com/elastic/kibana/issues/49605
https://github.com/Qard
Qardhttps://github.com/Qard
Dec 23, 2019https://github.com/nodejs/node/pull/30063#issuecomment-568374915
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 12, 2020https://github.com/nodejs/node/pull/30063#issuecomment-573369630
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 20, 2020 https://github.com/nodejs/node/pull/30063#ref-pullrequest-541082350
fs: simplify copy operations and more cleanups #31038 https://github.com/nodejs/node/pull/31038
https://github.com/alexbrasetvik
alexbrasetvikhttps://github.com/alexbrasetvik
Jan 29, 2020 https://github.com/nodejs/node/pull/30063#ref-pullrequest-508136255
Sanitize sourceURL so it cannot affect evaled code lodash/lodash#4518 https://github.com/lodash/lodash/pull/4518
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
8ae28ffhttps://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda
2935f72https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5
Compare https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
May 31, 2020 12:19https://github.com/nodejs/node/pull/30063#event-3390559328
https://github.com/jasnell
jasnellhttps://github.com/jasnell
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Jun 25, 2020https://github.com/nodejs/node/pull/30063#event-3482696697
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 25, 2020https://github.com/nodejs/node/pull/30063#issuecomment-649589414
@watsonhttps://github.com/watson
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 25, 2020https://github.com/nodejs/node/pull/30063#event-3482698699
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30063
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30063/files/a5bb9f5ecd5dd555d1b6ead90ed83c621c7ae966
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30063/files/589d287e47b1f99ce3c81d0eaa7e41fbf7d27d81
https://github.com/watson
watson https://github.com/watson
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
discuss https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adiscuss
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Please reload this pagehttps://github.com/nodejs/node/pull/30063
https://github.com/watson
https://github.com/devsnek
https://github.com/Qard
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.