| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d49f07d4-0900-b292-8571-5f7ac9a44e9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B71A:3D7639:993227:DCF7BF:6A4E4262 |
| html-safe-nonce | 5f1bdaeca96f34a4f7a28d22dba452c91860e5c2f11b107a14c64fd7a22d47ca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzFBOjNENzYzOTo5OTMyMjc6RENGN0JGOjZBNEU0MjYyIiwidmlzaXRvcl9pZCI6IjMyNjg1NzU3MzE1ODAyODk2MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 72e69efa49e372576a4d6b1578a9d252b2ea703ccaa1365e9e41b632978fb5ab |
| hovercard-subject-tag | pull_request:329864016 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30029/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6f8ea86c9666c8cfd5debd1591351360449b0de15987a1c4d2ee39085a623092/nodejs/node/pull/30029 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6f8ea86c9666c8cfd5debd1591351360449b0de15987a1c4d2ee39085a623092/nodejs/node/pull/30029 |
| og:image:alt | This PR removes some uses of NODE_USE_V8_PLATFORM in conjunction with HAVE_INSPECTOR.
Electron makes use of HAVE_INSPECTOR but does not run with NODE_USE_V8_PLATFORM so this prevented some Inspecto... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | codebytere |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9fabff9b8b127e686a3ec86f91422e818056ca2c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30029#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30029 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30029 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30029 |
| Reload | https://github.com/nodejs/node/pull/30029 |
| Reload | https://github.com/nodejs/node/pull/30029 |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:no-gate-inspector-v8-plat | https://github.com/codebytere/node/tree/no-gate-inspector-v8-plat |
| Conversation | https://github.com/nodejs/node/pull/30029 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30029/commits |
| Checks | https://github.com/nodejs/node/pull/30029/checks |
| Files changed | https://github.com/nodejs/node/pull/30029/files |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/pull/30029#top |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:no-gate-inspector-v8-plat | https://github.com/codebytere/node/tree/no-gate-inspector-v8-plat |
|
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/30029#issue-509233893 |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
| @joyeecheung | https://github.com/joyeecheung |
| @addaleax | https://github.com/addaleax |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
|
| https://github.com/codebytere |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/pull/30029/commits/0a4b335b0407d37f38651729429057bfc02aee7d |
| 0a4b335 | https://github.com/nodejs/node/pull/30029/commits/0a4b335b0407d37f38651729429057bfc02aee7d |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/30029#event-2725762023 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304063230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304065076 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304072094 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/30029#event-2725948944 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/30029#issuecomment-543893728 |
| https://ci.nodejs.org/job/node-test-pull-request/26103/ | https://ci.nodejs.org/job/node-test-pull-request/26103/ |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Oct 20, 2019
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304252940 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 20, 2019
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304276515 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/30029#pullrequestreview-304276515 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 21, 2019 | https://github.com/nodejs/node/pull/30029#issuecomment-544484391 |
| @joyeecheung | https://github.com/joyeecheung |
| @codebytere | https://github.com/codebytere |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
| addaleax | https://github.com/addaleax |
|
Oct 21, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-71b342f |
|
| https://github.com/codebytere |
|
| https://github.com/addaleax |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/71b342f93725a9bba5fa1f83a9f0fa88a482d759 |
| 71b342f | https://github.com/nodejs/node/commit/71b342f93725a9bba5fa1f83a9f0fa88a482d759 |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 21, 2019 | https://github.com/nodejs/node/pull/30029#issuecomment-544485426 |
| 71b342f | https://github.com/nodejs/node/commit/71b342f93725a9bba5fa1f83a9f0fa88a482d759 |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 21, 2019 | https://github.com/nodejs/node/pull/30029#event-2729412194 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| October 21, 2019 15:47 | https://github.com/nodejs/node/pull/30029#event-2730215953 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2019
| https://github.com/nodejs/node/pull/30029#ref-pullrequest-510082683 |
|
src: allow inspector without v8 platform
#30049
| https://github.com/nodejs/node/pull/30049 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-ada1aaa |
|
| https://github.com/codebytere |
|
| https://github.com/MylesBorins |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/ada1aaa482a337230a8e543149dd91b2db1b9599 |
| ada1aaa | https://github.com/nodejs/node/commit/ada1aaa482a337230a8e543149dd91b2db1b9599 |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-0c88dc1 |
|
| https://github.com/codebytere |
|
| https://github.com/MylesBorins |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/0c88dc19327d8daaebf46bbed9a9ce80b40bf2ae |
| 0c88dc1 | https://github.com/nodejs/node/commit/0c88dc19327d8daaebf46bbed9a9ce80b40bf2ae |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30029#ref-pullrequest-511137920 |
|
v13.0.1 proposal
#30081
| https://github.com/nodejs/node/pull/30081 |
| targos | https://github.com/targos |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-ad57e9f |
|
| https://github.com/codebytere |
|
| https://github.com/targos |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/ad57e9fde040b27eb6db9da04d10303e5a892b39 |
| ad57e9f | https://github.com/nodejs/node/commit/ad57e9fde040b27eb6db9da04d10303e5a892b39 |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-94d6719 |
|
| https://github.com/codebytere |
|
| https://github.com/targos |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/94d6719be348642819ff4c99f34b344e5c4a4e63 |
| 94d6719 | https://github.com/nodejs/node/commit/94d6719be348642819ff4c99f34b344e5c4a4e63 |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30029#ref-pullrequest-520604598 |
|
v12.13.1 release proposal
#30352
| https://github.com/nodejs/node/pull/30352 |
| targos | https://github.com/targos |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30029#ref-commit-4b57088 |
|
| https://github.com/codebytere |
|
| https://github.com/targos |
| src: fewer uses of NODE_USE_V8_PLATFORM | https://github.com/nodejs/node/commit/4b57088c2539f94a0019885e3ca392bc568b83d0 |
| 4b57088 | https://github.com/nodejs/node/commit/4b57088c2539f94a0019885e3ca392bc568b83d0 |
| #30029 | https://github.com/nodejs/node/pull/30029 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30029 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/30029/files/0a4b335b0407d37f38651729429057bfc02aee7d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/30029 |
|
| https://github.com/codebytere |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/joyeecheung |
|
| https://github.com/JungMinu |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |