René's URL Explorer Experiment


Title: util: fix isInsideNodeModules() check by codebytere · Pull Request #30014 · nodejs/node · GitHub

Open Graph Title: util: fix isInsideNodeModules() check by codebytere · Pull Request #30014 · nodejs/node

X Title: util: fix isInsideNodeModules() check by codebytere · Pull Request #30014 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR reverts away from use of overrideStackTrace in isInsideNodeModules() introduced in #29777. At the moment, Electron uses the v8 version of Error.prepareStackTrace as defined in v7.9.74 (wher...

X Description: This PR reverts away from use of overrideStackTrace in isInsideNodeModules() introduced in #29777. At the moment, Electron uses the v8 version of Error.prepareStackTrace as defined in v7.9.74 (wher...

Mail addresses
andy@slack-corp.com

Opengraph URL: https://github.com/nodejs/node/pull/30014

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2c6e2d99-3e76-5a1e-9540-dc596ad555a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id909E:1A1F1B:1A94675:24CAD14:6A4EBD33
html-safe-noncec05ac9b0072b83d1eef4e1f202a8d5abf79f38215cb7e9b84589cf652b7a8b00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDlFOjFBMUYxQjoxQTk0Njc1OjI0Q0FEMTQ6NkE0RUJEMzMiLCJ2aXNpdG9yX2lkIjoiNzQ3NDI5NjM2NzcwNTQ0OTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd7475148b6c063c3f7be60a7da1309ff2aedc2d8a2d776883c1df5cf59dc9b61
hovercard-subject-tagpull_request:329516825
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30014/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d12f7ded0f3fe66c26f5eb2f2ff65fe432ad276773db7765bf6d63fcae615904/nodejs/node/pull/30014
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d12f7ded0f3fe66c26f5eb2f2ff65fe432ad276773db7765bf6d63fcae615904/nodejs/node/pull/30014
og:image:altThis PR reverts away from use of overrideStackTrace in isInsideNodeModules() introduced in #29777. At the moment, Electron uses the v8 version of Error.prepareStackTrace as defined in v7.9.74 (wher...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30014#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30014
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30014
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30014
Reloadhttps://github.com/nodejs/node/pull/30014
Reloadhttps://github.com/nodejs/node/pull/30014
Please reload this pagehttps://github.com/nodejs/node/pull/30014
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30014
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:dont-use-overridestacktracehttps://github.com/codebytere/node/tree/dont-use-overridestacktrace
Conversationhttps://github.com/nodejs/node/pull/30014
Commits1 (1)https://github.com/nodejs/node/pull/30014/commits
Checkshttps://github.com/nodejs/node/pull/30014/checks
Files changedhttps://github.com/nodejs/node/pull/30014/files
util: fix isInsideNodeModules() checkhttps://github.com/nodejs/node/pull/30014#top
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:dont-use-overridestacktracehttps://github.com/codebytere/node/tree/dont-use-overridestacktrace
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issue-508790781
#29777https://github.com/nodejs/node/pull/29777
https://crbug.com/v8/7848https://crbug.com/v8/7848
#23926https://github.com/nodejs/node/pull/23926
@devsnekhttps://github.com/devsnek
@lochttps://github.com/loc
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Oct 18, 2019https://github.com/nodejs/node/pull/30014#event-2723169393
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 18, 2019https://github.com/nodejs/node/pull/30014#event-2723172344
https://github.com/codebytere
https://github.com/loc
util: fix isInsideNodeModules() checkhttps://github.com/nodejs/node/pull/30014/commits/7976e06807bed2a1b620894f65920495c4aa028b
7976e06https://github.com/nodejs/node/pull/30014/commits/7976e06807bed2a1b620894f65920495c4aa028b
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/bacdc4772a57e3d3c116bc97ee91b38fc0e2a327..7976e06807bed2a1b620894f65920495c4aa028b
bacdc47https://github.com/nodejs/node/commit/bacdc4772a57e3d3c116bc97ee91b38fc0e2a327
7976e06https://github.com/nodejs/node/commit/7976e06807bed2a1b620894f65920495c4aa028b
Compare https://github.com/nodejs/node/compare/bacdc4772a57e3d3c116bc97ee91b38fc0e2a327..7976e06807bed2a1b620894f65920495c4aa028b
October 18, 2019 00:44https://github.com/nodejs/node/pull/30014#event-2723173977
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 18, 2019https://github.com/nodejs/node/pull/30014#event-2723174067
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543430733
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 18, 2019 https://github.com/nodejs/node/pull/30014#pullrequestreview-303970818
View reviewed changes https://github.com/nodejs/node/pull/30014/files/7976e06807bed2a1b620894f65920495c4aa028b
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/30014#pullrequestreview-303970818
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29994https://github.com/nodejs/node/issues/29994
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543801381
70c2444https://github.com/nodejs/node/commit/70c24441559422455a51b6c90876034475ac76c6
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543802253
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543811569
Please reload this pagehttps://github.com/nodejs/node/pull/30014
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543947314
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 18, 2019https://github.com/nodejs/node/pull/30014#issuecomment-543951681
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545182087
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545184115
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545185389
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545185828
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545186804
Please reload this pagehttps://github.com/nodejs/node/pull/30014
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 22, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545187341
Please reload this pagehttps://github.com/nodejs/node/pull/30014
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 23, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545648236
Please reload this pagehttps://github.com/nodejs/node/pull/30014
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 23, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545649427
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 23, 2019https://github.com/nodejs/node/pull/30014#issuecomment-545650446
Please reload this pagehttps://github.com/nodejs/node/pull/30014
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 25, 2019https://github.com/nodejs/node/pull/30014#issuecomment-546391419
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 25, 2019https://github.com/nodejs/node/pull/30014#issuecomment-546397459
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2019 https://github.com/nodejs/node/pull/30014#pullrequestreview-307527549
View reviewed changes https://github.com/nodejs/node/pull/30014/files/7976e06807bed2a1b620894f65920495c4aa028b
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Dec 5, 2019https://github.com/nodejs/node/pull/30014#issuecomment-562340060
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Dec 5, 2019https://github.com/nodejs/node/pull/30014#event-2859491232
https://github.com/codebytere
codebyterehttps://github.com/codebytere
December 5, 2019 22:06https://github.com/nodejs/node/pull/30014#event-2859491416
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30014
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30014/files/7976e06807bed2a1b620894f65920495c4aa028b
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30014/files/7976e06807bed2a1b620894f65920495c4aa028b
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/30014
https://github.com/codebytere
https://github.com/devsnek
https://github.com/addaleax
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.