René's URL Explorer Experiment


Title: build: make linter failures fail `test-doc` target by richardlau · Pull Request #30012 · nodejs/node · GitHub

Open Graph Title: build: make linter failures fail `test-doc` target by richardlau · Pull Request #30012 · nodejs/node

X Title: build: make linter failures fail `test-doc` target by richardlau · Pull Request #30012 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Linter failures in the test-doc make target were not failing the build if the subsequent doctools test passed as its exit code wasn't being preserved. Make the lint target a dependency of test-...

X Description: Linter failures in the test-doc make target were not failing the build if the subsequent doctools test passed as its exit code wasn't being preserved. Make the lint target a dependency of t...

Opengraph URL: https://github.com/nodejs/node/pull/30012

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:88cb0c6f-520a-ff44-c199-c64f0388733a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8354:3D017:1449D31:1D85DFD:6A4E4280
html-safe-noncedb19b22ecbb133d1fdac1819d00d33cdaf73e450c771fe8b97b4741c9595420b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzU0OjNEMDE3OjE0NDlEMzE6MUQ4NURGRDo2QTRFNDI4MCIsInZpc2l0b3JfaWQiOiI4NTIwOTk5NDQ5NTU5NzEyMzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac92052b210f75e90477732430630482166dfe268040b7c02cb0d0c3016fc65757
hovercard-subject-tagpull_request:329395362
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30012/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/44e587a5b57531900bdfd33cd1a691fcb14f2081d8afde18eefc3a91169323d5/nodejs/node/pull/30012
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44e587a5b57531900bdfd33cd1a691fcb14f2081d8afde18eefc3a91169323d5/nodejs/node/pull/30012
og:image:altLinter failures in the test-doc make target were not failing the build if the subsequent doctools test passed as its exit code wasn't being preserved. Make the lint target a dependency of test-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30012#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30012
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30012
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30012
Reloadhttps://github.com/nodejs/node/pull/30012
Reloadhttps://github.com/nodejs/node/pull/30012
Please reload this pagehttps://github.com/nodejs/node/pull/30012
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30012
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:lintfailtest-dochttps://github.com/richardlau/node-1/tree/lintfailtest-doc
Conversationhttps://github.com/nodejs/node/pull/30012
Commits1 (1)https://github.com/nodejs/node/pull/30012/commits
Checkshttps://github.com/nodejs/node/pull/30012/checks
Files changedhttps://github.com/nodejs/node/pull/30012/files
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/pull/30012#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:lintfailtest-dochttps://github.com/richardlau/node-1/tree/lintfailtest-doc
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 17, 2019https://github.com/nodejs/node/pull/30012#issue-508640262
#29999 (comment)https://github.com/nodejs/node/pull/29999#discussion_r335756298
#28199https://github.com/nodejs/node/pull/28199
@danbevhttps://github.com/danbev
@sam-githubhttps://github.com/sam-github
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/richardlau
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/pull/30012/commits/1663f130e33c85053525717aff0242f7906fd829
1663f13https://github.com/nodejs/node/pull/30012/commits/1663f130e33c85053525717aff0242f7906fd829
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Oct 17, 2019https://github.com/nodejs/node/pull/30012#event-2722277209
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 17, 2019 https://github.com/nodejs/node/pull/30012#ref-pullrequest-508137705
src: only initialize openssl once #29999 https://github.com/nodejs/node/pull/29999
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2019https://github.com/nodejs/node/pull/30012#issuecomment-543298201
https://ci.nodejs.org/job/node-test-pull-request/26083/https://ci.nodejs.org/job/node-test-pull-request/26083/
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 17, 2019https://github.com/nodejs/node/pull/30012#issuecomment-543299991
@watsonhttps://github.com/watson
#30008 (comment)https://github.com/nodejs/node/pull/30008#issuecomment-543240064
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 17, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303454330
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 17, 2019 https://github.com/nodejs/node/pull/30012#ref-pullrequest-508533429
child_process: harden the API #30008 https://github.com/nodejs/node/pull/30008
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303476049
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2019https://github.com/nodejs/node/pull/30012#issuecomment-543317688
https://ci.nodejs.org/job/node-test-pull-request/26086/https://ci.nodejs.org/job/node-test-pull-request/26086/
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 17, 2019https://github.com/nodejs/node/pull/30012#event-2722425714
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 18, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303625007
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303642025
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 18, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303658022
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
danbevhttps://github.com/danbev
https://github.com/nodejs/node/pull/30012#pullrequestreview-303658022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 18, 2019 https://github.com/nodejs/node/pull/30012#pullrequestreview-303839689
View reviewed changes https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 22, 2019https://github.com/nodejs/node/pull/30012#issuecomment-545103288
b5b7e58https://github.com/nodejs/node/commit/b5b7e585f07c962a8329e021e9a9c56ce8a71420
Please reload this pagehttps://github.com/nodejs/node/pull/30012
Trotthttps://github.com/Trott
Oct 22, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-b5b7e58
https://github.com/richardlau
https://github.com/Trott
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/b5b7e585f07c962a8329e021e9a9c56ce8a71420
b5b7e58https://github.com/nodejs/node/commit/b5b7e585f07c962a8329e021e9a9c56ce8a71420
#30012https://github.com/nodejs/node/pull/30012
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 22, 2019https://github.com/nodejs/node/pull/30012#event-2734431225
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-b680905
https://github.com/richardlau
https://github.com/MylesBorins
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/b68090546fe50a9bd63638b1a17602cb2b13a3b4
b680905https://github.com/nodejs/node/commit/b68090546fe50a9bd63638b1a17602cb2b13a3b4
#30012https://github.com/nodejs/node/pull/30012
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-19a983c
https://github.com/richardlau
https://github.com/MylesBorins
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/19a983c6153a0bfb5336b8de37f9541c423863b3
19a983chttps://github.com/nodejs/node/commit/19a983c6153a0bfb5336b8de37f9541c423863b3
#30012https://github.com/nodejs/node/pull/30012
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/30012#ref-pullrequest-511137920
v13.0.1 proposal #30081 https://github.com/nodejs/node/pull/30081
targoshttps://github.com/targos
Nov 8, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-6c31cc6
https://github.com/richardlau
https://github.com/targos
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/6c31cc6bf8dd76b9c0c07f0c5e3e00e955fcdfa0
6c31cc6https://github.com/nodejs/node/commit/6c31cc6bf8dd76b9c0c07f0c5e3e00e955fcdfa0
#30012https://github.com/nodejs/node/pull/30012
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-c306917
https://github.com/richardlau
https://github.com/targos
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/c30691783580bf99bb2ec3e5fa582768d94c71ca
c306917https://github.com/nodejs/node/commit/c30691783580bf99bb2ec3e5fa582768d94c71ca
#30012https://github.com/nodejs/node/pull/30012
https://github.com/targos
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/30012#ref-pullrequest-520604598
v12.13.1 release proposal #30352 https://github.com/nodejs/node/pull/30352
targoshttps://github.com/targos
Nov 11, 2019 https://github.com/nodejs/node/pull/30012#ref-commit-032c23d
https://github.com/richardlau
https://github.com/targos
build: make linter failures fail test-doc targethttps://github.com/nodejs/node/commit/032c23d36072789c44275dbb7177b3d24b28373e
032c23dhttps://github.com/nodejs/node/commit/032c23d36072789c44275dbb7177b3d24b28373e
#30012https://github.com/nodejs/node/pull/30012
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30012
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/30012/files/1663f130e33c85053525717aff0242f7906fd829
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/30012
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/Trott
https://github.com/danbev
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.