| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b994531e-7c1a-7262-bec2-5f381bd7b39e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B8A:310BDB:AAEE71:EE8C87:6A4E85E9 |
| html-safe-nonce | d9a948510638e39d1a6febc1a2692b6c4ec64695d9592ea7543564a4a657257d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjhBOjMxMEJEQjpBQUVFNzE6RUU4Qzg3OjZBNEU4NUU5IiwidmlzaXRvcl9pZCI6IjQ0Nzc5MzIyNzc1Mjc5MDU3NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e6ce392a50b3ae3ec42fea9fe59bb4268e304f4e2e9a89f6a93ce7b51b844e62 |
| hovercard-subject-tag | pull_request:329132403 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30003/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b4572021cd75072a6bd90d08e7301c4aa9b6021036ea0b7ed2e1dc8be21286e5/nodejs/node/pull/30003 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b4572021cd75072a6bd90d08e7301c4aa9b6021036ea0b7ed2e1dc8be21286e5/nodejs/node/pull/30003 |
| og:image:alt | This commit removes a few std::endl that could be replaced by '\n' as it
does not look like the buffer needs to be flushed in these places.
This is only done in error handling, and once whe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30003#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30003 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30003 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30003 |
| Reload | https://github.com/nodejs/node/pull/30003 |
| Reload | https://github.com/nodejs/node/pull/30003 |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:node_report_endl | https://github.com/danbev/node/tree/node_report_endl |
| Conversation | https://github.com/nodejs/node/pull/30003 |
| Commits2 (2) | https://github.com/nodejs/node/pull/30003/commits |
| Checks | https://github.com/nodejs/node/pull/30003/checks |
| Files changed | https://github.com/nodejs/node/pull/30003/files |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/pull/30003#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:node_report_endl | https://github.com/danbev/node/tree/node_report_endl |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#issue-508318844 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
|
| https://github.com/danbev |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/pull/30003/commits/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| 0254759 | https://github.com/nodejs/node/pull/30003/commits/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
report
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#event-2720370475 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-543069864 |
| https://ci.nodejs.org/job/node-test-pull-request/26074/ | https://ci.nodejs.org/job/node-test-pull-request/26074/ |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303091558 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-543073358 |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| @DanDev | https://github.com/DanDev |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303100993 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303100993 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-543078487 |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-543089516 |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303204105 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303502183 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-303503771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Oct 21, 2019
| https://github.com/nodejs/node/pull/30003#pullrequestreview-304291491 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/danbev |
| squash: "fold" '\n' into strings | https://github.com/nodejs/node/pull/30003/commits/2c6b9fa485197c0715584494a47e3de33b6e5873 |
| 2c6b9fa | https://github.com/nodejs/node/pull/30003/commits/2c6b9fa485197c0715584494a47e3de33b6e5873 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 21, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-544349071 |
| https://ci.nodejs.org/job/node-test-pull-request/26124/ | https://ci.nodejs.org/job/node-test-pull-request/26124/ |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-544809862 |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| node-test-commit-freebsd | https://ci.nodejs.org/job/node-test-commit-freebsd/28933/ |
| node-test-commit-windows-fanned | https://ci.nodejs.org/job/node-test-commit-windows-fanned/30627/ |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30003#event-2732067024 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30003#issuecomment-545156642 |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/30003#event-2734832876 |
| Trott | https://github.com/Trott |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-4187fcb |
|
| https://github.com/danbev |
|
| https://github.com/Trott |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/4187fcb2001581004280685e78ab0f249d8347e7 |
| 4187fcb | https://github.com/nodejs/node/commit/4187fcb2001581004280685e78ab0f249d8347e7 |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| October 23, 2019 03:58 | https://github.com/nodejs/node/pull/30003#event-2735532969 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-84a7e0e |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/84a7e0e3be764e614ab15f984402111fde46c46b |
| 84a7e0e | https://github.com/nodejs/node/commit/84a7e0e3be764e614ab15f984402111fde46c46b |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-d561321 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/d561321e4a6a2775c7dc6782f05035bef66fed9d |
| d561321 | https://github.com/nodejs/node/commit/d561321e4a6a2775c7dc6782f05035bef66fed9d |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/30003#ref-pullrequest-511137920 |
|
v13.0.1 proposal
#30081
| https://github.com/nodejs/node/pull/30081 |
| targos | https://github.com/targos |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-fecc767 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/fecc767202bade2cd27efb29aec9a703a6110185 |
| fecc767 | https://github.com/nodejs/node/commit/fecc767202bade2cd27efb29aec9a703a6110185 |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-f8bfe5a |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/f8bfe5a72c335fb92ac563d591b21956feeb2b86 |
| f8bfe5a | https://github.com/nodejs/node/commit/f8bfe5a72c335fb92ac563d591b21956feeb2b86 |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/30003#ref-pullrequest-520604598 |
|
v12.13.1 release proposal
#30352
| https://github.com/nodejs/node/pull/30352 |
| targos | https://github.com/targos |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30003#ref-commit-f6655b4 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| src: remove unnecessary std::endl usage | https://github.com/nodejs/node/commit/f6655b41fa5f8cfd7c178114769cd4a4e4b30bb1 |
| f6655b4 | https://github.com/nodejs/node/commit/f6655b41fa5f8cfd7c178114769cd4a4e4b30bb1 |
| #30003 | https://github.com/nodejs/node/pull/30003 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30003 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30003/files/0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
report
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport |
| Please reload this page | https://github.com/nodejs/node/pull/30003 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/tniessen |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |