| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1bd0a86a-4dcc-d831-530c-3fc172dcdc65 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D38C:297F82:E837D3:142626D:696A91FD |
| html-safe-nonce | 40d50c8efdd1d06fe15bc2cdf648d69c6f8b4331907075215666b68e00f3459f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzhDOjI5N0Y4MjpFODM3RDM6MTQyNjI2RDo2OTZBOTFGRCIsInZpc2l0b3JfaWQiOiI1MTgxMjc4OTUyMjg5Mzc0NzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c96b704f285283aa39cf3bf92f5906a22c6eed6704465da21e4e1448ff07df5a |
| hovercard-subject-tag | pull_request:328489176 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29987/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55a846e313ae804af37d6c665e9b4c984907f6762be690ba7fa9cd4dc6b54f72/nodejs/node/pull/29987 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55a846e313ae804af37d6c665e9b4c984907f6762be690ba7fa9cd4dc6b54f72/nodejs/node/pull/29987 |
| og:image:alt | Let users provide more than one pattern separated by :
Let users provide a exclude pattern prefixed with !
Add tests for --filter
Document --filter
Checklist
make -j4 test (UNIX), or vcbuild t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mmarchini |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29987#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29987 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29987 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29987 |
| Reload | https://github.com/nodejs/node/pull/29987 |
| Reload | https://github.com/nodejs/node/pull/29987 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/29987#issue-comment-box |
| mmarchini | https://github.com/mmarchini |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmarchini:benchmark-improve-filter | https://github.com/mmarchini/node/tree/benchmark-improve-filter |
|
benchmark: improve --filter pattern matching
| https://github.com/nodejs/node/pull/29987#top |
| mmarchini | https://github.com/mmarchini |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmarchini:benchmark-improve-filter | https://github.com/mmarchini/node/tree/benchmark-improve-filter |
|
Conversation
35
| https://github.com/nodejs/node/pull/29987 |
|
Commits
1
| https://github.com/nodejs/node/pull/29987/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/29987/checks |
|
Files changed
| https://github.com/nodejs/node/pull/29987/files |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29987#issue-507511388 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29987#event-2715634463 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-542437940 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/c0034b91cfce9d4cfa1b47f82626d45a0f51a303..9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63 |
| c0034b9 | https://github.com/nodejs/node/commit/c0034b91cfce9d4cfa1b47f82626d45a0f51a303 |
| 9ea9c6e | https://github.com/nodejs/node/commit/9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63 |
|
Compare
| https://github.com/nodejs/node/compare/c0034b91cfce9d4cfa1b47f82626d45a0f51a303..9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63 |
| October 15, 2019 22:59 | https://github.com/nodejs/node/pull/29987#event-2715709089 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-542440176 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-542453497 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63..da2fbdd97820dfb66def34e3fe45191895319955 |
| 9ea9c6e | https://github.com/nodejs/node/commit/9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63 |
| da2fbdd | https://github.com/nodejs/node/commit/da2fbdd97820dfb66def34e3fe45191895319955 |
|
Compare
| https://github.com/nodejs/node/compare/9ea9c6ec2b0265b5c22d8244b95aeff5b1372f63..da2fbdd97820dfb66def34e3fe45191895319955 |
| October 16, 2019 00:26 | https://github.com/nodejs/node/pull/29987#event-2715844417 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-542459026 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-302343766 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files |
| doc/guides/writing-and-running-benchmarks.md | https://github.com/nodejs/node/pull/29987/files#diff-d6a00fcbf68214acf056afc0b9b1c69c481dbc98256fb138f389c826e29382a9 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-302344258 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files |
| doc/guides/writing-and-running-benchmarks.md | https://github.com/nodejs/node/pull/29987/files#diff-d6a00fcbf68214acf056afc0b9b1c69c481dbc98256fb138f389c826e29382a9 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/da2fbdd97820dfb66def34e3fe45191895319955..1a350be4e903f34ac12d1ec6e5ae806c084210c9 |
| da2fbdd | https://github.com/nodejs/node/commit/da2fbdd97820dfb66def34e3fe45191895319955 |
| 1a350be | https://github.com/nodejs/node/commit/1a350be4e903f34ac12d1ec6e5ae806c084210c9 |
|
Compare
| https://github.com/nodejs/node/compare/da2fbdd97820dfb66def34e3fe45191895319955..1a350be4e903f34ac12d1ec6e5ae806c084210c9 |
| October 16, 2019 15:57 | https://github.com/nodejs/node/pull/29987#event-2718196601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 19, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-544065856 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-544066145 |
| https://ci.nodejs.org/job/node-test-pull-request/26109/ | https://ci.nodejs.org/job/node-test-pull-request/26109/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 19, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-544066638 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9579/ | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9579/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-544090876 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://ci.nodejs.org/job/node-test-pull-request/26112/ | https://ci.nodejs.org/job/node-test-pull-request/26112/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-315624806 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files |
| test/parallel/test-benchmark-cli.js | https://github.com/nodejs/node/pull/29987/files#diff-a48c5dfd1455e63ea0d000ab70bad26e129e289f3c71d5c2ec95855be8fa8156 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| test/parallel/test-benchmark-cli.js | https://github.com/nodejs/node/pull/29987/files#diff-a48c5dfd1455e63ea0d000ab70bad26e129e289f3c71d5c2ec95855be8fa8156 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| benchmark/compare.js | https://github.com/nodejs/node/pull/29987/files#diff-b0bed8b607714c703f4de110a731294b2643bf274a536cc00f50fdd90bf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| benchmark/_cli.js | https://github.com/nodejs/node/pull/29987/files#diff-b1419d09e458a93e0ff3f4b13fe6883065a4b189e66cc22ea25bcc377d48a6b2 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/1a350be4e903f34ac12d1ec6e5ae806c084210c9..59b325adefef1773bf0e05942d299fe637e6b791 |
| 1a350be | https://github.com/nodejs/node/commit/1a350be4e903f34ac12d1ec6e5ae806c084210c9 |
| 59b325a | https://github.com/nodejs/node/commit/59b325adefef1773bf0e05942d299fe637e6b791 |
|
Compare
| https://github.com/nodejs/node/compare/1a350be4e903f34ac12d1ec6e5ae806c084210c9..59b325adefef1773bf0e05942d299fe637e6b791 |
| December 9, 2019 18:57 | https://github.com/nodejs/node/pull/29987#event-2867488118 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 9, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-563381528 |
| https://ci.nodejs.org/job/node-test-pull-request/27525/ | https://ci.nodejs.org/job/node-test-pull-request/27525/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Dec 9, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-563381664 |
| @lundibundi | https://github.com/lundibundi |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/59b325adefef1773bf0e05942d299fe637e6b791..d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
| 59b325a | https://github.com/nodejs/node/commit/59b325adefef1773bf0e05942d299fe637e6b791 |
| d868cca | https://github.com/nodejs/node/commit/d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
|
Compare
| https://github.com/nodejs/node/compare/59b325adefef1773bf0e05942d299fe637e6b791..d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
| December 9, 2019 20:40 | https://github.com/nodejs/node/pull/29987#event-2867809128 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 9, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-563430227 |
| https://ci.nodejs.org/job/node-test-pull-request/27527/ | https://ci.nodejs.org/job/node-test-pull-request/27527/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-329218950 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/29987#pullrequestreview-329218950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-329303119 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files |
| benchmark/_cli.js | https://github.com/nodejs/node/pull/29987/files#diff-b1419d09e458a93e0ff3f4b13fe6883065a4b189e66cc22ea25bcc377d48a6b2 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
|
| https://github.com/mmarchini |
| benchmark: improve --filter pattern matching | https://github.com/nodejs/node/pull/29987/commits/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| 2641c3e | https://github.com/nodejs/node/pull/29987/commits/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| force-pushed | https://github.com/nodejs/node/compare/d868cca73202c3a77ca7eabac730d110fbbbf2e9..2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| d868cca | https://github.com/nodejs/node/commit/d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
| 2641c3e | https://github.com/nodejs/node/commit/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
|
Compare
| https://github.com/nodejs/node/compare/d868cca73202c3a77ca7eabac730d110fbbbf2e9..2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| December 9, 2019 23:05 | https://github.com/nodejs/node/pull/29987#event-2868202415 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 9, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-563481857 |
| https://ci.nodejs.org/job/node-test-pull-request/27530/ | https://ci.nodejs.org/job/node-test-pull-request/27530/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Dec 10, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-329729568 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| lundibundi | https://github.com/lundibundi |
| https://github.com/nodejs/node/pull/29987#pullrequestreview-329729568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| benchmark/_cli.js | https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12#diff-b1419d09e458a93e0ff3f4b13fe6883065a4b189e66cc22ea25bcc377d48a6b2 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| benchmark/_cli.js | https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12#diff-b1419d09e458a93e0ff3f4b13fe6883065a4b189e66cc22ea25bcc377d48a6b2 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564139981 |
| https://ci.nodejs.org/job/node-test-pull-request/27553/ | https://ci.nodejs.org/job/node-test-pull-request/27553/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#event-2871517482 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564170380 |
| https://ci.nodejs.org/job/node-test-pull-request/27556/ | https://ci.nodejs.org/job/node-test-pull-request/27556/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564193014 |
| https://ci.nodejs.org/job/node-test-pull-request/27559/ | https://ci.nodejs.org/job/node-test-pull-request/27559/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 10, 2019
| https://github.com/nodejs/node/pull/29987#pullrequestreview-330083196 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564204471 |
| https://ci.nodejs.org/job/node-test-commit-arm/28083/ | https://ci.nodejs.org/job/node-test-commit-arm/28083/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Dec 10, 2019
| https://github.com/nodejs/node/pull/29987#ref-issue-535941695 |
|
Two tests consistently failing on ARM
#30890
| https://github.com/nodejs/node/issues/30890 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564206637 |
| #30890 | https://github.com/nodejs/node/issues/30890 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564209000 |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| a4e7ea8 | https://github.com/nodejs/node/commit/a4e7ea8a3af4b8062705c491607e8bd96810ab5b |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#event-2871807588 |
| mmarchini | https://github.com/mmarchini |
|
Dec 10, 2019
| https://github.com/nodejs/node/pull/29987#ref-commit-a4e7ea8 |
|
| https://github.com/mmarchini |
| benchmark: improve --filter pattern matching | https://github.com/nodejs/node/commit/a4e7ea8a3af4b8062705c491607e8bd96810ab5b |
| a4e7ea8 | https://github.com/nodejs/node/commit/a4e7ea8a3af4b8062705c491607e8bd96810ab5b |
| #29987 | https://github.com/nodejs/node/pull/29987 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 10, 2019 | https://github.com/nodejs/node/pull/29987#issuecomment-564209673 |
| https://ci.nodejs.org/job/node-test-pull-request/27561/ | https://ci.nodejs.org/job/node-test-pull-request/27561/ |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
| targos | https://github.com/targos |
|
Dec 11, 2019
| https://github.com/nodejs/node/pull/29987#ref-commit-78eaf50 |
|
| https://github.com/mmarchini |
|
| https://github.com/targos |
| benchmark: improve --filter pattern matching | https://github.com/nodejs/node/commit/78eaf50693474b45ca43fd4e938acc99a4c73362 |
| 78eaf50 | https://github.com/nodejs/node/commit/78eaf50693474b45ca43fd4e938acc99a4c73362 |
| #29987 | https://github.com/nodejs/node/pull/29987 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 13, 2019
| https://github.com/nodejs/node/pull/29987#ref-pullrequest-537630771 |
|
v13.4.0 proposal
#30937
| https://github.com/nodejs/node/pull/30937 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/29987#ref-commit-ac5de4f |
|
| https://github.com/mmarchini |
|
| https://github.com/targos |
| benchmark: improve --filter pattern matching | https://github.com/nodejs/node/commit/ac5de4f4c8b99faaa23c92c7328ebe188d311e62 |
| ac5de4f | https://github.com/nodejs/node/commit/ac5de4f4c8b99faaa23c92c7328ebe188d311e62 |
| #29987 | https://github.com/nodejs/node/pull/29987 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/29987#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/29987#ref-commit-667471e |
|
| https://github.com/mmarchini |
|
| https://github.com/BethGriggs |
| benchmark: improve --filter pattern matching | https://github.com/nodejs/node/commit/667471ee8b75bda9c9bb5834bd0590dab270e9f6 |
| 667471e | https://github.com/nodejs/node/commit/667471ee8b75bda9c9bb5834bd0590dab270e9f6 |
| #29987 | https://github.com/nodejs/node/pull/29987 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/29987#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29987 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/29987/files/d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/29987/files/d868cca73202c3a77ca7eabac730d110fbbbf2e9 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/29987/files/da2fbdd97820dfb66def34e3fe45191895319955 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/29987/files/2641c3eb4ff5a44f7be99b16e5953f8c82f38b12 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| Please reload this page | https://github.com/nodejs/node/pull/29987 |
|
| https://github.com/mmarchini |
|
| https://github.com/mscdex |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/joyeecheung |
|
| https://github.com/lundibundi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |