| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bc6af4b2-4bc5-1796-3316-aa48962c198e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D092:29428:1775993:224F537:6A4E5574 |
| html-safe-nonce | 4289a454e871dbf462da8b2ce8b91732c651bb5696b7cb9ffb821f27f5ead1d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDkyOjI5NDI4OjE3NzU5OTM6MjI0RjUzNzo2QTRFNTU3NCIsInZpc2l0b3JfaWQiOiIyNDg5OTIyNTYwNTI0NzAzMDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7bb35e3540d142f0dd35027a07d5c80d36b36de53087a274b8d08060e017cae7 |
| hovercard-subject-tag | pull_request:328327237 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29984/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/21a0ab2164c4c3926f478f3fe8194a51515ff52f07b1b90d3246dd59d2ea41ee/nodejs/node/pull/29984 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/21a0ab2164c4c3926f478f3fe8194a51515ff52f07b1b90d3246dd59d2ea41ee/nodejs/node/pull/29984 |
| og:image:alt | fix some typos in tls.DEFAULT_(MAX|MIN)_VERSION descriptions.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit gu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | akitsu-sanae |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f344f1eab54fc7dfc02d0d018cda7e158c3db65c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29984#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29984 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29984 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29984 |
| Reload | https://github.com/nodejs/node/pull/29984 |
| Reload | https://github.com/nodejs/node/pull/29984 |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| akitsu-sanae | https://github.com/akitsu-sanae |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| akitsu-sanae:tls-version-typo | https://github.com/akitsu-sanae/node/tree/tls-version-typo |
| Conversation | https://github.com/nodejs/node/pull/29984 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29984/commits |
| Checks | https://github.com/nodejs/node/pull/29984/checks |
| Files changed | https://github.com/nodejs/node/pull/29984/files |
| doc: fix tls version typo | https://github.com/nodejs/node/pull/29984#top |
| akitsu-sanae | https://github.com/akitsu-sanae |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| akitsu-sanae:tls-version-typo | https://github.com/akitsu-sanae/node/tree/tls-version-typo |
|
| https://github.com/akitsu-sanae |
| akitsu-sanae | https://github.com/akitsu-sanae |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29984#issue-507313589 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
|
| https://github.com/akitsu-sanae |
| doc: fix tls version typo | https://github.com/nodejs/node/pull/29984/commits/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| 7125057 | https://github.com/nodejs/node/pull/29984/commits/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29984#event-2714398831 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302041550 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302041550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302050437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302056115 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302088792 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302134873 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302231958 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-302307571 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29984#issuecomment-542499364 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3996/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3996/ |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29984#event-2716114722 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/29984#pullrequestreview-303825830 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/29984#ref-commit-05c8977 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/gireeshpunathil |
| doc: fix tls version typo | https://github.com/nodejs/node/commit/05c8977a6e8ec417be0c9856f050ab661249c11b |
| 05c8977 | https://github.com/nodejs/node/commit/05c8977a6e8ec417be0c9856f050ab661249c11b |
| #29984 | https://github.com/nodejs/node/pull/29984 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/29984#issuecomment-543687541 |
| 05c8977 | https://github.com/nodejs/node/commit/05c8977a6e8ec417be0c9856f050ab661249c11b |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/29984#event-2724537325 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29984#ref-commit-d8b3a60 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/MylesBorins |
| doc: fix tls version typo | https://github.com/nodejs/node/commit/d8b3a6078ca2926219b5ed3aa8e25cf6307d6df5 |
| d8b3a60 | https://github.com/nodejs/node/commit/d8b3a6078ca2926219b5ed3aa8e25cf6307d6df5 |
| #29984 | https://github.com/nodejs/node/pull/29984 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29984#ref-commit-ff4f299 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/MylesBorins |
| doc: fix tls version typo | https://github.com/nodejs/node/commit/ff4f2999e69e0a9d205a5b6d96374e2a201628a1 |
| ff4f299 | https://github.com/nodejs/node/commit/ff4f2999e69e0a9d205a5b6d96374e2a201628a1 |
| #29984 | https://github.com/nodejs/node/pull/29984 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29984#ref-pullrequest-511137920 |
|
v13.0.1 proposal
#30081
| https://github.com/nodejs/node/pull/30081 |
| targos | https://github.com/targos |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/29984#ref-commit-17b2526 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/targos |
| doc: fix tls version typo | https://github.com/nodejs/node/commit/17b25269ff03b697ea0b0466c8e85e6fb4a3fc7e |
| 17b2526 | https://github.com/nodejs/node/commit/17b25269ff03b697ea0b0466c8e85e6fb4a3fc7e |
| #29984 | https://github.com/nodejs/node/pull/29984 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/29984#ref-commit-d9b5508 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/targos |
| doc: fix tls version typo | https://github.com/nodejs/node/commit/d9b5508fc84cef5c3602080757449190cdc18297 |
| d9b5508 | https://github.com/nodejs/node/commit/d9b5508fc84cef5c3602080757449190cdc18297 |
| #29984 | https://github.com/nodejs/node/pull/29984 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/29984#ref-pullrequest-520604598 |
|
v12.13.1 release proposal
#30352
| https://github.com/nodejs/node/pull/30352 |
| https://github.com/akitsu-sanae |
| akitsu-sanae | https://github.com/akitsu-sanae |
| December 20, 2019 13:50 | https://github.com/nodejs/node/pull/29984#event-2900798048 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29984 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/29984/files/7125057cc75a55ae7812c54eddc34adbf49854a3 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/29984 |
|
| https://github.com/akitsu-sanae |
|
| https://github.com/trivikr |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/sam-github |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |