| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7e6bcfb5-7730-9d65-89ef-83ef868452cd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A17C:275F42:C3DCB8:10E5ECE:696A8B91 |
| html-safe-nonce | bcb10fbed4fc83e3c8ad56a66dbd505fc84ef0051f110e13aa8a4727d6c56cc3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTdDOjI3NUY0MjpDM0RDQjg6MTBFNUVDRTo2OTZBOEI5MSIsInZpc2l0b3JfaWQiOiI3NTE5NTkyNTA2OTY2MzEzODczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7f034321ebc2ccbf3de5258bd6e42495a718286b53d5ed042d3d3f03bdc199a8 |
| hovercard-subject-tag | pull_request:327975189 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29976/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c947058e6ba697186f0f9aa55a4f1338faab87d61215da92d7f3be9f206c6d8c/nodejs/node/pull/29976 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c947058e6ba697186f0f9aa55a4f1338faab87d61215da92d7f3be9f206c6d8c/nodejs/node/pull/29976 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aug2uag |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29976#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29976 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29976 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29976 |
| Reload | https://github.com/nodejs/node/pull/29976 |
| Reload | https://github.com/nodejs/node/pull/29976 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/29976#issue-comment-box |
| aug2uag | https://github.com/aug2uag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aug2uag:master | https://github.com/aug2uag/node/tree/master |
|
Fixes: https://github.com/nodejs/node/issues/29975
| https://github.com/nodejs/node/pull/29976#top |
| aug2uag | https://github.com/aug2uag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aug2uag:master | https://github.com/aug2uag/node/tree/master |
|
Conversation
44
| https://github.com/nodejs/node/pull/29976 |
|
Commits
1
| https://github.com/nodejs/node/pull/29976/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/29976/checks |
|
Files changed
| https://github.com/nodejs/node/pull/29976/files |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issue-506877521 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#event-2711838640 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541927879 |
| @aug2uag | https://github.com/aug2uag |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541927919 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541931305 |
| @addaleax | https://github.com/addaleax |
| @bnoordhuis | https://github.com/bnoordhuis |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541931969 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 14, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541954323 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-541992492 |
| https://ci.nodejs.org/job/node-test-pull-request/26024/ | https://ci.nodejs.org/job/node-test-pull-request/26024/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542007282 |
| https://ci.nodejs.org/job/node-test-pull-request/26028/ | https://ci.nodejs.org/job/node-test-pull-request/26028/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542009175 |
| https://ci.nodejs.org/job/node-test-pull-request/26030/ | https://ci.nodejs.org/job/node-test-pull-request/26030/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542011797 |
| https://ci.nodejs.org/job/node-test-pull-request/26031/ | https://ci.nodejs.org/job/node-test-pull-request/26031/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542013177 |
| https://ci.nodejs.org/job/node-test-pull-request/26032/ | https://ci.nodejs.org/job/node-test-pull-request/26032/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542015528 |
| https://ci.nodejs.org/job/node-test-pull-request/26035/ | https://ci.nodejs.org/job/node-test-pull-request/26035/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542025463 |
| https://ci.nodejs.org/job/node-test-pull-request/26038/ | https://ci.nodejs.org/job/node-test-pull-request/26038/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542076011 |
| #29979 | https://github.com/nodejs/node/pull/29979 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29976#ref-pullrequest-507031316 |
|
test: fix flaky doctool and test
#29979
| https://github.com/nodejs/node/pull/29979 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542107765 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542111071 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| force-pushed | https://github.com/nodejs/node/compare/812b8fcb01e26fb8dae139e1e5bb56668e3b6022..628a9f2b1cca47f0cb9882d7d001d9a102c4310a |
| 812b8fc | https://github.com/nodejs/node/commit/812b8fcb01e26fb8dae139e1e5bb56668e3b6022 |
| 628a9f2 | https://github.com/nodejs/node/commit/628a9f2b1cca47f0cb9882d7d001d9a102c4310a |
|
Compare
| https://github.com/nodejs/node/compare/812b8fcb01e26fb8dae139e1e5bb56668e3b6022..628a9f2b1cca47f0cb9882d7d001d9a102c4310a |
| October 15, 2019 09:03 | https://github.com/nodejs/node/pull/29976#event-2713148046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542390833 |
| @aug2uag | https://github.com/aug2uag |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| force-pushed | https://github.com/nodejs/node/compare/628a9f2b1cca47f0cb9882d7d001d9a102c4310a..cc360ad6ed2db8630247bc7d455645ee932086c9 |
| 628a9f2 | https://github.com/nodejs/node/commit/628a9f2b1cca47f0cb9882d7d001d9a102c4310a |
| cc360ad | https://github.com/nodejs/node/commit/cc360ad6ed2db8630247bc7d455645ee932086c9 |
|
Compare
| https://github.com/nodejs/node/compare/628a9f2b1cca47f0cb9882d7d001d9a102c4310a..cc360ad6ed2db8630247bc7d455645ee932086c9 |
| October 15, 2019 21:04 | https://github.com/nodejs/node/pull/29976#event-2715454280 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542414765 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542773838 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542812088 |
| https://ci.nodejs.org/job/node-test-pull-request/26065/ | https://ci.nodejs.org/job/node-test-pull-request/26065/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-542812547 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| force-pushed | https://github.com/nodejs/node/compare/cc360ad6ed2db8630247bc7d455645ee932086c9..6c7b0da95503c531a6e9665939fdcbb48a96eeaa |
| cc360ad | https://github.com/nodejs/node/commit/cc360ad6ed2db8630247bc7d455645ee932086c9 |
| 6c7b0da | https://github.com/nodejs/node/commit/6c7b0da95503c531a6e9665939fdcbb48a96eeaa |
|
Compare
| https://github.com/nodejs/node/compare/cc360ad6ed2db8630247bc7d455645ee932086c9..6c7b0da95503c531a6e9665939fdcbb48a96eeaa |
| October 16, 2019 23:36 | https://github.com/nodejs/node/pull/29976#event-2719440953 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-544810395 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 22, 2019
| https://github.com/nodejs/node/pull/29976#pullrequestreview-305144957 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29976/files |
| src/node_stat_watcher.h | https://github.com/nodejs/node/pull/29976/files#diff-774f48175644c20e8700e8c39652359c60104ea3c55ab77dde2de57112483d07 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 22, 2019 | https://github.com/nodejs/node/pull/29976#discussion_r337470502 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| aug2uag | https://github.com/aug2uag |
| Oct 24, 2019 | https://github.com/nodejs/node/pull/29976#discussion_r338357772 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 24, 2019 | https://github.com/nodejs/node/pull/29976#discussion_r338404203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| aug2uag | https://github.com/aug2uag |
| Oct 24, 2019 | https://github.com/nodejs/node/pull/29976#discussion_r338800558 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| force-pushed | https://github.com/nodejs/node/compare/6c7b0da95503c531a6e9665939fdcbb48a96eeaa..28168efc4d4e43e06ed478e649e976b08501bf8a |
| 6c7b0da | https://github.com/nodejs/node/commit/6c7b0da95503c531a6e9665939fdcbb48a96eeaa |
| 28168ef | https://github.com/nodejs/node/commit/28168efc4d4e43e06ed478e649e976b08501bf8a |
|
Compare
| https://github.com/nodejs/node/compare/6c7b0da95503c531a6e9665939fdcbb48a96eeaa..28168efc4d4e43e06ed478e649e976b08501bf8a |
| October 24, 2019 21:26 | https://github.com/nodejs/node/pull/29976#event-2742276431 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 26, 2019
| https://github.com/nodejs/node/pull/29976#pullrequestreview-307533797 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29976/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/29976#pullrequestreview-307533797 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560020394 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560020995 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560025634 |
| @aug2uag | https://github.com/aug2uag |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560026386 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560026793 |
| @aug2uag | https://github.com/aug2uag |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
|
| https://github.com/aug2uag |
| src: rebase for 29976 | https://github.com/nodejs/node/pull/29976/commits/d2862af6713909afa04dc46cfff44cf18b0c920d |
| d2862af | https://github.com/nodejs/node/pull/29976/commits/d2862af6713909afa04dc46cfff44cf18b0c920d |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| force-pushed | https://github.com/nodejs/node/compare/4b189a05a3a3a70a628dbf41281cf0aa2c4aadc5..d2862af6713909afa04dc46cfff44cf18b0c920d |
| 4b189a0 | https://github.com/nodejs/node/commit/4b189a05a3a3a70a628dbf41281cf0aa2c4aadc5 |
| d2862af | https://github.com/nodejs/node/commit/d2862af6713909afa04dc46cfff44cf18b0c920d |
|
Compare
| https://github.com/nodejs/node/compare/4b189a05a3a3a70a628dbf41281cf0aa2c4aadc5..d2862af6713909afa04dc46cfff44cf18b0c920d |
| December 1, 2019 01:23 | https://github.com/nodejs/node/pull/29976#event-2843071945 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560036462 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#event-2843073814 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560036638 |
| https://ci.nodejs.org/job/node-test-pull-request/27238/ | https://ci.nodejs.org/job/node-test-pull-request/27238/ |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/29976#pullrequestreview-324922976 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29976/files/d2862af6713909afa04dc46cfff44cf18b0c920d |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560068511 |
| #22147 | https://github.com/nodejs/node/issues/22147 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560069334 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/aug2uag |
| aug2uag | https://github.com/aug2uag |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560071241 |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560071526 |
| @aug2uag | https://github.com/aug2uag |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| addaleax | https://github.com/addaleax |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/29976#ref-commit-5473ceb |
|
| https://github.com/aug2uag |
|
| https://github.com/addaleax |
| src: rebase for 29976 | https://github.com/nodejs/node/commit/5473ceb534940eba7994325f5e71158f514b0973 |
| 5473ceb | https://github.com/nodejs/node/commit/5473ceb534940eba7994325f5e71158f514b0973 |
| #29976 | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560090849 |
| 5473ceb | https://github.com/nodejs/node/commit/5473ceb534940eba7994325f5e71158f514b0973 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#event-2843342376 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560095137 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| 5473ceb | https://github.com/nodejs/node/commit/5473ceb534940eba7994325f5e71158f514b0973 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| Trott | https://github.com/Trott |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/29976#ref-commit-7da6630 |
|
| https://github.com/aug2uag |
|
| https://github.com/Trott |
| src: change header file in node_stat_watcher.cc | https://github.com/nodejs/node/commit/7da6630aa4a3ba7f866be3af83ccd812102c281b |
| 7da6630 | https://github.com/nodejs/node/commit/7da6630aa4a3ba7f866be3af83ccd812102c281b |
| #29976 | https://github.com/nodejs/node/pull/29976 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560096445 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 1, 2019 | https://github.com/nodejs/node/pull/29976#issuecomment-560096566 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
| targos | https://github.com/targos |
|
Dec 2, 2019
| https://github.com/nodejs/node/pull/29976#ref-commit-e65ad86 |
|
| https://github.com/aug2uag |
|
| https://github.com/targos |
| src: change header file in node_stat_watcher.cc | https://github.com/nodejs/node/commit/e65ad865c6dd19c5ef2263b11109430f8f853f7d |
| e65ad86 | https://github.com/nodejs/node/commit/e65ad865c6dd19c5ef2263b11109430f8f853f7d |
| #29976 | https://github.com/nodejs/node/pull/29976 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/29976#ref-pullrequest-531889133 |
|
v13.3.0 proposal
#30774
| https://github.com/nodejs/node/pull/30774 |
| targos | https://github.com/targos |
|
Jan 13, 2020
| https://github.com/nodejs/node/pull/29976#ref-commit-3f1ca18 |
|
| https://github.com/aug2uag |
|
| https://github.com/targos |
| src: change header file in node_stat_watcher.cc | https://github.com/nodejs/node/commit/3f1ca18071c0ca28e90a9fe517134f8b7ce53bed |
| 3f1ca18 | https://github.com/nodejs/node/commit/3f1ca18071c0ca28e90a9fe517134f8b7ce53bed |
| #29976 | https://github.com/nodejs/node/pull/29976 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/29976#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/29976#ref-commit-78098d3 |
|
| https://github.com/aug2uag |
|
| https://github.com/BethGriggs |
| src: change header file in node_stat_watcher.cc | https://github.com/nodejs/node/commit/78098d3859b6cfdab80aadfa7ca2c2a167662695 |
| 78098d3 | https://github.com/nodejs/node/commit/78098d3859b6cfdab80aadfa7ca2c2a167662695 |
| #29976 | https://github.com/nodejs/node/pull/29976 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/29976#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29976 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29976/files/a0e23d82eb0771840ee6baa05f8a1ac1bc27952e |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/29976/files/a0e23d82eb0771840ee6baa05f8a1ac1bc27952e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29976/files/a0e23d82eb0771840ee6baa05f8a1ac1bc27952e |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/29976/files/d2862af6713909afa04dc46cfff44cf18b0c920d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Please reload this page | https://github.com/nodejs/node/pull/29976 |
|
| https://github.com/aug2uag |
|
| https://github.com/Trott |
|
| https://github.com/joyeecheung |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |