René's URL Explorer Experiment


Title: test: add cb error test for fs.close method by teorossi82 · Pull Request #29970 · nodejs/node · GitHub

Open Graph Title: test: add cb error test for fs.close method by teorossi82 · Pull Request #29970 · nodejs/node

X Title: test: add cb error test for fs.close method by teorossi82 · Pull Request #29970 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Added test on fs.close method when callback is not a function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows comm...

X Description: Added test on fs.close method when callback is not a function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows comm...

Opengraph URL: https://github.com/nodejs/node/pull/29970

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:79bf1c9b-e055-e39c-708e-0bb83a3b999a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE428:B6221:9D8A49:E1E1A9:6A4E4283
html-safe-noncec5a76a47a02a3f82d3c57803f8c9bd77f3bdc35eaa4370aae8be4dc0888967c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDI4OkI2MjIxOjlEOEE0OTpFMUUxQTk6NkE0RTQyODMiLCJ2aXNpdG9yX2lkIjoiMzc2MDIyMTUxODQyMTcwNTM0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace8fcc177ba11580a76d05a897cf58aa4046ad7704091c56eb52469e4b7e49d13
hovercard-subject-tagpull_request:327864164
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29970/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5fefa5ef57460da8603af9a732af9b4d8d548ff53cda4f8b79e495e23f4a672c/nodejs/node/pull/29970
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5fefa5ef57460da8603af9a732af9b4d8d548ff53cda4f8b79e495e23f4a672c/nodejs/node/pull/29970
og:image:altAdded test on fs.close method when callback is not a function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows comm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameteorossi82
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29970#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29970
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29970
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29970
Reloadhttps://github.com/nodejs/node/pull/29970
Reloadhttps://github.com/nodejs/node/pull/29970
Please reload this pagehttps://github.com/nodejs/node/pull/29970
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29970
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
teorossi82https://github.com/teorossi82
nodejs:masterhttps://github.com/nodejs/node/tree/master
teorossi82:test-fs-close-cb-errorhttps://github.com/teorossi82/node/tree/test-fs-close-cb-error
Conversationhttps://github.com/nodejs/node/pull/29970
Commits3 (3)https://github.com/nodejs/node/pull/29970/commits
Checkshttps://github.com/nodejs/node/pull/29970/checks
Files changedhttps://github.com/nodejs/node/pull/29970/files
test: add cb error test for fs.close methodhttps://github.com/nodejs/node/pull/29970#top
teorossi82https://github.com/teorossi82
nodejs:masterhttps://github.com/nodejs/node/tree/master
teorossi82:test-fs-close-cb-errorhttps://github.com/teorossi82/node/tree/test-fs-close-cb-error
https://github.com/teorossi82
teorossi82https://github.com/teorossi82
Oct 14, 2019https://github.com/nodejs/node/pull/29970#issue-506734109
Please reload this pagehttps://github.com/nodejs/node/pull/29970
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/teorossi82
test: add cb error test for fs.close methodhttps://github.com/nodejs/node/pull/29970/commits/f489a5234d0f5ccd1fa9c133a1909c6b0d89b6ad
f489a52https://github.com/nodejs/node/pull/29970/commits/f489a5234d0f5ccd1fa9c133a1909c6b0d89b6ad
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 14, 2019https://github.com/nodejs/node/pull/29970#event-2710920869
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 14, 2019https://github.com/nodejs/node/pull/29970#issuecomment-541869068
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3992/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3992/
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 14, 2019 https://github.com/nodejs/node/pull/29970#pullrequestreview-301495461
View reviewed changes https://github.com/nodejs/node/pull/29970/files/f489a5234d0f5ccd1fa9c133a1909c6b0d89b6ad
Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/nodejs/node/pull/29970#pullrequestreview-301495461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
common.mustCall()https://github.com/nodejs/node/tree/master/test/common#mustcallfn-exact
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 14, 2019https://github.com/nodejs/node/pull/29970#issuecomment-541925853
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/teorossi82
test: avoid block scope in cb error test for fs.close methodhttps://github.com/nodejs/node/pull/29970/commits/dcd979a88b8b2b5f03a678aa9eff56d13671d367
dcd979ahttps://github.com/nodejs/node/pull/29970/commits/dcd979a88b8b2b5f03a678aa9eff56d13671d367
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542079087
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 15, 2019 https://github.com/nodejs/node/pull/29970#pullrequestreview-301701761
View reviewed changes https://github.com/nodejs/node/pull/29970/files/dcd979a88b8b2b5f03a678aa9eff56d13671d367
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/29970#pullrequestreview-301701761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 15, 2019 https://github.com/nodejs/node/pull/29970#pullrequestreview-301704797
View reviewed changes https://github.com/nodejs/node/pull/29970/files/dcd979a88b8b2b5f03a678aa9eff56d13671d367
test/parallel/test-fs-close-errors.jshttps://github.com/nodejs/node/pull/29970/files/dcd979a88b8b2b5f03a678aa9eff56d13671d367#diff-b3b6d6eeb95bacc5dad925650aa1bfe9923e9803b97e8004da9c81868806e4b5
Trotthttps://github.com/Trott
Oct 15, 2019https://github.com/nodejs/node/pull/29970#discussion_r334793251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/teorossi82
teorossi82https://github.com/teorossi82
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542082086
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/teorossi82
test: added closeSynchttps://github.com/nodejs/node/pull/29970/commits/d31e2def3176779dfcbad821fdc8ec97bd48a07b
d31e2dehttps://github.com/nodejs/node/pull/29970/commits/d31e2def3176779dfcbad821fdc8ec97bd48a07b
https://github.com/teorossi82
teorossi82https://github.com/teorossi82
Fishrock123https://github.com/Fishrock123
October 15, 2019 07:42https://github.com/nodejs/node/pull/29970#event-2712889716
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542221008
https://ci.nodejs.org/job/node-test-pull-request/26041/https://ci.nodejs.org/job/node-test-pull-request/26041/
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542309570
#29979https://github.com/nodejs/node/pull/29979
#29979 (comment)https://github.com/nodejs/node/pull/29979#issuecomment-542060973
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 15, 2019 https://github.com/nodejs/node/pull/29970#pullrequestreview-302157115
View reviewed changes https://github.com/nodejs/node/pull/29970/files/d31e2def3176779dfcbad821fdc8ec97bd48a07b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542413399
https://ci.nodejs.org/job/node-test-pull-request/26046/https://ci.nodejs.org/job/node-test-pull-request/26046/
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542421657
https://ci.nodejs.org/job/node-test-pull-request/26048/https://ci.nodejs.org/job/node-test-pull-request/26048/
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 15, 2019 https://github.com/nodejs/node/pull/29970#pullrequestreview-302230105
View reviewed changes https://github.com/nodejs/node/pull/29970/files/d31e2def3176779dfcbad821fdc8ec97bd48a07b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 16, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542520023
https://ci.nodejs.org/job/node-test-pull-request/26056/https://ci.nodejs.org/job/node-test-pull-request/26056/
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 16, 2019https://github.com/nodejs/node/pull/29970#event-2716306306
https://github.com/teorossi82
teorossi82https://github.com/teorossi82
Oct 16, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542663583
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 16, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542793240
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/29970
Trotthttps://github.com/Trott
Oct 16, 2019 https://github.com/nodejs/node/pull/29970#ref-commit-e22efba
https://github.com/teorossi82
https://github.com/Trott
test: add cb error test for fs.close()https://github.com/nodejs/node/commit/e22efba812b2a6c2ee6d35f4e11af5b08afd881d
e22efbahttps://github.com/nodejs/node/commit/e22efba812b2a6c2ee6d35f4e11af5b08afd881d
#29970https://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 16, 2019https://github.com/nodejs/node/pull/29970#issuecomment-542794062
e22efbahttps://github.com/nodejs/node/commit/e22efba812b2a6c2ee6d35f4e11af5b08afd881d
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 16, 2019https://github.com/nodejs/node/pull/29970#event-2718378573
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/29970#ref-commit-b1b8663
https://github.com/teorossi82
https://github.com/MylesBorins
test: add cb error test for fs.close()https://github.com/nodejs/node/commit/b1b8663a233e3168565ceb618b2c14b6542fa871
b1b8663https://github.com/nodejs/node/commit/b1b8663a233e3168565ceb618b2c14b6542fa871
#29970https://github.com/nodejs/node/pull/29970
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/29970#ref-pullrequest-511137920
v13.0.1 proposal #30081 https://github.com/nodejs/node/pull/30081
targoshttps://github.com/targos
Nov 8, 2019 https://github.com/nodejs/node/pull/29970#ref-commit-5e436f8
https://github.com/teorossi82
https://github.com/targos
test: add cb error test for fs.close()https://github.com/nodejs/node/commit/5e436f89e5f9b18afba5249f37734f8870da2e89
5e436f8https://github.com/nodejs/node/commit/5e436f89e5f9b18afba5249f37734f8870da2e89
#29970https://github.com/nodejs/node/pull/29970
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/29970#ref-commit-3e39909
https://github.com/teorossi82
https://github.com/targos
test: add cb error test for fs.close()https://github.com/nodejs/node/commit/3e399090225302ed0cdaf136c24fdb5e41677479
3e39909https://github.com/nodejs/node/commit/3e399090225302ed0cdaf136c24fdb5e41677479
#29970https://github.com/nodejs/node/pull/29970
https://github.com/targos
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/29970#ref-pullrequest-520604598
v12.13.1 release proposal #30352 https://github.com/nodejs/node/pull/30352
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29970
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29970/files/dcd979a88b8b2b5f03a678aa9eff56d13671d367
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29970/files/d31e2def3176779dfcbad821fdc8ec97bd48a07b
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/29970/files/d31e2def3176779dfcbad821fdc8ec97bd48a07b
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/29970
https://github.com/teorossi82
https://github.com/Fishrock123
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.