René's URL Explorer Experiment


Title: [v10.x] net: treat ENOTCONN at shutdown as success by addaleax · Pull Request #29968 · nodejs/node · GitHub

Open Graph Title: [v10.x] net: treat ENOTCONN at shutdown as success by addaleax · Pull Request #29968 · nodejs/node

X Title: [v10.x] net: treat ENOTCONN at shutdown as success by addaleax · Pull Request #29968 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Only trivial conflicts (process.binding() vs internalBinding()). While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 PR-URL: #29912 ...

X Description: Only trivial conflicts (process.binding() vs internalBinding()). While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 PR-URL: #29912 ...

Opengraph URL: https://github.com/nodejs/node/pull/29968

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:20d47a78-a5ea-4ef8-3f41-68ef152f45cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA688:1691AA:3E0712F:5770651:6A4FA2E3
html-safe-noncea331f8110096545b4a95542fc097a586c82f4224920237006e1e97cf9e202815
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjg4OjE2OTFBQTozRTA3MTJGOjU3NzA2NTE6NkE0RkEyRTMiLCJ2aXNpdG9yX2lkIjoiODcwNDgxMTc3MDUxNzEwMzMzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac924efb608fc2a949698ecf4bfbcd78c39ec2d34a3ee07f6768dd84e104c29938
hovercard-subject-tagpull_request:327824505
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29968/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ddd1be4ed889e8fb884f5a7eb3dacf98a3e3367932f3f696ef653afb02a217b8/nodejs/node/pull/29968
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ddd1be4ed889e8fb884f5a7eb3dacf98a3e3367932f3f696ef653afb02a217b8/nodejs/node/pull/29968
og:image:altOnly trivial conflicts (process.binding() vs internalBinding()). While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 PR-URL: #29912 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29968#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29968
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29968
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29968
Reloadhttps://github.com/nodejs/node/pull/29968
Reloadhttps://github.com/nodejs/node/pull/29968
Please reload this pagehttps://github.com/nodejs/node/pull/29968
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29968
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:backport-shutdown-enotconnhttps://github.com/addaleax/node/tree/backport-shutdown-enotconn
Conversationhttps://github.com/nodejs/node/pull/29968
Commits1 (1)https://github.com/nodejs/node/pull/29968/commits
Checkshttps://github.com/nodejs/node/pull/29968/checks
Files changedhttps://github.com/nodejs/node/pull/29968/files
[v10.x] net: treat ENOTCONN at shutdown as successhttps://github.com/nodejs/node/pull/29968#top
addaleaxhttps://github.com/addaleax
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
addaleax:backport-shutdown-enotconnhttps://github.com/addaleax/node/tree/backport-shutdown-enotconn
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 14, 2019https://github.com/nodejs/node/pull/29968#issue-506683427
#26315https://github.com/nodejs/node/issues/26315
#29912https://github.com/nodejs/node/pull/29912
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://github.com/addaleax
net: treat ENOTCONN at shutdown as successhttps://github.com/nodejs/node/pull/29968/commits/1566f683fd0f2011a8649225fe50fb0841cbd6e7
1566f68https://github.com/nodejs/node/pull/29968/commits/1566f683fd0f2011a8649225fe50fb0841cbd6e7
nodejs#26315https://github.com/nodejs/node/issues/26315
nodejs#29912https://github.com/nodejs/node/pull/29912
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Oct 14, 2019https://github.com/nodejs/node/pull/29968#event-2710605257
v10.17.0 proposal #29875 https://github.com/nodejs/node/pull/29875
shutdown ENOTCONN on TLS.Socket._final #26315 https://github.com/nodejs/node/issues/26315
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2019https://github.com/nodejs/node/pull/29968#issuecomment-541706793
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://ci.nodejs.org/job/node-test-pull-request/26012/https://ci.nodejs.org/job/node-test-pull-request/26012/
#29977https://github.com/nodejs/node/issues/29977
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Oct 14, 2019 https://github.com/nodejs/node/pull/29968#pullrequestreview-301345029
View reviewed changes https://github.com/nodejs/node/pull/29968/files/1566f683fd0f2011a8649225fe50fb0841cbd6e7
lib/net.jshttps://github.com/nodejs/node/pull/29968/files/1566f683fd0f2011a8649225fe50fb0841cbd6e7#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 15, 2019 https://github.com/nodejs/node/pull/29968#pullrequestreview-302201877
View reviewed changes https://github.com/nodejs/node/pull/29968/files/1566f683fd0f2011a8649225fe50fb0841cbd6e7
BethGriggshttps://github.com/BethGriggs
Oct 16, 2019 https://github.com/nodejs/node/pull/29968#ref-commit-69bf5b7
https://github.com/addaleax
https://github.com/BethGriggs
net: treat ENOTCONN at shutdown as successhttps://github.com/nodejs/node/commit/69bf5b79446c9f2ecefe6d75d2a105b8e3d078a1
69bf5b7https://github.com/nodejs/node/commit/69bf5b79446c9f2ecefe6d75d2a105b8e3d078a1
#26315https://github.com/nodejs/node/issues/26315
#29968https://github.com/nodejs/node/pull/29968
#29912https://github.com/nodejs/node/pull/29912
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 16, 2019https://github.com/nodejs/node/pull/29968#issuecomment-542739814
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 16, 2019https://github.com/nodejs/node/pull/29968#event-2717943226
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29968
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/29968/files/1566f683fd0f2011a8649225fe50fb0841cbd6e7
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/29968/files/1566f683fd0f2011a8649225fe50fb0841cbd6e7
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/29968
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/devnexen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.