René's URL Explorer Experiment


Title: build: fix version checks in gyp files by bnoordhuis · Pull Request #29931 · nodejs/node · GitHub

Open Graph Title: build: fix version checks in gyp files by bnoordhuis · Pull Request #29931 · nodejs/node

X Title: build: fix version checks in gyp files by bnoordhuis · Pull Request #29931 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Make distutils.version.StrictVersion available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: StrictVersion does not like e...

X Description: Make distutils.version.StrictVersion available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: StrictVersion does not like e...

Opengraph URL: https://github.com/nodejs/node/pull/29931

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:397418d2-35c3-de74-89ed-ed92ac07d635
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF76:1EC1:64909B:8FB9AD:6A4E4278
html-safe-nonce7267b88298a4e5a0812803bca62e0c6fd13a48827c7b46ad57f0269c0d4743b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjc2OjFFQzE6NjQ5MDlCOjhGQjlBRDo2QTRFNDI3OCIsInZpc2l0b3JfaWQiOiI4ODg5NjYxMjQ4NzY2ODg2NTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8fec1b5c25215f2f91697571c69634d26331053ef3631b17ba5df47a31fc5281
hovercard-subject-tagpull_request:327152936
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29931/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d63a77fdcb6a2247d094e810e4cde185e3568b6d65b351ebb6a646d28255f75c/nodejs/node/pull/29931
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d63a77fdcb6a2247d094e810e4cde185e3568b6d65b351ebb6a646d28255f75c/nodejs/node/pull/29931
og:image:altMake distutils.version.StrictVersion available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: StrictVersion does not like e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29931#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29931
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29931
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29931
Reloadhttps://github.com/nodejs/node/pull/29931
Reloadhttps://github.com/nodejs/node/pull/29931
Please reload this pagehttps://github.com/nodejs/node/pull/29931
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29931
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix29927https://github.com/bnoordhuis/io.js/tree/fix29927
Conversationhttps://github.com/nodejs/node/pull/29931
Commits1 (1)https://github.com/nodejs/node/pull/29931/commits
Checkshttps://github.com/nodejs/node/pull/29931/checks
Files changedhttps://github.com/nodejs/node/pull/29931/files
build: fix version checks in gyp fileshttps://github.com/nodejs/node/pull/29931#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix29927https://github.com/bnoordhuis/io.js/tree/fix29927
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 11, 2019https://github.com/nodejs/node/pull/29931#issue-505794628
#29927https://github.com/nodejs/node/issues/29927
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29931
https://github.com/bnoordhuis
build: fix version checks in gyp fileshttps://github.com/nodejs/node/pull/29931/commits/e66620292e680f7300804fe3859d701de297719c
e666202https://github.com/nodejs/node/pull/29931/commits/e66620292e680f7300804fe3859d701de297719c
nodejs#29927https://github.com/nodejs/node/issues/29927
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 11, 2019https://github.com/nodejs/node/pull/29931#event-2705825891
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 11, 2019https://github.com/nodejs/node/pull/29931#issuecomment-541024729
https://ci.nodejs.org/job/node-test-pull-request/25956/https://ci.nodejs.org/job/node-test-pull-request/25956/
Please reload this pagehttps://github.com/nodejs/node/pull/29931
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 11, 2019 https://github.com/nodejs/node/pull/29931#ref-issue-505713289
Version number comparisons in Python and GYP files are not safe #29927 https://github.com/nodejs/node/issues/29927
https://github.com/targos
targoshttps://github.com/targos
Oct 11, 2019 https://github.com/nodejs/node/pull/29931#pullrequestreview-300674832
View reviewed changes https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
targoshttps://github.com/targos
https://github.com/nodejs/node/pull/29931#pullrequestreview-300674832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29931
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 11, 2019 https://github.com/nodejs/node/pull/29931#pullrequestreview-300678878
View reviewed changes https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 11, 2019 https://github.com/nodejs/node/pull/29931#pullrequestreview-300679607
View reviewed changes https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
Trotthttps://github.com/Trott
Oct 13, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-6f81401
https://github.com/bnoordhuis
https://github.com/Trott
build: fix version checks in gyp fileshttps://github.com/nodejs/node/commit/6f814013f45698a9178203331b62e3fe07fdb7d5
6f81401https://github.com/nodejs/node/commit/6f814013f45698a9178203331b62e3fe07fdb7d5
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2019https://github.com/nodejs/node/pull/29931#issuecomment-541469570
Please reload this pagehttps://github.com/nodejs/node/pull/29931
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2019https://github.com/nodejs/node/pull/29931#event-2708975278
targoshttps://github.com/targos
Oct 14, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-72e0fc1
https://github.com/targos
build: fix version checks in configure.pyhttps://github.com/targos/node/commit/72e0fc1ccabcf9799354f5735ed97fd079a49499
72e0fc1https://github.com/targos/node/commit/72e0fc1ccabcf9799354f5735ed97fd079a49499
nodejs#29927https://github.com/nodejs/node/issues/29927
nodejs#29931https://github.com/nodejs/node/pull/29931
https://github.com/targos
targoshttps://github.com/targos
Oct 14, 2019 https://github.com/nodejs/node/pull/29931#ref-pullrequest-506634856
build: fix version checks in configure.py #29965 https://github.com/nodejs/node/pull/29965
targoshttps://github.com/targos
Oct 18, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-d769ebc
https://github.com/targos
build: fix version checks in configure.pyhttps://github.com/nodejs/node/commit/d769ebc2b7be23d66033d8df71f70e0564436e72
d769ebchttps://github.com/nodejs/node/commit/d769ebc2b7be23d66033d8df71f70e0564436e72
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
#29965https://github.com/nodejs/node/pull/29965
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 21, 2019 https://github.com/nodejs/node/pull/29931#ref-pullrequest-491100896
2019-10-22, Version 13.0.0 (Current) #29504 https://github.com/nodejs/node/pull/29504
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-c1fade5
https://github.com/targos
https://github.com/MylesBorins
build: fix version checks in configure.pyhttps://github.com/nodejs/node/commit/c1fade53260fd0f4d3d9d64bb4993ef9cfca5651
c1fade5https://github.com/nodejs/node/commit/c1fade53260fd0f4d3d9d64bb4993ef9cfca5651
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
#29965https://github.com/nodejs/node/pull/29965
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-b92afcd
https://github.com/targos
https://github.com/MylesBorins
build: fix version checks in configure.pyhttps://github.com/nodejs/node/commit/b92afcd90c3eea494a22397234dced6d1d8c4032
b92afcdhttps://github.com/nodejs/node/commit/b92afcd90c3eea494a22397234dced6d1d8c4032
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
#29965https://github.com/nodejs/node/pull/29965
targoshttps://github.com/targos
Nov 8, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-22d73df
https://github.com/bnoordhuis
https://github.com/targos
build: fix version checks in gyp fileshttps://github.com/nodejs/node/commit/22d73df0087a45248514621615002797cfb20e41
22d73dfhttps://github.com/nodejs/node/commit/22d73df0087a45248514621615002797cfb20e41
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
targoshttps://github.com/targos
Nov 8, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-fcbd057
https://github.com/targos
build: fix version checks in configure.pyhttps://github.com/nodejs/node/commit/fcbd057120ae2d1e878d8da50e966d0ee90f6dfa
fcbd057https://github.com/nodejs/node/commit/fcbd057120ae2d1e878d8da50e966d0ee90f6dfa
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
#29965https://github.com/nodejs/node/pull/29965
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-735ec1b
https://github.com/bnoordhuis
https://github.com/targos
build: fix version checks in gyp fileshttps://github.com/nodejs/node/commit/735ec1bf968e2f173b653dfdd8c853c6924a317d
735ec1bhttps://github.com/nodejs/node/commit/735ec1bf968e2f173b653dfdd8c853c6924a317d
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/29931#ref-commit-02f6e5c
https://github.com/targos
build: fix version checks in configure.pyhttps://github.com/nodejs/node/commit/02f6e5cc403fe546e9074b99019ed4ff505a4b73
02f6e5chttps://github.com/nodejs/node/commit/02f6e5cc403fe546e9074b99019ed4ff505a4b73
#29927https://github.com/nodejs/node/issues/29927
#29931https://github.com/nodejs/node/pull/29931
#29965https://github.com/nodejs/node/pull/29965
https://github.com/targos
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/29931#ref-pullrequest-520604598
v12.13.1 release proposal #30352 https://github.com/nodejs/node/pull/30352
BaochengSuhttps://github.com/BaochengSu
Oct 20, 2020 https://github.com/nodejs/node/pull/29931#ref-commit-b091237
https://github.com/bnoordhuis
https://github.com/BaochengSu
build: fix version checks in gyp fileshttps://github.com/BaochengSu/node/commit/b091237162d866b283093b8231dd4ebbaa32f430
b091237https://github.com/BaochengSu/node/commit/b091237162d866b283093b8231dd4ebbaa32f430
nodejs#29927https://github.com/nodejs/node/issues/29927
nodejs#29931https://github.com/nodejs/node/pull/29931
6f81401https://github.com/BaochengSu/node/commit/6f814013f45698a9178203331b62e3fe07fdb7d5
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29931
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/29931/files/e66620292e680f7300804fe3859d701de297719c
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Version number comparisons in Python and GYP files are not safe https://github.com/nodejs/node/issues/29927
Please reload this pagehttps://github.com/nodejs/node/pull/29931
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/targos
https://github.com/cjihrig
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.