| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:685d7295-5672-577d-1da8-6631c84121f3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAAC:90996:40F985B:5CA4AEB:6A4FF547 |
| html-safe-nonce | b8f78430ddbbcff3f0b4a54644b447b245c10a20119ed3bb9e5cd3995b9ff3d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUFDOjkwOTk2OjQwRjk4NUI6NUNBNEFFQjo2QTRGRjU0NyIsInZpc2l0b3JfaWQiOiI2MjQyNTA4MTQ1MDAxNzU1OTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fe55e609b55053c7f95f3ebea18efde8de39b67e112e595fa4206439fd9cf69d |
| hovercard-subject-tag | pull_request:326895758 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29923/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/beffa6abe7fdaa9970210037b956ccaa2ea046c547cfc8633e7cc88fdf77f42c/nodejs/node/pull/29923 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/beffa6abe7fdaa9970210037b956ccaa2ea046c547cfc8633e7cc88fdf77f42c/nodejs/node/pull/29923 |
| og:image:alt | Refs: #29873 (review)
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 67a336083e4dcb40224dc2c01cd4c7ed413bdb09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29923#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29923 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29923 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29923 |
| Reload | https://github.com/nodejs/node/pull/29923 |
| Reload | https://github.com/nodejs/node/pull/29923 |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
976
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:remove/process-exit | https://github.com/lpinca/node/tree/remove/process-exit |
| Conversation | https://github.com/nodejs/node/pull/29923 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29923/commits |
| Checks | https://github.com/nodejs/node/pull/29923/checks |
| Files changed | https://github.com/nodejs/node/pull/29923/files |
| test: do not force the process to exit | https://github.com/nodejs/node/pull/29923#top |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:remove/process-exit | https://github.com/lpinca/node/tree/remove/process-exit |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29923#issue-505467989 |
| #29873 (review) | https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29923#event-2703928597 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300318451 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300325746 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300349597 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300353777 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300353777 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300367743 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300526518 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300620158 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| force-pushed | https://github.com/nodejs/node/compare/b3b92112eed198e022f63cae11490d9941504c58..b9139a49fa17da5446364cfba9e9f18dad7850f0 |
| b3b9211 | https://github.com/nodejs/node/commit/b3b92112eed198e022f63cae11490d9941504c58 |
| b9139a4 | https://github.com/nodejs/node/commit/b9139a49fa17da5446364cfba9e9f18dad7850f0 |
|
Compare
| https://github.com/nodejs/node/compare/b3b92112eed198e022f63cae11490d9941504c58..b9139a49fa17da5446364cfba9e9f18dad7850f0 |
| October 11, 2019 13:20 | https://github.com/nodejs/node/pull/29923#event-2706136499 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29923#event-2706684419 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29923#issuecomment-541126106 |
| https://ci.nodejs.org/job/node-test-pull-request/25962/ | https://ci.nodejs.org/job/node-test-pull-request/25962/ |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
|
| https://github.com/lpinca |
| test: do not force the process to exit | https://github.com/nodejs/node/pull/29923/commits/55273296e172dfb6a0679eb876ed0501fee9b93e |
| 5527329 | https://github.com/nodejs/node/pull/29923/commits/55273296e172dfb6a0679eb876ed0501fee9b93e |
| nodejs#29873 (review) | https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| force-pushed | https://github.com/nodejs/node/compare/b9139a49fa17da5446364cfba9e9f18dad7850f0..55273296e172dfb6a0679eb876ed0501fee9b93e |
| b9139a4 | https://github.com/nodejs/node/commit/b9139a49fa17da5446364cfba9e9f18dad7850f0 |
| 5527329 | https://github.com/nodejs/node/commit/55273296e172dfb6a0679eb876ed0501fee9b93e |
|
Compare
| https://github.com/nodejs/node/compare/b9139a49fa17da5446364cfba9e9f18dad7850f0..55273296e172dfb6a0679eb876ed0501fee9b93e |
| October 11, 2019 18:46 | https://github.com/nodejs/node/pull/29923#event-2707098975 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29923#issuecomment-541180887 |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29923#issuecomment-541181299 |
| https://ci.nodejs.org/job/node-test-pull-request/25969/ | https://ci.nodejs.org/job/node-test-pull-request/25969/ |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Oct 12, 2019
| https://github.com/nodejs/node/pull/29923#pullrequestreview-300997127 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29923/files/55273296e172dfb6a0679eb876ed0501fee9b93e |
| Trott | https://github.com/Trott |
|
Oct 13, 2019
| https://github.com/nodejs/node/pull/29923#ref-commit-19a8d22 |
|
| https://github.com/lpinca |
|
| https://github.com/Trott |
| test: do not force the process to exit | https://github.com/nodejs/node/commit/19a8d22c77f55858d8dfb1fa593837112fb4aad2 |
| 19a8d22 | https://github.com/nodejs/node/commit/19a8d22c77f55858d8dfb1fa593837112fb4aad2 |
| #29873 (review) | https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847 |
| #29923 | https://github.com/nodejs/node/pull/29923 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2019 | https://github.com/nodejs/node/pull/29923#issuecomment-541372153 |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2019 | https://github.com/nodejs/node/pull/29923#event-2708371596 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| October 13, 2019 05:13 | https://github.com/nodejs/node/pull/29923#event-2708462801 |
| targos | https://github.com/targos |
|
Oct 14, 2019
| https://github.com/nodejs/node/pull/29923#ref-commit-50f0660 |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
| test: do not force the process to exit | https://github.com/nodejs/node/commit/50f066087e4384c8fb13d875db8103b2b60b729d |
| 50f0660 | https://github.com/nodejs/node/commit/50f066087e4384c8fb13d875db8103b2b60b729d |
| #29873 (review) | https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847 |
| #29923 | https://github.com/nodejs/node/pull/29923 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29923#ref-pullrequest-507187967 |
|
v12.13.0 'Erbium' release proposal
#29981
| https://github.com/nodejs/node/pull/29981 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29923 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/29923/files/55273296e172dfb6a0679eb876ed0501fee9b93e |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/29923/files/b3b92112eed198e022f63cae11490d9941504c58 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/29923 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/Fishrock123 |
|
| https://github.com/antsmartian |
|
| https://github.com/cjihrig |
|
| https://github.com/devnexen |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |