| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:789a6a29-359c-c5dd-ebeb-b607242c9416 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A5CA:1F29:B4FD7:139D58:6A4FD2A7 |
| html-safe-nonce | 608c8f586e8837c5f4d842603e6f0b8cf01a30d80056d6cf32574d7eb32dd796 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUNBOjFGMjk6QjRGRDc6MTM5RDU4OjZBNEZEMkE3IiwidmlzaXRvcl9pZCI6IjY0NjI3MzY2NTYxNDMyMDkxMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8d58296a6468891d4945156cfcbb14bc3923bb95675a6d8b3c910c3235ef8fda |
| hovercard-subject-tag | pull_request:325462931 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29877/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2427a4f496fd008ce204c0d5ee63cc0e425eda38599688ffc21194ffa946d481/nodejs/node/pull/29877 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2427a4f496fd008ce204c0d5ee63cc0e425eda38599688ffc21194ffa946d481/nodejs/node/pull/29877 |
| og:image:alt | Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.
Checklist
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Flarna |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29877#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29877 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29877 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29877 |
| Reload | https://github.com/nodejs/node/pull/29877 |
| Reload | https://github.com/nodejs/node/pull/29877 |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Flarna | https://github.com/Flarna |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dynatrace-oss-contrib:abi-version-registry | https://github.com/dynatrace-oss-contrib/node/tree/abi-version-registry |
| Conversation | https://github.com/nodejs/node/pull/29877 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29877/commits |
| Checks | https://github.com/nodejs/node/pull/29877/checks |
| Files changed | https://github.com/nodejs/node/pull/29877/files |
| doc: set module version 72 to node 12 | https://github.com/nodejs/node/pull/29877#top |
| Flarna | https://github.com/Flarna |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dynatrace-oss-contrib:abi-version-registry | https://github.com/dynatrace-oss-contrib/node/tree/abi-version-registry |
|
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/29877#issue-503652192 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
|
| https://github.com/Flarna |
| doc: set module version 72 to node 12 | https://github.com/nodejs/node/pull/29877/commits/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| 3e8883a | https://github.com/nodejs/node/pull/29877/commits/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/29877#event-2693079164 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-298367948 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/29877#issuecomment-539174668 |
| release process for majors | https://github.com/nodejs/node/blob/master/doc/releases.md#major-Releases |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-298385598 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Oct 8, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-298488135 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Oct 8, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-298662061 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 8, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-298763826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-299599797 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29877#ref-issue-504813714 |
|
Update module version for new major releases
nodejs/Release#485
| https://github.com/nodejs/Release/issues/485 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29877#event-2701365359 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29877#issuecomment-540375573 |
| https://ci.nodejs.org/job/node-test-pull-request/25938/ | https://ci.nodejs.org/job/node-test-pull-request/25938/ |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-300151479 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29877#issuecomment-540637757 |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29877#event-2703154343 |
| mmarchini | https://github.com/mmarchini |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29877#ref-commit-8b9a578 |
|
| https://github.com/Flarna |
|
| https://github.com/mmarchini |
| doc: set module version 72 to node 12 | https://github.com/nodejs/node/commit/8b9a578bf96ce323a61fb6f255a413fa78e5b341 |
| 8b9a578 | https://github.com/nodejs/node/commit/8b9a578bf96ce323a61fb6f255a413fa78e5b341 |
| #29877 | https://github.com/nodejs/node/pull/29877 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| October 10, 2019 19:09 | https://github.com/nodejs/node/pull/29877#event-2703861304 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29877#pullrequestreview-300907665 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/29877#pullrequestreview-300907665 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
| targos | https://github.com/targos |
|
Oct 14, 2019
| https://github.com/nodejs/node/pull/29877#ref-commit-7683aa0 |
|
| https://github.com/Flarna |
|
| https://github.com/targos |
| doc: set module version 72 to node 12 | https://github.com/nodejs/node/commit/7683aa0bfb10d65ea0b137014add13adda62f9a5 |
| 7683aa0 | https://github.com/nodejs/node/commit/7683aa0bfb10d65ea0b137014add13adda62f9a5 |
| #29877 | https://github.com/nodejs/node/pull/29877 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29877#ref-pullrequest-507187967 |
|
v12.13.0 'Erbium' release proposal
#29981
| https://github.com/nodejs/node/pull/29981 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29877 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/mmarchini |
|
mmarchini
| https://github.com/mmarchini |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/29877/files/3e8883a1ab5871235a194c3ffdc849ebaaed8d09 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/29877 |
|
| https://github.com/Flarna |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mmarchini |
|
| https://github.com/MylesBorins |
|
| https://github.com/gengjiawen |
|
| https://github.com/devnexen |
|
| https://github.com/BethGriggs |
|
| https://github.com/BridgeAR |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |