René's URL Explorer Experiment


Title: test: remove extra process.exit() by cjihrig · Pull Request #29873 · nodejs/node · GitHub

Open Graph Title: test: remove extra process.exit() by cjihrig · Pull Request #29873 · nodejs/node

X Title: test: remove extra process.exit() by cjihrig · Pull Request #29873 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I missed this during the review of #29816. process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit r...

X Description: I missed this during the review of #29816. process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this comm...

Opengraph URL: https://github.com/nodejs/node/pull/29873

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:814a987b-5d32-35c9-c3d5-0ed40e40d868
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9F2:363DB3:41DF7D8:5DE08CE:6A4FF543
html-safe-noncec0a81eaf0de0c93175296ef631863c70c029967699da70664a7bb227a942231e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjM2M0RCMzo0MURGN0Q4OjVERTA4Q0U6NkE0RkY1NDMiLCJ2aXNpdG9yX2lkIjoiMTYyMzI5NTE0NDg0ODUyMDUxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc6f98b5f355973e009cf0c466ed1c98f42c78da5eed36b37418f5fe30a0a85c1
hovercard-subject-tagpull_request:325355088
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29873/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50b26b06866dad087cc4bdd25a980ea8c3bf38835c9140c449be68d9938dd523/nodejs/node/pull/29873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50b26b06866dad087cc4bdd25a980ea8c3bf38835c9140c449be68d9938dd523/nodejs/node/pull/29873
og:image:altI missed this during the review of #29816. process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67a336083e4dcb40224dc2c01cd4c7ed413bdb09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29873#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29873
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29873
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29873
Reloadhttps://github.com/nodejs/node/pull/29873
Reloadhttps://github.com/nodejs/node/pull/29873
Please reload this pagehttps://github.com/nodejs/node/pull/29873
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29873
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:testhttps://github.com/cjihrig/node/tree/test
Conversationhttps://github.com/nodejs/node/pull/29873
Commits1 (1)https://github.com/nodejs/node/pull/29873/commits
Checkshttps://github.com/nodejs/node/pull/29873/checks
Files changedhttps://github.com/nodejs/node/pull/29873/files
test: remove extra process.exit()https://github.com/nodejs/node/pull/29873#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:testhttps://github.com/cjihrig/node/tree/test
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 7, 2019https://github.com/nodejs/node/pull/29873#issue-503517718
#29816https://github.com/nodejs/node/pull/29816
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29873
https://github.com/cjihrig
test: remove extra process.exit()https://github.com/nodejs/node/pull/29873/commits/0987f23b738689ec0d50a4b02419e9a8e5a841f6
0987f23https://github.com/nodejs/node/pull/29873/commits/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 7, 2019https://github.com/nodejs/node/pull/29873#event-2692230040
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 7, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-298290102
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-298290673
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 7, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-298293244
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 7, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-298353290
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 7, 2019https://github.com/nodejs/node/pull/29873#event-2693051424
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 7, 2019https://github.com/nodejs/node/pull/29873#issuecomment-539169449
https://ci.nodejs.org/job/node-test-pull-request/25898/https://ci.nodejs.org/job/node-test-pull-request/25898/
Please reload this pagehttps://github.com/nodejs/node/pull/29873
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Oct 8, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
ZYSzyshttps://github.com/ZYSzys
https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/test/parallel/test-http-localaddress.jshttps://github.com/nodejs/node/blob/064e111515185529b6f943dc66929440557fd609/test/parallel/test-http-localaddress.js#L50-L53
064e111https://github.com/nodejs/node/commit/064e111515185529b6f943dc66929440557fd609
node/test/parallel/test-https-localaddress.jshttps://github.com/nodejs/node/blob/064e111515185529b6f943dc66929440557fd609/test/parallel/test-https-localaddress.js#L62-L65
064e111https://github.com/nodejs/node/commit/064e111515185529b6f943dc66929440557fd609
Please reload this pagehttps://github.com/nodejs/node/pull/29873
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 9, 2019 https://github.com/nodejs/node/pull/29873#pullrequestreview-299605372
View reviewed changes https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
danbevhttps://github.com/danbev
Oct 10, 2019 https://github.com/nodejs/node/pull/29873#ref-commit-7682874
https://github.com/cjihrig
https://github.com/danbev
test: remove extra process.exit()https://github.com/nodejs/node/commit/768287489a6d8feb956e8b9f004b08e1b11d62c5
7682874https://github.com/nodejs/node/commit/768287489a6d8feb956e8b9f004b08e1b11d62c5
#29873https://github.com/nodejs/node/pull/29873
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2019https://github.com/nodejs/node/pull/29873#issuecomment-540382374
7682874https://github.com/nodejs/node/commit/768287489a6d8feb956e8b9f004b08e1b11d62c5
Please reload this pagehttps://github.com/nodejs/node/pull/29873
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2019https://github.com/nodejs/node/pull/29873#event-2701394981
BridgeARhttps://github.com/BridgeAR
Oct 10, 2019 https://github.com/nodejs/node/pull/29873#ref-commit-5fdf4a4
https://github.com/cjihrig
https://github.com/BridgeAR
test: remove extra process.exit()https://github.com/nodejs/node/commit/5fdf4a474f011f745de1f924d470cdd2c0cd3382
5fdf4a4https://github.com/nodejs/node/commit/5fdf4a474f011f745de1f924d470cdd2c0cd3382
#29873https://github.com/nodejs/node/pull/29873
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 10, 2019 https://github.com/nodejs/node/pull/29873#ref-pullrequest-505244335
v12.12.0 proposal #29919 https://github.com/nodejs/node/pull/29919
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 10, 2019 https://github.com/nodejs/node/pull/29873#ref-pullrequest-505467989
test: do not force the process to exit #29923 https://github.com/nodejs/node/pull/29923
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
October 11, 2019 16:07https://github.com/nodejs/node/pull/29873#event-2706682594
lpincahttps://github.com/lpinca
Oct 11, 2019 https://github.com/nodejs/node/pull/29873#ref-commit-5527329
https://github.com/lpinca
test: do not force the process to exithttps://github.com/lpinca/node/commit/55273296e172dfb6a0679eb876ed0501fee9b93e
5527329https://github.com/lpinca/node/commit/55273296e172dfb6a0679eb876ed0501fee9b93e
nodejs#29873 (review)https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847
Trotthttps://github.com/Trott
Oct 13, 2019 https://github.com/nodejs/node/pull/29873#ref-commit-19a8d22
https://github.com/lpinca
https://github.com/Trott
test: do not force the process to exithttps://github.com/nodejs/node/commit/19a8d22c77f55858d8dfb1fa593837112fb4aad2
19a8d22https://github.com/nodejs/node/commit/19a8d22c77f55858d8dfb1fa593837112fb4aad2
#29873 (review)https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847
#29923https://github.com/nodejs/node/pull/29923
targoshttps://github.com/targos
Oct 14, 2019 https://github.com/nodejs/node/pull/29873#ref-commit-50f0660
https://github.com/lpinca
https://github.com/targos
test: do not force the process to exithttps://github.com/nodejs/node/commit/50f066087e4384c8fb13d875db8103b2b60b729d
50f0660https://github.com/nodejs/node/commit/50f066087e4384c8fb13d875db8103b2b60b729d
#29873 (review)https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847
#29923https://github.com/nodejs/node/pull/29923
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29873
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/29873/files/0987f23b738689ec0d50a4b02419e9a8e5a841f6
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/29873
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com/lpinca
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.