| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:73b8c387-0791-00e3-2466-e0231d14d509 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9A4:2086C7:812C1CD:B4F9152:6A504D06 |
| html-safe-nonce | f3ea1ebac866bbfd5d5b111c645f6ab455d19c252463d7ebfd5f1151b4b8e2fd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUE0OjIwODZDNzo4MTJDMUNEOkI0RjkxNTI6NkE1MDREMDYiLCJ2aXNpdG9yX2lkIjoiOTI3NjU3NzM4Nzk5OTU5MzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3211209ac9b780e78a04772a2ba9fa7bb1298551cfb8d10573b4c61295cf1181 |
| hovercard-subject-tag | pull_request:324977411 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/29854 |
| twitter:image | https://opengraph.githubassets.com/63662fa1f959914226c696608d849e548f2fd82832ebd270e13250187cb878a5/nodejs/node/pull/29854 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/63662fa1f959914226c696608d849e548f2fd82832ebd270e13250187cb878a5/nodejs/node/pull/29854 |
| og:image:alt | This guard used to prevent segfaults caused by a bug in OpenSSL, but this was fixed in OpenSSL 1.1.1d.
Refs: openssl/openssl#9433
Refs: openssl/openssl#9431
Checklist
make -j4 test (UNIX), or v... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29854#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29854 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29854 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29854 |
| Reload | https://github.com/nodejs/node/pull/29854 |
| Reload | https://github.com/nodejs/node/pull/29854 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:crypto-remove-openssl-segfault-guard | https://github.com/tniessen/node/tree/crypto-remove-openssl-segfault-guard |
| Conversation | https://github.com/nodejs/node/pull/29854 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29854/commits |
| Checks | https://github.com/nodejs/node/pull/29854/checks |
| Files changed | https://github.com/nodejs/node/pull/29854/files |
| crypto: remove guard against fixed OpenSSL bug | https://github.com/nodejs/node/pull/29854#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:crypto-remove-openssl-segfault-guard | https://github.com/tniessen/node/tree/crypto-remove-openssl-segfault-guard |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29854#issue-503017583 |
| openssl/openssl#9433 | https://github.com/openssl/openssl/pull/9433 |
| openssl/openssl#9431 | https://github.com/openssl/openssl/issues/9431 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
|
| https://github.com/tniessen |
| crypto: remove guard against fixed OpenSSL bug | https://github.com/nodejs/node/pull/29854/commits/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
| aa5fa1c | https://github.com/nodejs/node/pull/29854/commits/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
| openssl/openssl#9433 | https://github.com/openssl/openssl/pull/9433 |
| openssl/openssl#9431 | https://github.com/openssl/openssl/issues/9431 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29854#event-2689537882 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-538690327 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29854#event-2689543599 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 5, 2019
| https://github.com/nodejs/node/pull/29854#pullrequestreview-297809500 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29854/files/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-538692622 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 6, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-538701545 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 6, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-538737103 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 6, 2019
| https://github.com/nodejs/node/pull/29854#pullrequestreview-297857546 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29854/files/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-539173325 |
| https://github.com/nodejs/build/blob/dc94f7e911ea6d2ea90a28a9cf2966a06f2f12f2/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2#L57-L65 | https://github.com/nodejs/build/blob/dc94f7e911ea6d2ea90a28a9cf2966a06f2f12f2/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2#L57-L65 |
| 3473e58 | https://github.com/nodejs/node/commit/3473e58fee153a7fee143a33c512ee9cda08d20a |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 9, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-540201568 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 9, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-540233256 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 9, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-540255519 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 9, 2019 | https://github.com/nodejs/node/pull/29854#event-2700863516 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 10, 2019 | https://github.com/nodejs/node/pull/29854#issuecomment-540276721 |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29854 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29854/files/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29854/files/aa5fa1c740cef6ec63eb78665d29530ff916f2a2 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/29854 |
|
| https://github.com/tniessen |
|
| https://github.com/richardlau |
|
| https://github.com/sam-github |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |