| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6d424424-dc02-e7fb-4829-163a0817c725 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A12E:383777:813179F:B51949C:6A504981 |
| html-safe-nonce | b74cb54e7c7b09405b431c4d46b3147c98e58b7b3026c73f6165bc9584d8beb2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTJFOjM4Mzc3Nzo4MTMxNzlGOkI1MTk0OUM6NkE1MDQ5ODEiLCJ2aXNpdG9yX2lkIjoiODA1NzU2ODAyNDQ0MDM1OTI5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1723053df00d83026a1de6a0194269e6cbeaf35ca1f2cf1493eaf74bb8103b73 |
| hovercard-subject-tag | pull_request:323851179 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29815/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/972f21935589684b0cdf6134b49f94ef34d03803b77fbed561b0d52720a62cca/nodejs/node/pull/29815 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/972f21935589684b0cdf6134b49f94ef34d03803b77fbed561b0d52720a62cca/nodejs/node/pull/29815 |
| og:image:alt | Update tests to create more nested folders and files, like rimraf package tests do.
Each test will create 28 nested directories and 210 files.
It will also create different types of files, like sym... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mpaktiti |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29815#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29815 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29815 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29815 |
| Reload | https://github.com/nodejs/node/pull/29815 |
| Reload | https://github.com/nodejs/node/pull/29815 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mpaktiti | https://github.com/mpaktiti |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mpaktiti:mpaktiti-enhance-rmdir-recursive-tests | https://github.com/mpaktiti/node/tree/mpaktiti-enhance-rmdir-recursive-tests |
| Conversation | https://github.com/nodejs/node/pull/29815 |
| Commits5 (5) | https://github.com/nodejs/node/pull/29815/commits |
| Checks | https://github.com/nodejs/node/pull/29815/checks |
| Files changed | https://github.com/nodejs/node/pull/29815/files |
| fs: update tests for rmdir() | https://github.com/nodejs/node/pull/29815#top |
| mpaktiti | https://github.com/mpaktiti |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mpaktiti:mpaktiti-enhance-rmdir-recursive-tests | https://github.com/mpaktiti/node/tree/mpaktiti-enhance-rmdir-recursive-tests |
|
| https://github.com/mpaktiti |
| mpaktiti | https://github.com/mpaktiti |
| Oct 2, 2019 | https://github.com/nodejs/node/pull/29815#issue-501612136 |
| rimraf package tests do | https://github.com/isaacs/rimraf/blob/master/test/fill.js |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
|
| https://github.com/mpaktiti |
| fs: add more nested folders and files | https://github.com/nodejs/node/pull/29815/commits/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9 |
| 67847ac | https://github.com/nodejs/node/pull/29815/commits/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 2, 2019 | https://github.com/nodejs/node/pull/29815#event-2681340670 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
|
Oct 2, 2019
| https://github.com/nodejs/node/pull/29815#pullrequestreview-296429112 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9 |
| iansu | https://github.com/iansu |
| https://github.com/nodejs/node/pull/29815#pullrequestreview-296429112 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Oct 2, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-537619208 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Oct 2, 2019
| https://github.com/nodejs/node/pull/29815#pullrequestreview-296550477 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| mpaktiti | https://github.com/mpaktiti |
| October 3, 2019 16:48 | https://github.com/nodejs/node/pull/29815#commits-pushed-d3d50e9 |
|
| https://github.com/mpaktiti |
| fix: feedback and linting fixes | https://github.com/nodejs/node/pull/29815/commits/d3d50e9b6daa7776be3624a858c97bf384c832f8 |
| d3d50e9 | https://github.com/nodejs/node/pull/29815/commits/d3d50e9b6daa7776be3624a858c97bf384c832f8 |
|
| https://github.com/mpaktiti |
| fix: remove check for old node version | https://github.com/nodejs/node/pull/29815/commits/5c08a2bf5bc15d4190d6bc9077fb3159552dff16 |
| 5c08a2b | https://github.com/nodejs/node/pull/29815/commits/5c08a2bf5bc15d4190d6bc9077fb3159552dff16 |
|
| https://github.com/mpaktiti |
| fix: replace let with const | https://github.com/nodejs/node/pull/29815/commits/ca3efc0754ec2c5bb92da7d89bdff4efb8d5106e |
| ca3efc0 | https://github.com/nodejs/node/pull/29815/commits/ca3efc0754ec2c5bb92da7d89bdff4efb8d5106e |
|
| https://github.com/mpaktiti |
| feat: add more test cases | https://github.com/nodejs/node/pull/29815/commits/8524fa07272d8147020932d957cb24aba4cbac5e |
| 8524fa0 | https://github.com/nodejs/node/pull/29815/commits/8524fa07272d8147020932d957cb24aba4cbac5e |
| https://github.com/mpaktiti |
| mpaktiti | https://github.com/mpaktiti |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-538648548 |
| @iansu | https://github.com/iansu |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-538697025 |
| @mpaktiti | https://github.com/mpaktiti |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-540901594 |
| @bcoe | https://github.com/bcoe |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29815#pullrequestreview-300961728 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29815/files/8524fa07272d8147020932d957cb24aba4cbac5e |
| bcoe | https://github.com/bcoe |
| https://github.com/nodejs/node/pull/29815#pullrequestreview-300961728 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29815/files/8524fa07272d8147020932d957cb24aba4cbac5e#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| bcoe | https://github.com/bcoe |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29815#discussion_r334200803 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-541252683 |
| https://ci.nodejs.org/job/node-test-pull-request/25973/ | https://ci.nodejs.org/job/node-test-pull-request/25973/ |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 12, 2019 | https://github.com/nodejs/node/pull/29815#event-2707840637 |
| Trott | https://github.com/Trott |
|
Oct 13, 2019
| https://github.com/nodejs/node/pull/29815#ref-commit-27507ca |
|
| https://github.com/mpaktiti |
|
| https://github.com/Trott |
| test: add more recursive fs.rmdir() tests | https://github.com/nodejs/node/commit/27507ca10846592a928cb3b6e7f8152d8090a24d |
| 27507ca | https://github.com/nodejs/node/commit/27507ca10846592a928cb3b6e7f8152d8090a24d |
| #29815 | https://github.com/nodejs/node/pull/29815 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2019 | https://github.com/nodejs/node/pull/29815#issuecomment-541383627 |
| 27507ca | https://github.com/nodejs/node/commit/27507ca10846592a928cb3b6e7f8152d8090a24d |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 13, 2019 | https://github.com/nodejs/node/pull/29815#event-2708437408 |
| https://github.com/mpaktiti |
| mpaktiti | https://github.com/mpaktiti |
|
Oct 14, 2019
| https://github.com/nodejs/node/pull/29815#ref-issue-464258535 |
|
[Mentorship Diary] Ian and Maria
nodejs/mentorship#158
| https://github.com/nodejs/mentorship/issues/158 |
| targos | https://github.com/targos |
|
Oct 14, 2019
| https://github.com/nodejs/node/pull/29815#ref-commit-44c581e |
|
| https://github.com/mpaktiti |
|
| https://github.com/targos |
| test: add more recursive fs.rmdir() tests | https://github.com/nodejs/node/commit/44c581ef0ba7b11dc894d3124d8e33bbf88d85da |
| 44c581e | https://github.com/nodejs/node/commit/44c581ef0ba7b11dc894d3124d8e33bbf88d85da |
| #29815 | https://github.com/nodejs/node/pull/29815 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29815#ref-pullrequest-507187967 |
|
v12.13.0 'Erbium' release proposal
#29981
| https://github.com/nodejs/node/pull/29981 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29815 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/29815/files/d3d50e9b6daa7776be3624a858c97bf384c832f8 |
|
| https://github.com/iansu |
|
iansu
| https://github.com/iansu |
|
| https://github.com/nodejs/node/pull/29815/files/67847ac5f900bce1ea8a1337a1f0fcd4ed1d22e9 |
|
| https://github.com/bcoe |
|
bcoe
| https://github.com/bcoe |
|
| https://github.com/nodejs/node/pull/29815/files/8524fa07272d8147020932d957cb24aba4cbac5e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/29815 |
|
| https://github.com/mpaktiti |
|
| https://github.com/iansu |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/bcoe |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |