René's URL Explorer Experiment


Title: crypto: remove arbitrary UTF16 restriction by addaleax · Pull Request #29795 · nodejs/node · GitHub

Open Graph Title: crypto: remove arbitrary UTF16 restriction by addaleax · Pull Request #29795 · nodejs/node

X Title: crypto: remove arbitrary UTF16 restriction by addaleax · Pull Request #29795 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is c...

X Description: Since 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is c...

Opengraph URL: https://github.com/nodejs/node/pull/29795

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d690b1b9-12e1-977a-364d-fd41dd422859
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA184:1BECDB:64892:7FF8B:6990A46C
html-safe-noncead5fea03df84429985f3e17847f6e1f37624af9e19e441fefd8a2fc71c0499c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTg0OjFCRUNEQjo2NDg5Mjo3RkY4Qjo2OTkwQTQ2QyIsInZpc2l0b3JfaWQiOiIyMjY3MDc4MDg3ODcwMDMwOTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb20ef536d9e5e1922b952e078245520ed7b8379bf87cdbc391984d16b82ce7c6
hovercard-subject-tagpull_request:323235850
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29795/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e49bb9a62c97f469d74188160083a41e09d55c55f2c1c7c30b88a3623456221e/nodejs/node/pull/29795
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e49bb9a62c97f469d74188160083a41e09d55c55f2c1c7c30b88a3623456221e/nodejs/node/pull/29795
og:image:altSince 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29795#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29795
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29795
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29795
Reloadhttps://github.com/nodejs/node/pull/29795
Reloadhttps://github.com/nodejs/node/pull/29795
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29795
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:no-crypto-utf16-restrictionshttps://github.com/addaleax/node/tree/no-crypto-utf16-restrictions
Conversationhttps://github.com/nodejs/node/pull/29795
Commits2 (2)https://github.com/nodejs/node/pull/29795/commits
Checkshttps://github.com/nodejs/node/pull/29795/checks
Files changedhttps://github.com/nodejs/node/pull/29795/files
crypto: remove arbitrary UTF16 restrictionhttps://github.com/nodejs/node/pull/29795#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:no-crypto-utf16-restrictionshttps://github.com/addaleax/node/tree/no-crypto-utf16-restrictions
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 1, 2019https://github.com/nodejs/node/pull/29795#issue-500851631
71f633ahttps://github.com/nodejs/node/commit/71f633a32f1f5617c1c7b60ad936342a579bff74
#22622https://github.com/nodejs/node/pull/22622
#29793https://github.com/nodejs/node/issues/29793
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/addaleax
crypto: remove arbitrary UTF16 restrictionhttps://github.com/nodejs/node/pull/29795/commits/c702726ed495f52c783076598bd7364efc55dfd8
c702726https://github.com/nodejs/node/pull/29795/commits/c702726ed495f52c783076598bd7364efc55dfd8
71f633ahttps://github.com/addaleax/node/commit/71f633a32f1f5617c1c7b60ad936342a579bff74
nodejs#22622https://github.com/nodejs/node/pull/22622
nodejs#29793https://github.com/nodejs/node/issues/29793
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Oct 1, 2019https://github.com/nodejs/node/pull/29795#event-2676758461
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Oct 1, 2019https://github.com/nodejs/node/pull/29795#event-2676758662
https://github.com/targos
targoshttps://github.com/targos
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295554119
View reviewed changes https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 1, 2019https://github.com/nodejs/node/pull/29795#event-2676842914
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2019https://github.com/nodejs/node/pull/29795#issuecomment-537015190
https://ci.nodejs.org/job/node-test-pull-request/25788/https://ci.nodejs.org/job/node-test-pull-request/25788/
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295568570
View reviewed changes https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295576588
View reviewed changes https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295590061
View reviewed changes https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
doc/api/errors.mdhttps://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/addaleax
https://github.com/cjihrig
fixup! crypto: remove arbitrary UTF16 restrictionhttps://github.com/nodejs/node/pull/29795/commits/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
d50bcd7https://github.com/nodejs/node/pull/29795/commits/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2019https://github.com/nodejs/node/pull/29795#issuecomment-537030017
https://ci.nodejs.org/job/node-test-pull-request/25790/https://ci.nodejs.org/job/node-test-pull-request/25790/
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2019https://github.com/nodejs/node/pull/29795#issuecomment-537056025
https://ci.nodejs.org/job/node-test-pull-request/25794/https://ci.nodejs.org/job/node-test-pull-request/25794/
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295681910
View reviewed changes https://github.com/nodejs/node/pull/29795/files/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Oct 1, 2019 https://github.com/nodejs/node/pull/29795#pullrequestreview-295806736
View reviewed changes https://github.com/nodejs/node/pull/29795/files/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 1, 2019https://github.com/nodejs/node/pull/29795#issuecomment-537176117
https://ci.nodejs.org/job/node-test-pull-request/25805/https://ci.nodejs.org/job/node-test-pull-request/25805/
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 3, 2019https://github.com/nodejs/node/pull/29795#issuecomment-538124557
Please reload this pagehttps://github.com/nodejs/node/pull/29795
Trotthttps://github.com/Trott
Oct 3, 2019 https://github.com/nodejs/node/pull/29795#ref-commit-389969e
https://github.com/addaleax
https://github.com/Trott
crypto: remove arbitrary UTF16 restrictionhttps://github.com/nodejs/node/commit/389969ea9247a7bb12d5e595879a7f0f05357dc5
389969ehttps://github.com/nodejs/node/commit/389969ea9247a7bb12d5e595879a7f0f05357dc5
71f633ahttps://github.com/nodejs/node/commit/71f633a32f1f5617c1c7b60ad936342a579bff74
#22622https://github.com/nodejs/node/pull/22622
#29793https://github.com/nodejs/node/issues/29793
#29795https://github.com/nodejs/node/pull/29795
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 3, 2019https://github.com/nodejs/node/pull/29795#event-2685444391
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 3, 2019 21:03https://github.com/nodejs/node/pull/29795#event-2685466465
BridgeARhttps://github.com/BridgeAR
Oct 9, 2019 https://github.com/nodejs/node/pull/29795#ref-commit-ab4c53e
https://github.com/addaleax
https://github.com/BridgeAR
crypto: remove arbitrary UTF16 restrictionhttps://github.com/nodejs/node/commit/ab4c53e0ef6704b6c526bb8ee0cdc9e5aa896c92
ab4c53ehttps://github.com/nodejs/node/commit/ab4c53e0ef6704b6c526bb8ee0cdc9e5aa896c92
71f633ahttps://github.com/nodejs/node/commit/71f633a32f1f5617c1c7b60ad936342a579bff74
#22622https://github.com/nodejs/node/pull/22622
#29793https://github.com/nodejs/node/issues/29793
#29795https://github.com/nodejs/node/pull/29795
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 10, 2019 https://github.com/nodejs/node/pull/29795#ref-pullrequest-505244335
v12.12.0 proposal #29919 https://github.com/nodejs/node/pull/29919
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Dec 4, 2019https://github.com/nodejs/node/pull/29795#event-2855621764
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29795
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29795/files/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/29795/files/c702726ed495f52c783076598bd7364efc55dfd8
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/29795/files/d50bcd7a014f9c15b7094dfd8034ef9b50f1ba04
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
The digest function of the Crypto module's Hash object fails encoding hash in utf16le encoding https://github.com/nodejs/node/issues/29793
Please reload this pagehttps://github.com/nodejs/node/pull/29795
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/targos
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/BridgeAR
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.