René's URL Explorer Experiment


Title: stream: 'error' should be emitted asynchronously by ronag · Pull Request #29742 · nodejs/node · GitHub

Open Graph Title: stream: 'error' should be emitted asynchronously by ronag · Pull Request #29742 · nodejs/node

X Title: stream: 'error' should be emitted asynchronously by ronag · Pull Request #29742 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: errorOrDestroy emits 'error' synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code. Fixes: #29741 Checklist make -j4 test (UNIX)...

X Description: errorOrDestroy emits 'error' synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code. Fixes: #29741 Checklist make -j4 tes...

Opengraph URL: https://github.com/nodejs/node/pull/29742

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e586db51-c305-bdeb-c2b6-12f67a47e343
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1D4:16C3D3:19BEB39:234C1CF:6A4F1439
html-safe-nonce95bde783643a71c1471a1f77fa34e112f4c35fb877420569cbf4d19f8badc5c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUQ0OjE2QzNEMzoxOUJFQjM5OjIzNEMxQ0Y6NkE0RjE0MzkiLCJ2aXNpdG9yX2lkIjoiOTA5MDA5NTYyNTczNTcwNTY1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac48df9aa1dc39303330ade7cdeb073776f9e8a51aa43b48873564ce79e1665cac
hovercard-subject-tagpull_request:322385895
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29742/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c3eb9a522c6e762bcf9f41fdde9a8fc17abe21ed111b6e81ad0006e2264ec1d7/nodejs/node/pull/29742
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c3eb9a522c6e762bcf9f41fdde9a8fc17abe21ed111b6e81ad0006e2264ec1d7/nodejs/node/pull/29742
og:image:alterrorOrDestroy emits 'error' synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code. Fixes: #29741 Checklist make -j4 test (UNIX)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29742#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29742
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29742
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29742
Reloadhttps://github.com/nodejs/node/pull/29742
Reloadhttps://github.com/nodejs/node/pull/29742
Please reload this pagehttps://github.com/nodejs/node/pull/29742
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29742
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 968 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-async-errorhttps://github.com/nxtedition/node/tree/fix-async-error
Conversationhttps://github.com/nodejs/node/pull/29742
Commits1 (1)https://github.com/nodejs/node/pull/29742/commits
Checkshttps://github.com/nodejs/node/pull/29742/checks
Files changedhttps://github.com/nodejs/node/pull/29742/files
stream: 'error' should be emitted asynchronouslyhttps://github.com/nodejs/node/pull/29742#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-async-errorhttps://github.com/nxtedition/node/tree/fix-async-error
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019https://github.com/nodejs/node/pull/29742#issue-499729665
Please reload this pagehttps://github.com/nodejs/node/pull/29742
compat reasonshttps://github.com/nodejs/node/blob/master/lib/internal/streams/destroy.js#L111
#29741https://github.com/nodejs/node/pull/29741
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/cb7b8c616db2a09dd1fe751a47107eaf51d1cec8..72effb300517df50e08df3d0a343810a9774dd69
cb7b8c6https://github.com/nodejs/node/commit/cb7b8c616db2a09dd1fe751a47107eaf51d1cec8
72effb3https://github.com/nodejs/node/commit/72effb300517df50e08df3d0a343810a9774dd69
Compare https://github.com/nodejs/node/compare/cb7b8c616db2a09dd1fe751a47107eaf51d1cec8..72effb300517df50e08df3d0a343810a9774dd69
September 28, 2019 05:37https://github.com/nodejs/node/pull/29742#event-2670341022
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Sep 28, 2019https://github.com/nodejs/node/pull/29742#event-2670341041
https://github.com/ronag
stream: 'error' should be emitted asynchronouslyhttps://github.com/nodejs/node/pull/29742/commits/4557b4816861d7cf049c955689cd84126ad66343
4557b48https://github.com/nodejs/node/pull/29742/commits/4557b4816861d7cf049c955689cd84126ad66343
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/72effb300517df50e08df3d0a343810a9774dd69..4557b4816861d7cf049c955689cd84126ad66343
72effb3https://github.com/nodejs/node/commit/72effb300517df50e08df3d0a343810a9774dd69
4557b48https://github.com/nodejs/node/commit/4557b4816861d7cf049c955689cd84126ad66343
Compare https://github.com/nodejs/node/compare/72effb300517df50e08df3d0a343810a9774dd69..4557b4816861d7cf049c955689cd84126ad66343
September 28, 2019 05:37https://github.com/nodejs/node/pull/29742#event-2670341198
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019 https://github.com/nodejs/node/pull/29742#ref-pullrequest-499703003
Revert "stream: invoke callback before emitting error always" #29741 https://github.com/nodejs/node/pull/29741
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019https://github.com/nodejs/node/pull/29742#event-2670341449
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 28, 2019 https://github.com/nodejs/node/pull/29742#pullrequestreview-294622542
View reviewed changes https://github.com/nodejs/node/pull/29742/files/4557b4816861d7cf049c955689cd84126ad66343
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2019https://github.com/nodejs/node/pull/29742#issuecomment-536156337
https://ci.nodejs.org/job/node-test-pull-request/25748/https://ci.nodejs.org/job/node-test-pull-request/25748/
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29742#issuecomment-536156352
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/Trott
Trotthttps://github.com/Trott
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Sep 28, 2019https://github.com/nodejs/node/pull/29742#event-2670356935
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29742#issuecomment-536158449
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29742#issuecomment-536192263
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29742#event-2670576481
https://github.com/kissofire
kissofirehttps://github.com/kissofire
Feb 25, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-816828754
[Snyk] Security upgrade gatsby from 2.13.73 to 2.32.8 kissofire/node#27 https://github.com/kissofire/node/pull/27
https://github.com/aliceUnhinged613
aliceUnhinged613https://github.com/aliceUnhinged613
Feb 25, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-816892585
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 aliceUnhinged613/node#18 https://github.com/aliceUnhinged613/node/pull/18
https://github.com/ron-a20
ron-a20https://github.com/ron-a20
Feb 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-816910123
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 ron-a20/node#25 https://github.com/ron-a20/node/pull/25
https://github.com/sitedata
sitedatahttps://github.com/sitedata
Feb 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-817024956
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 sitedata/node#17 https://github.com/sitedata/node/pull/17
https://github.com/meghasfdc
meghasfdchttps://github.com/meghasfdc
Feb 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-817027425
[Snyk] Security upgrade gatsby from 2.13.73 to 2.32.8 meghasfdc/node#27 https://github.com/meghasfdc/node/pull/27
https://github.com/137717unity
137717unityhttps://github.com/137717unity
Feb 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-817063576
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 137717unity/node#18 https://github.com/137717unity/node/pull/18
https://github.com/Rednickle
Rednicklehttps://github.com/Rednickle
Feb 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-817141867
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 Rednickle/node-1#14 https://github.com/Rednickle/node-1/pull/14
[Snyk] Security upgrade gatsby from 2.24.27 to 2.32.8 Dmarch28/node#19 https://github.com/Dmarch28/node/pull/19
[Snyk] Security upgrade gatsby from 2.23.20 to 2.32.8 turkdevops/node#244 https://github.com/turkdevops/node/pull/244
[Snyk] Security upgrade gatsby from 2.23.20 to 2.32.8 turkdevops/node#245 https://github.com/turkdevops/node/pull/245
[Snyk] Security upgrade gatsby from 2.24.27 to 2.32.8 baby636/node#6 https://github.com/baby636/node/pull/6
[Snyk] Security upgrade gatsby from 2.24.27 to 2.32.8 baby636/node#8 https://github.com/baby636/node/pull/8
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
May 26, 2021 https://github.com/nodejs/node/pull/29742#ref-pullrequest-902861017
[Snyk] Security upgrade gatsby from 2.24.27 to 2.32.8 Dmarch28/node#23 https://github.com/Dmarch28/node/pull/23
https://github.com/aliceUnhinged613
aliceUnhinged613https://github.com/aliceUnhinged613
Oct 30, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1428881327
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 aliceUnhinged613/node#81 https://github.com/aliceUnhinged613/node/pull/81
https://github.com/137717unity
137717unityhttps://github.com/137717unity
Oct 30, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1428884079
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 137717unity/node#84 https://github.com/137717unity/node/pull/84
https://github.com/molllyn1
molllyn1https://github.com/molllyn1
Oct 30, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1428996177
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 molllyn1/node#64 https://github.com/molllyn1/node/pull/64
https://github.com/kissofire
kissofirehttps://github.com/kissofire
Oct 30, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1429004016
[Snyk] Security upgrade gatsby from 2.13.73 to 2.32.8 kissofire/node#86 https://github.com/kissofire/node/pull/86
https://github.com/wedataintelligence
wedataintelligencehttps://github.com/wedataintelligence
Oct 30, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1429011381
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 wedataintelligence/node#62 https://github.com/wedataintelligence/node/pull/62
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Oct 31, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1429119077
[Snyk] Security upgrade gatsby from 2.24.27 to 2.32.8 baby636/node#80 https://github.com/baby636/node/pull/80
https://github.com/ron-a20
ron-a20https://github.com/ron-a20
Oct 31, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1429152517
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 ron-a20/node#84 https://github.com/ron-a20/node/pull/84
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Oct 31, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1429280627
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 Rednickle/node-1#65 https://github.com/Rednickle/node-1/pull/65
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Nov 10, 2022 https://github.com/nodejs/node/pull/29742#ref-pullrequest-1444271436
[Snyk] Security upgrade gatsby from 2.23.20 to 2.32.8 turkdevops/node#418 https://github.com/turkdevops/node/pull/418
https://github.com/kissofire
kissofirehttps://github.com/kissofire
Dec 6, 2023 https://github.com/nodejs/node/pull/29742#ref-pullrequest-2028712728
[Snyk] Security upgrade gatsby from 2.13.73 to 2.32.8 kissofire/node#113 https://github.com/kissofire/node/pull/113
https://github.com/137717unity
137717unityhttps://github.com/137717unity
Dec 6, 2023 https://github.com/nodejs/node/pull/29742#ref-pullrequest-2028740480
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 137717unity/node#112 https://github.com/137717unity/node/pull/112
https://github.com/ron-a20
ron-a20https://github.com/ron-a20
Dec 6, 2023 https://github.com/nodejs/node/pull/29742#ref-pullrequest-2028966254
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 ron-a20/node#110 https://github.com/ron-a20/node/pull/110
https://github.com/aliceUnhinged613
aliceUnhinged613https://github.com/aliceUnhinged613
Dec 6, 2023 https://github.com/nodejs/node/pull/29742#ref-pullrequest-2029412058
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 aliceUnhinged613/node#111 https://github.com/aliceUnhinged613/node/pull/111
https://github.com/wedataintelligence
wedataintelligencehttps://github.com/wedataintelligence
Dec 7, 2023 https://github.com/nodejs/node/pull/29742#ref-pullrequest-2029667238
[Snyk] Security upgrade gatsby from 2.18.18 to 2.32.8 wedataintelligence/node#94 https://github.com/wedataintelligence/node/pull/94
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29742
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29742/files/4557b4816861d7cf049c955689cd84126ad66343
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/29742
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.