René's URL Explorer Experiment


Title: Revert "stream: invoke callback before emitting error always" by richardlau · Pull Request #29741 · nodejs/node · GitHub

Open Graph Title: Revert "stream: invoke callback before emitting error always" by richardlau · Pull Request #29741 · nodejs/node

X Title: Revert "stream: invoke callback before emitting error always" by richardlau · Pull Request #29741 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 3de5eae. Refs: #29293 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This reverts commit 3de5eae. Refs: #29293 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/29741

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26293ae9-266d-2550-a8c3-7308d4857bd3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6FA:1B445F:54E31F:735EB1:6A4EBC69
html-safe-nonce3187211e822bfe6fd7fc92545e02f5f2c4afdc817b87ccb8afe3c9281be30a0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkZBOjFCNDQ1Rjo1NEUzMUY6NzM1RUIxOjZBNEVCQzY5IiwidmlzaXRvcl9pZCI6IjU4NDA0NjUxNjczNTIyOTAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac182b300d4a0a89263c0726a4fc6dc162a3de06400ccbe97d8eb0142412ab2e07
hovercard-subject-tagpull_request:322366135
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29741/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/53347ac7e5b59ffe08ffcc856a3a258480025254949f9340398ef949d6c988ef/nodejs/node/pull/29741
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/53347ac7e5b59ffe08ffcc856a3a258480025254949f9340398ef949d6c988ef/nodejs/node/pull/29741
og:image:altThis reverts commit 3de5eae. Refs: #29293 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29741#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29741
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29741
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29741
Reloadhttps://github.com/nodejs/node/pull/29741
Reloadhttps://github.com/nodejs/node/pull/29741
Please reload this pagehttps://github.com/nodejs/node/pull/29741
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29741
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:unbreak-buildhttps://github.com/richardlau/node-1/tree/unbreak-build
Conversationhttps://github.com/nodejs/node/pull/29741
Commits1 (1)https://github.com/nodejs/node/pull/29741/commits
Checkshttps://github.com/nodejs/node/pull/29741/checks
Files changedhttps://github.com/nodejs/node/pull/29741/files
Revert "stream: invoke callback before emitting error always"https://github.com/nodejs/node/pull/29741#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:unbreak-buildhttps://github.com/richardlau/node-1/tree/unbreak-build
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issue-499703003
3de5eaehttps://github.com/nodejs/node/commit/3de5eae6dbe503485b95bdeb8bddbd67e4613d59
#29293 (comment)https://github.com/nodejs/node/pull/29293#issuecomment-536133796
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/richardlau
Revert "stream: invoke callback before emitting error always"https://github.com/nodejs/node/pull/29741/commits/44246251ab003b1b3d15ce0b3e637893b7a62721
4424625https://github.com/nodejs/node/pull/29741/commits/44246251ab003b1b3d15ce0b3e637893b7a62721
3de5eaehttps://github.com/richardlau/node-1/commit/3de5eae6dbe503485b95bdeb8bddbd67e4613d59
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Sep 28, 2019https://github.com/nodejs/node/pull/29741#event-2670205136
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#ref-pullrequest-478830434
fs: deprecate file stream open #29061 https://github.com/nodejs/node/pull/29061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536142869
https://ci.nodejs.org/job/node-test-pull-request/25747/https://ci.nodejs.org/job/node-test-pull-request/25747/
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#pullrequestreview-294619658
View reviewed changes https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536150711
https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1691/https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1691/
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536151182
https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1691/https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1691/
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 28, 2019https://github.com/nodejs/node/pull/29741#event-2670308424
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#ref-pullrequest-499215464
module: move cjs type check behind experimental-modules flag #29732 https://github.com/nodejs/node/pull/29732
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#ref-pullrequest-499729665
stream: 'error' should be emitted asynchronously #29742 https://github.com/nodejs/node/pull/29742
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536156171
Please reload this pagehttps://github.com/nodejs/node/pull/29741
#29742https://github.com/nodejs/node/pull/29742
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#pullrequestreview-294623648
View reviewed changes https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536158492
#29742https://github.com/nodejs/node/pull/29742
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536158647
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#pullrequestreview-294628080
View reviewed changes https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
test/parallel/test-zlib-write-after-close.jshttps://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721#diff-049988249591258076aa7165849170bbe6bd222b3eb3a4330fed940ed8eee6ab
ronaghttps://github.com/ronag
Sep 28, 2019https://github.com/nodejs/node/pull/29741#discussion_r329302698
Please reload this pagehttps://github.com/nodejs/node/pull/29741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#pullrequestreview-294628308
View reviewed changes https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/29741#pullrequestreview-294628308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29742https://github.com/nodejs/node/pull/29742
#29742https://github.com/nodejs/node/pull/29742
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#pullrequestreview-294636517
View reviewed changes https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536191953
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#issuecomment-536191975
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29741#event-2670574865
Trotthttps://github.com/Trott
Sep 28, 2019 https://github.com/nodejs/node/pull/29741#ref-commit-95792a7
https://github.com/richardlau
https://github.com/Trott
Revert "stream: invoke callback before emitting error always"https://github.com/nodejs/node/commit/95792a79892471e2c691c071e85d7fea29aa40cd
95792a7https://github.com/nodejs/node/commit/95792a79892471e2c691c071e85d7fea29aa40cd
3de5eaehttps://github.com/nodejs/node/commit/3de5eae6dbe503485b95bdeb8bddbd67e4613d59
#29741https://github.com/nodejs/node/pull/29741
https://github.com/richardlau
richardlauhttps://github.com/richardlau
September 28, 2019 16:59https://github.com/nodejs/node/pull/29741#event-2670666798
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Oct 1, 2019https://github.com/nodejs/node/pull/29741#event-2676865143
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29741
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/29741/files/44246251ab003b1b3d15ce0b3e637893b7a62721
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/29741
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/ronag
https://github.com/mcollina
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.