| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fa012526-d45e-ea1b-a491-747e65ed0055 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCD0:AC7DC:62A11A:902224:6A4E0F18 |
| html-safe-nonce | cbd1d395a48a9a2787e0e9a9ef1ec3ea7571f8caa517df257e8f0b17bea866f0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0QwOkFDN0RDOjYyQTExQTo5MDIyMjQ6NkE0RTBGMTgiLCJ2aXNpdG9yX2lkIjoiODI1MTgzNzAwNTkyMDM0MTc4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 768253a1d99a8e1ff3676d39b6b5359f5f58d279d2a2588fa5b82500b5bf0112 |
| hovercard-subject-tag | pull_request:322236655 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29736/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ae2d7366cdc85ec1f7d247cfba5e4b37c21945326c1d9220f98d47d681905902/nodejs/node/pull/29736 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ae2d7366cdc85ec1f7d247cfba5e4b37c21945326c1d9220f98d47d681905902/nodejs/node/pull/29736 |
| og:image:alt | This passes the full URL for the top-level "runMain" to the ESM loader, instead of the pathname. In addition the existing example loader check of the input path type is adjusted to catch ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29736#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29736 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29736 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29736 |
| Reload | https://github.com/nodejs/node/pull/29736 |
| Reload | https://github.com/nodejs/node/pull/29736 |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| guybedford | https://github.com/guybedford |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| guybedford:href | https://github.com/guybedford/node/tree/href |
| Conversation | https://github.com/nodejs/node/pull/29736 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29736/commits |
| Checks | https://github.com/nodejs/node/pull/29736/checks |
| Files changed | https://github.com/nodejs/node/pull/29736/files |
| module: pass full URL to loader for top-level load | https://github.com/nodejs/node/pull/29736#top |
| guybedford | https://github.com/guybedford |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| guybedford:href | https://github.com/guybedford/node/tree/href |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29736#issue-499535204 |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| #29610 | https://github.com/nodejs/node/issues/29610 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
|
| https://github.com/guybedford |
| module: pass full URL to loader for top-level load | https://github.com/nodejs/node/pull/29736/commits/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
| 43398d9 | https://github.com/nodejs/node/pull/29736/commits/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| bmeck | https://github.com/bmeck |
| September 27, 2019 16:22 | https://github.com/nodejs/node/pull/29736#event-2669204966 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29736#pullrequestreview-294432766 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29736/files/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29736#event-2669367809 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29736#issuecomment-536125791 |
| https://ci.nodejs.org/job/node-test-pull-request/25742/ | https://ci.nodejs.org/job/node-test-pull-request/25742/ |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Sep 28, 2019
| https://github.com/nodejs/node/pull/29736#pullrequestreview-294650842 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29736/files/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#issuecomment-536369896 |
| https://ci.nodejs.org/job/node-test-pull-request/25765/ | https://ci.nodejs.org/job/node-test-pull-request/25765/ |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#event-2671662336 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#issuecomment-536383799 |
| c42ab99 | https://github.com/nodejs/node/commit/c42ab995c16a134350078d70e32bc278cd74bc1f |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#event-2671754721 |
| Trott | https://github.com/Trott |
|
Sep 30, 2019
| https://github.com/nodejs/node/pull/29736#ref-commit-c42ab99 |
|
| https://github.com/guybedford |
|
| https://github.com/Trott |
| module: pass full URL to loader for top-level load | https://github.com/nodejs/node/commit/c42ab995c16a134350078d70e32bc278cd74bc1f |
| c42ab99 | https://github.com/nodejs/node/commit/c42ab995c16a134350078d70e32bc278cd74bc1f |
| #29736 | https://github.com/nodejs/node/pull/29736 |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#issuecomment-536519735 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29736#issuecomment-536692319 |
| @Trott | https://github.com/Trott |
| https://github.com/nodejs/node/blob/f663b31cc2aecd585e73430504f3d7f5252851ca/COLLABORATOR_GUIDE.md#landing-pull-requests | https://github.com/nodejs/node/blob/f663b31cc2aecd585e73430504f3d7f5252851ca/COLLABORATOR_GUIDE.md#landing-pull-requests |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29736#ref-commit-d1f4bef |
|
| https://github.com/guybedford |
|
| https://github.com/targos |
| module: pass full URL to loader for top-level load | https://github.com/nodejs/node/commit/d1f4befd09b74f9f39f14871b77c27f04c004b6b |
| d1f4bef | https://github.com/nodejs/node/commit/d1f4befd09b74f9f39f14871b77c27f04c004b6b |
| #29736 | https://github.com/nodejs/node/pull/29736 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29736#ref-pullrequest-500881212 |
|
v12.11.1 release proposal
#29796
| https://github.com/nodejs/node/pull/29796 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29736#ref-issue-501061281 |
|
2019-10-01 Version 12.11.1 (Current) @targos
beevelop/docker-nodejs#304
| https://github.com/beevelop/docker-nodejs/issues/304 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29736 |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/29736/files/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/29736/files/43398d99bc7d4c5870266367b1891634f0ee5bb6 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Please reload this page | https://github.com/nodejs/node/pull/29736 |
|
| https://github.com/guybedford |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/DerekNonGeneric |
|
| https://github.com/bmeck |
|
| https://github.com/devnexen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |