René's URL Explorer Experiment


Title: module: move cjs type check behind experimental-modules flag by guybedford · Pull Request #29732 · nodejs/node · GitHub

Open Graph Title: module: move cjs type check behind experimental-modules flag by guybedford · Pull Request #29732 · nodejs/node

X Title: module: move cjs type check behind experimental-modules flag by guybedford · Pull Request #29732 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This puts the check added in #29492 behind the --experimental-modules flag instead of being on by default. We added this error for require(.js) inside of "type": "module" packag...

X Description: This puts the check added in #29492 behind the --experimental-modules flag instead of being on by default. We added this error for require(.js) inside of "type": "module&...

Opengraph URL: https://github.com/nodejs/node/pull/29732

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:91dd95a9-4dfb-49cd-1520-7ee3ae7a11c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCEE:3DF948:137DFEA:1AC55E8:6A4DE886
html-safe-noncea62c1f3199f83fc6841e41b739d9cf74f1d4e0a888e1e61c2cfd090f211981d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0VFOjNERjk0ODoxMzdERkVBOjFBQzU1RTg6NkE0REU4ODYiLCJ2aXNpdG9yX2lkIjoiNDc4MTMyNjcxNDMyMjkzNzk5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc4de2111aa9401344a73c77facca9938706760780873187615baac60cbbc484c
hovercard-subject-tagpull_request:321984406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29732/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/13d109d92706cfb40888d840be708a9307856507b22b49fa74b026e2ce270101/nodejs/node/pull/29732
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/13d109d92706cfb40888d840be708a9307856507b22b49fa74b026e2ce270101/nodejs/node/pull/29732
og:image:altThis puts the check added in #29492 behind the --experimental-modules flag instead of being on by default. We added this error for require(.js) inside of "type": "module" packag...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29732#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29732
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29732
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29732
Reloadhttps://github.com/nodejs/node/pull/29732
Reloadhttps://github.com/nodejs/node/pull/29732
Please reload this pagehttps://github.com/nodejs/node/pull/29732
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29732
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:cjs-type-check-flaggedhttps://github.com/guybedford/node/tree/cjs-type-check-flagged
Conversationhttps://github.com/nodejs/node/pull/29732
Commits2 (2)https://github.com/nodejs/node/pull/29732/commits
Checkshttps://github.com/nodejs/node/pull/29732/checks
Files changedhttps://github.com/nodejs/node/pull/29732/files
module: move cjs type check behind experimental-modules flaghttps://github.com/nodejs/node/pull/29732#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:cjs-type-check-flaggedhttps://github.com/guybedford/node/tree/cjs-type-check-flagged
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issue-499215464
Please reload this pagehttps://github.com/nodejs/node/pull/29732
#29492https://github.com/nodejs/node/pull/29492
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/guybedford
module: move cjs type check behind flaghttps://github.com/nodejs/node/pull/29732/commits/68498665fc512a77e96155b53da2faa094adebdb
6849866https://github.com/nodejs/node/pull/29732/commits/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#ref-issue-499076545
Script-based configuration files in "type": "module" packages nodejs/modules#389 https://github.com/nodejs/modules/issues/389
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issuecomment-535772630
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#ref-issue-499069616
Transition Path Problems For Tooling nodejs/modules#388 https://github.com/nodejs/modules/issues/388
https://github.com/targos
targoshttps://github.com/targos
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294125247
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294127656
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294154350
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294265100
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294363360
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/hybrist
hybristhttps://github.com/hybrist
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294384754
View reviewed changes https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/guybedford
switch flag logical orderhttps://github.com/nodejs/node/pull/29732/commits/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
36cb1d1https://github.com/nodejs/node/pull/29732/commits/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Sep 27, 2019https://github.com/nodejs/node/pull/29732#event-2669054930
https://github.com/NemoStein
NemoSteinhttps://github.com/NemoStein
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#ref-pullrequest-490767612
module: error for CJS .js load within type: module #29492 https://github.com/nodejs/node/pull/29492
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536075419
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 27, 2019https://github.com/nodejs/node/pull/29732#event-2669728905
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294537737
View reviewed changes https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536079750
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/hybrist
hybristhttps://github.com/hybrist
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294552069
View reviewed changes https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/hybrist
hybristhttps://github.com/hybrist
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536088930
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 27, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294576617
View reviewed changes https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536125680
https://ci.nodejs.org/job/node-test-pull-request/25741/https://ci.nodejs.org/job/node-test-pull-request/25741/
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Sep 28, 2019 https://github.com/nodejs/node/pull/29732#pullrequestreview-294616107
View reviewed changes https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536152667
#29741 (comment)https://github.com/nodejs/node/pull/29741#issuecomment-536151182
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536192860
https://ci.nodejs.org/job/node-test-pull-request/25750/https://ci.nodejs.org/job/node-test-pull-request/25750/
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29732#issuecomment-536216739
Please reload this pagehttps://github.com/nodejs/node/pull/29732
Trotthttps://github.com/Trott
Sep 28, 2019 https://github.com/nodejs/node/pull/29732#ref-commit-2825e11
https://github.com/guybedford
https://github.com/Trott
module: move cjs type check behind flaghttps://github.com/nodejs/node/commit/2825e1183d87354507e2e847f0891116d48b1a38
2825e11https://github.com/nodejs/node/commit/2825e1183d87354507e2e847f0891116d48b1a38
#29732https://github.com/nodejs/node/pull/29732
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 28, 2019https://github.com/nodejs/node/pull/29732#event-2670728049
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Sep 28, 2019 https://github.com/nodejs/node/pull/29732#ref-pullrequest-499829329
Fix: Load CommonJS .eslintrc.js files within a "type": "module" package scope (fixes #12319) eslint/eslint#12333 https://github.com/eslint/eslint/pull/12333
targoshttps://github.com/targos
Oct 1, 2019 https://github.com/nodejs/node/pull/29732#ref-commit-3f02855
https://github.com/guybedford
https://github.com/targos
module: move cjs type check behind flaghttps://github.com/nodejs/node/commit/3f028551a8f679882b7ddc4d40788150fe27c168
3f02855https://github.com/nodejs/node/commit/3f028551a8f679882b7ddc4d40788150fe27c168
#29732https://github.com/nodejs/node/pull/29732
https://github.com/targos
targoshttps://github.com/targos
Oct 1, 2019 https://github.com/nodejs/node/pull/29732#ref-pullrequest-500881212
v12.11.1 release proposal #29796 https://github.com/nodejs/node/pull/29796
https://github.com/beevelop
beevelophttps://github.com/beevelop
Oct 1, 2019 https://github.com/nodejs/node/pull/29732#ref-issue-501061281
2019-10-01 Version 12.11.1 (Current) @targos beevelop/docker-nodejs#304 https://github.com/beevelop/docker-nodejs/issues/304
module: allow unrestricted cjs requires #29862 https://github.com/nodejs/node/pull/29862
module: warn on require of .js inside type: module #29909 https://github.com/nodejs/node/pull/29909
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29732
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/29732/files/68498665fc512a77e96155b53da2faa094adebdb
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/29732/files/36cb1d11121a4553f6e13e222b65b6ab30baa7f1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/29732
https://github.com/guybedford
https://github.com/devsnek
https://github.com/hybrist
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/antsmartian
https://github.com/targos
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com/devnexen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.