René's URL Explorer Experiment


Title: Revert "stream: make finished call the callback if the stream is closed" by mcollina · Pull Request #29717 · nodejs/node · GitHub

Open Graph Title: Revert "stream: make finished call the callback if the stream is closed" by mcollina · Pull Request #29717 · nodejs/node

X Title: Revert "stream: make finished call the callback if the stream is closed" by mcollina · Pull Request #29717 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #29699. This reverts commit b03845b. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Fixes #29699. This reverts commit b03845b. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/29717

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9efa1491-d938-6579-d095-6ac51761aabb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD88:FCD5E:45FCA1:5D05A3:6A516E66
html-safe-nonce6d36ed2b50bd4c3ee5458770e729367453cbeed04cb4b95f08a9240a803b8dc9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDg4OkZDRDVFOjQ1RkNBMTo1RDA1QTM6NkE1MTZFNjYiLCJ2aXNpdG9yX2lkIjoiNzA2NDM3MTkwMzk4NTcwODY0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b373385a51e58e98e1bd1b1bb20eaf188aeb83c5cbebdfd5f305fdfb0192ca1
hovercard-subject-tagpull_request:321622816
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29717/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5ba874292a21ceed1efeef6d467487e111ccee14077d7f67fbd0361a8c40b156/nodejs/node/pull/29717
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5ba874292a21ceed1efeef6d467487e111ccee14077d7f67fbd0361a8c40b156/nodejs/node/pull/29717
og:image:altFixes #29699. This reverts commit b03845b. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb19955a9dd40fd99462443f7911b522d7216776a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29717#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29717
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29717
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29717
Reloadhttps://github.com/nodejs/node/pull/29717
Reloadhttps://github.com/nodejs/node/pull/29717
Please reload this pagehttps://github.com/nodejs/node/pull/29717
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29717
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:revert-eos-changehttps://github.com/mcollina/node/tree/revert-eos-change
Conversationhttps://github.com/nodejs/node/pull/29717
Commits2 (2)https://github.com/nodejs/node/pull/29717/commits
Checkshttps://github.com/nodejs/node/pull/29717/checks
Files changedhttps://github.com/nodejs/node/pull/29717/files
Revert "stream: make finished call the callback if the stream is closed"https://github.com/nodejs/node/pull/29717#top
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:revert-eos-changehttps://github.com/mcollina/node/tree/revert-eos-change
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issue-498766885
#29699https://github.com/nodejs/node/issues/29699
b03845bhttps://github.com/nodejs/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
abandoned https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aabandoned
Sep 26, 2019https://github.com/nodejs/node/pull/29717#event-2664556911
https://github.com/mcollina
mcollinahttps://github.com/mcollina
addaleaxhttps://github.com/addaleax
jasnellhttps://github.com/jasnell
lpincahttps://github.com/lpinca
mafintoshhttps://github.com/mafintosh
sam-githubhttps://github.com/sam-github
September 26, 2019 09:25https://github.com/nodejs/node/pull/29717#event-2664556914
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
abandoned https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aabandoned
Sep 26, 2019https://github.com/nodejs/node/pull/29717#event-2664558023
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535420177
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535420910
@BethGriggshttps://github.com/BethGriggs
b03845bhttps://github.com/nodejs/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535421187
https://ci.nodejs.org/job/node-test-pull-request/25714/https://ci.nodejs.org/job/node-test-pull-request/25714/
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535421266
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2012/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2012/
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/529a573a864c98f01689c5c0f228f7b25c0733f8..5bbda7e038b260d32975946581a7d8fd89b481f5
529a573https://github.com/nodejs/node/commit/529a573a864c98f01689c5c0f228f7b25c0733f8
5bbda7ehttps://github.com/nodejs/node/commit/5bbda7e038b260d32975946581a7d8fd89b481f5
Compare https://github.com/nodejs/node/compare/529a573a864c98f01689c5c0f228f7b25c0733f8..5bbda7e038b260d32975946581a7d8fd89b481f5
September 26, 2019 09:58https://github.com/nodejs/node/pull/29717#event-2664660688
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535436381
Please reload this pagehttps://github.com/nodejs/node/pull/29717
#29699https://github.com/nodejs/node/issues/29699
#29699https://github.com/nodejs/node/issues/29699
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 26, 2019 https://github.com/nodejs/node/pull/29717#pullrequestreview-293753229
View reviewed changes https://github.com/nodejs/node/pull/29717/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/29717#pullrequestreview-293753229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535617050
@ronaghttps://github.com/ronag
@mafintoshhttps://github.com/mafintosh
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 26, 2019https://github.com/nodejs/node/pull/29717#issuecomment-535639942
Please reload this pagehttps://github.com/nodejs/node/pull/29717
#29699https://github.com/nodejs/node/issues/29699
#29724https://github.com/nodejs/node/pull/29724
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 1, 2019https://github.com/nodejs/node/pull/29717#issuecomment-536852047
@mcollinahttps://github.com/mcollina
@jasnellhttps://github.com/jasnell
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 1, 2019https://github.com/nodejs/node/pull/29717#issuecomment-536985343
#29724https://github.com/nodejs/node/pull/29724
https://github.com/nodejs/node/blob/master/doc/releases.md#release-branchhttps://github.com/nodejs/node/blob/master/doc/releases.md#release-branch
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 1, 2019https://github.com/nodejs/node/pull/29717#issuecomment-537021005
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 1, 2019https://github.com/nodejs/node/pull/29717#issuecomment-537092602
@BethGriggshttps://github.com/BethGriggs
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 1, 2019https://github.com/nodejs/node/pull/29717#issuecomment-537158581
#29724https://github.com/nodejs/node/pull/29724
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540102303
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540106874
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Oct 9, 2019 https://github.com/nodejs/node/pull/29717#pullrequestreview-299585837
View reviewed changes https://github.com/nodejs/node/pull/29717/files
https://github.com/Trott
Trotthttps://github.com/Trott
13.0.0https://github.com/nodejs/node/milestone/31
Oct 9, 2019https://github.com/nodejs/node/pull/29717#event-2699920246
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540112729
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2019 https://github.com/nodejs/node/pull/29717#pullrequestreview-299587222
View reviewed changes https://github.com/nodejs/node/pull/29717/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/29717#pullrequestreview-299587222
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540113132
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540113920
ce62e96https://github.com/nodejs/node/commit/ce62e963a13044817b43b7a7c6ef794eaa5ae905
Please reload this pagehttps://github.com/nodejs/node/pull/29717
mcollinahttps://github.com/mcollina
October 9, 2019 19:52https://github.com/nodejs/node/pull/29717#commits-pushed-7fc6286
https://github.com/mcollina
Revert "stream: remove ambiguous code"https://github.com/nodejs/node/pull/29717/commits/7fc6286c34133f82a46ad16bc3d51ed9c2700755
7fc6286https://github.com/nodejs/node/pull/29717/commits/7fc6286c34133f82a46ad16bc3d51ed9c2700755
ce62e96https://github.com/mcollina/node/commit/ce62e963a13044817b43b7a7c6ef794eaa5ae905
https://github.com/mcollina
Revert "stream: make finished call the callback if the stream is closed"https://github.com/nodejs/node/pull/29717/commits/fe76c85d6641ab1eb5e4710caba432417d44a3ef
fe76c85https://github.com/nodejs/node/pull/29717/commits/fe76c85d6641ab1eb5e4710caba432417d44a3ef
b03845bhttps://github.com/mcollina/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/5bbda7e038b260d32975946581a7d8fd89b481f5..fe76c85d6641ab1eb5e4710caba432417d44a3ef
5bbda7ehttps://github.com/nodejs/node/commit/5bbda7e038b260d32975946581a7d8fd89b481f5
fe76c85https://github.com/nodejs/node/commit/fe76c85d6641ab1eb5e4710caba432417d44a3ef
Compare https://github.com/nodejs/node/compare/5bbda7e038b260d32975946581a7d8fd89b481f5..fe76c85d6641ab1eb5e4710caba432417d44a3ef
October 9, 2019 18:15https://github.com/nodejs/node/pull/29717#event-2700005661
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540124212
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://ci.nodejs.org/job/node-test-pull-request/25930/https://ci.nodejs.org/job/node-test-pull-request/25930/
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 9, 2019 https://github.com/nodejs/node/pull/29717#ref-pullrequest-496947448
stream: remove ambiguous code #29664 https://github.com/nodejs/node/pull/29664
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29717
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 9, 2019 https://github.com/nodejs/node/pull/29717#pullrequestreview-299724646
View reviewed changes https://github.com/nodejs/node/pull/29717/files/fe76c85d6641ab1eb5e4710caba432417d44a3ef
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540227271
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2043/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2043/
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 10, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540461485
Please reload this pagehttps://github.com/nodejs/node/pull/29717
mcollinahttps://github.com/mcollina
Oct 10, 2019 https://github.com/nodejs/node/pull/29717#ref-commit-8c60685
https://github.com/mcollina
Revert "stream: remove ambiguous code"https://github.com/nodejs/node/commit/8c606851056a1bb38abdcf7ab15df8ae35ba0cf9
8c60685https://github.com/nodejs/node/commit/8c606851056a1bb38abdcf7ab15df8ae35ba0cf9
ce62e96https://github.com/nodejs/node/commit/ce62e963a13044817b43b7a7c6ef794eaa5ae905
#29717https://github.com/nodejs/node/pull/29717
mcollinahttps://github.com/mcollina
Oct 10, 2019 https://github.com/nodejs/node/pull/29717#ref-commit-9f873b3
https://github.com/mcollina
Revert "stream: make finished call the callback if the stream is closed"https://github.com/nodejs/node/commit/9f873b3a659e82eb232785c9e7cfec6df8dd5277
9f873b3https://github.com/nodejs/node/commit/9f873b3a659e82eb232785c9e7cfec6df8dd5277
b03845bhttps://github.com/nodejs/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
#29717https://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 10, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540462398
7682874...9f873b3https://github.com/nodejs/node/compare/768287489a6d8feb956e8b9f004b08e1b11d62c5...9f873b3a659e82eb232785c9e7cfec6df8dd5277
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 10, 2019https://github.com/nodejs/node/pull/29717#event-2701825508
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 10, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540462508
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 10, 2019https://github.com/nodejs/node/pull/29717#issuecomment-540500564
@mcollinahttps://github.com/mcollina
#29504https://github.com/nodejs/node/pull/29504
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 10, 2019 https://github.com/nodejs/node/pull/29717#ref-pullrequest-499058381
[x] stream: eof & pipeline compat #29724 https://github.com/nodejs/node/pull/29724
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
Jan 24, 2020https://github.com/nodejs/node/pull/29717#event-2977881225
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29717
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29717/files/5bbda7e038b260d32975946581a7d8fd89b481f5
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/29717/files/5bbda7e038b260d32975946581a7d8fd89b481f5
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/29717/files/fe76c85d6641ab1eb5e4710caba432417d44a3ef
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
https://github.com/nodejs/node/pull/29717/files/5bbda7e038b260d32975946581a7d8fd89b481f5
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
13.0.0 https://github.com/nodejs/node/milestone/31
stream.finished behaviour change https://github.com/nodejs/node/issues/29699
Please reload this pagehttps://github.com/nodejs/node/pull/29717
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/ronag
https://github.com/jasnell
https://github.com/Trott
https://github.com/BethGriggs
https://github.com/mafintosh
https://github.com/benjamingr
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.