| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d5074607-ea4c-02cf-cab8-a7682e187867 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D226:2C6DF7:D78DA9:1296861:6A4DEBC0 |
| html-safe-nonce | f3bef384f062ddf035ef500959510bd0af98102f853f986e15a6ab0b8da889b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjI2OjJDNkRGNzpENzhEQTk6MTI5Njg2MTo2QTRERUJDMCIsInZpc2l0b3JfaWQiOiI3ODgyODc3NTA4NTE2NTI1NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 89ed55046f798bea92326262b501cd597cdf7011e9f4fd4e392d1413ad77dec4 |
| hovercard-subject-tag | pull_request:320607297 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29687/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/88672904e142ffda5313679cb330f6c4088f7a39be1ae58bbc185454e8dbc56a/nodejs/node/pull/29687 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/88672904e142ffda5313679cb330f6c4088f7a39be1ae58bbc185454e8dbc56a/nodejs/node/pull/29687 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ImHype |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29687#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29687 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29687 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29687 |
| Reload | https://github.com/nodejs/node/pull/29687 |
| Reload | https://github.com/nodejs/node/pull/29687 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ImHype | https://github.com/ImHype |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ImHype:doc_29680 | https://github.com/ImHype/node/tree/doc_29680 |
| Conversation | https://github.com/nodejs/node/pull/29687 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29687/commits |
| Checks | https://github.com/nodejs/node/pull/29687/checks |
| Files changed | https://github.com/nodejs/node/pull/29687/files |
| doc: the method readable.push description | https://github.com/nodejs/node/pull/29687#top |
| ImHype | https://github.com/ImHype |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ImHype:doc_29680 | https://github.com/ImHype/node/tree/doc_29680 |
|
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29687#issue-497486221 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29687#event-2656829070 |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29687#event-2656829343 |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-534412404 |
| #29680 | https://github.com/nodejs/node/issues/29680 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| force-pushed | https://github.com/nodejs/node/compare/c3d30c8c06639af4920257dc5a96f2145ff534cd..65eb07ee13c2decdc5d9c52b38fe89f604242e70 |
| c3d30c8 | https://github.com/nodejs/node/commit/c3d30c8c06639af4920257dc5a96f2145ff534cd |
| 65eb07e | https://github.com/nodejs/node/commit/65eb07ee13c2decdc5d9c52b38fe89f604242e70 |
|
Compare
| https://github.com/nodejs/node/compare/c3d30c8c06639af4920257dc5a96f2145ff534cd..65eb07ee13c2decdc5d9c52b38fe89f604242e70 |
| September 24, 2019 07:00 | https://github.com/nodejs/node/pull/29687#event-2656894912 |
| https://github.com/reergymerej |
| reergymerej | https://github.com/reergymerej |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-534627603 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| force-pushed | https://github.com/nodejs/node/compare/65eb07ee13c2decdc5d9c52b38fe89f604242e70..2c9970bb895260d46e9148c420dbc695028e59c4 |
| 65eb07e | https://github.com/nodejs/node/commit/65eb07ee13c2decdc5d9c52b38fe89f604242e70 |
| 2c9970b | https://github.com/nodejs/node/commit/2c9970bb895260d46e9148c420dbc695028e59c4 |
|
Compare
| https://github.com/nodejs/node/compare/65eb07ee13c2decdc5d9c52b38fe89f604242e70..2c9970bb895260d46e9148c420dbc695028e59c4 |
| September 25, 2019 03:02 | https://github.com/nodejs/node/pull/29687#event-2660129501 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29687#pullrequestreview-292826581 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29687/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29687/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-534849690 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
|
| https://github.com/ImHype |
| doc: the description of readable.push() method | https://github.com/nodejs/node/pull/29687/commits/b6803ef7befe451603754bd037a30f9ab266cf6d |
| b6803ef | https://github.com/nodejs/node/pull/29687/commits/b6803ef7befe451603754bd037a30f9ab266cf6d |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| force-pushed | https://github.com/nodejs/node/compare/2c9970bb895260d46e9148c420dbc695028e59c4..b6803ef7befe451603754bd037a30f9ab266cf6d |
| 2c9970b | https://github.com/nodejs/node/commit/2c9970bb895260d46e9148c420dbc695028e59c4 |
| b6803ef | https://github.com/nodejs/node/commit/b6803ef7befe451603754bd037a30f9ab266cf6d |
|
Compare
| https://github.com/nodejs/node/compare/2c9970bb895260d46e9148c420dbc695028e59c4..b6803ef7befe451603754bd037a30f9ab266cf6d |
| September 25, 2019 06:02 | https://github.com/nodejs/node/pull/29687#event-2660392736 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29687#pullrequestreview-293212342 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29687/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/29687#pullrequestreview-293212342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/ImHype |
| ImHype | https://github.com/ImHype |
| Sep 26, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-535307359 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29687#pullrequestreview-294196225 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/29687#pullrequestreview-294196225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-535856683 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3937/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3937/ |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29687#pullrequestreview-294203406 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29687#pullrequestreview-294394880 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-535984143 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3938/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3938/ |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29687#event-2669023398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29687#issuecomment-536117291 |
| 63c0f15 | https://github.com/nodejs/node/commit/63c0f15a8286ffb1fa99d4eb5faebfd844d8451a |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
| Trott | https://github.com/Trott |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29687#ref-commit-63c0f15 |
|
| https://github.com/ImHype |
|
| https://github.com/Trott |
| doc: clarify description of readable.push() method | https://github.com/nodejs/node/commit/63c0f15a8286ffb1fa99d4eb5faebfd844d8451a |
| 63c0f15 | https://github.com/nodejs/node/commit/63c0f15a8286ffb1fa99d4eb5faebfd844d8451a |
| #29687 | https://github.com/nodejs/node/pull/29687 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29687#event-2670070298 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 28, 2019
| https://github.com/nodejs/node/pull/29687#ref-issue-497331938 |
|
Contradiction in Readable docs
#29680
| https://github.com/nodejs/node/issues/29680 |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29687#ref-commit-1303e35 |
|
| https://github.com/ImHype |
|
| https://github.com/targos |
| doc: clarify description of readable.push() method | https://github.com/nodejs/node/commit/1303e3551f305cfd5ba068eb47b6fd1e7d728a2f |
| 1303e35 | https://github.com/nodejs/node/commit/1303e3551f305cfd5ba068eb47b6fd1e7d728a2f |
| #29687 | https://github.com/nodejs/node/pull/29687 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29687#ref-pullrequest-500881212 |
|
v12.11.1 release proposal
#29796
| https://github.com/nodejs/node/pull/29796 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29687#ref-issue-501061281 |
|
2019-10-01 Version 12.11.1 (Current) @targos
beevelop/docker-nodejs#304
| https://github.com/beevelop/docker-nodejs/issues/304 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29687 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29687/files/2c9970bb895260d46e9148c420dbc695028e59c4 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29687/files/65eb07ee13c2decdc5d9c52b38fe89f604242e70 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/29687/files/b6803ef7befe451603754bd037a30f9ab266cf6d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/29687 |
|
| https://github.com/ImHype |
|
| https://github.com/reergymerej |
|
| https://github.com/Trott |
|
| https://github.com/mcollina |
|
| https://github.com/trivikr |
|
| https://github.com/jasnell |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |