| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7a6115f1-eb9c-853e-b67e-b2268a3e1078 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0F0:1B9CED:4E6D9E:68588E:6A5047D5 |
| html-safe-nonce | c999819ea9f0892e623039d66be63b7c474e0a6295c5c6e1f43fc39e765371db |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEYwOjFCOUNFRDo0RTZEOUU6Njg1ODhFOjZBNTA0N0Q1IiwidmlzaXRvcl9pZCI6Ijg1Mzk5MTE0MTg5MjQ3Nzk0NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9ff7ca776e74e29ea5e8516d6ef783dd431a924c50bb70b64c20e23fe3c3f374 |
| hovercard-subject-tag | pull_request:320317998 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29671/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c2298d9db66d5fb448210fa868854c360b0553dfcd08e678045621be26a9f049/nodejs/node/pull/29671 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c2298d9db66d5fb448210fa868854c360b0553dfcd08e678045621be26a9f049/nodejs/node/pull/29671 |
| og:image:alt | This comment:
// A better name for this function would be runNextTicks but
// it has been exposed to the process object so we keep this legacy name
// TODO(joyeecheung): either remove it or make i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lholmquist |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29671#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29671 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29671 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29671 |
| Reload | https://github.com/nodejs/node/pull/29671 |
| Reload | https://github.com/nodejs/node/pull/29671 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lholmquist | https://github.com/lholmquist |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lholmquist:deprecate-_tickCallback | https://github.com/lholmquist/node/tree/deprecate-_tickCallback |
| Conversation | https://github.com/nodejs/node/pull/29671 |
| Commits5 (5) | https://github.com/nodejs/node/pull/29671/commits |
| Checks | https://github.com/nodejs/node/pull/29671/checks |
| Files changed | https://github.com/nodejs/node/pull/29671/files |
| process: deprecate process._tickCallback | https://github.com/nodejs/node/pull/29671#top |
| lholmquist | https://github.com/lholmquist |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lholmquist:deprecate-_tickCallback | https://github.com/lholmquist/node/tree/deprecate-_tickCallback |
|
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29671#issue-497126741 |
| @joyeecheung | https://github.com/joyeecheung |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534120421 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534123216 |
| @devsnek | https://github.com/devsnek |
| https://nodejs.org/dist/latest-v12.x/docs/api/process.html#process_process_nexttick_callback_args | https://nodejs.org/dist/latest-v12.x/docs/api/process.html#process_process_nexttick_callback_args |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534126796 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534352277 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534397607 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-534958618 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535016041 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535017127 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535017924 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#event-2662277032 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293194839 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/29671/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293194937 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/29671/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293195111 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files |
| lib/internal/bootstrap/node.js | https://github.com/nodejs/node/pull/29671/files#diff-5dc112d202934c998db1f82432ccc091f1e588027b8f688cc50e1d7f46007df1 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293199976 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/29671/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535098896 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535114078 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535129745 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293294482 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files |
| benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/nodejs/node/pull/29671#pullrequestreview-293294482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| random user code | https://github.com/seebees/draino/blob/371ba95f2ef77386b4ec8b47612db9d7276946af/lib/snake.js#L108 |
| unpopular libraries | https://github.com/mamod/Pode/blob/7579c70a54d3508c5669ebe39f33c22082ab3444/lib/Pode/NativeModules/pode.js#L214 |
| popular libraries | https://github.com/standard-things/esm/blob/950e74186acf7e2e733168b327f8d9747ad13427/src/hook/main.js#L57 |
| more code | https://github.com/d3x0r/sack.vfs/blob/2918595cf47484353b9e9ed21c057e601e089e9f/vfs_module.js#L29 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535166642 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535167568 |
| @benjamingr | https://github.com/benjamingr |
| @jdalton | https://github.com/jdalton |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535169738 |
| @Fishrock123 | https://github.com/Fishrock123 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535173563 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535211368 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 26, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535339848 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 26, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535452442 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
|
Sep 26, 2019
| https://github.com/nodejs/node/pull/29671#ref-pullrequest-499064846 |
|
doc: clean up deprecations.md doc.
#29725
| https://github.com/nodejs/node/pull/29725 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-535792397 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
|
Sep 30, 2019
| https://github.com/nodejs/node/pull/29671#ref-pullrequest-500433383 |
|
doc: Add Documentation Deprecation for process._tickCallback
#29781
| https://github.com/nodejs/node/pull/29781 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Sep 30, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-536681935 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Oct 4, 2019 | https://github.com/nodejs/node/pull/29671#event-2687866740 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Oct 4, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-538454041 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| @Trott | https://github.com/Trott |
| @Fishrock123 | https://github.com/Fishrock123 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Oct 4, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-297563772 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files/a1a9df952c678e0d49b4f31dec27b288b818a7a6 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 5, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-538677860 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 5, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-297804960 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files/a1a9df952c678e0d49b4f31dec27b288b818a7a6 |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/29671/files/a1a9df952c678e0d49b4f31dec27b288b818a7a6#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/29671/files/a1a9df952c678e0d49b4f31dec27b288b818a7a6#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
|
| https://github.com/lholmquist |
| squash: put back dep code and change the metadata order | https://github.com/nodejs/node/pull/29671/commits/2781b4b58753f912368a0d11a8a07a798065300e |
| 2781b4b | https://github.com/nodejs/node/pull/29671/commits/2781b4b58753f912368a0d11a8a07a798065300e |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/29671#pullrequestreview-298125899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29671/files/2781b4b58753f912368a0d11a8a07a798065300e |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541067760 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541091439 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541093686 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541094317 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541100960 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541127091 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541177813 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| there is | https://github.com/nodejs/node/pull/29671#pullrequestreview-293294482 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/lholmquist |
| lholmquist | https://github.com/lholmquist |
| Oct 11, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-541196578 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/chris-codaio |
| chris-codaio | https://github.com/chris-codaio |
| Nov 22, 2019 | https://github.com/nodejs/node/pull/29671#issuecomment-557332166 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jan 12, 2020 | https://github.com/nodejs/node/pull/29671#event-2940960838 |
| https://github.com/mattkrick |
| mattkrick | https://github.com/mattkrick |
|
Jan 13, 2020
| https://github.com/nodejs/node/pull/29671#ref-issue-548659475 |
|
Possible memory leak-- processPromiseRejections never called?
uNetworking/uWebSockets.js#262
| https://github.com/uNetworking/uWebSockets.js/issues/262 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| 8ae28ff | https://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda |
| 2935f72 | https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5 |
|
Compare
| https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| May 31, 2020 12:19 | https://github.com/nodejs/node/pull/29671#event-3390559383 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Jun 25, 2020 | https://github.com/nodejs/node/pull/29671#event-3484485435 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/29671#issuecomment-654929315 |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/29671#event-3520925363 |
|
Add utility to synchronously inspect promise state
#40054
| https://github.com/nodejs/node/issues/40054 |
|
process: add process.runNextTicks() method
#40088
| https://github.com/nodejs/node/pull/40088 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29671 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29671/files/4f77e8def994f10a9cd16f94642a76846f9d6c2f |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/29671/files/a1a9df952c678e0d49b4f31dec27b288b818a7a6 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29671/files/2781b4b58753f912368a0d11a8a07a798065300e |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/29671 |
|
| https://github.com/lholmquist |
|
| https://github.com/devsnek |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/Fishrock123 |
|
| https://github.com/benjamingr |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
|
| https://github.com/chris-codaio |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |