René's URL Explorer Experiment


Title: crypto: use byteLength in timingSafeEqual by tniessen · Pull Request #29657 · nodejs/node · GitHub

Open Graph Title: crypto: use byteLength in timingSafeEqual by tniessen · Pull Request #29657 · nodejs/node

X Title: crypto: use byteLength in timingSafeEqual by tniessen · Pull Request #29657 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is a revival of #23341 which has shown no activity since last year. I fixed the branch, changed the error description as suggested by @jasnell in #23341 (comment), and simplified the test case...

X Description: This is a revival of #23341 which has shown no activity since last year. I fixed the branch, changed the error description as suggested by @jasnell in #23341 (comment), and simplified the test case...

Opengraph URL: https://github.com/nodejs/node/pull/29657

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ab050fc2-7e89-f1fc-3c88-8732cc0557b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC28A:39522F:D930F5:12926D4:6A4DCFEB
html-safe-nonceed7e59e20a5826db3310b5baf005b89fdd882ebf9bcf8e0ff2ed539e2b7e530d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjhBOjM5NTIyRjpEOTMwRjU6MTI5MjZENDo2QTREQ0ZFQiIsInZpc2l0b3JfaWQiOiI3Njg5MjgwMTIzNjEwOTc2MjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf259cef26e44233005c001acb1338bae3b1cfe3f1736264bc6e4f8d58d104a05
hovercard-subject-tagpull_request:320099827
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29657/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97a078370ccd559cc59056453c939b19b5df2ba40fae9eb0cd4017ac43c0db28/nodejs/node/pull/29657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97a078370ccd559cc59056453c939b19b5df2ba40fae9eb0cd4017ac43c0db28/nodejs/node/pull/29657
og:image:altThis is a revival of #23341 which has shown no activity since last year. I fixed the branch, changed the error description as suggested by @jasnell in #23341 (comment), and simplified the test case...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29657#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29657
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29657
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29657
Reloadhttps://github.com/nodejs/node/pull/29657
Reloadhttps://github.com/nodejs/node/pull/29657
Please reload this pagehttps://github.com/nodejs/node/pull/29657
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29657
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:ZaneHannanAU-patch-1https://github.com/tniessen/node/tree/ZaneHannanAU-patch-1
Conversationhttps://github.com/nodejs/node/pull/29657
Commits4 (4)https://github.com/nodejs/node/pull/29657/commits
Checkshttps://github.com/nodejs/node/pull/29657/checks
Files changedhttps://github.com/nodejs/node/pull/29657/files
crypto: use byteLength in timingSafeEqualhttps://github.com/nodejs/node/pull/29657#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:ZaneHannanAU-patch-1https://github.com/tniessen/node/tree/ZaneHannanAU-patch-1
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 23, 2019https://github.com/nodejs/node/pull/29657#issue-496856005
#23341https://github.com/nodejs/node/pull/23341
@jasnellhttps://github.com/jasnell
#23341 (comment)https://github.com/nodejs/node/pull/23341#discussion_r235443728
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29657
ZaneHannanAUhttps://github.com/ZaneHannanAU
September 23, 2019 00:05https://github.com/nodejs/node/pull/29657#commits-pushed-f63569b
https://github.com/ZaneHannanAU
https://github.com/tniessen
crypto: use byteLength in timingSafeEqualhttps://github.com/nodejs/node/pull/29657/commits/f63569bd59ff1f26171d686bb38284dde8458159
f63569bhttps://github.com/nodejs/node/pull/29657/commits/f63569bd59ff1f26171d686bb38284dde8458159
https://github.com/tniessen
errors: improve byteLength error messagehttps://github.com/nodejs/node/pull/29657/commits/8f42de8f154b6e64fc57ab6b7af4e7a271d2b06e
8f42de8https://github.com/nodejs/node/pull/29657/commits/8f42de8f154b6e64fc57ab6b7af4e7a271d2b06e
https://github.com/tniessen
test: simplify timingSafeEqual test casehttps://github.com/nodejs/node/pull/29657/commits/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
e1ada5bhttps://github.com/nodejs/node/pull/29657/commits/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Sep 23, 2019https://github.com/nodejs/node/pull/29657#event-2653001670
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 23, 2019https://github.com/nodejs/node/pull/29657#issuecomment-533934784
https://ci.nodejs.org/job/node-test-pull-request/25640/https://ci.nodejs.org/job/node-test-pull-request/25640/
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291538900
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
lib/internal/errors.jshttps://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291676098
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291760975
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291799893
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291914335
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-291965782
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 23, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-292009695
View reviewed changes https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/tniessen
https://github.com/Trott
Update lib/internal/errors.jshttps://github.com/nodejs/node/pull/29657/commits/8f12d81ee8cc571d913b6503d952cc4cdc39ab53
8f12d81https://github.com/nodejs/node/pull/29657/commits/8f12d81ee8cc571d913b6503d952cc4cdc39ab53
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/3b29af9bf3976da760b93d1bcad78f82a5377e88..8f12d81ee8cc571d913b6503d952cc4cdc39ab53
3b29af9https://github.com/nodejs/node/commit/3b29af9bf3976da760b93d1bcad78f82a5377e88
8f12d81https://github.com/nodejs/node/commit/8f12d81ee8cc571d913b6503d952cc4cdc39ab53
Compare https://github.com/nodejs/node/compare/3b29af9bf3976da760b93d1bcad78f82a5377e88..8f12d81ee8cc571d913b6503d952cc4cdc39ab53
September 24, 2019 01:53https://github.com/nodejs/node/pull/29657#event-2656405344
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 24, 2019https://github.com/nodejs/node/pull/29657#issuecomment-534383774
https://ci.nodejs.org/job/node-test-pull-request/25665/https://ci.nodejs.org/job/node-test-pull-request/25665/
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 24, 2019https://github.com/nodejs/node/pull/29657#event-2656772981
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 25, 2019https://github.com/nodejs/node/pull/29657#issuecomment-534852859
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Sep 25, 2019 https://github.com/nodejs/node/pull/29657#pullrequestreview-292884711
View reviewed changes https://github.com/nodejs/node/pull/29657/files/8f12d81ee8cc571d913b6503d952cc4cdc39ab53
tniessenhttps://github.com/tniessen
Sep 25, 2019 https://github.com/nodejs/node/pull/29657#ref-commit-6174306
https://github.com/tniessen
https://github.com/ZaneHannanAU
https://github.com/Trott
crypto: use byteLength in timingSafeEqualhttps://github.com/nodejs/node/commit/61743063cccf5b9ec6e1bc85f453bf9d3f83250a
6174306https://github.com/nodejs/node/commit/61743063cccf5b9ec6e1bc85f453bf9d3f83250a
#29657https://github.com/nodejs/node/pull/29657
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 25, 2019https://github.com/nodejs/node/pull/29657#issuecomment-535166031
6174306https://github.com/nodejs/node/commit/61743063cccf5b9ec6e1bc85f453bf9d3f83250a
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 25, 2019https://github.com/nodejs/node/pull/29657#event-2662806420
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 25, 2019 https://github.com/nodejs/node/pull/29657#ref-pullrequest-367985106
crypto: use byteLength in timingSafeEqual #23341 https://github.com/nodejs/node/pull/23341
targoshttps://github.com/targos
Oct 1, 2019 https://github.com/nodejs/node/pull/29657#ref-commit-588b388
https://github.com/tniessen
https://github.com/ZaneHannanAU
https://github.com/Trott
https://github.com/targos
crypto: use byteLength in timingSafeEqualhttps://github.com/nodejs/node/commit/588b388181b2884a3f7197c462227ce05c4c2358
588b388https://github.com/nodejs/node/commit/588b388181b2884a3f7197c462227ce05c4c2358
#29657https://github.com/nodejs/node/pull/29657
https://github.com/targos
targoshttps://github.com/targos
Oct 1, 2019 https://github.com/nodejs/node/pull/29657#ref-pullrequest-500881212
v12.11.1 release proposal #29796 https://github.com/nodejs/node/pull/29796
https://github.com/beevelop
beevelophttps://github.com/beevelop
Oct 1, 2019 https://github.com/nodejs/node/pull/29657#ref-issue-501061281
2019-10-01 Version 12.11.1 (Current) @targos beevelop/docker-nodejs#304 https://github.com/beevelop/docker-nodejs/issues/304
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 30, 2020 https://github.com/nodejs/node/pull/29657#ref-pullrequest-753416433
doc: add note about timingSafeEqual for TypedArray #36323 https://github.com/nodejs/node/pull/36323
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 14, 2021https://github.com/nodejs/node/pull/29657#event-4205695481
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29657
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/29657/files/8f12d81ee8cc571d913b6503d952cc4cdc39ab53
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/29657/files/e1ada5bf7c596f3a71e872d8e52cfce5eb7a66a4
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Please reload this pagehttps://github.com/nodejs/node/pull/29657
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/sam-github
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/JungMinu
https://github.com/BridgeAR
https://github.com/ZaneHannanAU
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.