| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:21ad6c63-3bea-fd3b-3f32-b4fc2c880106 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF8E:3854C1:5A5C6:78C30:6A4D7B75 |
| html-safe-nonce | 6fb64c1539d9b5a476b6da1b5dcfcdcd4fefd9a4cfcf9e7cdf203ec4c0dd4882 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjhFOjM4NTRDMTo1QTVDNjo3OEMzMDo2QTREN0I3NSIsInZpc2l0b3JfaWQiOiI0NjQ3OTM2ODMyNjc5Mjc5NDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6e4edee31d34838eca925eea1aa56946678530e8c73c2fb8b3661b02a7c202de |
| hovercard-subject-tag | pull_request:320075106 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29654/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2ec1b435715b2f3b6a67587a5f3058c9e0c065864e4558cf612cdc88eb82ec21/nodejs/node/pull/29654 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2ec1b435715b2f3b6a67587a5f3058c9e0c065864e4558cf612cdc88eb82ec21/nodejs/node/pull/29654 |
| og:image:alt | Documents that callback is optional for IncomingMessage setTimeout
node/lib/_http_incoming.js
Lines 88 to 89
in
0daec61
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trivikr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7f8e15305e2ab58890ca84b830615e375f5df303cf471cafcba0c08272981be3 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8608b0750fc35e283e5ec5b094bff942d7a0e197 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29654#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29654 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29654 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29654 |
| Reload | https://github.com/nodejs/node/pull/29654 |
| Reload | https://github.com/nodejs/node/pull/29654 |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| trivikr | https://github.com/trivikr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trivikr:http-incomingmessage-callback-optional | https://github.com/trivikr/node/tree/http-incomingmessage-callback-optional |
| Conversation | https://github.com/nodejs/node/pull/29654 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29654/commits |
| Checks | https://github.com/nodejs/node/pull/29654/checks |
| Files changed | https://github.com/nodejs/node/pull/29654/files |
| doc,http: optional callback for setTimeout | https://github.com/nodejs/node/pull/29654#top |
| trivikr | https://github.com/trivikr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trivikr:http-incomingmessage-callback-optional | https://github.com/trivikr/node/tree/http-incomingmessage-callback-optional |
|
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29654#issue-496821773 |
| node/lib/_http_incoming.js | https://github.com/nodejs/node/blob/0daec61b9bdefbde1026f0dacb7ee38eb6a91771/lib/_http_incoming.js#L88-L89 |
| 0daec61 | https://github.com/nodejs/node/commit/0daec61b9bdefbde1026f0dacb7ee38eb6a91771 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29654#event-2652848788 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29654#issuecomment-533910419 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3920/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3920/ |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 22, 2019
| https://github.com/nodejs/node/pull/29654#pullrequestreview-291524269 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29654/files |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29654#event-2652862308 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/8f2ff98f67151167c8a7f7f97dd6579476c89766..ef2e9e359c6dcc512beb7fe0356e05df907dd855 |
| 8f2ff98 | https://github.com/nodejs/node/commit/8f2ff98f67151167c8a7f7f97dd6579476c89766 |
| ef2e9e3 | https://github.com/nodejs/node/commit/ef2e9e359c6dcc512beb7fe0356e05df907dd855 |
|
Compare
| https://github.com/nodejs/node/compare/8f2ff98f67151167c8a7f7f97dd6579476c89766..ef2e9e359c6dcc512beb7fe0356e05df907dd855 |
| September 22, 2019 20:05 | https://github.com/nodejs/node/pull/29654#event-2652866331 |
|
| https://github.com/trivikr |
|
| https://github.com/Trott |
| doc,http: optional callback for setTimeout | https://github.com/nodejs/node/pull/29654/commits/18d529e6efc4a8f462e0674ce8293a35bace7635 |
| 18d529e | https://github.com/nodejs/node/pull/29654/commits/18d529e6efc4a8f462e0674ce8293a35bace7635 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1e157f49649a6d79bf093fde88ff2426a7ec3829..18d529e6efc4a8f462e0674ce8293a35bace7635 |
| 1e157f4 | https://github.com/nodejs/node/commit/1e157f49649a6d79bf093fde88ff2426a7ec3829 |
| 18d529e | https://github.com/nodejs/node/commit/18d529e6efc4a8f462e0674ce8293a35bace7635 |
|
Compare
| https://github.com/nodejs/node/compare/1e157f49649a6d79bf093fde88ff2426a7ec3829..18d529e6efc4a8f462e0674ce8293a35bace7635 |
| September 22, 2019 20:20 | https://github.com/nodejs/node/pull/29654#event-2652874282 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29654#pullrequestreview-291559874 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29654#pullrequestreview-291967790 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29654#issuecomment-534853480 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3932/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3932/ |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29654#issuecomment-534865545 |
| 7333c71 | https://github.com/nodejs/node/commit/7333c7163abdf58ffddb8dcbd3f0b43ad1885fdc |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29654#event-2660376749 |
| Trott | https://github.com/Trott |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29654#ref-commit-7333c71 |
|
| https://github.com/trivikr |
|
| https://github.com/Trott |
| doc,http: indicate callback is optional for message.setTimeout() | https://github.com/nodejs/node/commit/7333c7163abdf58ffddb8dcbd3f0b43ad1885fdc |
| 7333c71 | https://github.com/nodejs/node/commit/7333c7163abdf58ffddb8dcbd3f0b43ad1885fdc |
| #29654 | https://github.com/nodejs/node/pull/29654 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29654#pullrequestreview-293148183 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29654#ref-commit-6579b1a |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
| doc,http: indicate callback is optional for message.setTimeout() | https://github.com/nodejs/node/commit/6579b1a547455320bcecf00645f5623b7ccecac7 |
| 6579b1a | https://github.com/nodejs/node/commit/6579b1a547455320bcecf00645f5623b7ccecac7 |
| #29654 | https://github.com/nodejs/node/pull/29654 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29654#ref-pullrequest-500881212 |
|
v12.11.1 release proposal
#29796
| https://github.com/nodejs/node/pull/29796 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29654#ref-issue-501061281 |
|
2019-10-01 Version 12.11.1 (Current) @targos
beevelop/docker-nodejs#304
| https://github.com/beevelop/docker-nodejs/issues/304 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| August 31, 2023 14:46 | https://github.com/nodejs/node/pull/29654#event-10245866934 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29654 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/29654/files/1e157f49649a6d79bf093fde88ff2426a7ec3829 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/29654/files/18d529e6efc4a8f462e0674ce8293a35bace7635 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/29654 |
|
| https://github.com/trivikr |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |