| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:63ba16d7-b221-d529-a8ce-dd730fca3adb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D50E:9C379:AA6B52:AE56BA:6A4DB623 |
| html-safe-nonce | 96b1143638e0b4b3503badda5cbeed3841e530d166bc97f4509655c0ae5d1b43 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTBFOjlDMzc5OkFBNkI1MjpBRTU2QkE6NkE0REI2MjMiLCJ2aXNpdG9yX2lkIjoiMTI4NzAwMzQ4NzY1Mzk2NzM5NSIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9 |
| visitor-hmac | ded8c3faa1fd33033a1ce03c3ba62b6fcfd7cfbdcdd81d9f9b7173a98940e5ca |
| hovercard-subject-tag | pull_request:320048863 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29653/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fb9e40af0ba80d3e5883bac1eab877b6e671024a4cb5979573ffd72028d3bbc4/nodejs/node/pull/29653 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fb9e40af0ba80d3e5883bac1eab877b6e671024a4cb5979573ffd72028d3bbc4/nodejs/node/pull/29653 |
| og:image:alt | Errors should be propagated through destroy(err) for readable and callback for writable, anything else is undefined behaviour.
Refs: #29584
Checklist
make -j4 test (UNIX), or vcbuild test (Windo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32f7b614aca06e6bbd89842b1370df1328264f68 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29653#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29653 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29653 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29653 |
| Reload | https://github.com/nodejs/node/pull/29653 |
| Reload | https://github.com/nodejs/node/pull/29653 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:fix-doc-readable-error | https://github.com/nxtedition/node/tree/fix-doc-readable-error |
| Conversation | https://github.com/nodejs/node/pull/29653 |
| Commits11 (11) | https://github.com/nodejs/node/pull/29653/commits |
| Checks | https://github.com/nodejs/node/pull/29653/checks |
| Files changed | https://github.com/nodejs/node/pull/29653/files |
| doc: clarify stream errors while reading and writing | https://github.com/nodejs/node/pull/29653#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:fix-doc-readable-error | https://github.com/nxtedition/node/tree/fix-doc-readable-error |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29653#issue-496784092 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| #29584 | https://github.com/nodejs/node/issues/29584 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29653#event-2652691550 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/ce06247a942b9a9280d059b788c7dd0165b037d2..9c91dd215ccaf5a04caa0b2a5c121f925ade0742 |
| ce06247 | https://github.com/nodejs/node/commit/ce06247a942b9a9280d059b788c7dd0165b037d2 |
| 9c91dd2 | https://github.com/nodejs/node/commit/9c91dd215ccaf5a04caa0b2a5c121f925ade0742 |
|
Compare
| https://github.com/nodejs/node/compare/ce06247a942b9a9280d059b788c7dd0165b037d2..9c91dd215ccaf5a04caa0b2a5c121f925ade0742 |
| September 22, 2019 14:13 | https://github.com/nodejs/node/pull/29653#event-2652691903 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29653#issuecomment-533885668 |
| @jasnell | https://github.com/jasnell |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29653#event-2652695209 |
|
| https://github.com/ronag |
| doc: clarify stream errors while readingi and writing | https://github.com/nodejs/node/pull/29653/commits/82f209ecc5c5628980a77f776001e93cfe63df7b |
| 82f209e | https://github.com/nodejs/node/pull/29653/commits/82f209ecc5c5628980a77f776001e93cfe63df7b |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/df3867ea2c8ab334a219017cbc1c835c319d46a4..ee486d4668289cfa7415fc147266cd91610b4337 |
| df3867e | https://github.com/nodejs/node/commit/df3867ea2c8ab334a219017cbc1c835c319d46a4 |
| ee486d4 | https://github.com/nodejs/node/commit/ee486d4668289cfa7415fc147266cd91610b4337 |
|
Compare
| https://github.com/nodejs/node/compare/df3867ea2c8ab334a219017cbc1c835c319d46a4..ee486d4668289cfa7415fc147266cd91610b4337 |
| September 22, 2019 14:23 | https://github.com/nodejs/node/pull/29653#event-2652697581 |
|
| https://github.com/ronag |
| fixup: writable | https://github.com/nodejs/node/pull/29653/commits/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| 25c4396 | https://github.com/nodejs/node/pull/29653/commits/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/ee486d4668289cfa7415fc147266cd91610b4337..25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| ee486d4 | https://github.com/nodejs/node/commit/ee486d4668289cfa7415fc147266cd91610b4337 |
| 25c4396 | https://github.com/nodejs/node/commit/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
|
Compare
| https://github.com/nodejs/node/compare/ee486d4668289cfa7415fc147266cd91610b4337..25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| September 22, 2019 14:47 | https://github.com/nodejs/node/pull/29653#event-2652710243 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 22, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-291524193 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/29653#issuecomment-533913246 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3921/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3921/ |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Sep 22, 2019
| https://github.com/nodejs/node/pull/29653#ref-issue-494257923 |
|
Dealing with async errors during _read()
#29584
| https://github.com/nodejs/node/issues/29584 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-291967635 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29653#ref-commit-bd6a3d1 |
|
| https://github.com/Fishrock123 |
| fixup: always use destroy(err) instead of emit | https://github.com/Fishrock123/bob/commit/bd6a3d12024648d6bafd82771d561300b063f9c6 |
| bd6a3d1 | https://github.com/Fishrock123/bob/commit/bd6a3d12024648d6bafd82771d561300b063f9c6 |
| nodejs/node#29653 | https://github.com/nodejs/node/pull/29653 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-291975026 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/29653#pullrequestreview-291975026 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/billouboq |
| billouboq | https://github.com/billouboq |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-292711268 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-292724098 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
|
| https://github.com/ronag |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/2dca3cb1aaf253251cea51ed9a860e7d14abda70 |
| 2dca3cb | https://github.com/nodejs/node/pull/29653/commits/2dca3cb1aaf253251cea51ed9a860e7d14abda70 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293191880 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/2dca3cb1aaf253251cea51ed9a860e7d14abda70 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/2dca3cb1aaf253251cea51ed9a860e7d14abda70#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293192309 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/2dca3cb1aaf253251cea51ed9a860e7d14abda70 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/2dca3cb1aaf253251cea51ed9a860e7d14abda70#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| ronag | https://github.com/ronag |
| September 25, 2019 18:11 | https://github.com/nodejs/node/pull/29653#commits-pushed-09b2f98 |
|
| https://github.com/ronag |
|
| https://github.com/jasnell |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/09b2f983ca0ff03a177bdd9c8514654616b32033 |
| 09b2f98 | https://github.com/nodejs/node/pull/29653/commits/09b2f983ca0ff03a177bdd9c8514654616b32033 |
|
| https://github.com/ronag |
|
| https://github.com/jasnell |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| c02435b | https://github.com/nodejs/node/pull/29653/commits/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293253139 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293253463 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293253774 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293253907 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca |
| doc/api/stream.md | https://github.com/nodejs/node/pull/29653/files/c02435bfc17a689c61f0d65eadcbf7cc9c945aca#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| ronag | https://github.com/ronag |
| September 25, 2019 20:08 | https://github.com/nodejs/node/pull/29653#commits-pushed-63ec522 |
|
| https://github.com/ronag |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/63ec522098f4a562f72840c46dc24c0435012111 |
| 63ec522 | https://github.com/nodejs/node/pull/29653/commits/63ec522098f4a562f72840c46dc24c0435012111 |
|
| https://github.com/ronag |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/de8dc2d8116b7162a1f406647473d3cba631bb90 |
| de8dc2d | https://github.com/nodejs/node/pull/29653/commits/de8dc2d8116b7162a1f406647473d3cba631bb90 |
| ronag | https://github.com/ronag |
| September 25, 2019 20:09 | https://github.com/nodejs/node/pull/29653#commits-pushed-25cf976 |
|
| https://github.com/ronag |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/25cf9765f351de2c358a9cd229978dbcd07b34ba |
| 25cf976 | https://github.com/nodejs/node/pull/29653/commits/25cf9765f351de2c358a9cd229978dbcd07b34ba |
|
| https://github.com/ronag |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/29653/commits/e1d6651993b300b27e22b3c954f542969cdb64cc |
| e1d6651 | https://github.com/nodejs/node/pull/29653/commits/e1d6651993b300b27e22b3c954f542969cdb64cc |
|
| https://github.com/ronag |
| fixup: ascii order | https://github.com/nodejs/node/pull/29653/commits/e7709c10135c95d3fed485736a80b2ac02f1ee93 |
| e7709c1 | https://github.com/nodejs/node/pull/29653/commits/e7709c10135c95d3fed485736a80b2ac02f1ee93 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-293272215 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/e7709c10135c95d3fed485736a80b2ac02f1ee93 |
| test.js | https://github.com/nodejs/node/pull/29653/files/e7709c10135c95d3fed485736a80b2ac02f1ee93#diff-13876b4beb64b9f156474dc78f9c923952a7ca210d4507b6b3135bbe244f8a60 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
|
| https://github.com/ronag |
| fixup: accidental file | https://github.com/nodejs/node/pull/29653/commits/08c318650fe404a1555b5788336b625888050325 |
| 08c3186 | https://github.com/nodejs/node/pull/29653/commits/08c318650fe404a1555b5788336b625888050325 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29653#pullrequestreview-294398148 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29653/files/08c318650fe404a1555b5788336b625888050325 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/29653#pullrequestreview-294398148 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29653#issuecomment-536116350 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3939/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3939/ |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| Trott | https://github.com/Trott |
|
Sep 27, 2019
| https://github.com/nodejs/node/pull/29653#ref-commit-7223ce2 |
|
| https://github.com/ronag |
|
| https://github.com/Trott |
| doc: clarify stream errors while reading and writing | https://github.com/nodejs/node/commit/7223ce2a9c0fe250e199327ece14d2fcaea34bb1 |
|
| https://github.com/nodejs/node/commit/7223ce2a9c0fe250e199327ece14d2fcaea34bb1#comments |
| 7223ce2 | https://github.com/nodejs/node/commit/7223ce2a9c0fe250e199327ece14d2fcaea34bb1 |
| #29653 | https://github.com/nodejs/node/pull/29653 |
| #29584 | https://github.com/nodejs/node/issues/29584 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29653#issuecomment-536116973 |
| 7223ce2 | https://github.com/nodejs/node/commit/7223ce2a9c0fe250e199327ece14d2fcaea34bb1 |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2019 | https://github.com/nodejs/node/pull/29653#event-2670067287 |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29653#ref-commit-d258e02 |
|
| https://github.com/ronag |
|
| https://github.com/targos |
| doc: clarify stream errors while reading and writing | https://github.com/nodejs/node/commit/d258e0242cf5f735b1c338bd45be687fc4ea0328 |
| d258e02 | https://github.com/nodejs/node/commit/d258e0242cf5f735b1c338bd45be687fc4ea0328 |
| #29653 | https://github.com/nodejs/node/pull/29653 |
| #29584 | https://github.com/nodejs/node/issues/29584 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29653#ref-pullrequest-500881212 |
|
v12.11.1 release proposal
#29796
| https://github.com/nodejs/node/pull/29796 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29653#ref-issue-501061281 |
|
2019-10-01 Version 12.11.1 (Current) @targos
beevelop/docker-nodejs#304
| https://github.com/beevelop/docker-nodejs/issues/304 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29653 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29653/files/2dca3cb1aaf253251cea51ed9a860e7d14abda70 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/29653/files/08c318650fe404a1555b5788336b625888050325 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
|
| https://github.com/billouboq |
|
billouboq
| https://github.com/billouboq |
|
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/29653/files/e7709c10135c95d3fed485736a80b2ac02f1ee93 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/29653/files/25c4396be0a4278989b3c5c9f3ff959cb509bab4 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/29653 |
|
| https://github.com/ronag |
|
| https://github.com/trivikr |
|
| https://github.com/Trott |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/Fishrock123 |
|
| https://github.com/lpinca |
|
| https://github.com/billouboq |
|
| https://github.com/BridgeAR |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |