René's URL Explorer Experiment


Title: tls: honor pauseOnConnect option by r1b · Pull Request #29635 · nodejs/node · GitHub

Open Graph Title: tls: honor pauseOnConnect option by r1b · Pull Request #29635 · nodejs/node

X Title: tls: honor pauseOnConnect option by r1b · Pull Request #29635 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: pauseOnConnect is now passed along to the net.Socket constructor from the tls.Socket constructor. The readable flag must match the value of pauseOnConnect. Tests were added to cover all available n...

X Description: pauseOnConnect is now passed along to the net.Socket constructor from the tls.Socket constructor. The readable flag must match the value of pauseOnConnect. Tests were added to cover all available n...

Opengraph URL: https://github.com/nodejs/node/pull/29635

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6c4b8d5c-2e9e-adf1-f30d-90d1f7cd2e4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8266:2F8072:2381D4C:30996B7:6A4ECAEE
html-safe-nonce9a3649f7c072ee611055d0fb2cce372f6cf7a809a90587124d30ffcdb0a62ab8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjY2OjJGODA3MjoyMzgxRDRDOjMwOTk2Qjc6NkE0RUNBRUUiLCJ2aXNpdG9yX2lkIjoiMjk2ODQ0MDUxMzUzNzk1MjQ5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f2f842f6834ed4f5addf403e3bc2d47dc41571729e907770355ba94c332bbfe
hovercard-subject-tagpull_request:319831048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5f3534d3aeb1c29b013e96583c4fa1078edeb2a14365a3ec23c8ad9cd6659e35/nodejs/node/pull/29635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f3534d3aeb1c29b013e96583c4fa1078edeb2a14365a3ec23c8ad9cd6659e35/nodejs/node/pull/29635
og:image:altpauseOnConnect is now passed along to the net.Socket constructor from the tls.Socket constructor. The readable flag must match the value of pauseOnConnect. Tests were added to cover all available n...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamer1b
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29635#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29635
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29635
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29635
Reloadhttps://github.com/nodejs/node/pull/29635
Reloadhttps://github.com/nodejs/node/pull/29635
Please reload this pagehttps://github.com/nodejs/node/pull/29635
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29635
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
r1bhttps://github.com/r1b
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/29635
Commits3 (3)https://github.com/nodejs/node/pull/29635/commits
Checkshttps://github.com/nodejs/node/pull/29635/checks
Files changedhttps://github.com/nodejs/node/pull/29635/files
tls: honor pauseOnConnect optionhttps://github.com/nodejs/node/pull/29635#top
r1bhttps://github.com/r1b
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/r1b
r1bhttps://github.com/r1b
Sep 20, 2019https://github.com/nodejs/node/pull/29635#issue-496486269
#29620https://github.com/nodejs/node/issues/29620
#27665https://github.com/nodejs/node/pull/27665
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Sep 20, 2019https://github.com/nodejs/node/pull/29635#event-2651156831
https://github.com/r1b
r1bhttps://github.com/r1b
Sep 20, 2019 https://github.com/nodejs/node/pull/29635#pullrequestreview-291325258
View reviewed changes https://github.com/nodejs/node/pull/29635/files
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/29635/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/r1b
r1bhttps://github.com/r1b
Sep 20, 2019 https://github.com/nodejs/node/pull/29635#pullrequestreview-291325514
View reviewed changes https://github.com/nodejs/node/pull/29635/files
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/29635/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/r1b
tls: honor pauseOnConnect optionhttps://github.com/nodejs/node/pull/29635/commits/ac50259ccb2005bb135d9ed82f17188fc5a5732b
ac50259https://github.com/nodejs/node/pull/29635/commits/ac50259ccb2005bb135d9ed82f17188fc5a5732b
#29620https://github.com/nodejs/node/issues/29620
#27665https://github.com/nodejs/node/pull/27665
https://github.com/r1b
r1bhttps://github.com/r1b
lpincahttps://github.com/lpinca
mscdexhttps://github.com/mscdex
September 20, 2019 22:31https://github.com/nodejs/node/pull/29635#event-2651687187
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 21, 2019https://github.com/nodejs/node/pull/29635#issuecomment-533824117
https://ci.nodejs.org/job/node-test-pull-request/25622/https://ci.nodejs.org/job/node-test-pull-request/25622/
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 21, 2019 https://github.com/nodejs/node/pull/29635#pullrequestreview-291478287
View reviewed changes https://github.com/nodejs/node/pull/29635/files/ac50259ccb2005bb135d9ed82f17188fc5a5732b
lpincahttps://github.com/lpinca
https://github.com/nodejs/node/pull/29635#pullrequestreview-291478287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 24, 2019 https://github.com/nodejs/node/pull/29635#pullrequestreview-292189104
View reviewed changes https://github.com/nodejs/node/pull/29635/files/ac50259ccb2005bb135d9ed82f17188fc5a5732b
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 24, 2019https://github.com/nodejs/node/pull/29635#event-2656757464
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/29635#pullrequestreview-292189104
September 24, 2019 06:03https://github.com/nodejs/node/pull/29635#event-2656767428
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 25, 2019https://github.com/nodejs/node/pull/29635#issuecomment-534854582
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 25, 2019https://github.com/nodejs/node/pull/29635#issuecomment-535100340
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/r1b
https://github.com/Trott
Update lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/29635/commits/3b0c4639c74e177a16d89ff417e2bce909d96472
3b0c463https://github.com/nodejs/node/pull/29635/commits/3b0c4639c74e177a16d89ff417e2bce909d96472
https://github.com/r1b
r1bhttps://github.com/r1b
Sep 25, 2019https://github.com/nodejs/node/pull/29635#issuecomment-535226887
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/r1b
fix linthttps://github.com/nodejs/node/pull/29635/commits/98eacc4b69ea9b086cc2f2f352cdc277ad9f5f10
98eacc4https://github.com/nodejs/node/pull/29635/commits/98eacc4b69ea9b086cc2f2f352cdc277ad9f5f10
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2019https://github.com/nodejs/node/pull/29635#issuecomment-536128123
https://ci.nodejs.org/job/node-test-pull-request/25745/https://ci.nodejs.org/job/node-test-pull-request/25745/
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2019https://github.com/nodejs/node/pull/29635#issuecomment-536234239
https://ci.nodejs.org/job/node-test-pull-request/25758/https://ci.nodejs.org/job/node-test-pull-request/25758/
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Sep 30, 2019https://github.com/nodejs/node/pull/29635#event-2673728951
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 2, 2019https://github.com/nodejs/node/pull/29635#issuecomment-537724566
https://ci.nodejs.org/job/node-test-pull-request/25826/https://ci.nodejs.org/job/node-test-pull-request/25826/
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 3, 2019https://github.com/nodejs/node/pull/29635#issuecomment-537764181
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://ci.nodejs.org/job/node-test-pull-request/25828/https://ci.nodejs.org/job/node-test-pull-request/25828/
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 4, 2019https://github.com/nodejs/node/pull/29635#issuecomment-538210835
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 4, 2019https://github.com/nodejs/node/pull/29635#event-2686052114
Trotthttps://github.com/Trott
Oct 4, 2019 https://github.com/nodejs/node/pull/29635#ref-commit-1e12859
https://github.com/r1b
https://github.com/Trott
tls: honor pauseOnConnect optionhttps://github.com/nodejs/node/commit/1e1285926f35558f8ad1dad5fad2040ce576f46e
1e12859https://github.com/nodejs/node/commit/1e1285926f35558f8ad1dad5fad2040ce576f46e
#29620https://github.com/nodejs/node/issues/29620
#27665https://github.com/nodejs/node/pull/27665
#29635https://github.com/nodejs/node/pull/29635
BridgeARhttps://github.com/BridgeAR
Oct 9, 2019 https://github.com/nodejs/node/pull/29635#ref-commit-a7b56a5
https://github.com/r1b
https://github.com/BridgeAR
tls: honor pauseOnConnect optionhttps://github.com/nodejs/node/commit/a7b56a5b017834c87e4335f4d67192d063603be6
a7b56a5https://github.com/nodejs/node/commit/a7b56a5b017834c87e4335f4d67192d063603be6
#29620https://github.com/nodejs/node/issues/29620
#27665https://github.com/nodejs/node/pull/27665
#29635https://github.com/nodejs/node/pull/29635
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 10, 2019 https://github.com/nodejs/node/pull/29635#ref-pullrequest-505244335
v12.12.0 proposal #29919 https://github.com/nodejs/node/pull/29919
BridgeARhttps://github.com/BridgeAR
Oct 10, 2019 https://github.com/nodejs/node/pull/29635#ref-commit-75baa7e
https://github.com/BridgeAR
2019-10-10, Version 12.12.0 (Current)https://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96
75baa7ehttps://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96
#29631https://github.com/nodejs/node/pull/29631
#29781https://github.com/nodejs/node/pull/29781
#29754https://github.com/nodejs/node/pull/29754
#29349https://github.com/nodejs/node/pull/29349
#29564https://github.com/nodejs/node/pull/29564
#29635https://github.com/nodejs/node/pull/29635
#28973https://github.com/nodejs/node/pull/28973
#29919https://github.com/nodejs/node/pull/29919
BridgeARhttps://github.com/BridgeAR
Oct 11, 2019 https://github.com/nodejs/node/pull/29635#ref-commit-921493e
https://github.com/BridgeAR
2019-10-11, Version 12.12.0 (Current)https://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd
921493ehttps://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd
#29631https://github.com/nodejs/node/pull/29631
#29781https://github.com/nodejs/node/pull/29781
#29754https://github.com/nodejs/node/pull/29754
#29349https://github.com/nodejs/node/pull/29349
#29564https://github.com/nodejs/node/pull/29564
#29635https://github.com/nodejs/node/pull/29635
#28973https://github.com/nodejs/node/pull/28973
#29919https://github.com/nodejs/node/pull/29919
BridgeARhttps://github.com/BridgeAR
Oct 11, 2019 https://github.com/nodejs/node/pull/29635#ref-commit-06f6d66
https://github.com/BridgeAR
2019-10-11, Version 12.12.0 (Current)https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141
06f6d66https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141
#29631https://github.com/nodejs/node/pull/29631
#29781https://github.com/nodejs/node/pull/29781
#29754https://github.com/nodejs/node/pull/29754
#29349https://github.com/nodejs/node/pull/29349
#29564https://github.com/nodejs/node/pull/29564
#29635https://github.com/nodejs/node/pull/29635
#28973https://github.com/nodejs/node/pull/28973
#29919https://github.com/nodejs/node/pull/29919
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29635
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29635/files/ac50259ccb2005bb135d9ed82f17188fc5a5732b
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29635/files/ac50259ccb2005bb135d9ed82f17188fc5a5732b
https://github.com/mscdex
mscdex https://github.com/mscdex
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
tls: pauseOnConnect option not honored https://github.com/nodejs/node/issues/29620
Please reload this pagehttps://github.com/nodejs/node/pull/29635
https://github.com/r1b
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/mscdex
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.