| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bc5baf7f-e3ed-0228-1e2e-e12bb84a3e78 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B436:47EDE:DA3487:1338FD9:6A4F5193 |
| html-safe-nonce | 5533a7a9c6fb09a5aad7f40140c81c4baaba659cbfac3bfd2bb750dcc934e8c0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDM2OjQ3RURFOkRBMzQ4NzoxMzM4RkQ5OjZBNEY1MTkzIiwidmlzaXRvcl9pZCI6IjM3MTE3Nzg5NzMxMzIyMTQ2NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e3a4218ab005457b1bbbb7f95345b5297570757db11caae17a0851a46b212696 |
| hovercard-subject-tag | pull_request:319794443 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29631/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4f5dad93c5baf82eaba6eea681140428ee82be88bd31917b19f9dd03bb7233e8/nodejs/node/pull/29631 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4f5dad93c5baf82eaba6eea681140428ee82be88bd31917b19f9dd03bb7233e8/nodejs/node/pull/29631 |
| og:image:alt | This PR adds a new cli flag --force-context-aware whose purpose is to prevent usage of native node addons that aren't context aware. In an embedder context, loading native addons ahas always be... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | codebytere |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29631#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29631 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29631 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29631 |
| Reload | https://github.com/nodejs/node/pull/29631 |
| Reload | https://github.com/nodejs/node/pull/29631 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:warn-prevent-context-aware | https://github.com/codebytere/node/tree/warn-prevent-context-aware |
| Conversation | https://github.com/nodejs/node/pull/29631 |
| Commits2 (2) | https://github.com/nodejs/node/pull/29631/commits |
| Checks | https://github.com/nodejs/node/pull/29631/checks |
| Files changed | https://github.com/nodejs/node/pull/29631/files |
| src: add buildflag to force context-aware addons | https://github.com/nodejs/node/pull/29631#top |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:warn-prevent-context-aware | https://github.com/codebytere/node/tree/warn-prevent-context-aware |
|
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29631#issue-496441409 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| #18397 | https://github.com/electron/electron/issues/18397 |
| @MarshallOfSound | https://github.com/MarshallOfSound |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29631#event-2650869380 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/aaa73dbd6e5088bef30d178b5f0d11818b6fb10d..469bdbe5115f13794c36a4ab034aff34b29ca800 |
| aaa73db | https://github.com/nodejs/node/commit/aaa73dbd6e5088bef30d178b5f0d11818b6fb10d |
| 469bdbe | https://github.com/nodejs/node/commit/469bdbe5115f13794c36a4ab034aff34b29ca800 |
|
Compare
| https://github.com/nodejs/node/compare/aaa73dbd6e5088bef30d178b5f0d11818b6fb10d..469bdbe5115f13794c36a4ab034aff34b29ca800 |
| September 20, 2019 16:31 | https://github.com/nodejs/node/pull/29631#event-2650883800 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291285859 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| doc/api/cli.md | https://github.com/nodejs/node/pull/29631/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/469bdbe5115f13794c36a4ab034aff34b29ca800..23733d34f9b184b9b5851b8fdf06818452c56ca5 |
| 469bdbe | https://github.com/nodejs/node/commit/469bdbe5115f13794c36a4ab034aff34b29ca800 |
| 23733d3 | https://github.com/nodejs/node/commit/23733d34f9b184b9b5851b8fdf06818452c56ca5 |
|
Compare
| https://github.com/nodejs/node/compare/469bdbe5115f13794c36a4ab034aff34b29ca800..23733d34f9b184b9b5851b8fdf06818452c56ca5 |
| September 20, 2019 17:06 | https://github.com/nodejs/node/pull/29631#event-2650972613 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291315484 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291315484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| src/env.cc | https://github.com/nodejs/node/pull/29631/files#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| src/node_binding.cc | https://github.com/nodejs/node/pull/29631/files#diff-cea6643957d66774731d8224242d6e052f3da9198fbb1fa5afb7e91b896b4cc0 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| src/node_options.cc | https://github.com/nodejs/node/pull/29631/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29631#event-2651121716 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/23733d34f9b184b9b5851b8fdf06818452c56ca5..4d315c337e19cc07aab10cecbdda491d49d5e10c |
| 23733d3 | https://github.com/nodejs/node/commit/23733d34f9b184b9b5851b8fdf06818452c56ca5 |
| 4d315c3 | https://github.com/nodejs/node/commit/4d315c337e19cc07aab10cecbdda491d49d5e10c |
|
Compare
| https://github.com/nodejs/node/compare/23733d34f9b184b9b5851b8fdf06818452c56ca5..4d315c337e19cc07aab10cecbdda491d49d5e10c |
| September 20, 2019 23:42 | https://github.com/nodejs/node/pull/29631#event-2651771428 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-533745454 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291435801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| doc/api/errors.md | https://github.com/nodejs/node/pull/29631/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| src/node_binding.cc | https://github.com/nodejs/node/pull/29631/files#diff-cea6643957d66774731d8224242d6e052f3da9198fbb1fa5afb7e91b896b4cc0 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/6c5909fd0f907d5c06edebee82d9341ab1e49502..93d2420c4145b438d84940c23bbe06bfea10c0c4 |
| 6c5909f | https://github.com/nodejs/node/commit/6c5909fd0f907d5c06edebee82d9341ab1e49502 |
| 93d2420 | https://github.com/nodejs/node/commit/93d2420c4145b438d84940c23bbe06bfea10c0c4 |
|
Compare
| https://github.com/nodejs/node/compare/6c5909fd0f907d5c06edebee82d9341ab1e49502..93d2420c4145b438d84940c23bbe06bfea10c0c4 |
| September 21, 2019 04:02 | https://github.com/nodejs/node/pull/29631#event-2651908585 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Sep 21, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-533765395 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/93d2420c4145b438d84940c23bbe06bfea10c0c4..93dc64758f6c42a903acc0390bcd218a9e094698 |
| 93d2420 | https://github.com/nodejs/node/commit/93d2420c4145b438d84940c23bbe06bfea10c0c4 |
| 93dc647 | https://github.com/nodejs/node/commit/93dc64758f6c42a903acc0390bcd218a9e094698 |
|
Compare
| https://github.com/nodejs/node/compare/93d2420c4145b438d84940c23bbe06bfea10c0c4..93dc64758f6c42a903acc0390bcd218a9e094698 |
| September 21, 2019 04:04 | https://github.com/nodejs/node/pull/29631#event-2651909472 |
|
| https://github.com/codebytere |
| src: add buildflag to force context-aware addons | https://github.com/nodejs/node/pull/29631/commits/119d31f8c469a5191092d9d8c64b41d2b4af2669 |
| 119d31f | https://github.com/nodejs/node/pull/29631/commits/119d31f8c469a5191092d9d8c64b41d2b4af2669 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/3ac2c4a70d1b0aab23d72731011874dcff781894..c5efc2acc696a43584bffdc770cc0bf2e259ef85 |
| 3ac2c4a | https://github.com/nodejs/node/commit/3ac2c4a70d1b0aab23d72731011874dcff781894 |
| c5efc2a | https://github.com/nodejs/node/commit/c5efc2acc696a43584bffdc770cc0bf2e259ef85 |
|
Compare
| https://github.com/nodejs/node/compare/3ac2c4a70d1b0aab23d72731011874dcff781894..c5efc2acc696a43584bffdc770cc0bf2e259ef85 |
| September 21, 2019 05:01 | https://github.com/nodejs/node/pull/29631#event-2651927544 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 21, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291462631 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291462631 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 21, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-533792224 |
| https://ci.nodejs.org/job/node-test-pull-request/25619/ | https://ci.nodejs.org/job/node-test-pull-request/25619/ |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291805902 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/29631#pullrequestreview-291805902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| doc/api/cli.md | https://github.com/nodejs/node/pull/29631/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| test/addons/force-context-aware/binding.cc | https://github.com/nodejs/node/pull/29631/files#diff-fc51b3a81758036ed1244523a0d0ed3854bb6e063b21cd3d43b11ce218c402e6 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| test/addons/force-context-aware/test.js | https://github.com/nodejs/node/pull/29631/files#diff-18ac873a080dce65538f6391d16672f8af928dd883abb48c4b356dc0dd237d6d |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/c5efc2acc696a43584bffdc770cc0bf2e259ef85..094d8886584f39675f90a8a8c2c219d5e0b40937 |
| c5efc2a | https://github.com/nodejs/node/commit/c5efc2acc696a43584bffdc770cc0bf2e259ef85 |
| 094d888 | https://github.com/nodejs/node/commit/094d8886584f39675f90a8a8c2c219d5e0b40937 |
|
Compare
| https://github.com/nodejs/node/compare/c5efc2acc696a43584bffdc770cc0bf2e259ef85..094d8886584f39675f90a8a8c2c219d5e0b40937 |
| September 23, 2019 16:21 | https://github.com/nodejs/node/pull/29631#event-2655082205 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29631#event-2656772308 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-534404138 |
| https://ci.nodejs.org/job/node-test-pull-request/25669/ | https://ci.nodejs.org/job/node-test-pull-request/25669/ |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-292243297 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files |
| test/addons/force-context-aware/binding.cc | https://github.com/nodejs/node/pull/29631/files#diff-fc51b3a81758036ed1244523a0d0ed3854bb6e063b21cd3d43b11ce218c402e6 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
|
| https://github.com/codebytere |
| test: --force-context-aware cli flag | https://github.com/nodejs/node/pull/29631/commits/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| bcef054 | https://github.com/nodejs/node/pull/29631/commits/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/094d8886584f39675f90a8a8c2c219d5e0b40937..bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| 094d888 | https://github.com/nodejs/node/commit/094d8886584f39675f90a8a8c2c219d5e0b40937 |
| bcef054 | https://github.com/nodejs/node/commit/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
|
Compare
| https://github.com/nodejs/node/compare/094d8886584f39675f90a8a8c2c219d5e0b40937..bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| September 24, 2019 10:59 | https://github.com/nodejs/node/pull/29631#event-2657605972 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-292583743 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-534841335 |
| https://ci.nodejs.org/job/node-test-pull-request/25690/ | https://ci.nodejs.org/job/node-test-pull-request/25690/ |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-534854849 |
| https://ci.nodejs.org/job/node-test-pull-request/25691/ | https://ci.nodejs.org/job/node-test-pull-request/25691/ |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-534854970 |
| https://ci.nodejs.org/job/node-test-pull-request/25692/ | https://ci.nodejs.org/job/node-test-pull-request/25692/ |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| Trott | https://github.com/Trott |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-3c17f16 |
|
| https://github.com/codebytere |
|
| https://github.com/Trott |
| src: add buildflag to force context-aware addons | https://github.com/nodejs/node/commit/3c17f160e39d96d6e29b3e379bdf20169bacd75f |
| 3c17f16 | https://github.com/nodejs/node/commit/3c17f160e39d96d6e29b3e379bdf20169bacd75f |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| Trott | https://github.com/Trott |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-f120e6d |
|
| https://github.com/codebytere |
|
| https://github.com/Trott |
| test: --force-context-aware cli flag | https://github.com/nodejs/node/commit/f120e6d8177f1a982045bdc7df961a1926f3f8c1 |
| f120e6d | https://github.com/nodejs/node/commit/f120e6d8177f1a982045bdc7df961a1926f3f8c1 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#issuecomment-534864533 |
| 5058c7f...f120e6d | https://github.com/nodejs/node/compare/5058c7f13838801cdc1155227f9aa7267507b49a...f120e6d8177f1a982045bdc7df961a1926f3f8c1 |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#event-2660370419 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| September 25, 2019 10:46 | https://github.com/nodejs/node/pull/29631#event-2661199403 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-293206271 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| jasnell | https://github.com/jasnell |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#discussion_r328219818 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29631#pullrequestreview-293207590 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
| src/node_options.cc | https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| jasnell | https://github.com/jasnell |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29631#discussion_r328220805 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-6bfe8f4 |
|
| https://github.com/codebytere |
|
| https://github.com/BridgeAR |
| src: add buildflag to force context-aware addons | https://github.com/nodejs/node/commit/6bfe8f47fa70c113aea024452d6af840d960a127 |
| 6bfe8f4 | https://github.com/nodejs/node/commit/6bfe8f47fa70c113aea024452d6af840d960a127 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-54ef0fd |
|
| https://github.com/codebytere |
|
| https://github.com/BridgeAR |
| test: --force-context-aware cli flag | https://github.com/nodejs/node/commit/54ef0fd0106b4eb509c699637d8be86a7a40008f |
| 54ef0fd | https://github.com/nodejs/node/commit/54ef0fd0106b4eb509c699637d8be86a7a40008f |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29631#ref-pullrequest-505244335 |
|
v12.12.0 proposal
#29919
| https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-75baa7e |
|
| https://github.com/BridgeAR |
| 2019-10-10, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96 |
| 75baa7e | https://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-921493e |
|
| https://github.com/BridgeAR |
| 2019-10-11, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd |
| 921493e | https://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-06f6d66 |
|
| https://github.com/BridgeAR |
| 2019-10-11, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141 |
| 06f6d66 | https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| dhritzkiv | https://github.com/dhritzkiv |
|
Dec 31, 2019
| https://github.com/nodejs/node/pull/29631#ref-commit-d6cc49a |
|
| https://github.com/dhritzkiv |
| Make gl context aware | https://github.com/stackgl/headless-gl/commit/d6cc49a1cac71a1c59b5abb48528e19f7ba4e126 |
| d6cc49a | https://github.com/stackgl/headless-gl/commit/d6cc49a1cac71a1c59b5abb48528e19f7ba4e126 |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| electron/electron#18397 | https://github.com/electron/electron/issues/18397 |
| dhritzkiv | https://github.com/dhritzkiv |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/29631#ref-commit-b2a9cee |
|
| https://github.com/dhritzkiv |
| Make gl context aware | https://github.com/stackgl/headless-gl/commit/b2a9cee6f1d68b6009cefcfad26ec617e00d1d48 |
| b2a9cee | https://github.com/stackgl/headless-gl/commit/b2a9cee6f1d68b6009cefcfad26ec617e00d1d48 |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| electron/electron#18397 | https://github.com/electron/electron/issues/18397 |
| https://github.com/dhritzkiv |
| dhritzkiv | https://github.com/dhritzkiv |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/29631#ref-pullrequest-546114301 |
|
Make headless-gl context aware
stackgl/headless-gl#182
| https://github.com/stackgl/headless-gl/pull/182 |
| codebytere | https://github.com/codebytere |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/29631#ref-commit-371fddd |
|
| https://github.com/codebytere |
| Update warn/force context-aware patch | https://github.com/electron/electron/commit/371fddd6cda91704b0d958c0414aa850bd2b2ebb |
| 371fddd | https://github.com/electron/electron/commit/371fddd6cda91704b0d958c0414aa850bd2b2ebb |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| codebytere | https://github.com/codebytere |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/29631#ref-commit-2b841ad |
|
| https://github.com/codebytere |
| Update warn/force context-aware patch | https://github.com/electron/electron/commit/2b841ada336f4197dac772a27a68c2221c7b4178 |
| 2b841ad | https://github.com/electron/electron/commit/2b841ada336f4197dac772a27a68c2221c7b4178 |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| codebytere | https://github.com/codebytere |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/29631#ref-commit-9d2414d |
|
| https://github.com/codebytere |
| Update warn/force context-aware patch | https://github.com/electron/electron/commit/9d2414d0d3df4ea8ec1e2cc5406afd816dc2f2dd |
| 9d2414d | https://github.com/electron/electron/commit/9d2414d0d3df4ea8ec1e2cc5406afd816dc2f2dd |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| codebytere | https://github.com/codebytere |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/29631#ref-commit-df0d826 |
|
| https://github.com/codebytere |
| Update warn/force context-aware patch | https://github.com/electron/electron/commit/df0d8264b3fe32a926240e7116ad17287c86ef92 |
| df0d826 | https://github.com/electron/electron/commit/df0d8264b3fe32a926240e7116ad17287c86ef92 |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| jacobthesumurai | https://github.com/jacobthesumurai |
|
Jul 9, 2021
| https://github.com/nodejs/node/pull/29631#ref-commit-dd2119a |
|
| https://github.com/dhritzkiv |
| Make gl context aware | https://github.com/noblesamurai/headless-gl/commit/dd2119a6aad130d657ac4407bb887019947282d3 |
| dd2119a | https://github.com/noblesamurai/headless-gl/commit/dd2119a6aad130d657ac4407bb887019947282d3 |
| nodejs/node#29631 | https://github.com/nodejs/node/pull/29631 |
| electron/electron#18397 | https://github.com/electron/electron/issues/18397 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29631 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29631/files/469bdbe5115f13794c36a4ab034aff34b29ca800 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29631/files/bcef0546d0f43bdd83fff46248c076de2e709ec0 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29631/files/c5efc2acc696a43584bffdc770cc0bf2e259ef85 |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/29631 |
|
| https://github.com/codebytere |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |