René's URL Explorer Experiment


Title: [v8.x] backport HTTP/2 security release fixups by addaleax · Pull Request #29618 · nodejs/node · GitHub

Open Graph Title: [v8.x] backport HTTP/2 security release fixups by addaleax · Pull Request #29618 · nodejs/node

X Title: [v8.x] backport HTTP/2 security release fixups by addaleax · Pull Request #29618 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Backports of #29399 and #29459. These solve issues introduced in #29122. There was only one minor conflict (static method vs instance method for a C++ class).

X Description: Backports of #29399 and #29459. These solve issues introduced in #29122. There was only one minor conflict (static method vs instance method for a C++ class).

Opengraph URL: https://github.com/nodejs/node/pull/29618

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02d29f85-1ccf-5e89-c3e0-4d6d615eb406
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB99E:50FD4:58B88C3:7CDCEA0:6A4FB39D
html-safe-noncea15281ad1fe502e6dfd56629375035c7329714665b6f8604e2bbbd95a54fd0f3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTlFOjUwRkQ0OjU4Qjg4QzM6N0NEQ0VBMDo2QTRGQjM5RCIsInZpc2l0b3JfaWQiOiIyMjY5MTk0NzA3ODk1NTYzMTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac52be46ae1ddd9ee44867e35ca21b0340db89f6ff50407855f45fd2e34371235c
hovercard-subject-tagpull_request:319475685
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29618/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e9972da85b9b3322c869d3016e5ab3f9be1abc0c4758fd00790ca0a9c714741a/nodejs/node/pull/29618
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e9972da85b9b3322c869d3016e5ab3f9be1abc0c4758fd00790ca0a9c714741a/nodejs/node/pull/29618
og:image:altBackports of #29399 and #29459. These solve issues introduced in #29122. There was only one minor conflict (static method vs instance method for a C++ class).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29618#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29618
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29618
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29618
Reloadhttps://github.com/nodejs/node/pull/29618
Reloadhttps://github.com/nodejs/node/pull/29618
Please reload this pagehttps://github.com/nodejs/node/pull/29618
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29618
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
addaleax:v8.x-h2-fixupshttps://github.com/addaleax/node/tree/v8.x-h2-fixups
Conversationhttps://github.com/nodejs/node/pull/29618
Commits2 (2)https://github.com/nodejs/node/pull/29618/commits
Checkshttps://github.com/nodejs/node/pull/29618/checks
Files changedhttps://github.com/nodejs/node/pull/29618/files
[v8.x] backport HTTP/2 security release fixupshttps://github.com/nodejs/node/pull/29618#top
addaleaxhttps://github.com/addaleax
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
addaleax:v8.x-h2-fixupshttps://github.com/addaleax/node/tree/v8.x-h2-fixups
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 19, 2019https://github.com/nodejs/node/pull/29618#issue-496042327
#29399https://github.com/nodejs/node/pull/29399
#29459https://github.com/nodejs/node/pull/29459
#29122https://github.com/nodejs/node/pull/29122
Please reload this pagehttps://github.com/nodejs/node/pull/29618
addaleaxhttps://github.com/addaleax
September 19, 2019 22:59https://github.com/nodejs/node/pull/29618#commits-pushed-8f05a30
https://github.com/addaleax
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/pull/29618/commits/8f05a30d9ad7aaf11c0509b7211ec24f0e7aee52
8f05a30https://github.com/nodejs/node/pull/29618/commits/8f05a30d9ad7aaf11c0509b7211ec24f0e7aee52
nodejs#29457https://github.com/nodejs/node/issues/29457
nodejs#29459https://github.com/nodejs/node/pull/29459
https://github.com/addaleax
http2: do not start reading after write if new write is on wirehttps://github.com/nodejs/node/pull/29618/commits/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
fe899a2https://github.com/nodejs/node/pull/29618/commits/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
8a4a193https://github.com/addaleax/node/commit/8a4a1931b8b98242abb590936c31f0c20dd2e08f
nodejs#29353https://github.com/nodejs/node/issues/29353
nodejs#29393https://github.com/nodejs/node/issues/29393
nodejs#29399https://github.com/nodejs/node/pull/29399
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x
Sep 19, 2019https://github.com/nodejs/node/pull/29618#event-2648510589
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 19, 2019 https://github.com/nodejs/node/pull/29618#ref-pullrequest-496020050
v8.16.2 proposal #29617 https://github.com/nodejs/node/pull/29617
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 19, 2019https://github.com/nodejs/node/pull/29618#issuecomment-533321853
https://ci.nodejs.org/job/node-test-pull-request/25588/https://ci.nodejs.org/job/node-test-pull-request/25588/
Please reload this pagehttps://github.com/nodejs/node/pull/29618
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 20, 2019 https://github.com/nodejs/node/pull/29618#pullrequestreview-291059223
View reviewed changes https://github.com/nodejs/node/pull/29618/files/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Sep 20, 2019https://github.com/nodejs/node/pull/29618#event-2650575267
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 21, 2019 https://github.com/nodejs/node/pull/29618#pullrequestreview-291475220
View reviewed changes https://github.com/nodejs/node/pull/29618/files/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
BethGriggshttps://github.com/BethGriggs
Sep 25, 2019 https://github.com/nodejs/node/pull/29618#ref-commit-559a8e3
https://github.com/addaleax
https://github.com/BethGriggs
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/559a8e342b52401889e3c11c03fac129610c646f
559a8e3https://github.com/nodejs/node/commit/559a8e342b52401889e3c11c03fac129610c646f
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
#29618https://github.com/nodejs/node/pull/29618
BethGriggshttps://github.com/BethGriggs
Sep 25, 2019 https://github.com/nodejs/node/pull/29618#ref-commit-e45b6a3
https://github.com/addaleax
https://github.com/BethGriggs
http2: do not start reading after write if new write is on wirehttps://github.com/nodejs/node/commit/e45b6a3b98b95a16cd8e34914e64c40fe51af8e9
e45b6a3https://github.com/nodejs/node/commit/e45b6a3b98b95a16cd8e34914e64c40fe51af8e9
8a4a193https://github.com/nodejs/node/commit/8a4a1931b8b98242abb590936c31f0c20dd2e08f
#29353https://github.com/nodejs/node/issues/29353
#29393https://github.com/nodejs/node/issues/29393
#29399https://github.com/nodejs/node/pull/29399
#29618https://github.com/nodejs/node/pull/29618
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 26, 2019https://github.com/nodejs/node/pull/29618#issuecomment-535632171
Please reload this pagehttps://github.com/nodejs/node/pull/29618
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 26, 2019https://github.com/nodejs/node/pull/29618#event-2666293761
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29618
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/29618/files/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29618/files/fe899a278c98459b57c8acdd8ced0f0c0a0dc4ee
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/29618
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.