| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d6c09be-7251-9026-e47e-e1ba9d8020a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BBB6:16C3D3:4BD39E9:6B9A145:6A4FD22D |
| html-safe-nonce | 596aca320ceb2f97dd718523446e54e33370c8791a111800ca8a1071d96a1a91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkI2OjE2QzNEMzo0QkQzOUU5OjZCOUExNDU6NkE0RkQyMkQiLCJ2aXNpdG9yX2lkIjoiNTgxMDM1OTQ3OTI1NDg5NzE5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2eebc56dfede51ef37219fa716144137b1e327fffbd5dd443775f15e9097929f |
| hovercard-subject-tag | pull_request:317469876 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29550/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fea58af983015d545a53ed63318262f191bbc6427c3a16cde5588741ef73c5d6/nodejs/node/pull/29550 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fea58af983015d545a53ed63318262f191bbc6427c3a16cde5588741ef73c5d6/nodejs/node/pull/29550 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29550#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29550 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29550 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29550 |
| Reload | https://github.com/nodejs/node/pull/29550 |
| Reload | https://github.com/nodejs/node/pull/29550 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:update-openssl1.1.1d | https://github.com/sam-github/node/tree/update-openssl1.1.1d |
| Conversation | https://github.com/nodejs/node/pull/29550 |
| Commits4 (4) | https://github.com/nodejs/node/pull/29550/commits |
| Checks | https://github.com/nodejs/node/pull/29550/checks |
| Files changed | https://github.com/nodejs/node/pull/29550/files |
| Update openssl1.1.1d | https://github.com/nodejs/node/pull/29550#top |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:update-openssl1.1.1d | https://github.com/sam-github/node/tree/update-openssl1.1.1d |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#issue-493501199 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#event-2633461302 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531382871 |
| @mscdex | https://github.com/mscdex |
| @bnoordhuis | https://github.com/bnoordhuis |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| https://github.com/openssl/openssl/blob/2500c093aa1e9c90c11c415053c0a27a00661d0d/crypto/dh/dh_check.c#L143-L154 | https://github.com/openssl/openssl/blob/2500c093aa1e9c90c11c415053c0a27a00661d0d/crypto/dh/dh_check.c#L143-L154 |
| https://github.com/bernd-edlinger/openssl/blob/9087476b536dd13fe99fdd36773234923cea78bb/CHANGES#L12-L16 | https://github.com/bernd-edlinger/openssl/blob/9087476b536dd13fe99fdd36773234923cea78bb/CHANGES#L12-L16 |
| Change DH parameters to generate the order q subgroup instead of 2q openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#issuecomment-529079355 |
| @mscdex | https://github.com/mscdex |
| nodejs/node-v0.x-archive#7086 | https://github.com/nodejs/node-v0.x-archive/pull/7086 |
| nodejs/node-v0.x-archive#2338 | https://github.com/nodejs/node-v0.x-archive/issues/2338 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/29792ed9fceb2d7b954a52148bd101ee483cd344..01fd06da164292e212cc859590d164d5bd839a01 |
| 29792ed | https://github.com/nodejs/node/commit/29792ed9fceb2d7b954a52148bd101ee483cd344 |
| 01fd06d | https://github.com/nodejs/node/commit/01fd06da164292e212cc859590d164d5bd839a01 |
|
Compare
| https://github.com/nodejs/node/compare/29792ed9fceb2d7b954a52148bd101ee483cd344..01fd06da164292e212cc859590d164d5bd839a01 |
| September 13, 2019 20:41 | https://github.com/nodejs/node/pull/29550#event-2633509293 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531384394 |
| https://ci.nodejs.org/job/node-test-pull-request/25480/ | https://ci.nodejs.org/job/node-test-pull-request/25480/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/01fd06da164292e212cc859590d164d5bd839a01..96072053eaf5acc8f0d7a6ebd792fe37c7448d28 |
| 01fd06d | https://github.com/nodejs/node/commit/01fd06da164292e212cc859590d164d5bd839a01 |
| 9607205 | https://github.com/nodejs/node/commit/96072053eaf5acc8f0d7a6ebd792fe37c7448d28 |
|
Compare
| https://github.com/nodejs/node/compare/01fd06da164292e212cc859590d164d5bd839a01..96072053eaf5acc8f0d7a6ebd792fe37c7448d28 |
| September 13, 2019 20:57 | https://github.com/nodejs/node/pull/29550#event-2633544694 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531413167 |
| nodejs/node-v0.x-archive#2338 | https://github.com/nodejs/node-v0.x-archive/issues/2338 |
| here | https://github.com/nodejs/node-v0.x-archive/issues/7075 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Sep 13, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531414916 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 14, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531434780 |
| @mscdex | https://github.com/mscdex |
| 9607205 | https://github.com/nodejs/node/commit/96072053eaf5acc8f0d7a6ebd792fe37c7448d28 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| bnoordhuis | https://github.com/bnoordhuis |
| mscdex | https://github.com/mscdex |
| shigeki | https://github.com/shigeki |
| September 14, 2019 01:37 | https://github.com/nodejs/node/pull/29550#event-2633867261 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Sep 14, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531443506 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 15, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531542504 |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Sep 16, 2019
| https://github.com/nodejs/node/pull/29550#ref-pullrequest-467821623 |
|
Change DH parameters to generate the order q subgroup instead of 2q
openssl/openssl#9363
| https://github.com/openssl/openssl/pull/9363 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 16, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531879737 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324795256 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/kroeckx |
| kroeckx | https://github.com/kroeckx |
| Sep 16, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-531956793 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| 1ecc406 | https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2 |
| 49cf67e | https://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
|
Compare
| https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| September 17, 2019 16:50 | https://github.com/nodejs/node/pull/29550#event-2640603943 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| September 17, 2019 20:52 | https://github.com/nodejs/node/pull/29550#event-2641298277 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/96072053eaf5acc8f0d7a6ebd792fe37c7448d28..7dc56e082b96aeee34e83dabbad81ee12607e38f |
| 9607205 | https://github.com/nodejs/node/commit/96072053eaf5acc8f0d7a6ebd792fe37c7448d28 |
| 7dc56e0 | https://github.com/nodejs/node/commit/7dc56e082b96aeee34e83dabbad81ee12607e38f |
|
Compare
| https://github.com/nodejs/node/compare/96072053eaf5acc8f0d7a6ebd792fe37c7448d28..7dc56e082b96aeee34e83dabbad81ee12607e38f |
| September 17, 2019 20:53 | https://github.com/nodejs/node/pull/29550#event-2641298647 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 17, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-532397752 |
| https://ci.nodejs.org/job/node-test-pull-request/25522/ | https://ci.nodejs.org/job/node-test-pull-request/25522/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 17, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-532440067 |
| https://ci.nodejs.org/job/node-test-pull-request/25527/ | https://ci.nodejs.org/job/node-test-pull-request/25527/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 18, 2019
| https://github.com/nodejs/node/pull/29550#pullrequestreview-290128023 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29550/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/29550#pullrequestreview-290128023 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| test/parallel/test-crypto-dh.js | https://github.com/nodejs/node/pull/29550/files#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25 |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/29550#discussion_r325836446 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-532837884 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2 | https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-532888642 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 19, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-533000408 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| sam-github | https://github.com/sam-github |
| September 19, 2019 12:50 | https://github.com/nodejs/node/pull/29550#commits-pushed-6007d28 |
|
| https://github.com/sam-github |
| deps: upgrade openssl sources to 1.1.1d | https://github.com/nodejs/node/pull/29550/commits/6007d2881c33c14d606132cdd41062051919b324 |
| 6007d28 | https://github.com/nodejs/node/pull/29550/commits/6007d2881c33c14d606132cdd41062051919b324 |
|
| https://github.com/sam-github |
| deps: update archs files for OpenSSL-1.1.1 | https://github.com/nodejs/node/pull/29550/commits/bf3f469070f11896cb0e70c0a1b5cc718a5d95e8 |
| bf3f469 | https://github.com/nodejs/node/pull/29550/commits/bf3f469070f11896cb0e70c0a1b5cc718a5d95e8 |
|
| https://github.com/sam-github |
| test: well-defined DH groups now verify clean | https://github.com/nodejs/node/pull/29550/commits/13f31595591f46b1d0575b21892058c9380d07ac |
| 13f3159 | https://github.com/nodejs/node/pull/29550/commits/13f31595591f46b1d0575b21892058c9380d07ac |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324802618 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/7dc56e082b96aeee34e83dabbad81ee12607e38f..e78c120e07958210a66a4c89ef04e501432ec17d |
| 7dc56e0 | https://github.com/nodejs/node/commit/7dc56e082b96aeee34e83dabbad81ee12607e38f |
| e78c120 | https://github.com/nodejs/node/commit/e78c120e07958210a66a4c89ef04e501432ec17d |
|
Compare
| https://github.com/nodejs/node/compare/7dc56e082b96aeee34e83dabbad81ee12607e38f..e78c120e07958210a66a4c89ef04e501432ec17d |
| September 19, 2019 20:07 | https://github.com/nodejs/node/pull/29550#event-2648264294 |
|
| https://github.com/sam-github |
| fixup! test: well-defined DH groups now verify clean | https://github.com/nodejs/node/pull/29550/commits/94c599e80218b09b27c0df93573a51e6adb45e61 |
| 94c599e | https://github.com/nodejs/node/pull/29550/commits/94c599e80218b09b27c0df93573a51e6adb45e61 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/e78c120e07958210a66a4c89ef04e501432ec17d..94c599e80218b09b27c0df93573a51e6adb45e61 |
| e78c120 | https://github.com/nodejs/node/commit/e78c120e07958210a66a4c89ef04e501432ec17d |
| 94c599e | https://github.com/nodejs/node/commit/94c599e80218b09b27c0df93573a51e6adb45e61 |
|
Compare
| https://github.com/nodejs/node/compare/e78c120e07958210a66a4c89ef04e501432ec17d..94c599e80218b09b27c0df93573a51e6adb45e61 |
| September 19, 2019 20:11 | https://github.com/nodejs/node/pull/29550#event-2648274103 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 19, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-533290715 |
| https://ci.nodejs.org/job/node-test-pull-request/25586/ | https://ci.nodejs.org/job/node-test-pull-request/25586/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-533689638 |
| https://ci.nodejs.org/job/node-test-pull-request/25607/ | https://ci.nodejs.org/job/node-test-pull-request/25607/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-534213814 |
| https://ci.nodejs.org/job/node-test-pull-request/25649/ | https://ci.nodejs.org/job/node-test-pull-request/25649/ |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 23, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-534279226 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 1, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-537150566 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 1, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-537157648 |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29550#pullrequestreview-295790899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29550/files/94c599e80218b09b27c0df93573a51e6adb45e61 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 1, 2019 | https://github.com/nodejs/node/pull/29550#issuecomment-537160796 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 1, 2019 | https://github.com/nodejs/node/pull/29550#event-2678033339 |
| sam-github | https://github.com/sam-github |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-17d1d16 |
|
| https://github.com/sam-github |
| deps: upgrade openssl sources to 1.1.1d | https://github.com/nodejs/node/commit/17d1d164418552089fcd72568e97a88b17ec1d21 |
| 17d1d16 | https://github.com/nodejs/node/commit/17d1d164418552089fcd72568e97a88b17ec1d21 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| sam-github | https://github.com/sam-github |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-1ca1e01 |
|
| https://github.com/sam-github |
| deps: update archs files for OpenSSL-1.1.1 | https://github.com/nodejs/node/commit/1ca1e0163e62cd9df771a6f0809e30a3382c54b6 |
| 1ca1e01 | https://github.com/nodejs/node/commit/1ca1e0163e62cd9df771a6f0809e30a3382c54b6 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| sam-github | https://github.com/sam-github |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-3473e58 |
|
| https://github.com/sam-github |
| test: well-defined DH groups now verify clean | https://github.com/nodejs/node/commit/3473e58fee153a7fee143a33c512ee9cda08d20a |
| 3473e58 | https://github.com/nodejs/node/commit/3473e58fee153a7fee143a33c512ee9cda08d20a |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324802618 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/29550#ref-pullrequest-503017583 |
|
crypto: remove guard against fixed OpenSSL bug
#29854
| https://github.com/nodejs/node/pull/29854 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-1766cfc |
|
| https://github.com/sam-github |
|
| https://github.com/BridgeAR |
| deps: upgrade openssl sources to 1.1.1d | https://github.com/nodejs/node/commit/1766cfcb9e3e579d5ca6cdd2aa5ed26021cf8dfd |
| 1766cfc | https://github.com/nodejs/node/commit/1766cfcb9e3e579d5ca6cdd2aa5ed26021cf8dfd |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-5eb013b |
|
| https://github.com/sam-github |
|
| https://github.com/BridgeAR |
| deps: update archs files for OpenSSL-1.1.1 | https://github.com/nodejs/node/commit/5eb013b8540c3426ff7f9c8fdc20110ad9a8e757 |
| 5eb013b | https://github.com/nodejs/node/commit/5eb013b8540c3426ff7f9c8fdc20110ad9a8e757 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-3153dd6 |
|
| https://github.com/sam-github |
|
| https://github.com/BridgeAR |
| test: well-defined DH groups now verify clean | https://github.com/nodejs/node/commit/3153dd67668d28c551f571636927613cd4f8c0c4 |
| 3153dd6 | https://github.com/nodejs/node/commit/3153dd67668d28c551f571636927613cd4f8c0c4 |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324802618 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29550#ref-pullrequest-505244335 |
|
v12.12.0 proposal
#29919
| https://github.com/nodejs/node/pull/29919 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29550#ref-pullrequest-505387160 |
|
[v10.x backport] Update openssl 1.1.1d
#29921
| https://github.com/nodejs/node/pull/29921 |
| sam-github | https://github.com/sam-github |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-9788101 |
|
| https://github.com/sam-github |
| test: well-defined DH groups now verify clean | https://github.com/sam-github/node/commit/978810109cc909a26512c620b8c90d11f1323d0d |
| 9788101 | https://github.com/sam-github/node/commit/978810109cc909a26512c620b8c90d11f1323d0d |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324802618 |
| nodejs#29550 | https://github.com/nodejs/node/pull/29550 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29550#ref-commit-13d8549 |
|
| https://github.com/sam-github |
|
| https://github.com/BethGriggs |
| test: well-defined DH groups now verify clean | https://github.com/nodejs/node/commit/13d8549abdb2b6aa6137637193b1815a14a5f9a8 |
| 13d8549 | https://github.com/nodejs/node/commit/13d8549abdb2b6aa6137637193b1815a14a5f9a8 |
| openssl/openssl#9363 | https://github.com/openssl/openssl/pull/9363 |
| openssl/openssl#9363 (comment) | https://github.com/openssl/openssl/pull/9363#discussion_r324802618 |
| #29550 | https://github.com/nodejs/node/pull/29550 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/29550#ref-pullrequest-503572635 |
|
v10.17.0 proposal
#29875
| https://github.com/nodejs/node/pull/29875 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| November 28, 2019 22:14 | https://github.com/nodejs/node/pull/29550#event-2839963420 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29550 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29550/files/7dc56e082b96aeee34e83dabbad81ee12607e38f |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29550/files/94c599e80218b09b27c0df93573a51e6adb45e61 |
|
| https://github.com/shigeki |
|
shigeki
| https://github.com/shigeki |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
| Please reload this page | https://github.com/nodejs/node/pull/29550 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/bnoordhuis |
|
| https://github.com/kroeckx |
|
| https://github.com/richardlau |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |