René's URL Explorer Experiment


Title: http2: no crash on stream listener removal w/ destroyed session by addaleax · Pull Request #29459 · nodejs/node · GitHub

Open Graph Title: http2: no crash on stream listener removal w/ destroyed session by addaleax · Pull Request #29459 · nodejs/node

X Title: http2: no crash on stream listener removal w/ destroyed session by addaleax · Pull Request #29459 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not crash when the session is no longer available. Fixes: #29457 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follow...

X Description: Do not crash when the session is no longer available. Fixes: #29457 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follow...

Opengraph URL: https://github.com/nodejs/node/pull/29459

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4cd87072-425e-55fe-df67-a7a3fb4f4812
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id909E:1EE1:45B0A89:62FB124:6A4FE3E4
html-safe-nonce85353ffb82b3fc2adfcfb8371f4833aaabc3a427bd877593c5245207ce7b1a08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDlFOjFFRTE6NDVCMEE4OTo2MkZCMTI0OjZBNEZFM0U0IiwidmlzaXRvcl9pZCI6Ijg1Nzc3NzAzODMxMTI5MjIwODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97570d611619e444e242c94bab3acef615e4983b9ee9ee11948022ef72b6edfe
hovercard-subject-tagpull_request:314631383
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29459/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4ae40de3d4d8b06e7c2e70685ece4245bdf1a151218bb234513a0917df9df59/nodejs/node/pull/29459
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4ae40de3d4d8b06e7c2e70685ece4245bdf1a151218bb234513a0917df9df59/nodejs/node/pull/29459
og:image:altDo not crash when the session is no longer available. Fixes: #29457 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29459#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29459
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29459
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29459
Reloadhttps://github.com/nodejs/node/pull/29459
Reloadhttps://github.com/nodejs/node/pull/29459
Please reload this pagehttps://github.com/nodejs/node/pull/29459
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29459
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 975 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-listener-session-destroyedhttps://github.com/addaleax/node/tree/http2-listener-session-destroyed
Conversationhttps://github.com/nodejs/node/pull/29459
Commits1 (1)https://github.com/nodejs/node/pull/29459/commits
Checkshttps://github.com/nodejs/node/pull/29459/checks
Files changedhttps://github.com/nodejs/node/pull/29459/files
http2: no crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/pull/29459#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-listener-session-destroyedhttps://github.com/addaleax/node/tree/http2-listener-session-destroyed
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 5, 2019https://github.com/nodejs/node/pull/29459#issue-489917194
#29457https://github.com/nodejs/node/issues/29457
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29459
https://github.com/addaleax
http2: no crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/pull/29459/commits/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
87b6db5https://github.com/nodejs/node/pull/29459/commits/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
nodejs#29457https://github.com/nodejs/node/issues/29457
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Sep 5, 2019https://github.com/nodejs/node/pull/29459#event-2611726934
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2019https://github.com/nodejs/node/pull/29459#issuecomment-528506678
https://ci.nodejs.org/job/node-test-pull-request/25368/https://ci.nodejs.org/job/node-test-pull-request/25368/
Please reload this pagehttps://github.com/nodejs/node/pull/29459
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 5, 2019 https://github.com/nodejs/node/pull/29459#pullrequestreview-284451850
View reviewed changes https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 5, 2019 https://github.com/nodejs/node/pull/29459#pullrequestreview-284583148
View reviewed changes https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 5, 2019https://github.com/nodejs/node/pull/29459#event-2612591303
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Sep 6, 2019https://github.com/nodejs/node/pull/29459#event-2612812419
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Sep 6, 2019 https://github.com/nodejs/node/pull/29459#pullrequestreview-284615781
View reviewed changes https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 6, 2019 https://github.com/nodejs/node/pull/29459#pullrequestreview-284817274
View reviewed changes https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 6, 2019 https://github.com/nodejs/node/pull/29459#ref-issue-489463144
OpenSSL sec releases upcoming #29445 https://github.com/nodejs/node/issues/29445
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 8, 2019https://github.com/nodejs/node/pull/29459#issuecomment-529168109
e585caahttps://github.com/nodejs/node/commit/e585caa2bebbd238c763af588a40879b61cf240f
Please reload this pagehttps://github.com/nodejs/node/pull/29459
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 8, 2019https://github.com/nodejs/node/pull/29459#event-2616545203
Trotthttps://github.com/Trott
Sep 8, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-e585caa
https://github.com/addaleax
https://github.com/Trott
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/e585caa2bebbd238c763af588a40879b61cf240f
e585caahttps://github.com/nodejs/node/commit/e585caa2bebbd238c763af588a40879b61cf240f
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
September 19, 2019 20:55https://github.com/nodejs/node/pull/29459#event-2648389561
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 19, 2019 https://github.com/nodejs/node/pull/29459#ref-pullrequest-496020050
v8.16.2 proposal #29617 https://github.com/nodejs/node/pull/29617
addaleaxhttps://github.com/addaleax
Sep 19, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-2f878d2
https://github.com/addaleax
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/addaleax/node/commit/2f878d2d6f48542ec82082fcc76586ee817e2edc
2f878d2https://github.com/addaleax/node/commit/2f878d2d6f48542ec82082fcc76586ee817e2edc
nodejs#29457https://github.com/nodejs/node/issues/29457
nodejs#29459https://github.com/nodejs/node/pull/29459
addaleaxhttps://github.com/addaleax
Sep 19, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-8f05a30
https://github.com/addaleax
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/addaleax/node/commit/8f05a30d9ad7aaf11c0509b7211ec24f0e7aee52
8f05a30https://github.com/addaleax/node/commit/8f05a30d9ad7aaf11c0509b7211ec24f0e7aee52
nodejs#29457https://github.com/nodejs/node/issues/29457
nodejs#29459https://github.com/nodejs/node/pull/29459
[v8.x] backport HTTP/2 security release fixups #29618 https://github.com/nodejs/node/pull/29618
[v10.x] backport HTTP/2 security release fixups #29619 https://github.com/nodejs/node/pull/29619
targoshttps://github.com/targos
Sep 20, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-26e6c6a
https://github.com/addaleax
https://github.com/targos
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/26e6c6aa3b94e7df98f43cb23548d303ff63eb86
26e6c6ahttps://github.com/nodejs/node/commit/26e6c6aa3b94e7df98f43cb23548d303ff63eb86
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 24, 2019 https://github.com/nodejs/node/pull/29459#ref-pullrequest-497808887
v12.11.0 proposal #29695 https://github.com/nodejs/node/pull/29695
BethGriggshttps://github.com/BethGriggs
Sep 25, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-559a8e3
https://github.com/addaleax
https://github.com/BethGriggs
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/559a8e342b52401889e3c11c03fac129610c646f
559a8e3https://github.com/nodejs/node/commit/559a8e342b52401889e3c11c03fac129610c646f
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
#29618https://github.com/nodejs/node/pull/29618
BridgeARhttps://github.com/BridgeAR
Sep 25, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-6a7d24b
https://github.com/addaleax
https://github.com/BridgeAR
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/6a7d24b69c2f5cb930258d8666ea1a67bf547c27
6a7d24bhttps://github.com/nodejs/node/commit/6a7d24b69c2f5cb930258d8666ea1a67bf547c27
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#301 https://github.com/beevelop/docker-nodejs/issues/301
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#333 https://github.com/beevelop/docker-android-nodejs/issues/333
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#302 https://github.com/beevelop/docker-nodejs/issues/302
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#334 https://github.com/beevelop/docker-android-nodejs/issues/334
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-nodejs#303 https://github.com/beevelop/docker-nodejs/issues/303
2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#335 https://github.com/beevelop/docker-android-nodejs/issues/335
BethGriggshttps://github.com/BethGriggs
Oct 1, 2019 https://github.com/nodejs/node/pull/29459#ref-commit-36a0e9a
https://github.com/addaleax
https://github.com/BethGriggs
http2: do not crash on stream listener removal w/ destroyed sessionhttps://github.com/nodejs/node/commit/36a0e9a06319210f7feff925840066e6bac7c3a4
36a0e9ahttps://github.com/nodejs/node/commit/36a0e9a06319210f7feff925840066e6bac7c3a4
#29457https://github.com/nodejs/node/issues/29457
#29459https://github.com/nodejs/node/pull/29459
#29619https://github.com/nodejs/node/pull/29619
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/29459#ref-pullrequest-503572635
v10.17.0 proposal #29875 https://github.com/nodejs/node/pull/29875
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Oct 17, 2019https://github.com/nodejs/node/pull/29459#event-2722959611
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29459
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29459/files/87b6db5f8fd23be9ba88e458680aace5ef67ae1b
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Cannot read property 'Symbol(kNativeFields)' using http2 session removeAllListeners https://github.com/nodejs/node/issues/29457
Please reload this pagehttps://github.com/nodejs/node/pull/29459
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/JungMinu
https://github.com/trivikr
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.