| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:83ff7d2a-69bc-a49e-2c53-8da0bcc1ea38 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D2C:33952:4C78D2:681939:6A4EB939 |
| html-safe-nonce | 76441aa04a0a8d541d2599164b95b43c7137e49dffbd45090b3cb743e329d84a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDJDOjMzOTUyOjRDNzhEMjo2ODE5Mzk6NkE0RUI5MzkiLCJ2aXNpdG9yX2lkIjoiMTk2NjcxMzk0Njk1NTI2NzEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9ddffa5c6c09432651619aa8677fe97789a7bcc675cd2d62338fa34a2311082e |
| hovercard-subject-tag | pull_request:314520183 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29451/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/452ff0c1f622b7ca354550a0356fe35b8e5ff37db43430a62cb15c7b88b1c8a5/nodejs/node/pull/29451 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/452ff0c1f622b7ca354550a0356fe35b8e5ff37db43430a62cb15c7b88b1c8a5/nodejs/node/pull/29451 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29451#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29451 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29451 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29451 |
| Reload | https://github.com/nodejs/node/pull/29451 |
| Reload | https://github.com/nodejs/node/pull/29451 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cclauss | https://github.com/cclauss |
| master | https://github.com/nodejs/node/tree/master |
| Travis-test-Py36-or-Py37 | https://github.com/nodejs/node/tree/Travis-test-Py36-or-Py37 |
| Conversation | https://github.com/nodejs/node/pull/29451 |
| Commits2 (2) | https://github.com/nodejs/node/pull/29451/commits |
| Checks | https://github.com/nodejs/node/pull/29451/checks |
| Files changed | https://github.com/nodejs/node/pull/29451/files |
| build: test Python 3.7 on Travis CI | https://github.com/nodejs/node/pull/29451#top |
| cclauss | https://github.com/cclauss |
| master | https://github.com/nodejs/node/tree/master |
| Travis-test-Py36-or-Py37 | https://github.com/nodejs/node/tree/Travis-test-Py36-or-Py37 |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29451#issue-489773793 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29451#event-2610755715 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Sep 5, 2019
| https://github.com/nodejs/node/pull/29451#ref-issue-483428909 |
|
tools/test.py is not yet Python 3 compatible
#29246
| https://github.com/nodejs/node/issues/29246 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29451#event-2611350824 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29451#event-2611393098 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/cfe37bd51ca999bdd5896300e08538ac4ca6bfe2..0d6036162ae2c94725cd215f3d2e22f8d28d0906 |
| cfe37bd | https://github.com/nodejs/node/commit/cfe37bd51ca999bdd5896300e08538ac4ca6bfe2 |
| 0d60361 | https://github.com/nodejs/node/commit/0d6036162ae2c94725cd215f3d2e22f8d28d0906 |
|
Compare
| https://github.com/nodejs/node/compare/cfe37bd51ca999bdd5896300e08538ac4ca6bfe2..0d6036162ae2c94725cd215f3d2e22f8d28d0906 |
| September 5, 2019 16:57 | https://github.com/nodejs/node/pull/29451#event-2611455221 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-528490888 |
| #25878 | https://github.com/nodejs/node/pull/25878 |
| tools: python3 compat for inspector code generator #29340 | https://github.com/nodejs/node/pull/29340 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @targos | https://github.com/targos |
| #29340 | https://github.com/nodejs/node/pull/29340 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 6, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-528703921 |
| #29340 | https://github.com/nodejs/node/pull/29340 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 6, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-528706275 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/567ca38fe665e27c77f031279bc607ce49517e01..b5fd477dd942461a35584acc23fb43f72f4f25b7 |
| 567ca38 | https://github.com/nodejs/node/commit/567ca38fe665e27c77f031279bc607ce49517e01 |
| b5fd477 | https://github.com/nodejs/node/commit/b5fd477dd942461a35584acc23fb43f72f4f25b7 |
|
Compare
| https://github.com/nodejs/node/compare/567ca38fe665e27c77f031279bc607ce49517e01..b5fd477dd942461a35584acc23fb43f72f4f25b7 |
| September 6, 2019 10:37 | https://github.com/nodejs/node/pull/29451#event-2613927968 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 6, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-528806205 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Sep 6, 2019
| https://github.com/nodejs/node/pull/29451#ref-pullrequest-490272490 |
|
build: add comment to .travis.yml on how to test Py3
#29473
| https://github.com/nodejs/node/pull/29473 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 6, 2019 | https://github.com/nodejs/node/pull/29451#event-2614022667 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 6, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-528986430 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/7d70614630763c10cedaa7e1db1e1e36ec71ba8f..014f468184795d612123dd7de8e4388a50770cd1 |
| 7d70614 | https://github.com/nodejs/node/commit/7d70614630763c10cedaa7e1db1e1e36ec71ba8f |
| 014f468 | https://github.com/nodejs/node/commit/014f468184795d612123dd7de8e4388a50770cd1 |
|
Compare
| https://github.com/nodejs/node/compare/7d70614630763c10cedaa7e1db1e1e36ec71ba8f..014f468184795d612123dd7de8e4388a50770cd1 |
| September 7, 2019 05:55 | https://github.com/nodejs/node/pull/29451#event-2616021574 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 7, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529076708 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 7, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529080292 |
| https://travis-ci.com/nodejs/node/jobs/232041903#L1008 | https://travis-ci.com/nodejs/node/jobs/232041903#L1008 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 7, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529128946 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529595931 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 9, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-285682608 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files |
| .travis.yml | https://github.com/nodejs/node/pull/29451/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 |
| Trott | https://github.com/Trott |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#discussion_r322376850 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529597004 |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529630277 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529630944 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529652823 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/2ba9e6272e066adbe4ed5f376d0c2f4a506061e1..b535e9c70b31593ce77d3c5bef9996cb277a0df9 |
| 2ba9e62 | https://github.com/nodejs/node/commit/2ba9e6272e066adbe4ed5f376d0c2f4a506061e1 |
| b535e9c | https://github.com/nodejs/node/commit/b535e9c70b31593ce77d3c5bef9996cb277a0df9 |
|
Compare
| https://github.com/nodejs/node/compare/2ba9e6272e066adbe4ed5f376d0c2f4a506061e1..b535e9c70b31593ce77d3c5bef9996cb277a0df9 |
| September 9, 2019 21:34 | https://github.com/nodejs/node/pull/29451#event-2620232105 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/b535e9c70b31593ce77d3c5bef9996cb277a0df9..23ce0296219a8be5b5188d15260666d68e01215f |
| b535e9c | https://github.com/nodejs/node/commit/b535e9c70b31593ce77d3c5bef9996cb277a0df9 |
| 23ce029 | https://github.com/nodejs/node/commit/23ce0296219a8be5b5188d15260666d68e01215f |
|
Compare
| https://github.com/nodejs/node/compare/b535e9c70b31593ce77d3c5bef9996cb277a0df9..23ce0296219a8be5b5188d15260666d68e01215f |
| September 9, 2019 21:35 | https://github.com/nodejs/node/pull/29451#event-2620233745 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 9, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529677269 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/23ce0296219a8be5b5188d15260666d68e01215f..5a6e21dea315ef58608e51982abfdbc12d841465 |
| 23ce029 | https://github.com/nodejs/node/commit/23ce0296219a8be5b5188d15260666d68e01215f |
| 5a6e21d | https://github.com/nodejs/node/commit/5a6e21dea315ef58608e51982abfdbc12d841465 |
|
Compare
| https://github.com/nodejs/node/compare/23ce0296219a8be5b5188d15260666d68e01215f..5a6e21dea315ef58608e51982abfdbc12d841465 |
| September 9, 2019 21:48 | https://github.com/nodejs/node/pull/29451#event-2620263330 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 10, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529835003 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/5a6e21dea315ef58608e51982abfdbc12d841465..9ab7107716001efe06fd4efe71689844ec8732c2 |
| 5a6e21d | https://github.com/nodejs/node/commit/5a6e21dea315ef58608e51982abfdbc12d841465 |
| 9ab7107 | https://github.com/nodejs/node/commit/9ab7107716001efe06fd4efe71689844ec8732c2 |
|
Compare
| https://github.com/nodejs/node/compare/5a6e21dea315ef58608e51982abfdbc12d841465..9ab7107716001efe06fd4efe71689844ec8732c2 |
| September 10, 2019 10:28 | https://github.com/nodejs/node/pull/29451#event-2621737886 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Sep 10, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-529881236 |
| dlopen(/home/travis/build/nodejs/node/test/addons/dlopen-ping-pong/build/Release/ping.so): /home/travis/build/nodejs/node/test/addons/dlopen-ping-pong/build/Release/ping.so: cannot open shared object file: No such file or directory | https://travis-ci.com/nodejs/node/jobs/232659488#L1023 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/253137b5502a6732eac9f0f899c6577c04338023..2ff431b7a08fab7938a73fb6f10ed76f151035aa |
| 253137b | https://github.com/nodejs/node/commit/253137b5502a6732eac9f0f899c6577c04338023 |
| 2ff431b | https://github.com/nodejs/node/commit/2ff431b7a08fab7938a73fb6f10ed76f151035aa |
|
Compare
| https://github.com/nodejs/node/compare/253137b5502a6732eac9f0f899c6577c04338023..2ff431b7a08fab7938a73fb6f10ed76f151035aa |
| October 16, 2019 01:13 | https://github.com/nodejs/node/pull/29451#event-2715905995 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-542468346 |
| #29885 | https://github.com/nodejs/node/pull/29885 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-302303008 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files/2ff431b7a08fab7938a73fb6f10ed76f151035aa |
| .travis.yml | https://github.com/nodejs/node/pull/29451/files/2ff431b7a08fab7938a73fb6f10ed76f151035aa#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-302304419 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files/2ff431b7a08fab7938a73fb6f10ed76f151035aa |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/29451#pullrequestreview-302304419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| review comments | https://github.com/nodejs/node/pull/29985#pullrequestreview-302131024 |
| #29985 | https://github.com/nodejs/node/pull/29985 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| .travis.yml | https://github.com/nodejs/node/pull/29451/files/2ff431b7a08fab7938a73fb6f10ed76f151035aa#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| .travis.yml | https://github.com/nodejs/node/pull/29451/files/2ff431b7a08fab7938a73fb6f10ed76f151035aa#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-542501973 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-542502827 |
| @cclauss | https://github.com/cclauss |
| #29985 | https://github.com/nodejs/node/pull/29985 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 16, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-542503373 |
| https://github.com/nodejs/node/compare/253137b5502a6732eac9f0f899c6577c04338023..2ff431b7a08fab7938a73fb6f10ed76f151035aa#diff-42f385dff7890b3c213d9699bcc350cc | https://github.com/nodejs/node/compare/253137b5502a6732eac9f0f899c6577c04338023..2ff431b7a08fab7938a73fb6f10ed76f151035aa#diff-42f385dff7890b3c213d9699bcc350cc |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
|
| https://github.com/cclauss |
| fixup: remove EXPERIMENTAL_NODE_GYP_PYTHON3="yes" | https://github.com/nodejs/node/pull/29451/commits/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
| 77fb266 | https://github.com/nodejs/node/pull/29451/commits/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#event-2722235166 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-303454813 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543301378 |
| https://ci.nodejs.org/job/node-test-pull-request/26085/ | https://ci.nodejs.org/job/node-test-pull-request/26085/ |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543301489 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-303456348 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/29451#ref-issue-508600803 |
|
flaky test: test-http-dump-req-when-res-ends on windows
#30011
| https://github.com/nodejs/node/issues/30011 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543338574 |
| #30011 | https://github.com/nodejs/node/issues/30011 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543338762 |
| https://ci.nodejs.org/job/node-test-pull-request/26087/ | https://ci.nodejs.org/job/node-test-pull-request/26087/ |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543339309 |
| #29451 (comment) | https://github.com/nodejs/node/pull/29451#issuecomment-543338574 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/29451#pullrequestreview-303598255 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
| sam-github | https://github.com/sam-github |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/29451#ref-commit-d594a9a |
|
| https://github.com/cclauss |
|
| https://github.com/sam-github |
| build: use python3 to build and test on Travis | https://github.com/nodejs/node/commit/d594a9a79890b76e002fbc1c7aa2a3aaed82c160 |
| d594a9a | https://github.com/nodejs/node/commit/d594a9a79890b76e002fbc1c7aa2a3aaed82c160 |
| #29451 | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/29451#issuecomment-543882069 |
| d594a9a | https://github.com/nodejs/node/commit/d594a9a79890b76e002fbc1c7aa2a3aaed82c160 |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 18, 2019 | https://github.com/nodejs/node/pull/29451#event-2725868496 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29451#ref-commit-dda73b0 |
|
| https://github.com/cclauss |
|
| https://github.com/MylesBorins |
| build: use python3 to build and test on Travis | https://github.com/nodejs/node/commit/dda73b0c97aae722a610fea880c62c415b7666a7 |
| dda73b0 | https://github.com/nodejs/node/commit/dda73b0c97aae722a610fea880c62c415b7666a7 |
| #29451 | https://github.com/nodejs/node/pull/29451 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29451#ref-commit-ccf5883 |
|
| https://github.com/cclauss |
|
| https://github.com/MylesBorins |
| build: use python3 to build and test on Travis | https://github.com/nodejs/node/commit/ccf58835c70a2c70a7898980d574f89100c4b0fe |
| ccf5883 | https://github.com/nodejs/node/commit/ccf58835c70a2c70a7898980d574f89100c4b0fe |
| #29451 | https://github.com/nodejs/node/pull/29451 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 23, 2019
| https://github.com/nodejs/node/pull/29451#ref-pullrequest-511137920 |
|
v13.0.1 proposal
#30081
| https://github.com/nodejs/node/pull/30081 |
| targos | https://github.com/targos |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/29451#ref-commit-57066a4 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: use python3 to build and test on Travis | https://github.com/nodejs/node/commit/57066a46c94de2f9d3c7c493ce59c6e9f9160c12 |
| 57066a4 | https://github.com/nodejs/node/commit/57066a46c94de2f9d3c7c493ce59c6e9f9160c12 |
| #29451 | https://github.com/nodejs/node/pull/29451 |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/29451#ref-commit-90e7c4c |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| build: use python3 to build and test on Travis | https://github.com/nodejs/node/commit/90e7c4cd4716ec5cd2732c252f5ea2184191fcbe |
| 90e7c4c | https://github.com/nodejs/node/commit/90e7c4cd4716ec5cd2732c252f5ea2184191fcbe |
| #29451 | https://github.com/nodejs/node/pull/29451 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 10, 2019
| https://github.com/nodejs/node/pull/29451#ref-pullrequest-520604598 |
|
v12.13.1 release proposal
#30352
| https://github.com/nodejs/node/pull/30352 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/29451#event-2787230000 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| May 21, 2020 17:27 | https://github.com/nodejs/node/pull/29451#event-3361587754 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29451 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29451/files/2ba9e6272e066adbe4ed5f376d0c2f4a506061e1 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
|
| https://github.com/rvagg |
|
rvagg
| https://github.com/rvagg |
|
| https://github.com/nodejs/node/pull/29451/files/77fb26603582e9a015a5ee1fbfce67a39422fff1 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Please reload this page | https://github.com/nodejs/node/pull/29451 |
|
| https://github.com/cclauss |
|
| https://github.com/sam-github |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/rvagg |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |