| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7fcc7a97-edd8-39e2-c4dc-2eb407a61e18 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD1C:FD8C5:136E024:1ACBD0E:6A4DE80A |
| html-safe-nonce | 0700ff115de0dfc400dc499daae3109aa7f33ae14e39d5a469cc3845783b3397 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDFDOkZEOEM1OjEzNkUwMjQ6MUFDQkQwRTo2QTRERTgwQSIsInZpc2l0b3JfaWQiOiI4MjY0MzQzODA4OTUyMzYzMDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2d19128320a363c9750a97b4ab7725c2a2fe3a482a9edad6386b066542f4fa60 |
| hovercard-subject-tag | pull_request:313120825 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29400/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5ce6def7e1d20cc8ffe8e7a97f5e7943d5cb29603f0bfa280d1575b8e4ee7202/nodejs/node/pull/29400 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5ce6def7e1d20cc8ffe8e7a97f5e7943d5cb29603f0bfa280d1575b8e4ee7202/nodejs/node/pull/29400 |
| og:image:alt | Follow up of this #26648. Adding support for fs.promises also updated the test files.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
docum... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | antsmartian |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29400#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29400 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29400 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29400 |
| Reload | https://github.com/nodejs/node/pull/29400 |
| Reload | https://github.com/nodejs/node/pull/29400 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| antsmartian | https://github.com/antsmartian |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| antsmartian:master | https://github.com/antsmartian/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/29400 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29400/commits |
| Checks | https://github.com/nodejs/node/pull/29400/checks |
| Files changed | https://github.com/nodejs/node/pull/29400/files |
| repl: add autocomplete support for fs.promises | https://github.com/nodejs/node/pull/29400#top |
| antsmartian | https://github.com/antsmartian |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| antsmartian:master | https://github.com/antsmartian/node/tree/master |
|
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29400#issue-488007984 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| #26648 | https://github.com/nodejs/node/pull/26648 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29400#event-2599980583 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-527016439 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29400#pullrequestreview-283318476 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29400/files |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29400#event-2609034563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-528165711 |
| https://ci.nodejs.org/job/node-test-pull-request/25359/ | https://ci.nodejs.org/job/node-test-pull-request/25359/ |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-528186632 |
| https://ci.nodejs.org/job/node-test-pull-request/25363/ | https://ci.nodejs.org/job/node-test-pull-request/25363/ |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-528196264 |
| https://ci.nodejs.org/job/node-test-pull-request/25364/ | https://ci.nodejs.org/job/node-test-pull-request/25364/ |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 5, 2019
| https://github.com/nodejs/node/pull/29400#pullrequestreview-284245475 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29400/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/29400#pullrequestreview-284245475 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| test/parallel/test-repl-tab-complete.js | https://github.com/nodejs/node/pull/29400/files#diff-a643109e5f1448b76b546b2a124e42bab57880cc115658f46922ca7b942a9c59 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| lib/repl.js | https://github.com/nodejs/node/pull/29400/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 7, 2019 | https://github.com/nodejs/node/pull/29400#event-2615974747 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 7, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-529069801 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 7, 2019
| https://github.com/nodejs/node/pull/29400#pullrequestreview-285169521 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29400/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/29400#pullrequestreview-285169521 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
|
| https://github.com/antsmartian |
| repl: add autocomplete support for fs.promises | https://github.com/nodejs/node/pull/29400/commits/d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
| d6d3477 | https://github.com/nodejs/node/pull/29400/commits/d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
| force-pushed | https://github.com/nodejs/node/compare/3921802f414ad50cac55fcb084f8dc4e12641b4b..d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
| 3921802 | https://github.com/nodejs/node/commit/3921802f414ad50cac55fcb084f8dc4e12641b4b |
| d6d3477 | https://github.com/nodejs/node/commit/d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
|
Compare
| https://github.com/nodejs/node/compare/3921802f414ad50cac55fcb084f8dc4e12641b4b..d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
| September 9, 2019 16:03 | https://github.com/nodejs/node/pull/29400#event-2619270232 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
| Sep 10, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-529736648 |
| @addaleax | https://github.com/addaleax |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 10, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-529739507 |
| https://ci.nodejs.org/job/node-test-pull-request/25414/ | https://ci.nodejs.org/job/node-test-pull-request/25414/ |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 10, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-529763757 |
| https://ci.nodejs.org/job/node-test-pull-request/25415/ | https://ci.nodejs.org/job/node-test-pull-request/25415/ |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Sep 15, 2019
| https://github.com/nodejs/node/pull/29400#pullrequestreview-288363936 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29400/files/d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 15, 2019 | https://github.com/nodejs/node/pull/29400#event-2634671293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 16, 2019 | https://github.com/nodejs/node/pull/29400#issuecomment-531639560 |
| ed0e5c8 | https://github.com/nodejs/node/commit/ed0e5c8c744439c759343030bd429bc514aef5c0 |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
| Trott | https://github.com/Trott |
|
Sep 16, 2019
| https://github.com/nodejs/node/pull/29400#ref-commit-ed0e5c8 |
|
| https://github.com/antsmartian |
|
| https://github.com/Trott |
| repl: add autocomplete support for fs.promises | https://github.com/nodejs/node/commit/ed0e5c8c744439c759343030bd429bc514aef5c0 |
| ed0e5c8 | https://github.com/nodejs/node/commit/ed0e5c8c744439c759343030bd429bc514aef5c0 |
| #29400 | https://github.com/nodejs/node/pull/29400 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 16, 2019 | https://github.com/nodejs/node/pull/29400#event-2635172171 |
| targos | https://github.com/targos |
|
Sep 20, 2019
| https://github.com/nodejs/node/pull/29400#ref-commit-d57d47b |
|
| https://github.com/antsmartian |
|
| https://github.com/targos |
| repl: add autocomplete support for fs.promises | https://github.com/nodejs/node/commit/d57d47bc342f5ae53f51a01c6aa17dc849838e7b |
| d57d47b | https://github.com/nodejs/node/commit/d57d47bc342f5ae53f51a01c6aa17dc849838e7b |
| #29400 | https://github.com/nodejs/node/pull/29400 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29400#ref-pullrequest-497808887 |
|
v12.11.0 proposal
#29695
| https://github.com/nodejs/node/pull/29695 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/29400#ref-commit-596dd9f |
|
| https://github.com/antsmartian |
|
| https://github.com/BridgeAR |
| repl: add autocomplete support for fs.promises | https://github.com/nodejs/node/commit/596dd9fe346ef600f98552f584f0664d39c3811f |
| 596dd9f | https://github.com/nodejs/node/commit/596dd9fe346ef600f98552f584f0664d39c3811f |
| #29400 | https://github.com/nodejs/node/pull/29400 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#301
| https://github.com/beevelop/docker-nodejs/issues/301 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#333
| https://github.com/beevelop/docker-android-nodejs/issues/333 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#302
| https://github.com/beevelop/docker-nodejs/issues/302 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#334
| https://github.com/beevelop/docker-android-nodejs/issues/334 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#303
| https://github.com/beevelop/docker-nodejs/issues/303 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#335
| https://github.com/beevelop/docker-android-nodejs/issues/335 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29400 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29400/files/3921802f414ad50cac55fcb084f8dc4e12641b4b |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29400/files/3921802f414ad50cac55fcb084f8dc4e12641b4b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/29400/files/3921802f414ad50cac55fcb084f8dc4e12641b4b |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/29400/files/d6d34774a5b896f9ebd4cd1fd79db38e653b2ea2 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Please reload this page | https://github.com/nodejs/node/pull/29400 |
|
| https://github.com/antsmartian |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |