| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3a62d9ff-a5c6-1cbd-a1f5-a18fa14ec6da |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 874A:1E53DB:AACA91:AEB957:6A4DB66F |
| html-safe-nonce | bafff1b529f0c356f93993251223461b5cce2823087f6a2eb5a5445e7a93b1cd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzRBOjFFNTNEQjpBQUNBOTE6QUVCOTU3OjZBNERCNjZGIiwidmlzaXRvcl9pZCI6Ijc0ODE0NTkyNTMyOTY2MDg4NzkiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | 01f770827871990c2eb52e916feb7f80445321cb3adfa5700c86538113ad5fe7 |
| hovercard-subject-tag | pull_request:312929923 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29383/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4b3a16cb66a0a651dccb83223c025968d0dad8dd95d02b4b768c0e9a0ef3c2ed/nodejs/node/pull/29383 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4b3a16cb66a0a651dccb83223c025968d0dad8dd95d02b4b768c0e9a0ef3c2ed/nodejs/node/pull/29383 |
| og:image:alt | adding missing header for the leak check. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devnexen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32f7b614aca06e6bbd89842b1370df1328264f68 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29383#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29383 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29383 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29383 |
| Reload | https://github.com/nodejs/node/pull/29383 |
| Reload | https://github.com/nodejs/node/pull/29383 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| devnexen | https://github.com/devnexen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/29383 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29383/commits |
| Checks | https://github.com/nodejs/node/pull/29383/checks |
| Files changed | https://github.com/nodejs/node/pull/29383/files |
| src: asan build fix for clang | https://github.com/nodejs/node/pull/29383#top |
| devnexen | https://github.com/devnexen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| Aug 31, 2019 | https://github.com/nodejs/node/pull/29383#issue-487730382 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Aug 31, 2019 | https://github.com/nodejs/node/pull/29383#event-2598656938 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 31, 2019
| https://github.com/nodejs/node/pull/29383#pullrequestreview-282303420 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29383/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/29383#pullrequestreview-282303420 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 31, 2019
| https://github.com/nodejs/node/pull/29383#pullrequestreview-282306414 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29383/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 31, 2019
| https://github.com/nodejs/node/pull/29383#pullrequestreview-282319894 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29383/files |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Sep 1, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-526923412 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 1, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-526923651 |
| https://ci.nodejs.org/job/node-test-pull-request/25312/ | https://ci.nodejs.org/job/node-test-pull-request/25312/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| Sep 1, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-526928047 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527027508 |
| https://ci.nodejs.org/job/node-test-pull-request/25323/ | https://ci.nodejs.org/job/node-test-pull-request/25323/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527034120 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527038615 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Sep 2, 2019
| https://github.com/nodejs/node/pull/29383#ref-issue-488048842 |
|
Add task to build asan
nodejs/build#1906
| https://github.com/nodejs/build/issues/1906 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527041439 |
| nodejs/build#1906 | https://github.com/nodejs/build/issues/1906 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527043193 |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
|
| https://github.com/devnexen |
| src: asan build fix for gcc/clang | https://github.com/nodejs/node/pull/29383/commits/ae807ec7212495630369c9e6109425bb2e2cec8b |
| ae807ec | https://github.com/nodejs/node/pull/29383/commits/ae807ec7212495630369c9e6109425bb2e2cec8b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29383#pullrequestreview-283318234 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29383/files/ae807ec7212495630369c9e6109425bb2e2cec8b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 4, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-527728033 |
| https://ci.nodejs.org/job/node-test-pull-request/25346/ | https://ci.nodejs.org/job/node-test-pull-request/25346/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| 1ecc406 | https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2 |
| 49cf67e | https://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
|
Compare
| https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| September 17, 2019 16:51 | https://github.com/nodejs/node/pull/29383#event-2640604484 |
| https://github.com/mapsam |
| mapsam | https://github.com/mapsam |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29383#ref-issue-497828566 |
|
sanitizer ASAN build failures
mapbox/vtquery#112
| https://github.com/mapbox/vtquery/issues/112 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-534840491 |
| https://ci.nodejs.org/job/node-test-pull-request/25689/ | https://ci.nodejs.org/job/node-test-pull-request/25689/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-534855076 |
| https://ci.nodejs.org/job/node-test-pull-request/25693/ | https://ci.nodejs.org/job/node-test-pull-request/25693/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-534867870 |
| https://ci.nodejs.org/job/node-test-pull-request/25699/ | https://ci.nodejs.org/job/node-test-pull-request/25699/ |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| Trott | https://github.com/Trott |
|
Sep 26, 2019
| https://github.com/nodejs/node/pull/29383#ref-commit-4d2856e |
|
| https://github.com/devnexen |
|
| https://github.com/Trott |
| src: fix asan build for gcc/clang | https://github.com/nodejs/node/commit/4d2856ed5aa9d831c06828d98db88ee91385372c |
| 4d2856e | https://github.com/nodejs/node/commit/4d2856ed5aa9d831c06828d98db88ee91385372c |
| #29383 | https://github.com/nodejs/node/pull/29383 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 26, 2019 | https://github.com/nodejs/node/pull/29383#issuecomment-535347008 |
| 4d2856e | https://github.com/nodejs/node/commit/4d2856ed5aa9d831c06828d98db88ee91385372c |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 26, 2019 | https://github.com/nodejs/node/pull/29383#event-2663977961 |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29383#ref-commit-17c3478 |
|
| https://github.com/devnexen |
|
| https://github.com/targos |
| src: fix asan build for gcc/clang | https://github.com/nodejs/node/commit/17c3478d7851928bb97f31c2be3a32feb0d8443e |
| 17c3478 | https://github.com/nodejs/node/commit/17c3478d7851928bb97f31c2be3a32feb0d8443e |
| #29383 | https://github.com/nodejs/node/pull/29383 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29383#ref-pullrequest-500881212 |
|
v12.11.1 release proposal
#29796
| https://github.com/nodejs/node/pull/29796 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29383#ref-issue-501061281 |
|
2019-10-01 Version 12.11.1 (Current) @targos
beevelop/docker-nodejs#304
| https://github.com/beevelop/docker-nodejs/issues/304 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29383 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29383/files/e5e099ed81589f1b27d5a5bfac7774358b71bd2c |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29383/files/ae807ec7212495630369c9e6109425bb2e2cec8b |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29383/files/8150b63d51156d25c630e9a390de457155acbdce |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29383/files/8150b63d51156d25c630e9a390de457155acbdce |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Please reload this page | https://github.com/nodejs/node/pull/29383 |
|
| https://github.com/devnexen |
|
| https://github.com/gengjiawen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |