René's URL Explorer Experiment


Title: tools: from io import StringIO in ninja.py by cclauss · Pull Request #29371 · nodejs/node · GitHub

Open Graph Title: tools: from io import StringIO in ninja.py by cclauss · Pull Request #29371 · nodejs/node

X Title: tools: from io import StringIO in ninja.py by cclauss · Pull Request #29371 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: cStringIO was removed in Python 3 so this PR advocates that we use the io module instead. As reported #25789 (comment), #29196 (comment), and #29236 (comment) this issue is being seen by Windows u...

X Description: cStringIO was removed in Python 3 so this PR advocates that we use the io module instead. As reported #25789 (comment), #29196 (comment), and #29236 (comment) this issue is being seen by Windows u...

Opengraph URL: https://github.com/nodejs/node/pull/29371

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ea3d84db-0f9a-d8aa-5664-7befbf9ca9a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA422:358B3C:1789EFD:21BE4FF:6A4F735D
html-safe-nonce7e701dbe8409c1649a06262bb518ee5c45db684e46dc512ea22a81c0d5f21034
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDIyOjM1OEIzQzoxNzg5RUZEOjIxQkU0RkY6NkE0RjczNUQiLCJ2aXNpdG9yX2lkIjoiNTgxNTk3ODIzNzA3NTg3ODc0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac570efb9d79484630db90d99d2bf9ec09206e1e06f346befcca977591aeb287cf
hovercard-subject-tagpull_request:312481387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29371/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6b3f8788182f74127786e9b3fcaec1882a6d7882097f87597b768599c05abf09/nodejs/node/pull/29371
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6b3f8788182f74127786e9b3fcaec1882a6d7882097f87597b768599c05abf09/nodejs/node/pull/29371
og:image:altcStringIO was removed in Python 3 so this PR advocates that we use the io module instead. As reported #25789 (comment), #29196 (comment), and #29236 (comment) this issue is being seen by Windows u...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecclauss
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29371#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29371
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29371
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29371
Reloadhttps://github.com/nodejs/node/pull/29371
Reloadhttps://github.com/nodejs/node/pull/29371
Please reload this pagehttps://github.com/nodejs/node/pull/29371
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29371
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:Py3-ninja.pyhttps://github.com/cclauss/node/tree/Py3-ninja.py
Conversationhttps://github.com/nodejs/node/pull/29371
Commits1 (1)https://github.com/nodejs/node/pull/29371/commits
Checkshttps://github.com/nodejs/node/pull/29371/checks
Files changedhttps://github.com/nodejs/node/pull/29371/files
tools: from io import StringIO in ninja.py https://github.com/nodejs/node/pull/29371#top
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:Py3-ninja.pyhttps://github.com/cclauss/node/tree/Py3-ninja.py
https://github.com/cclauss
cclausshttps://github.com/cclauss
Aug 29, 2019https://github.com/nodejs/node/pull/29371#issue-487160533
Please reload this pagehttps://github.com/nodejs/node/pull/29371
#25789 (comment)https://github.com/nodejs/node/issues/25789#issuecomment-522109282
#29196 (comment)https://github.com/nodejs/node/pull/29196#issuecomment-523263598
#29236 (comment)https://github.com/nodejs/node/pull/29236#issuecomment-526236087
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Aug 29, 2019https://github.com/nodejs/node/pull/29371#event-2595242402
https://github.com/cclauss
cclausshttps://github.com/cclauss
joaocgreishttps://github.com/joaocgreis
August 29, 2019 20:28https://github.com/nodejs/node/pull/29371#event-2595243092
https://github.com/cclauss
cclausshttps://github.com/cclauss
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Aug 29, 2019https://github.com/nodejs/node/pull/29371#event-2595243791
https://github.com/cclauss
cclausshttps://github.com/cclauss
gengjiawenhttps://github.com/gengjiawen
sam-githubhttps://github.com/sam-github
August 29, 2019 20:28https://github.com/nodejs/node/pull/29371#event-2595244098
https://github.com/cclauss
cclausshttps://github.com/cclauss
Aug 29, 2019https://github.com/nodejs/node/pull/29371#event-2595256234
Accept Python 3 on Windows #29236 https://github.com/nodejs/node/pull/29236
build: ongoing list of actions for Python 3 compatibility #25789 https://github.com/nodejs/node/issues/25789
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526355375
https://ci.nodejs.org/job/node-test-pull-request/25297/https://ci.nodejs.org/job/node-test-pull-request/25297/
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 29, 2019 https://github.com/nodejs/node/pull/29371#pullrequestreview-281737896
View reviewed changes https://github.com/nodejs/node/pull/29371/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 29, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526374461
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 30, 2019 https://github.com/nodejs/node/pull/29371#pullrequestreview-281794033
View reviewed changes https://github.com/nodejs/node/pull/29371/files
https://github.com/cclauss
tools: from io import StringIO in ninja.pyhttps://github.com/nodejs/node/pull/29371/commits/64fa5942d9ba37dbd64f2d0795596f633a6347e7
64fa594https://github.com/nodejs/node/pull/29371/commits/64fa5942d9ba37dbd64f2d0795596f633a6347e7
https://github.com/cclauss
cclausshttps://github.com/cclauss
force-pushedhttps://github.com/nodejs/node/compare/331b268fccfe60e2aa3dd204c82426280da32ef0..64fa5942d9ba37dbd64f2d0795596f633a6347e7
331b268https://github.com/nodejs/node/commit/331b268fccfe60e2aa3dd204c82426280da32ef0
64fa594https://github.com/nodejs/node/commit/64fa5942d9ba37dbd64f2d0795596f633a6347e7
Compare https://github.com/nodejs/node/compare/331b268fccfe60e2aa3dd204c82426280da32ef0..64fa5942d9ba37dbd64f2d0795596f633a6347e7
August 30, 2019 03:53https://github.com/nodejs/node/pull/29371#event-2595920223
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526446792
https://ci.nodejs.org/job/node-test-pull-request/25298/https://ci.nodejs.org/job/node-test-pull-request/25298/
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526447513
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Aug 30, 2019 https://github.com/nodejs/node/pull/29371#pullrequestreview-281820817
View reviewed changes https://github.com/nodejs/node/pull/29371/files/64fa5942d9ba37dbd64f2d0795596f633a6347e7
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526448333
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/cclauss
cclausshttps://github.com/cclauss
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526453388
@gengjiawenhttps://github.com/gengjiawen
https://docs.travis-ci.com/user/languages/python/#running-python-tests-on-multiple-operating-systemshttps://docs.travis-ci.com/user/languages/python/#running-python-tests-on-multiple-operating-systems
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526453535
https://ci.nodejs.org/job/node-test-pull-request/25299/https://ci.nodejs.org/job/node-test-pull-request/25299/
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526454183
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/cclauss
cclausshttps://github.com/cclauss
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526495935
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 30, 2019https://github.com/nodejs/node/pull/29371#issuecomment-526497888
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 30, 2019 https://github.com/nodejs/node/pull/29371#pullrequestreview-282216941
View reviewed changes https://github.com/nodejs/node/pull/29371/files/64fa5942d9ba37dbd64f2d0795596f633a6347e7
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 31, 2019https://github.com/nodejs/node/pull/29371#event-2598802251
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 3, 2019https://github.com/nodejs/node/pull/29371#issuecomment-527295214
020c2eahttps://github.com/nodejs/node/commit/020c2eaf4bf630652c1e9d3b238579c37036a4aa
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 3, 2019https://github.com/nodejs/node/pull/29371#event-2602181220
Trotthttps://github.com/Trott
Sep 3, 2019 https://github.com/nodejs/node/pull/29371#ref-commit-020c2ea
https://github.com/cclauss
https://github.com/Trott
tools: use 'from io import StringIO' in ninja.pyhttps://github.com/nodejs/node/commit/020c2eaf4bf630652c1e9d3b238579c37036a4aa
020c2eahttps://github.com/nodejs/node/commit/020c2eaf4bf630652c1e9d3b238579c37036a4aa
#29371https://github.com/nodejs/node/pull/29371
https://github.com/targos
targoshttps://github.com/targos
Sep 3, 2019https://github.com/nodejs/node/pull/29371#issuecomment-527331969
Please reload this pagehttps://github.com/nodejs/node/pull/29371
gyp: make StringIO work in ninja.py #29414 https://github.com/nodejs/node/pull/29414
Tests do not test ./configure --ninja #29415 https://github.com/nodejs/node/issues/29415
sam-githubhttps://github.com/sam-github
Sep 3, 2019 https://github.com/nodejs/node/pull/29371#ref-commit-40060f4
https://github.com/cclauss
https://github.com/sam-github
gyp: make StringIO work in ninja.pyhttps://github.com/nodejs/node/commit/40060f4e42a9f2c79d14c704f4496320b18c0483
40060f4https://github.com/nodejs/node/commit/40060f4e42a9f2c79d14c704f4496320b18c0483
#29371https://github.com/nodejs/node/pull/29371
#29371 (comment)https://github.com/nodejs/node/pull/29371#issuecomment-527331969
#29414https://github.com/nodejs/node/pull/29414
https://github.com/cclauss
cclausshttps://github.com/cclauss
September 3, 2019 20:34https://github.com/nodejs/node/pull/29371#event-2604905198
BridgeARhttps://github.com/BridgeAR
Sep 3, 2019 https://github.com/nodejs/node/pull/29371#ref-commit-1f40413
https://github.com/cclauss
https://github.com/BridgeAR
tools: use 'from io import StringIO' in ninja.pyhttps://github.com/nodejs/node/commit/1f404134b3434a040fbb5f456e531811c1d9de4e
1f40413https://github.com/nodejs/node/commit/1f404134b3434a040fbb5f456e531811c1d9de4e
#29371https://github.com/nodejs/node/pull/29371
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 3, 2019 https://github.com/nodejs/node/pull/29371#ref-pullrequest-488849745
v12.10.0 proposal #29429 https://github.com/nodejs/node/pull/29429
BridgeARhttps://github.com/BridgeAR
Sep 4, 2019 https://github.com/nodejs/node/pull/29371#ref-commit-350975e
https://github.com/cclauss
https://github.com/BridgeAR
tools: use 'from io import StringIO' in ninja.pyhttps://github.com/nodejs/node/commit/350975e312b706c9185a94cf0e049b994f60ae22
350975ehttps://github.com/nodejs/node/commit/350975e312b706c9185a94cf0e049b994f60ae22
#29371https://github.com/nodejs/node/pull/29371
targoshttps://github.com/targos
Sep 20, 2019 https://github.com/nodejs/node/pull/29371#ref-commit-a20a8f4
https://github.com/cclauss
https://github.com/targos
gyp: make StringIO work in ninja.pyhttps://github.com/nodejs/node/commit/a20a8f48f7b9b8243dd6db03e3fb2cd058208c03
a20a8f4https://github.com/nodejs/node/commit/a20a8f48f7b9b8243dd6db03e3fb2cd058208c03
#29371https://github.com/nodejs/node/pull/29371
#29371 (comment)https://github.com/nodejs/node/pull/29371#issuecomment-527331969
#29414https://github.com/nodejs/node/pull/29414
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29371
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/29371/files/331b268fccfe60e2aa3dd204c82426280da32ef0
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29371/files/64fa5942d9ba37dbd64f2d0795596f633a6347e7
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/29371/files/331b268fccfe60e2aa3dd204c82426280da32ef0
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/29371/files/64fa5942d9ba37dbd64f2d0795596f633a6347e7
https://github.com/joaocgreis
joaocgreis https://github.com/joaocgreis
https://github.com/sam-github
sam-github https://github.com/sam-github
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/29371
https://github.com/cclauss
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/gengjiawen
https://github.com/richardlau
https://github.com/Trott
https://github.com/targos
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.