| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:09047f15-d80b-e974-3f59-6d55942db1fd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD1E:7E3D2:DB4A67:129B32D:6A4F01BD |
| html-safe-nonce | 565e20c3475967ac446e382009aecc1a6294cea820a7cfda524414d1ff1c9333 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDFFOjdFM0QyOkRCNEE2NzoxMjlCMzJEOjZBNEYwMUJEIiwidmlzaXRvcl9pZCI6IjIyODk5MjE4ODA3NjM1OTcyNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fa1b943778e541dd94ede3a0ca8d8c5b58ffb2f10114da12786a7dcfa41bca1f |
| hovercard-subject-tag | pull_request:311624194 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29349/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/539a97c151c05b27049630de1289a3c3d768b988b8ed10aafa9f0de0cf148ab8/nodejs/node/pull/29349 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/539a97c151c05b27049630de1289a3c3d768b988b8ed10aafa9f0de0cf148ab8/nodejs/node/pull/29349 |
| og:image:alt | This adds long-requested methods for asynchronously interacting and iterating through directory entries by using uv_fs_opendir, uv_fs_readdir, and uv_fs_closedir.
const fs = require('fs');
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fishrock123 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29349#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29349 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29349 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29349 |
| Reload | https://github.com/nodejs/node/pull/29349 |
| Reload | https://github.com/nodejs/node/pull/29349 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:async-readdir-iteration | https://github.com/Fishrock123/node/tree/async-readdir-iteration |
| Conversation | https://github.com/nodejs/node/pull/29349 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29349/commits |
| Checks | https://github.com/nodejs/node/pull/29349/checks |
| Files changed | https://github.com/nodejs/node/pull/29349/files |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/node/pull/29349#top |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:async-readdir-iteration | https://github.com/Fishrock123/node/tree/async-readdir-iteration |
|
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Aug 28, 2019 | https://github.com/nodejs/node/pull/29349#issue-486102295 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| #583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Aug 28, 2019 | https://github.com/nodejs/node/pull/29349#event-2588885060 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| cjihrig | https://github.com/cjihrig |
| August 28, 2019 00:41 | https://github.com/nodejs/node/pull/29349#event-2588885071 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 28, 2019 | https://github.com/nodejs/node/pull/29349#event-2588885152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| addaleax | https://github.com/addaleax |
| jasnell | https://github.com/jasnell |
| August 28, 2019 00:42 | https://github.com/nodejs/node/pull/29349#event-2588885840 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#ref-issue-55348288 |
|
streaming / iterative fs.readdir
#583
| https://github.com/nodejs/node/issues/583 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-280541558 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-280540965 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.h | https://github.com/nodejs/node/pull/29349/files#diff-5a0fa708afa6a2202dc64e5038e16c8e249cb1c3ec23c87885acc2a662a1ec00 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_file.h | https://github.com/nodejs/node/pull/29349/files#diff-418f37207bed6c8852c6120c4faaa1234d68c5c936645ba748d88e3c5b87bf7b |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| test/parallel/test-fs-opendir.js | https://github.com/nodejs/node/pull/29349/files#diff-686aca8889b55f0afbba155ebd90257331b35b996e6d3fff090e11b56579c70d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.h | https://github.com/nodejs/node/pull/29349/files#diff-5a0fa708afa6a2202dc64e5038e16c8e249cb1c3ec23c87885acc2a662a1ec00 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 28, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-525544157 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 28, 2019 | https://github.com/nodejs/node/pull/29349#event-2588939523 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-280672105 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| src/node_dir.cc | https://github.com/nodejs/node/pull/29349/files#diff-12768848757b514f1f042fddf06af34b9ba1d395113539ee98ff4bde165d1d4d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-280881977 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_file.h | https://github.com/nodejs/node/pull/29349/files#diff-418f37207bed6c8852c6120c4faaa1234d68c5c936645ba748d88e3c5b87bf7b |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281120875 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| src/env.h | https://github.com/nodejs/node/pull/29349/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.cc | https://github.com/nodejs/node/pull/29349/files#diff-12768848757b514f1f042fddf06af34b9ba1d395113539ee98ff4bde165d1d4d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| stale review | https://github.com/nodejs/node/pull/29349#pullrequestreview-280541558 |
| August 28, 2019 22:30 | https://github.com/nodejs/node/pull/29349#event-2592124244 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281151685 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281152212 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281152675 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281153876 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281154100 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 28, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281154143 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 29, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281172974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29349/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 29, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281173494 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 29, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-281173666 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| Aug 30, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-526539915 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 30, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-282173821 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/29349#pullrequestreview-282173821 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.cc | https://github.com/nodejs/node/pull/29349/files#diff-12768848757b514f1f042fddf06af34b9ba1d395113539ee98ff4bde165d1d4d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.cc | https://github.com/nodejs/node/pull/29349/files#diff-12768848757b514f1f042fddf06af34b9ba1d395113539ee98ff4bde165d1d4d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| src/node_dir.cc | https://github.com/nodejs/node/pull/29349/files#diff-12768848757b514f1f042fddf06af34b9ba1d395113539ee98ff4bde165d1d4d |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| lib/internal/fs/dir.js | https://github.com/nodejs/node/pull/29349/files#diff-375f192e069850ba11219b6a7995d12ac7dbc63c9ffd11f6181a5759b395a7bb |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 5, 2019
| https://github.com/nodejs/node/pull/29349#pullrequestreview-284424523 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29349/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/29349#pullrequestreview-284424523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 5, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-528489817 |
| https://ci.nodejs.org/job/node-test-pull-request/25366/ | https://ci.nodejs.org/job/node-test-pull-request/25366/ |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
|
| https://github.com/Fishrock123 |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/node/pull/29349/commits/018fc768afe6f28266d31e111affa0495c3eeca4 |
| 018fc76 | https://github.com/nodejs/node/pull/29349/commits/018fc768afe6f28266d31e111affa0495c3eeca4 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/cf9574e9f1803c8bd4b69e03060fe484854ef3f4..018fc768afe6f28266d31e111affa0495c3eeca4 |
| cf9574e | https://github.com/nodejs/node/commit/cf9574e9f1803c8bd4b69e03060fe484854ef3f4 |
| 018fc76 | https://github.com/nodejs/node/commit/018fc768afe6f28266d31e111affa0495c3eeca4 |
|
Compare
| https://github.com/nodejs/node/compare/cf9574e9f1803c8bd4b69e03060fe484854ef3f4..018fc768afe6f28266d31e111affa0495c3eeca4 |
| October 7, 2019 23:34 | https://github.com/nodejs/node/pull/29349#event-2693622436 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-539248986 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 8, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-cbd8d71 |
|
| https://github.com/Fishrock123 |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/node/commit/cbd8d715b2286e5726e6988921f5c870cbf74127 |
| cbd8d71 | https://github.com/nodejs/node/commit/cbd8d715b2286e5726e6988921f5c870cbf74127 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| #583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 8, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-539622153 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 8, 2019 | https://github.com/nodejs/node/pull/29349#event-2696279855 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Oct 9, 2019 | https://github.com/nodejs/node/pull/29349#issuecomment-539886299 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
| https://github.com/mrmlnc |
| mrmlnc | https://github.com/mrmlnc |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29349#ref-issue-504842754 |
|
[fs.walk] Explore fs.opendir
nodelib/nodelib#46
| https://github.com/nodelib/nodelib/issues/46 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-b76a2e5 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/BridgeAR |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/node/commit/b76a2e502c6f227f7df5f35ac3bbb0dcb2a8372d |
| b76a2e5 | https://github.com/nodejs/node/commit/b76a2e502c6f227f7df5f35ac3bbb0dcb2a8372d |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| #583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| addaleax | https://github.com/addaleax |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-13b25c3 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/quic/commit/13b25c3e76e996f219f72e0dcadf6507c5471d9b |
| 13b25c3 | https://github.com/nodejs/quic/commit/13b25c3e76e996f219f72e0dcadf6507c5471d9b |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs/node#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| addaleax | https://github.com/addaleax |
|
Oct 9, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-91561d0 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/quic/commit/91561d0217db7f075bb0b73e2eb7ebaca2126d68 |
| 91561d0 | https://github.com/nodejs/quic/commit/91561d0217db7f075bb0b73e2eb7ebaca2126d68 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs/node#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29349#ref-pullrequest-505244335 |
|
v12.12.0 proposal
#29919
| https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 10, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-75baa7e |
|
| https://github.com/BridgeAR |
| 2019-10-10, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96 |
| 75baa7e | https://github.com/nodejs/node/commit/75baa7e41ec8b0ce2442178305a421222c424e96 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-921493e |
|
| https://github.com/BridgeAR |
| 2019-10-11, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd |
| 921493e | https://github.com/nodejs/node/commit/921493e2287aa895679620155b5288b2e1587bfd |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| BridgeAR | https://github.com/BridgeAR |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-06f6d66 |
|
| https://github.com/BridgeAR |
| 2019-10-11, Version 12.12.0 (Current) | https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141 |
| 06f6d66 | https://github.com/nodejs/node/commit/06f6d662f679ee04679d97ecd5087e6f17268141 |
| #29631 | https://github.com/nodejs/node/pull/29631 |
| #29781 | https://github.com/nodejs/node/pull/29781 |
| #29754 | https://github.com/nodejs/node/pull/29754 |
| #29349 | https://github.com/nodejs/node/pull/29349 |
| #29564 | https://github.com/nodejs/node/pull/29564 |
| #29635 | https://github.com/nodejs/node/pull/29635 |
| #28973 | https://github.com/nodejs/node/pull/28973 |
| #29919 | https://github.com/nodejs/node/pull/29919 |
| addaleax | https://github.com/addaleax |
|
Oct 11, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-e2fd30e |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
| fs: introduce opendir() and fs.Dir | https://github.com/nodejs/quic/commit/e2fd30e5656ed1332cb8528a0b59d6505838cdc0 |
| e2fd30e | https://github.com/nodejs/quic/commit/e2fd30e5656ed1332cb8528a0b59d6505838cdc0 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs/node#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| https://github.com/paulmillr |
| paulmillr | https://github.com/paulmillr |
|
Oct 12, 2019
| https://github.com/nodejs/node/pull/29349#ref-issue-506113039 |
|
fs.Dir.read() is very slow
#29941
| https://github.com/nodejs/node/issues/29941 |
| codebytere | https://github.com/codebytere |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-cdce32d |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/cdce32d9bd85da060163eb9def3eb68fd82c9ebb |
| cdce32d | https://github.com/electron/electron/commit/cdce32d9bd85da060163eb9def3eb68fd82c9ebb |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| codebytere | https://github.com/codebytere |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-08dd0f6 |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/08dd0f67091fd8b4a2749ec75f0c341570fe3a4c |
| 08dd0f6 | https://github.com/electron/electron/commit/08dd0f67091fd8b4a2749ec75f0c341570fe3a4c |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| codebytere | https://github.com/codebytere |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-d9e1bf2 |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/d9e1bf2f553e2bc519f25a9fe5dde7c51ac785d2 |
| d9e1bf2 | https://github.com/electron/electron/commit/d9e1bf2f553e2bc519f25a9fe5dde7c51ac785d2 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| codebytere | https://github.com/codebytere |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-1e9c1aa |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/1e9c1aa12998088b72a2d50c50df38894ef2aea0 |
| 1e9c1aa | https://github.com/electron/electron/commit/1e9c1aa12998088b72a2d50c50df38894ef2aea0 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| codebytere | https://github.com/codebytere |
|
Oct 16, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-e96764c |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/e96764c42801682fe4070fee61919fc231b1a11d |
| e96764c | https://github.com/electron/electron/commit/e96764c42801682fe4070fee61919fc231b1a11d |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| codebytere | https://github.com/codebytere |
|
Oct 17, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-158d8a8 |
|
| https://github.com/codebytere |
| update BUILD.gn for new files | https://github.com/electron/electron/commit/158d8a894654fe54ad9e0ed551cf9e4f6320ac31 |
| 158d8a8 | https://github.com/electron/electron/commit/158d8a894654fe54ad9e0ed551cf9e4f6320ac31 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| juanarbol | https://github.com/juanarbol |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-4a3c5c3 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/juanarbol |
| fs: introduce opendir() and fs.Dir | https://github.com/juanarbol/quic/commit/4a3c5c3177d82e6f3f3ac9c97db186b2931e2f04 |
| 4a3c5c3 | https://github.com/juanarbol/quic/commit/4a3c5c3177d82e6f3f3ac9c97db186b2931e2f04 |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs/node#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| juanarbol | https://github.com/juanarbol |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/29349#ref-commit-7dfa2b5 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/juanarbol |
| fs: introduce opendir() and fs.Dir | https://github.com/juanarbol/quic/commit/7dfa2b5a19079e561a543c10fc289b9e2c22e0bc |
| 7dfa2b5 | https://github.com/juanarbol/quic/commit/7dfa2b5a19079e561a543c10fc289b9e2c22e0bc |
| nodejs/node-v0.x-archive#388 | https://github.com/nodejs/node-v0.x-archive/issues/388 |
| nodejs/node#583 | https://github.com/nodejs/node/issues/583 |
| libuv/libuv#2057 | https://github.com/libuv/libuv/pull/2057 |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 6, 2020
| https://github.com/nodejs/node/pull/29349#ref-pullrequest-738044370 |
|
Begin docs-deprecation of fs.readdir{Sync}(), add fs.scandirSync() alias.
#36008
| https://github.com/nodejs/node/pull/36008 |
| abhishekumar-tyagi | https://github.com/abhishekumar-tyagi |
|
May 5, 2024
| https://github.com/nodejs/node/pull/29349#ref-commit-35d1c50 |
|
| https://github.com/Fishrock123 |
| fs: add scandirSync(), rename internals to scandir | https://github.com/abhishekumar-tyagi/node/commit/35d1c503cb5601971c07f9ed1e84c173fef1707e |
| 35d1c50 | https://github.com/abhishekumar-tyagi/node/commit/35d1c503cb5601971c07f9ed1e84c173fef1707e |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| abhishekumar-tyagi | https://github.com/abhishekumar-tyagi |
|
May 5, 2024
| https://github.com/nodejs/node/pull/29349#ref-commit-792b6c4 |
|
| https://github.com/Fishrock123 |
| fs,doc: docs-deprecate fs.readdir{Sync}() | https://github.com/abhishekumar-tyagi/node/commit/792b6c4dd0422a48469de6c90310fd0ad36c121b |
| 792b6c4 | https://github.com/abhishekumar-tyagi/node/commit/792b6c4dd0422a48469de6c90310fd0ad36c121b |
| nodejs/node#29349 | https://github.com/nodejs/node/pull/29349 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29349 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29349/files/2cbbb0f6e1ac376861beaa7d69c969d57c6c8e93 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29349/files/11ccdbdeca28137f04f2087b69c0bb075d69e071 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29349/files/582ef3f205a327657f2f109229073c8eae0eb5ae |
|
| https://github.com/saghul |
|
saghul
| https://github.com/saghul |
|
| https://github.com/nodejs/node/pull/29349/files/582ef3f205a327657f2f109229073c8eae0eb5ae |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/29349/files/1d1675644e4d346535d52712fb4bcc67358bd30f |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/29349/files/8f20ba35ee9e3eda7593f3b14df938aa73fb96e2 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/29349 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
|
| https://github.com/devnexen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/saghul |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |