René's URL Explorer Experiment


Title: crypto: don't expose OpenSSL internals by codebytere · Pull Request #29325 · nodejs/node · GitHub

Open Graph Title: crypto: don't expose OpenSSL internals by codebytere · Pull Request #29325 · nodejs/node

X Title: crypto: don't expose OpenSSL internals by codebytere · Pull Request #29325 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: #28335 extended RSA-OAEP support with oaepHash, which works perfectly fine for OpenSSL but unfortunately is a bespoke internal for BoringSSL, and so fails to compile in Electron as BoringSSL does n...

X Description: #28335 extended RSA-OAEP support with oaepHash, which works perfectly fine for OpenSSL but unfortunately is a bespoke internal for BoringSSL, and so fails to compile in Electron as BoringSSL does n...

Opengraph URL: https://github.com/nodejs/node/pull/29325

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:91c4b4d2-ef42-0f61-829e-7d5e0b4ac82f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBD8:9D1CD:67C42BE:911BEF5:6A501FA1
html-safe-noncee26249b0cad39ccf691ec569c6105b31a779862e38e69aa93523de769901585a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkQ4OjlEMUNEOjY3QzQyQkU6OTExQkVGNTo2QTUwMUZBMSIsInZpc2l0b3JfaWQiOiI1NTAyMTYyMDc1MDIyMDA4MjI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd973ffeccf0a8dfd1f05596627206ca7b78da3295afa8485910eb70500c9c5bf
hovercard-subject-tagpull_request:311052843
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29325/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/45f74057819982fc92dda0f140b4ed4516e72e54a05bdd07288887462fb81581/nodejs/node/pull/29325
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45f74057819982fc92dda0f140b4ed4516e72e54a05bdd07288887462fb81581/nodejs/node/pull/29325
og:image:alt#28335 extended RSA-OAEP support with oaepHash, which works perfectly fine for OpenSSL but unfortunately is a bespoke internal for BoringSSL, and so fails to compile in Electron as BoringSSL does n...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
Nonea08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1b91b18e7330fc458dfd824c61eaed7daa830d6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29325#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29325
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29325
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29325
Reloadhttps://github.com/nodejs/node/pull/29325
Reloadhttps://github.com/nodejs/node/pull/29325
Please reload this pagehttps://github.com/nodejs/node/pull/29325
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29325
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:crypto-oaepHash-boringsslhttps://github.com/codebytere/node/tree/crypto-oaepHash-boringssl
Conversationhttps://github.com/nodejs/node/pull/29325
Commits1 (1)https://github.com/nodejs/node/pull/29325/commits
Checkshttps://github.com/nodejs/node/pull/29325/checks
Files changedhttps://github.com/nodejs/node/pull/29325/files
crypto: don't expose OpenSSL internalshttps://github.com/nodejs/node/pull/29325#top
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:crypto-oaepHash-boringsslhttps://github.com/codebytere/node/tree/crypto-oaepHash-boringssl
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 26, 2019https://github.com/nodejs/node/pull/29325#issue-485403426
Please reload this pagehttps://github.com/nodejs/node/pull/29325
#28335https://github.com/nodejs/node/pull/28335
documentedhttps://www.openssl.org/docs/manmaster/man3/EVP_PKEY_CTX_ctrl.html
@tniessenhttps://github.com/tniessen
@ryzokukenhttps://github.com/ryzokuken
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/codebytere
codebyterehttps://github.com/codebytere
tniessenhttps://github.com/tniessen
August 26, 2019 19:24https://github.com/nodejs/node/pull/29325#event-2584726794
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 26, 2019https://github.com/nodejs/node/pull/29325#event-2584726994
https://github.com/codebytere
codebyterehttps://github.com/codebytere
ryzokukenhttps://github.com/ryzokuken
August 26, 2019 19:25https://github.com/nodejs/node/pull/29325#event-2584730718
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 26, 2019 https://github.com/nodejs/node/pull/29325#pullrequestreview-279794008
View reviewed changes https://github.com/nodejs/node/pull/29325/files
ryzokukenhttps://github.com/ryzokuken
https://github.com/nodejs/node/pull/29325#pullrequestreview-279794008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tniessenhttps://github.com/tniessen
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/davidben
davidbenhttps://github.com/davidben
Aug 26, 2019 https://github.com/nodejs/node/pull/29325#pullrequestreview-279812273
View reviewed changes https://github.com/nodejs/node/pull/29325/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/29325/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/codebytere
crypto: don't expose openssl internalshttps://github.com/nodejs/node/pull/29325/commits/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
5b722d6https://github.com/nodejs/node/pull/29325/commits/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/2ec84d4e6028b39a06e59f358852816e10aa5fdb..5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
2ec84d4https://github.com/nodejs/node/commit/2ec84d4e6028b39a06e59f358852816e10aa5fdb
5b722d6https://github.com/nodejs/node/commit/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
Compare https://github.com/nodejs/node/compare/2ec84d4e6028b39a06e59f358852816e10aa5fdb..5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
August 26, 2019 20:21https://github.com/nodejs/node/pull/29325#event-2584889132
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 26, 2019 https://github.com/nodejs/node/pull/29325#pullrequestreview-279871403
View reviewed changes https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 27, 2019https://github.com/nodejs/node/pull/29325#event-2585541664
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 27, 2019https://github.com/nodejs/node/pull/29325#issuecomment-525140015
https://ci.nodejs.org/job/node-test-pull-request/25256/https://ci.nodejs.org/job/node-test-pull-request/25256/
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 27, 2019 https://github.com/nodejs/node/pull/29325#pullrequestreview-280113734
View reviewed changes https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 28, 2019 https://github.com/nodejs/node/pull/29325#pullrequestreview-281155544
View reviewed changes https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
tniessenhttps://github.com/tniessen
https://github.com/nodejs/node/pull/29325#pullrequestreview-281155544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/danbev
danbevhttps://github.com/danbev
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 29, 2019https://github.com/nodejs/node/pull/29325#event-2592568235
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 29, 2019https://github.com/nodejs/node/pull/29325#issuecomment-526019035
Please reload this pagehttps://github.com/nodejs/node/pull/29325
ryzokukenhttps://github.com/ryzokuken
Aug 29, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-17a697c
https://github.com/codebytere
https://github.com/ryzokuken
crypto: don't expose openssl internalshttps://github.com/nodejs/node/commit/17a697c794f2525c9789fd92c2206a1b634cf473
17a697chttps://github.com/nodejs/node/commit/17a697c794f2525c9789fd92c2206a1b634cf473
#29325https://github.com/nodejs/node/pull/29325
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 29, 2019https://github.com/nodejs/node/pull/29325#issuecomment-526019678
17a697chttps://github.com/nodejs/node/commit/17a697c794f2525c9789fd92c2206a1b634cf473
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 29, 2019https://github.com/nodejs/node/pull/29325#event-2592641127
https://github.com/codebytere
codebyterehttps://github.com/codebytere
August 29, 2019 05:33https://github.com/nodejs/node/pull/29325#event-2592715250
BridgeARhttps://github.com/BridgeAR
Sep 3, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-d11ee19
https://github.com/codebytere
https://github.com/BridgeAR
crypto: don't expose openssl internalshttps://github.com/nodejs/node/commit/d11ee1951b78b38acc5610ce43291c3cc12f756c
d11ee19https://github.com/nodejs/node/commit/d11ee1951b78b38acc5610ce43291c3cc12f756c
#29325https://github.com/nodejs/node/pull/29325
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 3, 2019 https://github.com/nodejs/node/pull/29325#ref-pullrequest-488849745
v12.10.0 proposal #29429 https://github.com/nodejs/node/pull/29429
BridgeARhttps://github.com/BridgeAR
Sep 4, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-5c3e49d
https://github.com/codebytere
https://github.com/BridgeAR
crypto: don't expose openssl internalshttps://github.com/nodejs/node/commit/5c3e49d84e4d89205e2c4d30fa790b81e8e1e507
5c3e49dhttps://github.com/nodejs/node/commit/5c3e49d84e4d89205e2c4d30fa790b81e8e1e507
#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 5, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-2ea7a19
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/2ea7a198eb02e470e1cebf7b1325b718ba9c80b6
2ea7a19https://github.com/electron/electron/commit/2ea7a198eb02e470e1cebf7b1325b718ba9c80b6
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 5, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-fbb32c2
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/fbb32c2e4b9a0241fbe5504ee328fca38a09ce2b
fbb32c2https://github.com/electron/electron/commit/fbb32c2e4b9a0241fbe5504ee328fca38a09ce2b
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 5, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-a98ed3e
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/a98ed3e06a711faef5a5cdf7b006d1e41a088955
a98ed3ehttps://github.com/electron/electron/commit/a98ed3e06a711faef5a5cdf7b006d1e41a088955
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 5, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-862f00e
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/862f00e74b7c27db07491d5cecb8c23ea088a0a9
862f00ehttps://github.com/electron/electron/commit/862f00e74b7c27db07491d5cecb8c23ea088a0a9
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 6, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-e60b4c8
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/e60b4c8eae6b1b835b13114e68eeca29d8123b29
e60b4c8https://github.com/electron/electron/commit/e60b4c8eae6b1b835b13114e68eeca29d8123b29
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 19, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-47bcfbc
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/47bcfbc4f32a8f59f50044953c15becbf5fe8a71
47bcfbchttps://github.com/electron/electron/commit/47bcfbc4f32a8f59f50044953c15becbf5fe8a71
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 23, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-5098f50
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/5098f50bf741a80141b448965e5b0261d37fc1dd
5098f50https://github.com/electron/electron/commit/5098f50bf741a80141b448965e5b0261d37fc1dd
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Sep 27, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-56a0f05
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/56a0f055d36226fde198a2caeb70037c8dec2bcb
56a0f05https://github.com/electron/electron/commit/56a0f055d36226fde198a2caeb70037c8dec2bcb
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Oct 14, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-a404bce
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/a404bcef2dbfc66dec30f93f81e3a0eb05dcc486
a404bcehttps://github.com/electron/electron/commit/a404bcef2dbfc66dec30f93f81e3a0eb05dcc486
nodejs/node#29325https://github.com/nodejs/node/pull/29325
codebyterehttps://github.com/codebytere
Oct 14, 2019 https://github.com/nodejs/node/pull/29325#ref-commit-852d8b2
https://github.com/codebytere
remove add_openssl_is_boringssl_guard_to_oaep_hash_check.patchhttps://github.com/electron/electron/commit/852d8b2aa2dab8e3ea659fa09f0e3c736db78608
852d8b2https://github.com/electron/electron/commit/852d8b2aa2dab8e3ea659fa09f0e3c736db78608
nodejs/node#29325https://github.com/nodejs/node/pull/29325
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29325
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/29325/files/5b722d617d9785ad0f9caa2d3d4f11a3e9b523b5
https://github.com/davidben
davidben https://github.com/davidben
https://github.com/nodejs/node/pull/29325/files/2ec84d4e6028b39a06e59f358852816e10aa5fdb
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/29325/files/2ec84d4e6028b39a06e59f358852816e10aa5fdb
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/29325
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com/ryzokuken
https://github.com/davidben
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/tniessen
https://github.com/danbev
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.