René's URL Explorer Experiment


Title: fs: validate writev fds consistently by cjihrig · Pull Request #29185 · nodejs/node · GitHub

Open Graph Title: fs: validate writev fds consistently by cjihrig · Pull Request #29185 · nodejs/node

X Title: fs: validate writev fds consistently by cjihrig · Pull Request #29185 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit updates the recently added writev methods to validate file descriptors like the other fs methods do. Refs: #25925 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes com...

X Description: This commit updates the recently added writev methods to validate file descriptors like the other fs methods do. Refs: #25925 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes com...

Opengraph URL: https://github.com/nodejs/node/pull/29185

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7fe72637-d2c0-25ca-c351-d9674aef6ae3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB930:20853D:64066E8:8BBDDD3:6A4FAFC2
html-safe-noncecc9e80968d4d19d4ee160bde47c4e145ff6da827874c31c6918270c9991ec527
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTMwOjIwODUzRDo2NDA2NkU4OjhCQkRERDM6NkE0RkFGQzIiLCJ2aXNpdG9yX2lkIjoiMjI4MDE2MjYyNDE0NTQzNjYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacff32206888c438e121de00a6a11dd8186e59f101a9bf44879cffd7b02841e1d5
hovercard-subject-tagpull_request:308305200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29185/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/36013f8e9d2f4f76b0514707bbff8acfc13594e8cf096f21c6456aac3273c952/nodejs/node/pull/29185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36013f8e9d2f4f76b0514707bbff8acfc13594e8cf096f21c6456aac3273c952/nodejs/node/pull/29185
og:image:altThis commit updates the recently added writev methods to validate file descriptors like the other fs methods do. Refs: #25925 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29185#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29185
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29185
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29185
Reloadhttps://github.com/nodejs/node/pull/29185
Reloadhttps://github.com/nodejs/node/pull/29185
Please reload this pagehttps://github.com/nodejs/node/pull/29185
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29185
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:fdshttps://github.com/cjihrig/node/tree/fds
Conversationhttps://github.com/nodejs/node/pull/29185
Commits1 (1)https://github.com/nodejs/node/pull/29185/commits
Checkshttps://github.com/nodejs/node/pull/29185/checks
Files changedhttps://github.com/nodejs/node/pull/29185/files
fs: validate writev fds consistentlyhttps://github.com/nodejs/node/pull/29185#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:fdshttps://github.com/cjihrig/node/tree/fds
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 17, 2019https://github.com/nodejs/node/pull/29185#issue-481906218
#25925https://github.com/nodejs/node/pull/25925
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Aug 17, 2019https://github.com/nodejs/node/pull/29185#event-2564058563
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 17, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276246258
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 17, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276247849
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 17, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276248266
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276257687
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2019https://github.com/nodejs/node/pull/29185#issuecomment-522285847
https://ci.nodejs.org/job/node-test-pull-request/25060/https://ci.nodejs.org/job/node-test-pull-request/25060/
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Aug 18, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276258553
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 18, 2019https://github.com/nodejs/node/pull/29185#event-2564243587
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 18, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276260055
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Aug 18, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276271593
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2019https://github.com/nodejs/node/pull/29185#issuecomment-522326154
https://ci.nodejs.org/job/node-test-pull-request/25069/https://ci.nodejs.org/job/node-test-pull-request/25069/
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 18, 2019 https://github.com/nodejs/node/pull/29185#pullrequestreview-276297195
View reviewed changes https://github.com/nodejs/node/pull/29185/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29185#issuecomment-522588441
https://ci.nodejs.org/job/node-test-pull-request/25088/https://ci.nodejs.org/job/node-test-pull-request/25088/
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/2bf4e4f466df11974223b392ea428339b4954b92..a8b757d472e0eae8db965767cbeda4421ca0b2bf
2bf4e4fhttps://github.com/nodejs/node/commit/2bf4e4f466df11974223b392ea428339b4954b92
a8b757dhttps://github.com/nodejs/node/commit/a8b757d472e0eae8db965767cbeda4421ca0b2bf
Compare https://github.com/nodejs/node/compare/2bf4e4f466df11974223b392ea428339b4954b92..a8b757d472e0eae8db965767cbeda4421ca0b2bf
August 19, 2019 14:07https://github.com/nodejs/node/pull/29185#event-2566440166
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29185#issuecomment-522591463
https://ci.nodejs.org/job/node-test-pull-request/25089/https://ci.nodejs.org/job/node-test-pull-request/25089/
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29185#issuecomment-522626797
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://ci.nodejs.org/job/node-test-pull-request/25096/https://ci.nodejs.org/job/node-test-pull-request/25096/
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/cjihrig
fs: validate writev fds consistentlyhttps://github.com/nodejs/node/pull/29185/commits/9f9a201cc67d09c7c61169f9e274a76afd4159fe
9f9a201https://github.com/nodejs/node/pull/29185/commits/9f9a201cc67d09c7c61169f9e274a76afd4159fe
nodejs#29185https://github.com/nodejs/node/pull/29185
nodejs#25925https://github.com/nodejs/node/pull/25925
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/a8b757d472e0eae8db965767cbeda4421ca0b2bf..9f9a201cc67d09c7c61169f9e274a76afd4159fe
a8b757dhttps://github.com/nodejs/node/commit/a8b757d472e0eae8db965767cbeda4421ca0b2bf
9f9a201https://github.com/nodejs/node/commit/9f9a201cc67d09c7c61169f9e274a76afd4159fe
Compare https://github.com/nodejs/node/compare/a8b757d472e0eae8db965767cbeda4421ca0b2bf..9f9a201cc67d09c7c61169f9e274a76afd4159fe
August 19, 2019 19:14https://github.com/nodejs/node/pull/29185#event-2567381705
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
9f9a201https://github.com/nodejs/node/commit/9f9a201cc67d09c7c61169f9e274a76afd4159fe
Aug 19, 2019https://github.com/nodejs/node/pull/29185#event-2567386109
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 19, 2019 19:16https://github.com/nodejs/node/pull/29185#event-2567387067
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29185#ref-commit-4356836
https://github.com/cjihrig
https://github.com/targos
fs: validate writev fds consistentlyhttps://github.com/nodejs/node/commit/435683610b8559755f424c7714336b364d95c1b5
4356836https://github.com/nodejs/node/commit/435683610b8559755f424c7714336b364d95c1b5
#29185https://github.com/nodejs/node/pull/29185
#25925https://github.com/nodejs/node/pull/25925
https://github.com/targos
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29185#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29185
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/29185/files/2bf4e4f466df11974223b392ea428339b4954b92
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/29185
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/addaleax
https://github.com/antsmartian
https://github.com/lpinca
https://github.com/gengjiawen
https://github.com/trivikr
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.