René's URL Explorer Experiment


Title: net: use callback to properly propagate error by ronag · Pull Request #29178 · nodejs/node · GitHub

Open Graph Title: net: use callback to properly propagate error by ronag · Pull Request #29178 · nodejs/node

X Title: net: use callback to properly propagate error by ronag · Pull Request #29178 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The socket will be destroyed upstream through the proper error flow. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is chan...

X Description: The socket will be destroyed upstream through the proper error flow. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is chan...

Opengraph URL: https://github.com/nodejs/node/pull/29178

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1995ff25-5f11-3ecb-3956-c510bb00aeff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD888:1F19:25CDE31:3652097:6A4F8D4E
html-safe-nonceb01cbdc15e6a225a33980b5db3105c95435d765815733bc44a6d3b6393343b5f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODg4OjFGMTk6MjVDREUzMTozNjUyMDk3OjZBNEY4RDRFIiwidmlzaXRvcl9pZCI6IjQzMjc1OTc3MDE5Mjk2MDIzODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf91bd71ab6e5da631150a045a62c1f65cf130539c53f885444591685b53c8ded
hovercard-subject-tagpull_request:308284254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29178/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e11394ba3cf851030a97192bb29294432953db1f50e73fee453fd7891e710d57/nodejs/node/pull/29178
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e11394ba3cf851030a97192bb29294432953db1f50e73fee453fd7891e710d57/nodejs/node/pull/29178
og:image:altThe socket will be destroyed upstream through the proper error flow. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is chan...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29178#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29178
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29178
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29178
Reloadhttps://github.com/nodejs/node/pull/29178
Reloadhttps://github.com/nodejs/node/pull/29178
Please reload this pagehttps://github.com/nodejs/node/pull/29178
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29178
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:net-use-cbhttps://github.com/nxtedition/node/tree/net-use-cb
Conversationhttps://github.com/nodejs/node/pull/29178
Commits1 (1)https://github.com/nodejs/node/pull/29178/commits
Checkshttps://github.com/nodejs/node/pull/29178/checks
Files changedhttps://github.com/nodejs/node/pull/29178/files
net: use callback to properly propagate errorhttps://github.com/nodejs/node/pull/29178#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:net-use-cbhttps://github.com/nxtedition/node/tree/net-use-cb
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 17, 2019https://github.com/nodejs/node/pull/29178#issue-481875195
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/ronag
net: use callback to properly propagate errorhttps://github.com/nodejs/node/pull/29178/commits/6a91ea25e0b708e724a7a32adea11ddf777b9454
6a91ea2https://github.com/nodejs/node/pull/29178/commits/6a91ea25e0b708e724a7a32adea11ddf777b9454
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Aug 17, 2019https://github.com/nodejs/node/pull/29178#event-2563914632
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 17, 2019 https://github.com/nodejs/node/pull/29178#ref-issue-481875996
stream: destroy with callback #29180 https://github.com/nodejs/node/issues/29180
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 18, 2019 https://github.com/nodejs/node/pull/29178#pullrequestreview-276291537
View reviewed changes https://github.com/nodejs/node/pull/29178/files/6a91ea25e0b708e724a7a32adea11ddf777b9454
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2019https://github.com/nodejs/node/pull/29178#issuecomment-522346819
https://ci.nodejs.org/job/node-test-pull-request/25070/https://ci.nodejs.org/job/node-test-pull-request/25070/
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 19, 2019 https://github.com/nodejs/node/pull/29178#pullrequestreview-276629427
View reviewed changes https://github.com/nodejs/node/pull/29178/files/6a91ea25e0b708e724a7a32adea11ddf777b9454
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29178#issuecomment-522663234
https://ci.nodejs.org/job/node-test-pull-request/25101/https://ci.nodejs.org/job/node-test-pull-request/25101/
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29178#issuecomment-522673043
https://ci.nodejs.org/job/node-test-pull-request/25103/https://ci.nodejs.org/job/node-test-pull-request/25103/
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019https://github.com/nodejs/node/pull/29178#issuecomment-522678265
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1968/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1968/
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 20, 2019https://github.com/nodejs/node/pull/29178#issuecomment-522823255
cc7cec2https://github.com/nodejs/node/commit/cc7cec25c5fc2fdb8e055e25162c4b231f19e287
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 20, 2019https://github.com/nodejs/node/pull/29178#event-2568161427
Trotthttps://github.com/Trott
Aug 20, 2019 https://github.com/nodejs/node/pull/29178#ref-commit-cc7cec2
https://github.com/ronag
https://github.com/Trott
net: use callback to properly propagate errorhttps://github.com/nodejs/node/commit/cc7cec25c5fc2fdb8e055e25162c4b231f19e287
cc7cec2https://github.com/nodejs/node/commit/cc7cec25c5fc2fdb8e055e25162c4b231f19e287
#29178https://github.com/nodejs/node/pull/29178
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29178#ref-commit-17319e7
https://github.com/ronag
https://github.com/targos
net: use callback to properly propagate errorhttps://github.com/nodejs/node/commit/17319e7f441d81ab62b01f3e2961d6b38e7b10d3
17319e7https://github.com/nodejs/node/commit/17319e7f441d81ab62b01f3e2961d6b38e7b10d3
#29178https://github.com/nodejs/node/pull/29178
https://github.com/targos
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29178#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29178
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29178/files/6a91ea25e0b708e724a7a32adea11ddf777b9454
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29178/files/6a91ea25e0b708e724a7a32adea11ddf777b9454
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/29178
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.