| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:415dfdca-56fa-82ac-a410-ff26c221a607 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9656:45A31:526EAD:6B9FBF:699216DA |
| html-safe-nonce | 96e3228d3d93c528f6e34a505c828dba5d38a6197d1c370319a545f88f331140 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjU2OjQ1QTMxOjUyNkVBRDo2QjlGQkY6Njk5MjE2REEiLCJ2aXNpdG9yX2lkIjoiNDkzNTQ2MTA5MDQyNTQ0NDA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2d5589ec41e365f606cbb759435c032b17f7524d884678aa61a17f9bd7612d68 |
| hovercard-subject-tag | pull_request:308191285 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29168/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/09dcc265297d3f364f520b851d6e51eef9c89d6b865a5b16a08d4fda37920e92/nodejs/node/pull/29168 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/09dcc265297d3f364f520b851d6e51eef9c89d6b865a5b16a08d4fda37920e92/nodejs/node/pull/29168 |
| og:image:alt | This PR adds a recursive option to fs.rmdir(), fs.rmdirSync(), and fs.promises.rmdir(). The implementation is a port of the npm module rimraf. I added an option to rmdir() to match the approach tak... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29168#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29168 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29168 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29168 |
| Reload | https://github.com/nodejs/node/pull/29168 |
| Reload | https://github.com/nodejs/node/pull/29168 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:rimraf | https://github.com/cjihrig/node/tree/rimraf |
| Conversation | https://github.com/nodejs/node/pull/29168 |
| Commits3 (3) | https://github.com/nodejs/node/pull/29168/commits |
| Checks | https://github.com/nodejs/node/pull/29168/checks |
| Files changed | https://github.com/nodejs/node/pull/29168/files |
| fs: add recursive option to rmdir() | https://github.com/nodejs/node/pull/29168#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:rimraf | https://github.com/cjihrig/node/tree/rimraf |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Aug 16, 2019 | https://github.com/nodejs/node/pull/29168#issue-481752479 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| #28208 | https://github.com/nodejs/node/pull/28208 |
| #28208 (review) | https://github.com/nodejs/node/pull/28208#pullrequestreview-275046863 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 16, 2019 | https://github.com/nodejs/node/pull/29168#event-2563215858 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Aug 17, 2019
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-454608888 |
|
fs: implement fs.rmdir recurisve
#28171
| https://github.com/nodejs/node/pull/28171 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-522365555 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-522682644 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/97b7a02a92c92d4bd44a542b28bea9f070daeb6d..e293b5daa6f3b3836cb236d23a68bd96b817dbd3 |
| 97b7a02 | https://github.com/nodejs/node/commit/97b7a02a92c92d4bd44a542b28bea9f070daeb6d |
| e293b5d | https://github.com/nodejs/node/commit/e293b5daa6f3b3836cb236d23a68bd96b817dbd3 |
|
Compare
| https://github.com/nodejs/node/compare/97b7a02a92c92d4bd44a542b28bea9f070daeb6d..e293b5daa6f3b3836cb236d23a68bd96b817dbd3 |
| August 19, 2019 19:07 | https://github.com/nodejs/node/pull/29168#event-2567366056 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| August 19, 2019 19:09 | https://github.com/nodejs/node/pull/29168#event-2567370710 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-522714449 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-522717958 |
| https://ci.nodejs.org/job/node-test-pull-request/25108/ | https://ci.nodejs.org/job/node-test-pull-request/25108/ |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276789353 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| lib/internal/fs/utils.js | https://github.com/nodejs/node/pull/29168/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276791453 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29168#event-2567583672 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276797948 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276886790 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29168/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276886921 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29168/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-276896806 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29168/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-523067029 |
| https://ci.nodejs.org/job/node-test-pull-request/25124/ | https://ci.nodejs.org/job/node-test-pull-request/25124/ |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/2a2fbd8889ebc3eec26773375cbe45aee228022e..28dab64d2796ea1a4a424d6249aadf15adbbf9ae |
| 2a2fbd8 | https://github.com/nodejs/node/commit/2a2fbd8889ebc3eec26773375cbe45aee228022e |
| 28dab64 | https://github.com/nodejs/node/commit/28dab64d2796ea1a4a424d6249aadf15adbbf9ae |
|
Compare
| https://github.com/nodejs/node/compare/2a2fbd8889ebc3eec26773375cbe45aee228022e..28dab64d2796ea1a4a424d6249aadf15adbbf9ae |
| August 20, 2019 15:52 | https://github.com/nodejs/node/pull/29168#event-2570207769 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-523078098 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://ci.nodejs.org/job/node-test-pull-request/25126/ | https://ci.nodejs.org/job/node-test-pull-request/25126/ |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29168#event-2570363114 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29168#event-2570492557 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277324002 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| bcoe | https://github.com/bcoe |
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277324002 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| doc/api/fs.md | https://github.com/nodejs/node/pull/29168/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| lib/internal/fs/rimraf.js | https://github.com/nodejs/node/pull/29168/files#diff-102db77122b5d23f42d497abfc7d626e60723d911caa6293fd16a5ec92b0d653 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| lib/internal/fs/rimraf.js | https://github.com/nodejs/node/pull/29168/files#diff-102db77122b5d23f42d497abfc7d626e60723d911caa6293fd16a5ec92b0d653 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| test/parallel/test-fs-rmdir-recursive.js | https://github.com/nodejs/node/pull/29168/files#diff-4b59b7dac0f7ee445102ac16fe4ab126c107c7f73a365a33b4647c673b143446 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277337652 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| lib/internal/fs/rimraf.js | https://github.com/nodejs/node/pull/29168/files#diff-102db77122b5d23f42d497abfc7d626e60723d911caa6293fd16a5ec92b0d653 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-523142790 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/a93476bfa855c7040c45481cb456df04e897647b..a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
| a93476b | https://github.com/nodejs/node/commit/a93476bfa855c7040c45481cb456df04e897647b |
| a46d568 | https://github.com/nodejs/node/commit/a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
|
Compare
| https://github.com/nodejs/node/compare/a93476bfa855c7040c45481cb456df04e897647b..a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
| August 20, 2019 19:17 | https://github.com/nodejs/node/pull/29168#event-2570788791 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277426133 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-483092576 |
|
test: use fs rimraf to refresh tmpdir
#29235
| https://github.com/nodejs/node/pull/29235 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277490770 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Aug 21, 2019
| https://github.com/nodejs/node/pull/29168#pullrequestreview-277511141 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29168/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 21, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-523281816 |
| https://ci.nodejs.org/job/node-test-pull-request/25137/ | https://ci.nodejs.org/job/node-test-pull-request/25137/ |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| Trott | https://github.com/Trott |
|
Aug 23, 2019
| https://github.com/nodejs/node/pull/29168#ref-commit-53816cc |
|
| https://github.com/cjihrig |
|
| https://github.com/Trott |
| fs: add recursive option to rmdir() | https://github.com/nodejs/node/commit/53816cce699d02fb28a49b258e1fbc474568bbf8 |
| 53816cc | https://github.com/nodejs/node/commit/53816cce699d02fb28a49b258e1fbc474568bbf8 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 23, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-524460510 |
| 53816cc | https://github.com/nodejs/node/commit/53816cce699d02fb28a49b258e1fbc474568bbf8 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 23, 2019 | https://github.com/nodejs/node/pull/29168#event-2580839182 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| August 23, 2019 21:36 | https://github.com/nodejs/node/pull/29168#event-2580909693 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
|
Aug 23, 2019
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-455848798 |
|
lib: port rimraf to core as shutil.rmtree
#28208
| https://github.com/nodejs/node/pull/28208 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Aug 24, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-524511566 |
| #28208 | https://github.com/nodejs/node/pull/28208 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 24, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-524525545 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| #28208 | https://github.com/nodejs/node/pull/28208 |
| Not everyone was thrilled about version sniffing | https://github.com/nodejs/node/pull/22302#issuecomment-435596821 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29168#ref-commit-ed2293e |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
| fs: add recursive option to rmdir() | https://github.com/nodejs/node/commit/ed2293e3d70b36d139023dbe8f31faab3f255dd1 |
| ed2293e | https://github.com/nodejs/node/commit/ed2293e3d70b36d139023dbe8f31faab3f255dd1 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-488849745 |
|
v12.10.0 proposal
#29429
| https://github.com/nodejs/node/pull/29429 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29168#ref-commit-471f4a9 |
|
| https://github.com/BridgeAR |
| 2019-09-04, Version 12.10.0 (Current) | https://github.com/nodejs/node/commit/471f4a9fceff419613c5d12e4c647ce6b3a88d23 |
| 471f4a9 | https://github.com/nodejs/node/commit/471f4a9fceff419613c5d12e4c647ce6b3a88d23 |
| #29023 | https://github.com/nodejs/node/pull/29023 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| #29212 | https://github.com/nodejs/node/pull/29212 |
| #21387 | https://github.com/nodejs/node/pull/21387 |
| #25436 | https://github.com/nodejs/node/pull/25436 |
| #29429 | https://github.com/nodejs/node/pull/29429 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 4, 2019
| https://github.com/nodejs/node/pull/29168#ref-commit-3a2e75d |
|
| https://github.com/BridgeAR |
| 2019-09-04, Version 12.10.0 (Current) | https://github.com/nodejs/node/commit/3a2e75d9a5c31d20e429d505b82dd182e33f459a |
| 3a2e75d | https://github.com/nodejs/node/commit/3a2e75d9a5c31d20e429d505b82dd182e33f459a |
| #29023 | https://github.com/nodejs/node/pull/29023 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| #29212 | https://github.com/nodejs/node/pull/29212 |
| #21387 | https://github.com/nodejs/node/pull/21387 |
| #25436 | https://github.com/nodejs/node/pull/25436 |
| #29429 | https://github.com/nodejs/node/pull/29429 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 4, 2019
| https://github.com/nodejs/node/pull/29168#ref-commit-02c74e7 |
|
| https://github.com/BridgeAR |
| 2019-09-04, Version 12.10.0 (Current) | https://github.com/nodejs/node/commit/02c74e72eacc34fa90ae85983900a5d93f13b6c8 |
| 02c74e7 | https://github.com/nodejs/node/commit/02c74e72eacc34fa90ae85983900a5d93f13b6c8 |
| #29023 | https://github.com/nodejs/node/pull/29023 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| #29212 | https://github.com/nodejs/node/pull/29212 |
| #21387 | https://github.com/nodejs/node/pull/21387 |
| #25436 | https://github.com/nodejs/node/pull/25436 |
| #29429 | https://github.com/nodejs/node/pull/29429 |
| https://github.com/mysticatea |
| mysticatea | https://github.com/mysticatea |
| Sep 4, 2019 | https://github.com/nodejs/node/pull/29168#issuecomment-528060330 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
|
Sep 6, 2019
| https://github.com/nodejs/node/pull/29168#ref-issue-422904529 |
|
Implement shutil in Node.js core
nodejs/tooling#23
| https://github.com/nodejs/tooling/issues/23 |
| https://github.com/SimonSchick |
| SimonSchick | https://github.com/SimonSchick |
|
Sep 16, 2019
| https://github.com/nodejs/node/pull/29168#ref-issue-493821470 |
|
Add note that module is now shipped in node by default.
isaacs/rimraf#204
| https://github.com/isaacs/rimraf/issues/204 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 7, 2019
| https://github.com/nodejs/node/pull/29168#ref-issue-356779168 |
|
An optional parameter that lets us delete folders that aren't empty directly
#22686
| https://github.com/nodejs/node/issues/22686 |
| https://github.com/ntwb |
| ntwb | https://github.com/ntwb |
|
Nov 28, 2019
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-529469840 |
|
Package: Replace fs-extra with rimraf.
WordPress/gutenberg#18790
| https://github.com/WordPress/gutenberg/pull/18790 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 11, 2020 | https://github.com/nodejs/node/pull/29168#issuecomment-626760026 |
| sindresorhus/del#124 | https://github.com/sindresorhus/del/issues/124 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
May 11, 2020
| https://github.com/nodejs/node/pull/29168#ref-issue-615786320 |
|
Cannot delete dirs containing files with invalid UTF8 sequences in their name
sindresorhus/del#124
| https://github.com/sindresorhus/del/issues/124 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 11, 2020 | https://github.com/nodejs/node/pull/29168#issuecomment-626923928 |
| … | https://github.com/nodejs/node/pull/29168 |
| sindresorhus/del#124 | https://github.com/sindresorhus/del/issues/124 |
| sindresorhus/del#124 | https://github.com/sindresorhus/del/issues/124 |
| #29168 (comment) | https://github.com/nodejs/node/pull/29168#issuecomment-626760026 |
| https://github.com/notifications/unsubscribe-auth/AADZYV26DAS6E6RI276YBYTRRAHQXANCNFSM4IMMFUTA | https://github.com/notifications/unsubscribe-auth/AADZYV26DAS6E6RI276YBYTRRAHQXANCNFSM4IMMFUTA |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 11, 2020 | https://github.com/nodejs/node/pull/29168#issuecomment-626927384 |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
| https://github.com/RyanZim |
| RyanZim | https://github.com/RyanZim |
|
Jun 3, 2020
| https://github.com/nodejs/node/pull/29168#ref-issue-630259172 |
|
Recursive fs.rmdir / fs.rm
jprichardson/node-fs-extra#806
| https://github.com/jprichardson/node-fs-extra/issues/806 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Jul 11, 2020
| https://github.com/nodejs/node/pull/29168#ref-issue-654074174 |
|
Rethink recursive flag (and design more generally) for fs.rmdir
#34278
| https://github.com/nodejs/node/issues/34278 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Sep 13, 2020
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-700460416 |
|
fs: remove experimental language from rmdir recursive
#35171
| https://github.com/nodejs/node/pull/35171 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 2, 2021
| https://github.com/nodejs/node/pull/29168#ref-pullrequest-900986880 |
|
fs: stop fixing EPERM on Windows
#38810
| https://github.com/nodejs/node/pull/38810 |
| https://github.com/live627 |
| live627 | https://github.com/live627 |
|
Jan 23, 2022
| https://github.com/nodejs/node/pull/29168#ref-issue-1111870822 |
|
Consider replacing del with its dependency rimraf
avajs/ava#2952
| https://github.com/avajs/ava/issues/2952 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29168 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29168/files/a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29168/files/a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/29168/files/a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/29168/files/a93476bfa855c7040c45481cb456df04e897647b |
|
| https://github.com/bcoe |
|
bcoe
| https://github.com/bcoe |
|
| https://github.com/nodejs/node/pull/29168/files/a93476bfa855c7040c45481cb456df04e897647b |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/29168/files/a93476bfa855c7040c45481cb456df04e897647b |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/29168/files/a46d5680e9d540cb2978a17bcac8f7beba6ecb2a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/29168 |
|
| https://github.com/cjihrig |
|
| https://github.com/Trott |
|
| https://github.com/silverwind |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ljharb |
|
| https://github.com/mysticatea |
|
| https://github.com/MylesBorins |
|
| https://github.com/bcoe |
|
| https://github.com/jasnell |
|
| https://github.com/gengjiawen |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |